4900349245390848

Build Type

cirrus-ci

Committed by Anderson Bravalheri

Commit Message

Add test case for extra keys in authors

Pull Request Pull Request #82: Error-out when extra keys are added to project.authos/maintainers

Run Details

255 of 261 branches covered (97.7%)

Branch coverage included in aggregate %.

736 of 746 relevant lines covered (98.66%)

10.85 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

99.18

/src/validate_pyproject/error_reporting.py

import io
import json
import logging
import os
import re
from contextlib import contextmanager
from textwrap import indent, wrap
from typing import Any, Dict, Iterator, List, Optional, Sequence, Union, cast

from ._vendor.fastjsonschema import JsonSchemaValueException

_logger = logging.getLogger(__name__)

_MESSAGE_REPLACEMENTS = {
    "must be named by propertyName definition": "keys must be named by",
    "one of contains definition": "at least one item that matches",
    " same as const definition:": "",
    "only specified items": "only items matching the definition",
}

_SKIP_DETAILS = (
    "must not be empty",
    "is always invalid",
    "must not be there",
)

_NEED_DETAILS = {"anyOf", "oneOf", "anyOf", "contains", "propertyNames", "not", "items"}

_CAMEL_CASE_SPLITTER = re.compile(r"\W+|([A-Z][^A-Z\W]*)")
_IDENTIFIER = re.compile(r"^[\w_]+$", re.I)

_TOML_JARGON = {
    "object": "table",
    "property": "key",
    "properties": "keys",
    "property names": "keys",
}


class ValidationError(JsonSchemaValueException):
    """Report violations of a given JSON schema.

    This class extends :exc:`~fastjsonschema.JsonSchemaValueException`
    by adding the following properties:

    - ``summary``: an improved version of the ``JsonSchemaValueException`` error message
      with only the necessary information)

    - ``details``: more contextual information about the error like the failing schema
      itself and the value that violates the schema.

    Depending on the level of the verbosity of the ``logging`` configuration
    the exception message will be only ``summary`` (default) or a combination of
    ``summary`` and ``details`` (when the logging level is set to :obj:`logging.DEBUG`).
    """

    summary = ""
    details = ""
    _original_message = ""

    @classmethod
    def _from_jsonschema(cls, ex: JsonSchemaValueException):
        formatter = _ErrorFormatting(ex)
        obj = cls(str(formatter), ex.value, formatter.name, ex.definition, ex.rule)
        debug_code = os.getenv("JSONSCHEMA_DEBUG_CODE_GENERATION", "false").lower()
        if debug_code != "false":  # pragma: no cover
            obj.__cause__, obj.__traceback__ = ex.__cause__, ex.__traceback__
        obj._original_message = ex.message
        obj.summary = formatter.summary
        obj.details = formatter.details
        return obj


@contextmanager
def detailed_errors():
    try:
        yield
    except JsonSchemaValueException as ex:
        raise ValidationError._from_jsonschema(ex) from None


class _ErrorFormatting:
    def __init__(self, ex: JsonSchemaValueException):
        self.ex = ex
        self.name = f"`{self._simplify_name(ex.name)}`"
        self._original_message = self.ex.message.replace(ex.name, self.name)
        self._summary = ""
        self._details = ""

    def __str__(self) -> str:
        if _logger.getEffectiveLevel() <= logging.DEBUG and self.details:
            return f"{self.summary}\n\n{self.details}"

        return self.summary

    @property
    def summary(self) -> str:
        if not self._summary:
            self._summary = self._expand_summary()

        return self._summary

    @property
    def details(self) -> str:
        if not self._details:
            self._details = self._expand_details()

        return self._details

    def _simplify_name(self, name):
        x = len("data.")
        return name[x:] if name.startswith("data.") else name

    def _expand_summary(self):
        msg = self._original_message

        for bad, repl in _MESSAGE_REPLACEMENTS.items():
            msg = msg.replace(bad, repl)

        if any(substring in msg for substring in _SKIP_DETAILS):
            return msg

        schema = self.ex.rule_definition
        if self.ex.rule in _NEED_DETAILS and schema:
            summary = _SummaryWriter(_TOML_JARGON)
            return f"{msg}:\n\n{indent(summary(schema), '    ')}"

        return msg

    def _expand_details(self) -> str:
        optional = []
        desc_lines = self.ex.definition.pop("$$description", [])
        desc = self.ex.definition.pop("description", None) or " ".join(desc_lines)
        if desc:
            description = "\n".join(
                wrap(
                    desc,
                    width=80,
                    initial_indent="    ",
                    subsequent_indent="    ",
                    break_long_words=False,
                )
            )
            optional.append(f"DESCRIPTION:\n{description}")
        schema = json.dumps(self.ex.definition, indent=4)
        value = json.dumps(self.ex.value, indent=4)
        defaults = [
            f"GIVEN VALUE:\n{indent(value, '    ')}",
            f"OFFENDING RULE: {self.ex.rule!r}",
            f"DEFINITION:\n{indent(schema, '    ')}",
        ]
        return "\n\n".join(optional + defaults)


class _SummaryWriter:
    _IGNORE = {"description", "default", "title", "examples"}

    def __init__(self, jargon: Optional[Dict[str, str]] = None):
        self.jargon: Dict[str, str] = jargon or {}
        # Clarify confusing terms
        self._terms = {
            "anyOf": "at least one of the following",
            "oneOf": "exactly one of the following",
            "allOf": "all of the following",
            "not": "(*NOT* the following)",
            "prefixItems": f"{self._jargon('items')} (in order)",
            "items": "items",
            "contains": "contains at least one of",
            "propertyNames": (
                f"non-predefined acceptable {self._jargon('property names')}"
            ),
            "patternProperties": f"{self._jargon('properties')} named via pattern",
            "const": "predefined value",
            "enum": "one of",
        }
        # Attributes that indicate that the definition is easy and can be done
        # inline (e.g. string and number)
        self._guess_inline_defs = [
            "enum",
            "const",
            "maxLength",
            "minLength",
            "pattern",
            "format",
            "minimum",
            "maximum",
            "exclusiveMinimum",
            "exclusiveMaximum",
            "multipleOf",
        ]

    def _jargon(self, term: Union[str, List[str]]) -> Union[str, List[str]]:
        if isinstance(term, list):
            return [self.jargon.get(t, t) for t in term]
        return self.jargon.get(term, term)

    def __call__(
        self,
        schema: Union[dict, List[dict]],
        prefix: str = "",
        *,
        _path: Sequence[str] = (),
    ) -> str:
        if isinstance(schema, list):
            return self._handle_list(schema, prefix, _path)

        filtered = self._filter_unecessary(schema, _path)
        simple = self._handle_simple_dict(filtered, _path)
        if simple:
            return f"{prefix}{simple}"

        child_prefix = self._child_prefix(prefix, "  ")
        item_prefix = self._child_prefix(prefix, "- ")
        indent = len(prefix) * " "
        with io.StringIO() as buffer:
            for i, (key, value) in enumerate(filtered.items()):
                child_path = [*_path, key]
                line_prefix = prefix if i == 0 else indent
                buffer.write(f"{line_prefix}{self._label(child_path)}:")
                # ^  just the first item should receive the complete prefix
                if isinstance(value, dict):
                    filtered = self._filter_unecessary(value, child_path)
                    simple = self._handle_simple_dict(filtered, child_path)
                    buffer.write(
                        f" {simple}"
                        if simple
                        else f"\n{self(value, child_prefix, _path=child_path)}"
                    )
                elif isinstance(value, list) and (
                    key != "type" or self._is_property(child_path)
                ):
                    children = self._handle_list(value, item_prefix, child_path)
                    sep = " " if children.startswith("[") else "\n"
                    buffer.write(f"{sep}{children}")
                else:
                    buffer.write(f" {self._value(value, child_path)}\n")
            return buffer.getvalue()

    def _is_unecessary(self, path: Sequence[str]) -> bool:
        if self._is_property(path) or not path:  # empty path => instruction @ root
            return False
        key = path[-1]
        return any(key.startswith(k) for k in "$_") or key in self._IGNORE

    def _filter_unecessary(self, schema: dict, path: Sequence[str]):
        return {
            key: value
            for key, value in schema.items()
            if not self._is_unecessary([*path, key])
        }

    def _handle_simple_dict(self, value: dict, path: Sequence[str]) -> Optional[str]:
        inline = any(p in value for p in self._guess_inline_defs)
        simple = not any(isinstance(v, (list, dict)) for v in value.values())
        if inline or simple:
            return f"{{{', '.join(self._inline_attrs(value, path))}}}\n"
        return None

    def _handle_list(
        self, schemas: list, prefix: str = "", path: Sequence[str] = ()
    ) -> str:
        if self._is_unecessary(path):
            return ""

        repr_ = repr(schemas)
        if all(not isinstance(e, (dict, list)) for e in schemas) and len(repr_) < 60:
            return f"{repr_}\n"

        item_prefix = self._child_prefix(prefix, "- ")
        return "".join(
            self(v, item_prefix, _path=[*path, f"[{i}]"]) for i, v in enumerate(schemas)
        )

    def _is_property(self, path: Sequence[str]):
        """Check if the given path can correspond to an arbitrarily named property"""
        counter = 0
        for key in path[-2::-1]:
            if key not in {"properties", "patternProperties"}:
                break
            counter += 1

        # If the counter if even, the path correspond to a JSON Schema keyword
        # otherwise it can be any arbitrary string naming a property
        return counter % 2 == 1

    def _label(self, path: Sequence[str]) -> str:
        *parents, key = path
        if not self._is_property(path):
            norm_key = _separate_terms(key)
            return self._terms.get(key) or " ".join(self._jargon(norm_key))

        if parents[-1] == "patternProperties":
            return f"(regex {key!r})"
        return repr(key)  # property name

    def _value(self, value: Any, path: Sequence[str]) -> str:
        if path[-1] == "type" and not self._is_property(path):
            type_ = self._jargon(value)
            return (
                f"[{', '.join(type_)}]" if isinstance(value, list) else cast(str, type_)
            )
        return repr(value)

    def _inline_attrs(self, schema: dict, path: Sequence[str]) -> Iterator[str]:
        for key, value in schema.items():
            child_path = [*path, key]
            yield f"{self._label(child_path)}: {self._value(value, child_path)}"

    def _child_prefix(self, parent_prefix: str, child_prefix: str) -> str:
        return len(parent_prefix) * " " + child_prefix


def _separate_terms(word: str) -> List[str]:
    """
    >>> _separate_terms("FooBar-foo")
    ['foo', 'bar', 'foo']
    """
    return [w.lower() for w in _CAMEL_CASE_SPLITTER.split(word) if w]

1	import io	11✔
2	import json	11✔
3	import logging	11✔
4	import os	11✔
5	import re	11✔
6	from contextlib import contextmanager	11✔
7	from textwrap import indent, wrap	11✔
8	from typing import Any, Dict, Iterator, List, Optional, Sequence, Union, cast	11✔
9
10	from ._vendor.fastjsonschema import JsonSchemaValueException	11✔
11
12	_logger = logging.getLogger(__name__)	11✔
13
14	_MESSAGE_REPLACEMENTS = {	11✔
15	"must be named by propertyName definition": "keys must be named by",
16	"one of contains definition": "at least one item that matches",
17	" same as const definition:": "",
18	"only specified items": "only items matching the definition",
19	}
20
21	_SKIP_DETAILS = (	11✔
22	"must not be empty",
23	"is always invalid",
24	"must not be there",
25	)
26
27	_NEED_DETAILS = {"anyOf", "oneOf", "anyOf", "contains", "propertyNames", "not", "items"}	11✔
28
29	_CAMEL_CASE_SPLITTER = re.compile(r"\W+\|([A-Z][^A-Z\W]*)")	11✔
30	_IDENTIFIER = re.compile(r"^[\w_]+$", re.I)	11✔
31
32	_TOML_JARGON = {	11✔
33	"object": "table",
34	"property": "key",
35	"properties": "keys",
36	"property names": "keys",
37	}
38
39
40	class ValidationError(JsonSchemaValueException):	11✔
41	"""Report violations of a given JSON schema.
42
43	This class extends :exc:`~fastjsonschema.JsonSchemaValueException`
44	by adding the following properties:
45
46	- ``summary``: an improved version of the ``JsonSchemaValueException`` error message
47	with only the necessary information)
48
49	- ``details``: more contextual information about the error like the failing schema
50	itself and the value that violates the schema.
51
52	Depending on the level of the verbosity of the ``logging`` configuration
53	the exception message will be only ``summary`` (default) or a combination of
54	``summary`` and ``details`` (when the logging level is set to :obj:`logging.DEBUG`).
55	"""
56
57	summary = ""	11✔
58	details = ""	11✔
59	_original_message = ""	11✔
60
61	@classmethod	11✔
62	def _from_jsonschema(cls, ex: JsonSchemaValueException):	11✔
63	formatter = _ErrorFormatting(ex)	11✔
64	obj = cls(str(formatter), ex.value, formatter.name, ex.definition, ex.rule)	11✔
65	debug_code = os.getenv("JSONSCHEMA_DEBUG_CODE_GENERATION", "false").lower()	11✔
66	if debug_code != "false": # pragma: no cover
67	obj.__cause__, obj.__traceback__ = ex.__cause__, ex.__traceback__
68	obj._original_message = ex.message	11✔
69	obj.summary = formatter.summary	11✔
70	obj.details = formatter.details	11✔
71	return obj	11✔
72
73
74	@contextmanager	11✔
75	def detailed_errors():	9✔
76	try:	11✔
77	yield	11✔
78	except JsonSchemaValueException as ex:	11✔
79	raise ValidationError._from_jsonschema(ex) from None	11✔
80
81
82	class _ErrorFormatting:	11✔
83	def __init__(self, ex: JsonSchemaValueException):	11✔
84	self.ex = ex	11✔
85	self.name = f"`{self._simplify_name(ex.name)}`"	11✔
86	self._original_message = self.ex.message.replace(ex.name, self.name)	11✔
87	self._summary = ""	11✔
88	self._details = ""	11✔
89
90	def __str__(self) -> str:	11✔
91	if _logger.getEffectiveLevel() <= logging.DEBUG and self.details:	11✔
92	return f"{self.summary}\n\n{self.details}"	11✔
93
94	return self.summary	11✔
95
96	@property	11✔
97	def summary(self) -> str:	11✔
98	if not self._summary:	11✔
99	self._summary = self._expand_summary()	11✔
100
101	return self._summary	11✔
102
103	@property	11✔
104	def details(self) -> str:	11✔
105	if not self._details:	11✔
106	self._details = self._expand_details()	11✔
107
108	return self._details	11✔
109
110	def _simplify_name(self, name):	11✔
111	x = len("data.")	11✔
112	return name[x:] if name.startswith("data.") else name	11✔
113
114	def _expand_summary(self):	11✔
115	msg = self._original_message	11✔
116
117	for bad, repl in _MESSAGE_REPLACEMENTS.items():	11✔
118	msg = msg.replace(bad, repl)	11✔
119
120	if any(substring in msg for substring in _SKIP_DETAILS):	11✔
121	return msg	11✔
122
123	schema = self.ex.rule_definition	11✔
124	if self.ex.rule in _NEED_DETAILS and schema:	11✔
125	summary = _SummaryWriter(_TOML_JARGON)	11✔
126	return f"{msg}:\n\n{indent(summary(schema), ' ')}"	11✔
127
128	return msg	11✔
129
130	def _expand_details(self) -> str:	11✔
131	optional = []	11✔
132	desc_lines = self.ex.definition.pop("$$description", [])	11✔
133	desc = self.ex.definition.pop("description", None) or " ".join(desc_lines)	11✔
134	if desc:	11✔
135	description = "\n".join(	11✔
136	wrap(
137	desc,
138	width=80,
139	initial_indent=" ",
140	subsequent_indent=" ",
141	break_long_words=False,
142	)
143	)
144	optional.append(f"DESCRIPTION:\n{description}")	11✔
145	schema = json.dumps(self.ex.definition, indent=4)	11✔
146	value = json.dumps(self.ex.value, indent=4)	11✔
147	defaults = [	11✔
148	f"GIVEN VALUE:\n{indent(value, ' ')}",
149	f"OFFENDING RULE: {self.ex.rule!r}",
150	f"DEFINITION:\n{indent(schema, ' ')}",
151	]
152	return "\n\n".join(optional + defaults)	11✔
153
154
155	class _SummaryWriter:	11✔
156	_IGNORE = {"description", "default", "title", "examples"}	11✔
157
158	def __init__(self, jargon: Optional[Dict[str, str]] = None):	11✔
159	self.jargon: Dict[str, str] = jargon or {}	11✔
160	# Clarify confusing terms
161	self._terms = {	11✔
162	"anyOf": "at least one of the following",
163	"oneOf": "exactly one of the following",
164	"allOf": "all of the following",
165	"not": "(NOT the following)",
166	"prefixItems": f"{self._jargon('items')} (in order)",
167	"items": "items",
168	"contains": "contains at least one of",
169	"propertyNames": (
170	f"non-predefined acceptable {self._jargon('property names')}"
171	),
172	"patternProperties": f"{self._jargon('properties')} named via pattern",
173	"const": "predefined value",
174	"enum": "one of",
175	}
176	# Attributes that indicate that the definition is easy and can be done
177	# inline (e.g. string and number)
178	self._guess_inline_defs = [	11✔
179	"enum",
180	"const",
181	"maxLength",
182	"minLength",
183	"pattern",
184	"format",
185	"minimum",
186	"maximum",
187	"exclusiveMinimum",
188	"exclusiveMaximum",
189	"multipleOf",
190	]
191
192	def _jargon(self, term: Union[str, List[str]]) -> Union[str, List[str]]:	11✔
193	if isinstance(term, list):	11✔
194	return [self.jargon.get(t, t) for t in term]	11✔
195	return self.jargon.get(term, term)	11✔
196
197	def __call__(	11✔
198	self,
199	schema: Union[dict, List[dict]],
200	prefix: str = "",
201	*,
202	_path: Sequence[str] = (),
203	) -> str:
204	if isinstance(schema, list):	11✔
205	return self._handle_list(schema, prefix, _path)	11✔
206
207	filtered = self._filter_unecessary(schema, _path)	11✔
208	simple = self._handle_simple_dict(filtered, _path)	11✔
209	if simple:	11✔
210	return f"{prefix}{simple}"	11✔
211
212	child_prefix = self._child_prefix(prefix, " ")	11✔
213	item_prefix = self._child_prefix(prefix, "- ")	11✔
214	indent = len(prefix) * " "	11✔
215	with io.StringIO() as buffer:	11✔
216	for i, (key, value) in enumerate(filtered.items()):	11✔
217	child_path = [*_path, key]	11✔
218	line_prefix = prefix if i == 0 else indent	11✔
219	buffer.write(f"{line_prefix}{self._label(child_path)}:")	11✔
220	# ^ just the first item should receive the complete prefix
221	if isinstance(value, dict):	11✔
222	filtered = self._filter_unecessary(value, child_path)	11✔
223	simple = self._handle_simple_dict(filtered, child_path)	11✔
224	buffer.write(	11✔
225	f" {simple}"
226	if simple
227	else f"\n{self(value, child_prefix, _path=child_path)}"
228	)
229	elif isinstance(value, list) and (	11✔
230	key != "type" or self._is_property(child_path)
231	):
232	children = self._handle_list(value, item_prefix, child_path)	11✔
233	sep = " " if children.startswith("[") else "\n"	11✔
234	buffer.write(f"{sep}{children}")	11✔
235	else:
236	buffer.write(f" {self._value(value, child_path)}\n")	11✔
237	return buffer.getvalue()	11✔
238
239	def _is_unecessary(self, path: Sequence[str]) -> bool:	11✔
240	if self._is_property(path) or not path: # empty path => instruction @ root	11✔
241	return False	11✔
242	key = path[-1]	11✔
243	return any(key.startswith(k) for k in "$_") or key in self._IGNORE	11✔
244
245	def _filter_unecessary(self, schema: dict, path: Sequence[str]):	11✔
246	return {	11✔
247	key: value
248	for key, value in schema.items()
249	if not self._is_unecessary([*path, key])
250	}
251
252	def _handle_simple_dict(self, value: dict, path: Sequence[str]) -> Optional[str]:	11✔
253	inline = any(p in value for p in self._guess_inline_defs)	11✔
254	simple = not any(isinstance(v, (list, dict)) for v in value.values())	11✔
255	if inline or simple:	11✔
256	return f"{{{', '.join(self._inline_attrs(value, path))}}}\n"	11✔
257	return None	11✔
258
259	def _handle_list(	11✔
260	self, schemas: list, prefix: str = "", path: Sequence[str] = ()
261	) -> str:
262	if self._is_unecessary(path):	11!
263	return ""	×
264
265	repr_ = repr(schemas)	11✔
266	if all(not isinstance(e, (dict, list)) for e in schemas) and len(repr_) < 60:	11✔
267	return f"{repr_}\n"	11✔
268
269	item_prefix = self._child_prefix(prefix, "- ")	11✔
270	return "".join(	11✔
271	self(v, item_prefix, _path=[*path, f"[{i}]"]) for i, v in enumerate(schemas)
272	)
273
274	def _is_property(self, path: Sequence[str]):	11✔
275	"""Check if the given path can correspond to an arbitrarily named property"""
276	counter = 0	11✔
277	for key in path[-2::-1]:	11✔
278	if key not in {"properties", "patternProperties"}:	11✔
279	break	11✔
280	counter += 1	11✔
281
282	# If the counter if even, the path correspond to a JSON Schema keyword
283	# otherwise it can be any arbitrary string naming a property
284	return counter % 2 == 1	11✔
285
286	def _label(self, path: Sequence[str]) -> str:	11✔
287	*parents, key = path	11✔
288	if not self._is_property(path):	11✔
289	norm_key = _separate_terms(key)	11✔
290	return self._terms.get(key) or " ".join(self._jargon(norm_key))	11✔
291
292	if parents[-1] == "patternProperties":	11✔
293	return f"(regex {key!r})"	11✔
294	return repr(key) # property name	11✔
295
296	def _value(self, value: Any, path: Sequence[str]) -> str:	11✔
297	if path[-1] == "type" and not self._is_property(path):	11✔
298	type_ = self._jargon(value)	11✔
299	return (	11✔
300	f"[{', '.join(type_)}]" if isinstance(value, list) else cast(str, type_)
301	)
302	return repr(value)	11✔
303
304	def _inline_attrs(self, schema: dict, path: Sequence[str]) -> Iterator[str]:	11✔
305	for key, value in schema.items():	11✔
306	child_path = [*path, key]	11✔
307	yield f"{self._label(child_path)}: {self._value(value, child_path)}"	11✔
308
309	def _child_prefix(self, parent_prefix: str, child_prefix: str) -> str:	11✔
310	return len(parent_prefix) * " " + child_prefix	11✔
311
312
313	def _separate_terms(word: str) -> List[str]:	11✔
314	"""
315	>>> _separate_terms("FooBar-foo")
316	['foo', 'bar', 'foo']
317	"""
318	return [w.lower() for w in _CAMEL_CASE_SPLITTER.split(word) if w]	11✔

abravalheri / validate-pyproject / 4900349245390848

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous