jstasiak / python-zeroconf / 141

pending completion

Build # 141

Build Type

Pull #45

travis-ci

Committed by

stephenrauch

Commit Message

Fix ability for a cache lookup to match properly

When querying for a service type, the response is processed.  During the
processing, an info lookup is performed.  If the info is not found in
the cache, then a query is sent.  Trouble is that the info requested is
present in the same packet that triggered the lookup, and a query is not
necessary.  But two problems caused the cache lookup to fail.

1) The info was not yet in the cache.  The call back was fired before
all answers in the packet were cached.

2) The test for a cache hit did not work, because the cache hit test
uses a DNSEntry as the comparison object.  But some of the objects in
the cache are descendents of DNSEntry and have their own __eq__()
defined which accesses fields only present on the descendent.  Thus the
test can NEVER work since the descendent's __eq__() will be used.

Also continuing the theme of some other recent pull requests, add three
_GLOBAL_DONE tests to avoid doing work after the attempted stop, and
thus avoid generating (harmless, but annoying) exceptions during
shutdown

Pull Request Pull Request #45: Fix ability for a cache lookup to match properly

Run Details

52 of 52 new or added lines in 1 file covered. (100.0%)

766 of 999 relevant lines covered (76.68%)

4.53 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.68

/zeroconf.py

Build SHA Not Found

The commit SHA "9c884a5c688daa44468fe9b5937107be645c0b2a" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

jstasiak / python-zeroconf / 141

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous