3368151512

Build Type

github

Committed by GitHub

Commit Message

Merge bfb536e76 into dbc97f411

Pull Request Pull Request #743: fix: some setters doesn't update UI

Run Details

4436 of 7203 branches covered (61.59%)

Branch coverage included in aggregate %.

198 of 217 new or added lines in 11 files covered. (91.24%)

52 existing lines in 11 files now uncovered.

8395 of 8983 relevant lines covered (93.45%)

139.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

/src/control/states/DraggingState.ts

/*
 * Copyright (c) 2015 NAVER Corp.
 * egjs projects are licensed under the MIT license
 */
import { ComponentEvent } from "@egjs/component";

import { EVENTS } from "../../const/external";
import * as AXES from "../../const/axes";

import State, { STATE_TYPE } from "./State";

/**
 * A state that activates when user's dragging the Flicking area
 * @ko 사용자가 드래깅중인 상태
 * @internal
 */
class DraggingState extends State {
  /**
   * Whether user is clicking or touching
   * @ko 현재 사용자가 클릭/터치중인지 여부
   * @type {true}
   * @readonly
   */
  public readonly holding = true;
  /**
   * Whether Flicking's animating
   * @ko 현재 애니메이션 동작 여부
   * @type {true}
   * @readonly
   */
  public readonly animating = true;

  public onChange(ctx: Parameters<State["onChange"]>[0]): void {
    this._moveToChangedPosition(ctx);
  }

  public onRelease(ctx: Parameters<State["onRelease"]>[0]) {
    const { flicking, axesEvent, transitTo } = ctx;

    // Update last position to cope with Axes's animating behavior
    // Axes uses start position when animation start
    flicking.trigger(new ComponentEvent(EVENTS.HOLD_END, {
      axesEvent
    }));

    if (flicking.renderer.panelCount <= 0) {
      // There're no panels
      transitTo(STATE_TYPE.IDLE);
      return;
    }

    transitTo(STATE_TYPE.ANIMATING);

    const control = flicking.control;
    const position = axesEvent.destPos[AXES.POSITION_KEY];
    const duration = Math.max(axesEvent.duration, flicking.duration);

    try {
      void control.moveToPosition(position, duration, axesEvent);
    } catch (err) {
      transitTo(STATE_TYPE.IDLE);
      axesEvent.setTo({ [AXES.POSITION_KEY]: flicking.camera.position }, 0);
    }
  }
}

export default DraggingState;

1	/*	1✔
2	* Copyright (c) 2015 NAVER Corp.	1✔
3	* egjs projects are licensed under the MIT license	1✔
4	*/	1!
5	import { ComponentEvent } from "@egjs/component";	5✔
6		×
7	import { EVENTS } from "../../const/external";	6✔
8	import * as AXES from "../../const/axes";	5✔
9		1✔
10	import State, { STATE_TYPE } from "./State";	6!
11
12	/**	1✔
13	* A state that activates when user's dragging the Flicking area	1✔
14	* @ko 사용자가 드래깅중인 상태	1!
15	* @internal
16	*/
17	class DraggingState extends State {	6!
18	/**	×
19	* Whether user is clicking or touching
20	* @ko 현재 사용자가 클릭/터치중인지 여부
21	* @type {true}	×
22	* @readonly
23	*/
24	public readonly holding = true;	3!
25	/**
26	* Whether Flicking's animating
27	* @ko 현재 애니메이션 동작 여부
28	* @type {true}
29	* @readonly	1✔
30	*/	2!
31	public readonly animating = true;	2✔
32		×
33	public onChange(ctx: Parameters<State["onChange"]>[0]): void {	5✔
34	this._moveToChangedPosition(ctx);	253✔
35	}
36		1✔
37	public onRelease(ctx: Parameters<State["onRelease"]>[0]) {	5✔
38	const { flicking, axesEvent, transitTo } = ctx;	6✔
39
40	// Update last position to cope with Axes's animating behavior
41	// Axes uses start position when animation start	1✔
42	flicking.trigger(new ComponentEvent(EVENTS.HOLD_END, {	3✔
43	axesEvent	1✔
44	}));	1✔
45
46	if (flicking.renderer.panelCount <= 0) {	2!
47	// There're no panels
48	transitTo(STATE_TYPE.IDLE);
49	return;
50	}	1✔
51		1✔
52	transitTo(STATE_TYPE.ANIMATING);	2✔
53		45✔
54	const control = flicking.control;	2✔
55	const position = axesEvent.destPos[AXES.POSITION_KEY];	2✔
56	const duration = Math.max(axesEvent.duration, flicking.duration);	2✔
57
58	try {	2✔
59	void control.moveToPosition(position, duration, axesEvent);	2✔
60	} catch (err) {	45✔
61	transitTo(STATE_TYPE.IDLE);
62	axesEvent.setTo({ [AXES.POSITION_KEY]: flicking.camera.position }, 0);
63	}
64	}
65	}	5✔
66
67	export default DraggingState;	50✔

naver / egjs-flicking / 3368151512

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous