3290596867

Build Type

push

github

Committed by GitHub

Commit Message

fix: update fastify + others (#1055)

Run Details

596 of 791 branches covered (75.35%)

Branch coverage included in aggregate %.

19 of 21 new or added lines in 6 files covered. (90.48%)

1 existing line in 1 file now uncovered.

1141 of 1328 relevant lines covered (85.92%)

22.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.36

/src/api/scheduler/routes/activity.ts

import type { FastifyPluginCallback, FastifyRequest } from "fastify";
import fastifyWebsocket from "@fastify/websocket";

// https://stackoverflow.com/questions/4361173/http-headers-in-websockets-client-api
function workAroundWebsocketAuth(req: FastifyRequest) {
  const authToken = req.headers["sec-websocket-protocol"];
  if (!req.headers.authorization) {
    req.headers.authorization = `Bearer ${authToken}`;
  }
}

const activityPlugin: FastifyPluginCallback = (fastify, _opts, done) => {
  fastify.register(fastifyWebsocket);

  fastify.register(async (fastify) => {
    fastify.get(
      "/",
      {
        websocket: true,
        schema: {
          tags: ["DX"],
          summary: "Activity feed, published as websocket",
          description: "Token is passed via Websocket protocol.",
          security: fastify.adminBasedAuthEnabled
            ? [
                {
                  Admin: [],
                  Impersonation: [],
                },
              ]
            : undefined,
        },
      },
      async (connection, req) => {
        workAroundWebsocketAuth(req);

        const tokenId = await fastify.tokenAuth.authenticate(req);

        if (!tokenId) {
          connection.socket.close();
          return;
        }

        const close = fastify.jobs.onEvent(tokenId, (event, job) => {
          connection.socket.send(JSON.stringify([event, job]));
        });

        connection.on("close", close);
      }
    );
  });

  done();
};

export default activityPlugin;

1	import type { FastifyPluginCallback, FastifyRequest } from "fastify";
2	import fastifyWebsocket from "@fastify/websocket";	23✔
3
4	// https://stackoverflow.com/questions/4361173/http-headers-in-websockets-client-api
5	function workAroundWebsocketAuth(req: FastifyRequest) {
6	const authToken = req.headers["sec-websocket-protocol"];	2✔
7	if (!req.headers.authorization) {	2✔
8	req.headers.authorization = `Bearer ${authToken}`;	2✔
9	}
10	}
11
12	const activityPlugin: FastifyPluginCallback = (fastify, _opts, done) => {	23✔
13	fastify.register(fastifyWebsocket);	41✔
14
15	fastify.register(async (fastify) => {	41✔
16	fastify.get(	41✔
17	"/",
18	{
19	websocket: true,
20	schema: {
21	tags: ["DX"],
22	summary: "Activity feed, published as websocket",
23	description: "Token is passed via Websocket protocol.",
24	security: fastify.adminBasedAuthEnabled	41✔
25	? [
26	{
27	Admin: [],
28	Impersonation: [],
29	},
30	]
31	: undefined,
32	},
33	},
34	async (connection, req) => {
35	workAroundWebsocketAuth(req);	2✔
36
37	const tokenId = await fastify.tokenAuth.authenticate(req);	2✔
38
39	if (!tokenId) {	2!
NEW 40	connection.socket.close();	×
NEW 41	return;	×
42	}
43
44	const close = fastify.jobs.onEvent(tokenId, (event, job) => {	2✔
45	connection.socket.send(JSON.stringify([event, job]));	12✔
46	});
47
48	connection.on("close", close);	2✔
49	}
50	);
51	});
52
53	done();	41✔
54	};
55
56	export default activityPlugin;	23✔

quirrel-dev / quirrel / 3290596867

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous