couchbase / moss / 19

pending completion

Build # 19

Build Type

push

travis-ci

Committed by

steveyen

Commit Message

<a href="https://github.com/couchbase/moss/commit/<a class=hub.com/couchbase/moss/commit/6712cd2b73644e1791b186cbadf205590e3e71c6">6712cd2b7<a href="https://github.com/couchbase/moss/commit/6712cd2b73644e1791b186cbadf205590e3e71c6">&quot;&gt;MB-18433 - added CachePersisted option

Change-Id: I</a><a class="double-link" href="https://github.com/couchbase/moss/commit/<a class="double-link" href="https://github.com/couchbase/moss/commit/ac562b2c36b21eed0a076e6de672d8bb192a16b6">ac562b2c3</a>">ac562b2c3</a><a href="https://github.com/couchbase/moss/commit/6712cd2b73644e1791b186cbadf205590e3e71c6">
Reviewed-on: http://review.couchbase.org/60864
Reviewed-by: Marty Schoch <marty.schoch@gmail.com>
Tested-by: Steve Yen <steve.yen@gmail.com>

Run Details

15 of 15 new or added lines in 1 file covered. (100.0%)

1095 of 1166 relevant lines covered (93.91%)

50643.3 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

97.67

/persister.go

//  Copyright (c) 2016 Couchbase, Inc.
//  Licensed under the Apache License, Version 2.0 (the "License");
//  you may not use this file except in compliance with the
//  License. You may obtain a copy of the License at
//    http://www.apache.org/licenses/LICENSE-2.0
//  Unless required by applicable law or agreed to in writing,
//  software distributed under the License is distributed on an "AS
//  IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
//  express or implied. See the License for the specific language
//  governing permissions and limitations under the License.

package moss

// runPersister() implements the persister task.
func (m *collection) runPersister() {
        defer close(m.donePersisterCh)

        if m.options.LowerLevelUpdate == nil {
                return
        }

        checkStop := func() bool {
                select {
                case <-m.stopCh:
                        return true

                default:
                        // NO-OP.
                }

                return false
        }

OUTER:
        for {
                m.m.Lock()

                for m.stackDirtyBase == nil && !checkStop() {
                        m.stackDirtyBaseCond.Wait()
                }

                stackDirtyBase := m.stackDirtyBase

                m.m.Unlock()

                if checkStop() {
                        return
                }

                llssNext, err := m.options.LowerLevelUpdate(stackDirtyBase)
                if err != nil {
                        m.Logf("collection: runPersister, LowerLevelUpdate, err: %v", err)

                        m.OnError(err)

                        continue OUTER
                }

                var stackDirtyBasePrev *segmentStack
                var stackCleanPrev *segmentStack

                m.m.Lock()

                stackCleanPrev = m.stackClean
                if m.options.CachePersisted {
                        m.stackClean = m.stackDirtyBase
                } else {
                        m.stackClean = nil

                        stackDirtyBasePrev = m.stackDirtyBase
                }
                m.stackDirtyBase = nil

                llssPrev := m.lowerLevelSnapshot
                m.lowerLevelSnapshot = newSnapshotWrapper(llssNext)

                m.m.Unlock()

                if stackDirtyBasePrev != nil {
                        stackDirtyBasePrev.Close()
                }

                if stackCleanPrev != nil {
                        stackCleanPrev.Close()
                }

                if llssPrev != nil {
                        llssPrev.Close()
                }
        }

        // TODO: More advanced eviction of stackClean.
        // TODO: Timer based eviction of stackClean?
        // TODO: Randomized eviction?
        // TODO: Merging of stackClean to 1 level?
        // TODO: WaitForMerger() also considers stackClean?
        // TODO: Track popular Get() keys?
        // TODO: Track shadowing during merges for writes.
        // TODO: Consider our own simple storage format?
}

1	// Copyright (c) 2016 Couchbase, Inc.
2	// Licensed under the Apache License, Version 2.0 (the "License");
3	// you may not use this file except in compliance with the
4	// License. You may obtain a copy of the License at
5	// http://www.apache.org/licenses/LICENSE-2.0
6	// Unless required by applicable law or agreed to in writing,
7	// software distributed under the License is distributed on an "AS
8	// IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
9	// express or implied. See the License for the specific language
10	// governing permissions and limitations under the License.
11
12	package moss
13
14	// runPersister() implements the persister task.
15	func (m *collection) runPersister() {	1✔
16	defer close(m.donePersisterCh)	9✔
17		1✔
18	if m.options.LowerLevelUpdate == nil {	9✔
19	return	5✔
20	}	1✔
21		1✔
22	checkStop := func() bool {	1✔
23	select {	3,859,501✔
24	case <-m.stopCh:	1✔
25	return true	6✔
26		1✔
27	default:	1✔
28	// NO-OP.	1✔
29	}	1✔
30		1✔
31	return false	3,859,499✔
32	}	1✔
33		1✔
34	OUTER:	4✔
35	for {	1✔
36	m.m.Lock()	3,859,538✔
37		1✔
38	for m.stackDirtyBase == nil && !checkStop() {	3,859,538✔
39	m.stackDirtyBaseCond.Wait()	8✔
40	}	1✔
41		1✔
42	stackDirtyBase := m.stackDirtyBase	3,859,548✔
43		1✔
44	m.m.Unlock()	3,859,548✔
45		1✔
46	if checkStop() {	3,859,548✔
47	return	3✔
48	}	1✔
49		1✔
50	llssNext, err := m.options.LowerLevelUpdate(stackDirtyBase)	3,859,553✔
51	if err != nil {	3,859,553✔
52	m.Logf("collection: runPersister, LowerLevelUpdate, err: %v", err)	3,859,645✔
53		1✔
54	m.OnError(err)	3,859,645✔
55		1✔
56	continue OUTER	3,859,645✔
57	}	1✔
58		1✔
59	var stackDirtyBasePrev *segmentStack	6✔
60	var stackCleanPrev *segmentStack	6✔
61		1✔
62	m.m.Lock()	6✔
63		1✔
64	stackCleanPrev = m.stackClean	6✔
65	if m.options.CachePersisted {	6✔
66	m.stackClean = m.stackDirtyBase	×
67	} else {	1✔
68	m.stackClean = nil	6✔
69		1✔
70	stackDirtyBasePrev = m.stackDirtyBase	6✔
71	}	1✔
72	m.stackDirtyBase = nil	6✔
73		1✔
74	llssPrev := m.lowerLevelSnapshot	6✔
75	m.lowerLevelSnapshot = newSnapshotWrapper(llssNext)	6✔
76		1✔
77	m.m.Unlock()	6✔
78		1✔
79	if stackDirtyBasePrev != nil {	6✔
80	stackDirtyBasePrev.Close()	6✔
81	}	1✔
82		1✔
83	if stackCleanPrev != nil {	6✔
84	stackCleanPrev.Close()	×
85	}	1✔
86		1✔
87	if llssPrev != nil {	6✔
88	llssPrev.Close()	6✔
89	}	1✔
90	}	1✔
91		1✔
92	// TODO: More advanced eviction of stackClean.	1✔
93	// TODO: Timer based eviction of stackClean?	1✔
94	// TODO: Randomized eviction?	1✔
95	// TODO: Merging of stackClean to 1 level?	1✔
96	// TODO: WaitForMerger() also considers stackClean?	1✔
97	// TODO: Track popular Get() keys?	1✔
98	// TODO: Track shadowing during merges for writes.	1✔
99	// TODO: Consider our own simple storage format?	1✔
100	}	1✔

couchbase / moss / 19

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous