2926998706

Committed 25 Aug 2022 01:45PM UTC coverage: 42.074% (+0.5%) from 41.604%

Build Type

push

github

Committed by GitHub

Commit Message

feat: add permissions management (#4019)

Run Details

1775 of 5210 branches covered (34.07%)

Branch coverage included in aggregate %.

86 of 229 new or added lines in 19 files covered. (37.55%)

41 existing lines in 3 files now uncovered.

4765 of 10334 relevant lines covered (46.11%)

38.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/routes/safe/components/Apps/index.tsx

import { useCallback } from 'react'
import { useHistory } from 'react-router-dom'
import { useSafeAppUrl } from 'src/logic/hooks/useSafeAppUrl'
import AppFrame from 'src/routes/safe/components/Apps/components/AppFrame'
import AppsList from 'src/routes/safe/components/Apps/components/AppsList'
import SecurityFeedbackModal from 'src/routes/safe/components/Apps/components/SecurityFeedbackModal'
import SafeAppsErrorBoundary from 'src/routes/safe/components/Apps/components/SafeAppsErrorBoundary'
import SafeAppsLoadError from 'src/routes/safe/components/Apps/components/SafeAppsLoadError'
import { useSecurityFeedbackModal } from 'src/routes/safe/components/Apps/hooks/useSecurityFeedbackModal'
import { useSafeAppFromManifest } from 'src/routes/safe/components/Apps/hooks/useSafeAppFromManifest'
import { useAppList } from 'src/routes/safe/components/Apps/hooks/appList/useAppList'
import { useBrowserPermissions } from 'src/routes/safe/components/Apps/hooks/permissions'

const Apps = (): React.ReactElement => {
  const history = useHistory()
  const { getAppUrl } = useSafeAppUrl()
  const url = getAppUrl()
  const { addPermissions, getPermissions, getAllowedFeaturesList } = useBrowserPermissions()
  const { isLoading: isSafeAppListLoading, getSafeApp } = useAppList()
  const { isLoading: isSafeAppManifestLoading, safeApp: safeAppManifest } = useSafeAppFromManifest(url)

  const {
    isModalVisible,
    isSafeAppInDefaultList,
    isFirstTimeAccessingApp,
    isConsentAccepted,
    isPermissionsReviewCompleted,
    isExtendedListReviewed,
    onComplete,
    onRemoveCustomApp,
  } = useSecurityFeedbackModal({ url, safeAppManifest, safeApp: getSafeApp(url), addPermissions, getPermissions })

  const goBack = useCallback(() => history.goBack(), [history])

  if (isSafeAppListLoading || isSafeAppManifestLoading) {
    return <div />
  }

  if (url) {
    if (isModalVisible) {
      return (
        <SecurityFeedbackModal
          onCancel={goBack}
          onConfirm={onComplete}
          appUrl={url}
          features={safeAppManifest.safeAppsPermissions || []}
          isConsentAccepted={isConsentAccepted}
          isSafeAppInDefaultList={isSafeAppInDefaultList}
          isFirstTimeAccessingApp={isFirstTimeAccessingApp}
          isExtendedListReviewed={isExtendedListReviewed}
          isPermissionsReviewCompleted={isPermissionsReviewCompleted}
        />
      )
    }

    return (
      <SafeAppsErrorBoundary render={() => <SafeAppsLoadError />}>
        <AppFrame appUrl={url} allowedFeaturesList={getAllowedFeaturesList(url)} />
      </SafeAppsErrorBoundary>
    )
  } else {
    return <AppsList onRemoveApp={onRemoveCustomApp} />
  }
}

export default Apps

1	import { useCallback } from 'react'
2	import { useHistory } from 'react-router-dom'
3	import { useSafeAppUrl } from 'src/logic/hooks/useSafeAppUrl'
4	import AppFrame from 'src/routes/safe/components/Apps/components/AppFrame'
5	import AppsList from 'src/routes/safe/components/Apps/components/AppsList'
6	import SecurityFeedbackModal from 'src/routes/safe/components/Apps/components/SecurityFeedbackModal'
7	import SafeAppsErrorBoundary from 'src/routes/safe/components/Apps/components/SafeAppsErrorBoundary'
8	import SafeAppsLoadError from 'src/routes/safe/components/Apps/components/SafeAppsLoadError'
9	import { useSecurityFeedbackModal } from 'src/routes/safe/components/Apps/hooks/useSecurityFeedbackModal'
10	import { useSafeAppFromManifest } from 'src/routes/safe/components/Apps/hooks/useSafeAppFromManifest'
11	import { useAppList } from 'src/routes/safe/components/Apps/hooks/appList/useAppList'
12	import { useBrowserPermissions } from 'src/routes/safe/components/Apps/hooks/permissions'
13
14	const Apps = (): React.ReactElement => {	×
15	const history = useHistory()	×
16	const { getAppUrl } = useSafeAppUrl()	×
17	const url = getAppUrl()	×
NEW 18	const { addPermissions, getPermissions, getAllowedFeaturesList } = useBrowserPermissions()	×
NEW 19	const { isLoading: isSafeAppListLoading, getSafeApp } = useAppList()	×
NEW 20	const { isLoading: isSafeAppManifestLoading, safeApp: safeAppManifest } = useSafeAppFromManifest(url)	×
21
22	const {
23	isModalVisible,
24	isSafeAppInDefaultList,
25	isFirstTimeAccessingApp,
26	isConsentAccepted,
27	isPermissionsReviewCompleted,
28	isExtendedListReviewed,
29	onComplete,
30	onRemoveCustomApp,
NEW 31	} = useSecurityFeedbackModal({ url, safeAppManifest, safeApp: getSafeApp(url), addPermissions, getPermissions })	×
32
33	const goBack = useCallback(() => history.goBack(), [history])	×
34
NEW 35	if (isSafeAppListLoading \|\| isSafeAppManifestLoading) {	×
NEW 36	return <div />	×
37	}
38
39	if (url) {	×
40	if (isModalVisible) {	×
41	return (	×
42	<SecurityFeedbackModal
43	onCancel={goBack}
44	onConfirm={onComplete}
45	appUrl={url}
46	features={safeAppManifest.safeAppsPermissions \|\| []}	×
47	isConsentAccepted={isConsentAccepted}
48	isSafeAppInDefaultList={isSafeAppInDefaultList}
49	isFirstTimeAccessingApp={isFirstTimeAccessingApp}
50	isExtendedListReviewed={isExtendedListReviewed}
51	isPermissionsReviewCompleted={isPermissionsReviewCompleted}
52	/>
53	)
54	}
55
56	return (	×
57	<SafeAppsErrorBoundary render={() => <SafeAppsLoadError />}>	×
58	<AppFrame appUrl={url} allowedFeaturesList={getAllowedFeaturesList(url)} />
59	</SafeAppsErrorBoundary>
60	)
61	} else {
62	return <AppsList onRemoveApp={onRemoveCustomApp} />	×
63	}
64	}
65
66	export default Apps

safe-global / safe-react / 2926998706

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous