2795561137

Build Type

github

Committed by GitHub

Commit Message

Merge f06ff8140 into 586d8248a

Pull Request Pull Request #711: fix: fix error when onChange occur during holding state

Run Details

4319 of 7033 branches covered (61.41%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 4 files covered. (100.0%)

31 existing lines in 7 files now uncovered.

7995 of 8559 relevant lines covered (93.41%)

137.78 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

17.11

/src/cfc/withFlickingMethods.ts

import Component from "@egjs/component";

import Flicking from "../Flicking";

/**
 * Decorator that makes the method of flicking available in the framework.
 * @ko 프레임워크에서 플리킹의 메소드를 사용할 수 있게 하는 데코레이터.
 * @memberof eg.Flicking
 * @private
 * @example
 * ```js
 * import Flicking, { withFlickingMethods } from "@egjs/flicking";
 *
 * class Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>> {
 *   &#64;withFlickingMethods
 *   private flicking: Flicking;
 * }
 * ```
 */
const withFlickingMethods = (prototype: any, flickingName: string) => {
  [Component.prototype, Flicking.prototype].forEach(proto => {
    Object.getOwnPropertyNames(proto).filter(name => !prototype[name] && name.indexOf("_") !== 0 && name !== "constructor")
      .forEach((name: string) => {
        const descriptor = Object.getOwnPropertyDescriptor(proto, name)!;

        if (descriptor.value) {
          // Public Function
          Object.defineProperty(prototype, name, {
            value: function(...args) {
              return descriptor.value.call(this[flickingName], ...args);
            }
          });
        } else {
          const getterDescriptor: { get?: () => any; set?: (val: any) => void } = {};
          if (descriptor.get) {
            getterDescriptor.get = function() {
              const flicking = this[flickingName];
              return flicking && descriptor.get?.call(flicking);
            };
          }
          if (descriptor.set) {
            getterDescriptor.set = function(...args) {
              return descriptor.set?.call(this[flickingName], ...args);
            };
          }

          Object.defineProperty(prototype, name, getterDescriptor);
        }
      });
  });
};

export default withFlickingMethods;

1	import Component from "@egjs/component";	6✔
2		1✔
3	import Flicking from "../Flicking";	5!
4		×
5	/**	×
6	* Decorator that makes the method of flicking available in the framework.
7	* @ko 프레임워크에서 플리킹의 메소드를 사용할 수 있게 하는 데코레이터.
8	* @memberof eg.Flicking
9	* @private	×
10	* @example
11	* ```js	1✔
12	* import Flicking, { withFlickingMethods } from "@egjs/flicking";	2!
13	*
14	* class Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>> {	1✔
15	* @withFlickingMethods	1✔
16	* private flicking: Flicking;	1✔
17	* }
18	* ```
19	*/
20	const withFlickingMethods = (prototype: any, flickingName: string) => {	5✔
21	[Component.prototype, Flicking.prototype].forEach(proto => {
22	Object.getOwnPropertyNames(proto).filter(name => !prototype[name] && name.indexOf("_") !== 0 && name !== "constructor")	×
23	.forEach((name: string) => {
24	const descriptor = Object.getOwnPropertyDescriptor(proto, name)!;
25
26	if (descriptor.value) {	×
27	// Public Function
28	Object.defineProperty(prototype, name, {
29	value: function(...args) {
30	return descriptor.value.call(this[flickingName], ...args);
31	}
32	});	1✔
33	} else {
34	const getterDescriptor: { get?: () => any; set?: (val: any) => void } = {};	×
35	if (descriptor.get) {	×
36	getterDescriptor.get = function() {	×
37	const flicking = this[flickingName];	×
38	return flicking && descriptor.get?.call(flicking);	×
39	};
40	}
41	if (descriptor.set) {	×
42	getterDescriptor.set = function(...args) {	×
43	return descriptor.set?.call(this[flickingName], ...args);	×
44	};
45	}
46
47	Object.defineProperty(prototype, name, getterDescriptor);
48	}
49	});
50	});
51	};
52		×
53	export default withFlickingMethods;	5✔

naver / egjs-flicking / 2795561137

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous