#3424

pending completion

Build # #3424

Build Type

push

coveralls-python

Committed by

suhaibmujahid

Commit Message

<a href="https://github.com/mozilla/relman-auto-nag/commit/<a class=hub.com/mozilla/relman-auto-nag/commit/163d45b62a2e499229afeb11198aa0d96678c059">163d45b62<a href="https://github.com/mozilla/relman-auto-nag/commit/163d45b62a2e499229afeb11198aa0d96678c059">&quot;&gt;Revert &amp;quot;[fuzz_blockers] Exclude old bugs (#1584)&quot;

This reverts commit </a><a class="double-link" href="https://github.com/mozilla/relman-auto-nag/commit/<a class="double-link" href="https://github.com/mozilla/relman-auto-nag/commit/c5727e01c8a34afab5939e4453178e50599b5484">c5727e01c</a>">c5727e01c</a><a href="https://github.com/mozilla/relman-auto-nag/commit/163d45b62a2e499229afeb11198aa0d96678c059">.

Run Details

502 of 2881 branches covered (17.42%)

1517 of 7068 relevant lines covered (21.46%)

0.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/auto_nag/scripts/workflow/no_severity.py

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at http://mozilla.org/MPL/2.0/.

from libmozdata import utils as lmdutils

from auto_nag import utils
from auto_nag.bzcleaner import BzCleaner
from auto_nag.escalation import Escalation
from auto_nag.nag_me import Nag
from auto_nag.round_robin import RoundRobin


class NoSeverity(BzCleaner, Nag):
    def __init__(self, typ, inactivity_days: int = 3):
        """Constructor

        Args:
            typ: the mode that the tool should run with (first or second). Nag
                emails will be sent only if `typ` is second.
            inactivity_days: number of days that a bug should be inactive before
                being considered.
        """
        super(NoSeverity, self).__init__()
        assert typ in {"first", "second"}
        self.typ = typ
        self.lookup_first = utils.get_config(self.name(), "first-step", 2)
        self.lookup_second = utils.get_config(self.name(), "second-step", 4)
        self.escalation = Escalation(
            self.people,
            data=utils.get_config(self.name(), "escalation-{}".format(typ)),
            skiplist=utils.get_config("workflow", "supervisor_skiplist", []),
        )
        self.round_robin = RoundRobin.get_instance()
        self.components_skiplist = utils.get_config("workflow", "components_skiplist")
        self.activity_date = lmdutils.get_date("today", inactivity_days)

    def description(self):
        return "Bugs without a severity or statuses set"

    def nag_template(self):
        return self.template()

    def nag_preamble(self):
        return """<p>
  <ul>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#why-triage">Why triage?</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#what-do-you-triage">What do you triage?</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/priority.html">Priority definitions</a></li>
    <li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/severity.html">Severty definitions</a></li>
  </ul>
</p>"""

    def get_extra_for_template(self):
        return {
            "nweeks": self.lookup_first if self.typ == "first" else self.lookup_second
        }

    def get_extra_for_needinfo_template(self):
        return self.get_extra_for_template()

    def get_extra_for_nag_template(self):
        return self.get_extra_for_template()

    def has_product_component(self):
        return True

    def ignore_meta(self):
        return True

    def columns(self):
        return ["component", "id", "summary"]

    def handle_bug(self, bug, data):
        if (
            # check if the product::component is in the list
            utils.check_product_component(self.components_skiplist, bug)
            or utils.get_last_no_bot_comment_date(bug) > self.activity_date
        ):
            return None
        return bug

    def get_mail_to_auto_ni(self, bug):
        if self.typ == "second":
            return None

        mail, nick = self.round_robin.get(bug, self.date)
        if mail and nick:
            return {"mail": mail, "nickname": nick}

        return None

    def set_people_to_nag(self, bug, buginfo):
        priority = "default"
        if not self.filter_bug(priority):
            return None

        # don't nag in the first step (just a ni is enough)
        if self.typ == "first":
            return bug

        owners = self.round_robin.get(bug, self.date, only_one=False, has_nick=False)
        real_owner = bug["triage_owner"]
        self.add_triage_owner(owners, real_owner=real_owner)
        if not self.add(owners, buginfo, priority=priority):
            self.add_no_manager(buginfo["id"])
        return bug

    def get_bz_params(self, date):
        fields = [
            "triage_owner",
            "flags",
            "comments.creator",
            "comments.creation_time",
        ]
        params = {
            "include_fields": fields,
            "keywords": "intermittent-failure",
            "keywords_type": "nowords",
            "email2": "wptsync@mozilla.bugs",
            "emailreporter2": "1",
            "emailtype2": "notequals",
            "resolution": "---",
            "f21": "bug_type",
            "o21": "equals",
            "v21": "defect",
            "f22": "flagtypes.name",
            "o22": "notsubstring",
            "v22": "needinfo?",
            "f23": "bug_severity",
            "o23": "anyexact",
            "v23": "--, n/a",
        }
        self.date = lmdutils.get_date_ymd(date)
        first = f"-{self.lookup_first * 7}d"
        second = f"-{self.lookup_second * 7}d"
        if self.typ == "first":
            # TODO: change this when https://bugzilla.mozilla.org/1543984 will be fixed
            # Here we have to get bugs where product/component have been set (bug has been triaged)
            # between 4 and 2 weeks
            # If the product/component never changed after bug creation, we need to get them too
            # (second < p < first && c < first) ||
            # (second < c < first && p < first) ||
            # ((second < creation < first) && pc never changed)
            params.update(
                {
                    "f2": "flagtypes.name",
                    "o2": "notequals",
                    "v2": "needinfo?",
                    "j3": "OR",
                    "f3": "OP",
                    "j4": "AND",
                    "f4": "OP",
                    "n5": 1,  # we use a negation here to be sure that no change after first
                    "f5": "product",
                    "o5": "changedafter",
                    "v5": first,
                    "f6": "product",  # here the bug has changed
                    "o6": "changedafter",
                    "v6": second,
                    "n7": 1,
                    "f7": "component",
                    "o7": "changedafter",
                    "v7": first,
                    "f8": "CP",
                    "j9": "AND",
                    "f9": "OP",
                    "n10": 1,
                    "f10": "component",
                    "o10": "changedafter",
                    "v10": first,
                    "f11": "component",
                    "o11": "changedafter",
                    "v11": second,
                    "n12": 1,
                    "f12": "product",
                    "o12": "changedafter",
                    "v12": first,
                    "f13": "CP",
                    "j14": "AND",
                    "f14": "OP",
                    "f15": "creation_ts",
                    "o15": "lessthaneq",
                    "v15": first,
                    "f16": "creation_ts",
                    "o16": "greaterthan",
                    "v16": second,
                    "n17": 1,
                    "f17": "product",
                    "o17": "everchanged",
                    "n18": 1,
                    "f18": "component",
                    "o18": "everchanged",
                    "f19": "CP",
                    "f20": "CP",
                }
            )
        else:
            params.update(
                {
                    "j2": "OR",
                    "f2": "OP",
                    "j3": "AND",
                    "f3": "OP",
                    "f4": "product",
                    "o4": "changedbefore",
                    "v4": second,
                    "n5": 1,
                    "f5": "product",
                    "o5": "changedafter",
                    "v5": second,
                    "f6": "CP",
                    "j7": "AND",
                    "f7": "OP",
                    "f8": "component",
                    "o8": "changedbefore",
                    "v8": second,
                    "n9": 1,
                    "f9": "component",
                    "o9": "changedafter",
                    "v9": second,
                    "f10": "CP",
                    "j11": "AND",
                    "f11": "OP",
                    "f12": "creation_ts",
                    "o12": "lessthaneq",
                    "v12": second,
                    "n13": 1,
                    "f13": "product",
                    "o13": "everchanged",
                    "n14": 1,
                    "f14": "component",
                    "o14": "everchanged",
                    "f15": "CP",
                    "f16": "CP",
                }
            )

        return params


if __name__ == "__main__":
    NoSeverity("first").run()
    NoSeverity("second").run()

1	# This Source Code Form is subject to the terms of the Mozilla Public
2	# License, v. 2.0. If a copy of the MPL was not distributed with this file,
3	# You can obtain one at http://mozilla.org/MPL/2.0/.
4
5	from libmozdata import utils as lmdutils	×
6
7	from auto_nag import utils	×
8	from auto_nag.bzcleaner import BzCleaner	×
9	from auto_nag.escalation import Escalation	×
10	from auto_nag.nag_me import Nag	×
11	from auto_nag.round_robin import RoundRobin	×
12
13
14	class NoSeverity(BzCleaner, Nag):	×
15	def __init__(self, typ, inactivity_days: int = 3):	×
16	"""Constructor
17
18	Args:
19	typ: the mode that the tool should run with (first or second). Nag
20	emails will be sent only if `typ` is second.
21	inactivity_days: number of days that a bug should be inactive before
22	being considered.
23	"""
24	super(NoSeverity, self).__init__()	×
25	assert typ in {"first", "second"}	×
26	self.typ = typ	×
27	self.lookup_first = utils.get_config(self.name(), "first-step", 2)	×
28	self.lookup_second = utils.get_config(self.name(), "second-step", 4)	×
29	self.escalation = Escalation(	×
30	self.people,
31	data=utils.get_config(self.name(), "escalation-{}".format(typ)),
32	skiplist=utils.get_config("workflow", "supervisor_skiplist", []),
33	)
34	self.round_robin = RoundRobin.get_instance()	×
35	self.components_skiplist = utils.get_config("workflow", "components_skiplist")	×
36	self.activity_date = lmdutils.get_date("today", inactivity_days)	×
37
38	def description(self):	×
39	return "Bugs without a severity or statuses set"	×
40
41	def nag_template(self):	×
42	return self.template()	×
43
44	def nag_preamble(self):	×
45	return """<p>	×
46	<ul>
47	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#why-triage">Why triage?</a></li>
48	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#what-do-you-triage">What do you triage?</a></li>
49	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/priority.html">Priority definitions</a></li>
50	<li><a href="https://firefox-source-docs.mozilla.org/bug-mgmt/guides/severity.html">Severty definitions</a></li>
51	</ul>
52	</p>"""
53
54	def get_extra_for_template(self):	×
55	return {	×
56	"nweeks": self.lookup_first if self.typ == "first" else self.lookup_second
57	}
58
59	def get_extra_for_needinfo_template(self):	×
60	return self.get_extra_for_template()	×
61
62	def get_extra_for_nag_template(self):	×
63	return self.get_extra_for_template()	×
64
65	def has_product_component(self):	×
66	return True	×
67
68	def ignore_meta(self):	×
69	return True	×
70
71	def columns(self):	×
72	return ["component", "id", "summary"]	×
73
74	def handle_bug(self, bug, data):	×
75	if (	×
76	# check if the product::component is in the list
77	utils.check_product_component(self.components_skiplist, bug)
78	or utils.get_last_no_bot_comment_date(bug) > self.activity_date
79	):
80	return None	×
81	return bug	×
82
83	def get_mail_to_auto_ni(self, bug):	×
84	if self.typ == "second":	×
85	return None	×
86
87	mail, nick = self.round_robin.get(bug, self.date)	×
88	if mail and nick:	×
89	return {"mail": mail, "nickname": nick}	×
90
91	return None	×
92
93	def set_people_to_nag(self, bug, buginfo):	×
94	priority = "default"	×
95	if not self.filter_bug(priority):	×
96	return None	×
97
98	# don't nag in the first step (just a ni is enough)
99	if self.typ == "first":	×
100	return bug	×
101
102	owners = self.round_robin.get(bug, self.date, only_one=False, has_nick=False)	×
103	real_owner = bug["triage_owner"]	×
104	self.add_triage_owner(owners, real_owner=real_owner)	×
105	if not self.add(owners, buginfo, priority=priority):	×
106	self.add_no_manager(buginfo["id"])	×
107	return bug	×
108
109	def get_bz_params(self, date):	×
110	fields = [	×
111	"triage_owner",
112	"flags",
113	"comments.creator",
114	"comments.creation_time",
115	]
116	params = {	×
117	"include_fields": fields,
118	"keywords": "intermittent-failure",
119	"keywords_type": "nowords",
120	"email2": "wptsync@mozilla.bugs",
121	"emailreporter2": "1",
122	"emailtype2": "notequals",
123	"resolution": "---",
124	"f21": "bug_type",
125	"o21": "equals",
126	"v21": "defect",
127	"f22": "flagtypes.name",
128	"o22": "notsubstring",
129	"v22": "needinfo?",
130	"f23": "bug_severity",
131	"o23": "anyexact",
132	"v23": "--, n/a",
133	}
134	self.date = lmdutils.get_date_ymd(date)	×
135	first = f"-{self.lookup_first * 7}d"	×
136	second = f"-{self.lookup_second * 7}d"	×
137	if self.typ == "first":	×
138	# TODO: change this when https://bugzilla.mozilla.org/1543984 will be fixed
139	# Here we have to get bugs where product/component have been set (bug has been triaged)
140	# between 4 and 2 weeks
141	# If the product/component never changed after bug creation, we need to get them too
142	# (second < p < first && c < first) \|\|
143	# (second < c < first && p < first) \|\|
144	# ((second < creation < first) && pc never changed)
145	params.update(	×
146	{
147	"f2": "flagtypes.name",
148	"o2": "notequals",
149	"v2": "needinfo?",
150	"j3": "OR",
151	"f3": "OP",
152	"j4": "AND",
153	"f4": "OP",
154	"n5": 1, # we use a negation here to be sure that no change after first
155	"f5": "product",
156	"o5": "changedafter",
157	"v5": first,
158	"f6": "product", # here the bug has changed
159	"o6": "changedafter",
160	"v6": second,
161	"n7": 1,
162	"f7": "component",
163	"o7": "changedafter",
164	"v7": first,
165	"f8": "CP",
166	"j9": "AND",
167	"f9": "OP",
168	"n10": 1,
169	"f10": "component",
170	"o10": "changedafter",
171	"v10": first,
172	"f11": "component",
173	"o11": "changedafter",
174	"v11": second,
175	"n12": 1,
176	"f12": "product",
177	"o12": "changedafter",
178	"v12": first,
179	"f13": "CP",
180	"j14": "AND",
181	"f14": "OP",
182	"f15": "creation_ts",
183	"o15": "lessthaneq",
184	"v15": first,
185	"f16": "creation_ts",
186	"o16": "greaterthan",
187	"v16": second,
188	"n17": 1,
189	"f17": "product",
190	"o17": "everchanged",
191	"n18": 1,
192	"f18": "component",
193	"o18": "everchanged",
194	"f19": "CP",
195	"f20": "CP",
196	}
197	)
198	else:
199	params.update(	×
200	{
201	"j2": "OR",
202	"f2": "OP",
203	"j3": "AND",
204	"f3": "OP",
205	"f4": "product",
206	"o4": "changedbefore",
207	"v4": second,
208	"n5": 1,
209	"f5": "product",
210	"o5": "changedafter",
211	"v5": second,
212	"f6": "CP",
213	"j7": "AND",
214	"f7": "OP",
215	"f8": "component",
216	"o8": "changedbefore",
217	"v8": second,
218	"n9": 1,
219	"f9": "component",
220	"o9": "changedafter",
221	"v9": second,
222	"f10": "CP",
223	"j11": "AND",
224	"f11": "OP",
225	"f12": "creation_ts",
226	"o12": "lessthaneq",
227	"v12": second,
228	"n13": 1,
229	"f13": "product",
230	"o13": "everchanged",
231	"n14": 1,
232	"f14": "component",
233	"o14": "everchanged",
234	"f15": "CP",
235	"f16": "CP",
236	}
237	)
238
239	return params	×
240
241
242	if __name__ == "__main__":	×
243	NoSeverity("first").run()	×
244	NoSeverity("second").run()	×

mozilla / relman-auto-nag / #3424

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous