2696329494

Committed 19 Jul 2022 08:47AM UTC coverage: 41.614% (+0.001%) from 41.613%

Build Type

push

github

Committed by GitHub

Commit Message

fix: Verify spending limit contract address for displaying custom UI (#4020)

Run Details

1756 of 5111 branches covered (34.36%)

Branch coverage included in aggregate %.

1 of 6 new or added lines in 2 files covered. (16.67%)

11 existing lines in 3 files now uncovered.

4581 of 10117 relevant lines covered (45.28%)

38.47 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

4.88

/src/routes/safe/components/Transactions/TxList/TxData.tsx

import { TransactionData } from '@gnosis.pm/safe-react-gateway-sdk'
import { ReactElement, ReactNode } from 'react'

import { getNativeCurrency } from 'src/config'
import { ExpandedTxDetails, isCustomTxInfo } from 'src/logic/safe/store/models/types/gateway.d'
import { fromTokenUnit } from 'src/logic/tokens/utils/humanReadableValue'
import {
  DeleteSpendingLimitDetails,
  isDeleteAllowance,
  isSetAllowance,
  isSupportedSpendingLimitAddress,
  ModifySpendingLimitDetails,
} from './SpendingLimitDetails'
import { TxInfoDetails } from './TxInfoDetails'
import { HexEncodedData } from './HexEncodedData'
import { MethodDetails } from './MethodDetails'
import { MultiSendDetails } from './MultiSendDetails'
import { TransactionInfo } from '@gnosis.pm/safe-react-gateway-sdk'
import { getInteractionTitle } from '../helpers/utils'
import { isSupportedMultiSendCall } from 'src/logic/safe/transactions/multisend'

type DetailsWithTxInfoProps = {
  children: ReactNode
  txData: TransactionData
  txInfo: TransactionInfo
}

const DetailsWithTxInfo = ({ children, txData, txInfo }: DetailsWithTxInfoProps): ReactElement => {
  const nativeCurrency = getNativeCurrency()
  const amount = txData.value ? fromTokenUnit(txData.value, nativeCurrency.decimals) : 'n/a'
  let name
  let avatarUrl

  if (isCustomTxInfo(txInfo)) {
    name = txInfo.to.name
    avatarUrl = txInfo.to.logoUri
  }

  return (
    <>
      <TxInfoDetails address={txData.to.value} name={name} avatarUrl={avatarUrl} title={getInteractionTitle(amount)} />
      {children}
    </>
  )
}

type TxDataProps = {
  txData: ExpandedTxDetails['txData']
  txInfo: TransactionInfo
}

export const TxData = ({ txData, txInfo }: TxDataProps): ReactElement | null => {
  // nothing to render
  if (!txData) {
    return null
  }

  // unknown tx information
  if (!txData.dataDecoded) {
    // no hex data, nothing to render
    if (!txData.hexData) {
      return null
    }

    // we render the hex encoded data
    return (
      <DetailsWithTxInfo txData={txData} txInfo={txInfo}>
        <HexEncodedData title="Data (hex encoded)" hexData={txData.hexData} />
      </DetailsWithTxInfo>
    )
  }

  if (isSupportedMultiSendCall(txInfo)) {
    return <MultiSendDetails txData={txData} />
  }

  // FixMe: this way won't scale well
  if (isSupportedSpendingLimitAddress(txInfo) && isSetAllowance(txData.dataDecoded.method)) {
    return <ModifySpendingLimitDetails txData={txData} txInfo={txInfo} />
  }

  // FixMe: this way won't scale well
  if (isSupportedSpendingLimitAddress(txInfo) && isDeleteAllowance(txData.dataDecoded.method)) {
    return <DeleteSpendingLimitDetails txData={txData} txInfo={txInfo} />
  }

  // we render the decoded data
  return (
    <DetailsWithTxInfo txData={txData} txInfo={txInfo}>
      <MethodDetails data={txData.dataDecoded} />
    </DetailsWithTxInfo>
  )
}

1	import { TransactionData } from '@gnosis.pm/safe-react-gateway-sdk'
2	import { ReactElement, ReactNode } from 'react'
3
4	import { getNativeCurrency } from 'src/config'
5	import { ExpandedTxDetails, isCustomTxInfo } from 'src/logic/safe/store/models/types/gateway.d'
6	import { fromTokenUnit } from 'src/logic/tokens/utils/humanReadableValue'
7	import {
8	DeleteSpendingLimitDetails,
9	isDeleteAllowance,
10	isSetAllowance,
11	isSupportedSpendingLimitAddress,
12	ModifySpendingLimitDetails,
13	} from './SpendingLimitDetails'
14	import { TxInfoDetails } from './TxInfoDetails'
15	import { HexEncodedData } from './HexEncodedData'
16	import { MethodDetails } from './MethodDetails'
17	import { MultiSendDetails } from './MultiSendDetails'
18	import { TransactionInfo } from '@gnosis.pm/safe-react-gateway-sdk'
19	import { getInteractionTitle } from '../helpers/utils'
20	import { isSupportedMultiSendCall } from 'src/logic/safe/transactions/multisend'
21
22	type DetailsWithTxInfoProps = {
23	children: ReactNode
24	txData: TransactionData
25	txInfo: TransactionInfo
26	}
27
28	const DetailsWithTxInfo = ({ children, txData, txInfo }: DetailsWithTxInfoProps): ReactElement => {	2✔
29	const nativeCurrency = getNativeCurrency()	×
30	const amount = txData.value ? fromTokenUnit(txData.value, nativeCurrency.decimals) : 'n/a'	×
31	let name
32	let avatarUrl
33
34	if (isCustomTxInfo(txInfo)) {	×
35	name = txInfo.to.name	×
36	avatarUrl = txInfo.to.logoUri	×
37	}
38
39	return (	×
40	<>
41	<TxInfoDetails address={txData.to.value} name={name} avatarUrl={avatarUrl} title={getInteractionTitle(amount)} />
42	{children}
43	</>
44	)
45	}
46
47	type TxDataProps = {
48	txData: ExpandedTxDetails['txData']
49	txInfo: TransactionInfo
50	}
51
52	export const TxData = ({ txData, txInfo }: TxDataProps): ReactElement \| null => {	2✔
53	// nothing to render
54	if (!txData) {	×
55	return null	×
56	}
57
58	// unknown tx information
59	if (!txData.dataDecoded) {	×
60	// no hex data, nothing to render
61	if (!txData.hexData) {	×
62	return null	×
63	}
64
65	// we render the hex encoded data
66	return (	×
67	<DetailsWithTxInfo txData={txData} txInfo={txInfo}>
68	<HexEncodedData title="Data (hex encoded)" hexData={txData.hexData} />
69	</DetailsWithTxInfo>
70	)
71	}
72
UNCOV 73	if (isSupportedMultiSendCall(txInfo)) {	×
74	return <MultiSendDetails txData={txData} />	×
75	}
76
77	// FixMe: this way won't scale well
NEW 78	if (isSupportedSpendingLimitAddress(txInfo) && isSetAllowance(txData.dataDecoded.method)) {	×
79	return <ModifySpendingLimitDetails txData={txData} txInfo={txInfo} />	×
80	}
81
82	// FixMe: this way won't scale well
NEW 83	if (isSupportedSpendingLimitAddress(txInfo) && isDeleteAllowance(txData.dataDecoded.method)) {	×
84	return <DeleteSpendingLimitDetails txData={txData} txInfo={txInfo} />	×
85	}
86
87	// we render the decoded data
UNCOV 88	return (	×
89	<DetailsWithTxInfo txData={txData} txInfo={txInfo}>
90	<MethodDetails data={txData.dataDecoded} />
91	</DetailsWithTxInfo>
92	)
93	}

safe-global / safe-react / 2696329494

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous