2508393672

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/electron/fiddle/commit/<a class=hub.com/electron/fiddle/commit/<a class="double-link" href="https://git"><a class=hub.com/electron/fiddle/commit/<a class="double-link" href="https://git"><a class=hub.com/electron/fiddle/commit/<a class="double-link" href="https://git"><a class=hub.com/electron/fiddle/commit/<a class="double-link" href="https://git"><a class=hub.com/electron/fiddle/commit/c311a8ed13fbce4e92e77d5113efe10f931c6a99">c311a8ed1">&lt;a href=&quot;https://github.com/electron/fiddle/commit/</a><a class="double-link" href="https://github.com/electron/fiddle/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/electron/fiddle/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/electron/fiddle/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/electron/fiddle/commit/c311a8ed13fbce4e92e77d5113efe10f931c6a99">c311a8ed1</a><a href="https://github.com/electron/fiddle/commit/c311a8ed13fbce4e92e77d5113efe10f931c6a99">&lt;a href=&quot;https://github.com/electron/fiddle/commit/c311a8ed13fbce4e92e77d5113efe10f931c6a99&quot;&gt;&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/electron/fiddle/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/electron/fiddle/commit/&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://git&amp;quot;&amp;gt;&amp;amp;lt;a class=&amp;lt;/a&amp;gt;hub.com/electron/fiddle/commit/c311a8ed13fbce4e92e77d5113efe10f931c6a99&amp;quot;&amp;gt;c311a8ed1&amp;lt;/a&amp;gt;&amp;lt;a href=&amp;quot;https://github.com/electron/fiddle/commit/c311a8ed13fbce4e92e77d5113efe10f931c6a99&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/electron/fiddle/commit/c311a8ed13fbce4e92e77d5113efe10f&amp;lt;/a&amp;gt;931</a>c6a99&quot;&gt;&amp;quot;&amp;gt;Merge &amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/electron/fiddle/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/electron/fiddle/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/electron/fiddle/commit/29460ee08&quot;&gt;29460ee08&lt;/a&gt;&lt;a href=&quot;htt... (continued)

Pull Request Pull Request #1106: Test make

Run Details

1088 of 1240 branches covered (87.74%)

Branch coverage included in aggregate %.

2484 of 2484 new or added lines in 86 files covered. (100.0%)

3342 of 3522 relevant lines covered (94.89%)

116.39 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.0

/src/renderer/components/version-select.tsx

import {
  Button,
  ButtonGroupProps,
  ContextMenu,
  Menu,
  MenuItem,
} from '@blueprintjs/core';
import { ItemListPredicate, ItemRenderer, Select } from '@blueprintjs/select';
import { clipboard } from 'electron';
import { observer } from 'mobx-react';
import * as React from 'react';
import semver from 'semver';

import { RunnableVersion, VersionSource, VersionState } from '../../interfaces';
import { highlightText } from '../../utils/highlight-text';
import { AppState } from '../state';

const ElectronVersionSelect = Select.ofType<RunnableVersion>();

/**
 * Helper method: Returns the <Select /> label for an Electron
 * version.
 *
 * @param {RunnableVersion} { source, state }
 * @returns {string}
 */
export function getItemLabel({ source, state, name }: RunnableVersion): string {
  let label = '';

  if (source === VersionSource.local) {
    label = name || 'Local';
  } else {
    if (state === VersionState.unknown) {
      label = `Not downloaded`;
    } else if (state === VersionState.ready) {
      label = `Downloaded`;
    } else if (state === VersionState.downloading) {
      label = `Downloading`;
    }
  }

  return label;
}

/**
 * Helper method: Returns the <Select /> icon for an Electron
 * version.
 *
 * @param {RunnableVersion} { state }
 * @returns
 */
export function getItemIcon({ state }: RunnableVersion) {
  switch (state) {
    case VersionState.unknown:
      return 'cloud';
    case VersionState.ready:
      return 'saved';
    case VersionState.downloading:
      return 'cloud-download';
    case VersionState.unzipping:
      return 'compressed';
  }
}

/**
 * Helper method: Returns the <Select /> predicate for an Electron
 * version.
 *
 * Sorts by index of the chosen query.
 * For example, if we take the following versions:
 * [3.0.0, 14.3.0, 13.2.0, 12.0.0-nightly.20210301, 12.0.0-beta.3]
 * and a search query of '3', this method would sort them into:
 * [3.0.0, 13.2.0, 14.3.0, 12.0.0-beta.3, 12.0.0-nightly.20210301]
 *
 * @param {string} query
 * @param {RunnableVersion[]} versions
 * @returns
 */
export const filterItems: ItemListPredicate<RunnableVersion> = (
  query,
  versions,
) => {
  if (query === '') return versions;

  const q = query.toLowerCase();

  return versions
    .map((version: RunnableVersion) => {
      const lowercase = version.version.toLowerCase();
      return {
        index: lowercase.indexOf(q),
        coerced: semver.coerce(lowercase),
        version,
      };
    })
    .filter((item) => item.index !== -1)
    .sort((a, b) => {
      // If the user is searching for e.g. 'nightly' we
      // want to sort nightlies by descending major version.
      if (isNaN(+q)) {
        if (a.coerced && b.coerced) {
          return semver.rcompare(a.coerced, b.coerced);
        }
      }
      return a.index - b.index;
    })
    .map((item) => item.version);
};

/**
 * Renders a context menu to copy the current Electron version.
 *
 * @param {React.MouseEvent<HTMLButtonElement>} e
 * @param {string} version the Electron version number to copy.
 */
export const renderVersionContextMenu = (
  e: React.MouseEvent<HTMLButtonElement>,
  version: string,
) => {
  e.preventDefault();

  ContextMenu.show(
    <Menu>
      <MenuItem
        text="Copy Version Number"
        onClick={() => {
          clipboard.writeText(version);
        }}
      />
    </Menu>,
    { left: e.clientX, top: e.clientY },
  );
};

/**
 * Helper method: Returns the <Select /> <MenuItem /> for Electron
 * versions.
 *
 * @param {RunnableVersion} item
 * @param {IItemRendererProps} { handleClick, modifiers, query }
 * @returns
 */
export const renderItem: ItemRenderer<RunnableVersion> = (
  item,
  { handleClick, modifiers, query },
) => {
  if (!modifiers.matchesPredicate) {
    return null;
  }

  return (
    <MenuItem
      active={modifiers.active}
      disabled={modifiers.disabled}
      text={highlightText(item.version, query)}
      key={item.version}
      onClick={handleClick}
      label={getItemLabel(item)}
      icon={getItemIcon(item)}
    />
  );
};

interface VersionSelectState {
  value: string;
}

interface VersionSelectProps {
  appState: AppState;
  disabled?: boolean;
  currentVersion: RunnableVersion;
  onVersionSelect: (version: RunnableVersion) => void;
  buttonGroupProps?: ButtonGroupProps;
  itemDisabled?:
    | keyof RunnableVersion
    | ((item: RunnableVersion, index: number) => boolean);
}

/**
 * A dropdown allowing the selection of Electron versions. The actual
 * download is managed in the state.
 *
 * @class VersionSelect
 * @extends {React.Component<VersionSelectProps, VersionSelectState>}
 */
@observer
export class VersionSelect extends React.Component<
  VersionSelectProps,
  VersionSelectState
> {
  public render() {
    const { currentVersion, itemDisabled } = this.props;
    const { version } = currentVersion;

    return (
      <ElectronVersionSelect
        filterable={true}
        items={this.props.appState.versionsToShow}
        itemRenderer={renderItem}
        itemListPredicate={filterItems}
        itemDisabled={itemDisabled}
        onItemSelect={this.props.onVersionSelect}
        noResults={<MenuItem disabled={true} text="No results." />}
        disabled={!!this.props.disabled}
      >
        <Button
          className="version-chooser"
          text={`Electron v${version}`}
          icon={getItemIcon(currentVersion)}
          onContextMenu={(e: React.MouseEvent<HTMLButtonElement>) => {
            renderVersionContextMenu(e, version);
          }}
          disabled={!!this.props.disabled}
        />
      </ElectronVersionSelect>
    );
  }
}

1	import {	4✔
2	Button,
3	ButtonGroupProps,
4	ContextMenu,
5	Menu,
6	MenuItem,
7	} from '@blueprintjs/core';
8	import { ItemListPredicate, ItemRenderer, Select } from '@blueprintjs/select';	4✔
9	import { clipboard } from 'electron';	4✔
10	import { observer } from 'mobx-react';	4✔
11	import * as React from 'react';	4✔
12	import semver from 'semver';	4✔
13
14	import { RunnableVersion, VersionSource, VersionState } from '../../interfaces';	4✔
15	import { highlightText } from '../../utils/highlight-text';	4✔
16	import { AppState } from '../state';
17
18	const ElectronVersionSelect = Select.ofType<RunnableVersion>();	4✔
19
20	/**
21	* Helper method: Returns the <Select /> label for an Electron
22	* version.
23	*
24	* @param {RunnableVersion} { source, state }
25	* @returns {string}
26	*/
27	export function getItemLabel({ source, state, name }: RunnableVersion): string {	4✔
28	let label = '';	6✔
29
30	if (source === VersionSource.local) {	6✔
31	label = name \|\| 'Local';	2✔
32	} else {
33	if (state === VersionState.unknown) {	4✔
34	label = `Not downloaded`;	2✔
35	} else if (state === VersionState.ready) {	2✔
36	label = `Downloaded`;	1✔
37	} else if (state === VersionState.downloading) {	1!
38	label = `Downloading`;	1✔
39	}
40	}
41
42	return label;	6✔
43	}
44
45	/**
46	* Helper method: Returns the <Select /> icon for an Electron
47	* version.
48	*
49	* @param {RunnableVersion} { state }
50	* @returns
51	*/
52	export function getItemIcon({ state }: RunnableVersion) {	4✔
53	switch (state) {	7✔
54	case VersionState.unknown:	7✔
55	return 'cloud';	3✔
56	case VersionState.ready:
57	return 'saved';	2✔
58	case VersionState.downloading:
59	return 'cloud-download';	1✔
60	case VersionState.unzipping:
61	return 'compressed';	1✔
62	}
63	}
64
65	/**
66	* Helper method: Returns the <Select /> predicate for an Electron
67	* version.
68	*
69	* Sorts by index of the chosen query.
70	* For example, if we take the following versions:
71	* [3.0.0, 14.3.0, 13.2.0, 12.0.0-nightly.20210301, 12.0.0-beta.3]
72	* and a search query of '3', this method would sort them into:
73	* [3.0.0, 13.2.0, 14.3.0, 12.0.0-beta.3, 12.0.0-nightly.20210301]
74	*
75	* @param {string} query
76	* @param {RunnableVersion[]} versions
77	* @returns
78	*/
79	export const filterItems: ItemListPredicate<RunnableVersion> = (	4✔
80	query,
81	versions,
82	) => {
83	if (query === '') return versions;	3✔
84
85	const q = query.toLowerCase();	2✔
86
87	return versions	2✔
88	.map((version: RunnableVersion) => {
89	const lowercase = version.version.toLowerCase();	14✔
90	return {	14✔
91	index: lowercase.indexOf(q),
92	coerced: semver.coerce(lowercase),
93	version,
94	};
95	})
96	.filter((item) => item.index !== -1)	14✔
97	.sort((a, b) => {
98	// If the user is searching for e.g. 'nightly' we
99	// want to sort nightlies by descending major version.
100	if (isNaN(+q)) {	15✔
101	if (a.coerced && b.coerced) {	7!
102	return semver.rcompare(a.coerced, b.coerced);	7✔
103	}
104	}
105	return a.index - b.index;	8✔
106	})
107	.map((item) => item.version);	10✔
108	};
109
110	/**
111	* Renders a context menu to copy the current Electron version.
112	*
113	* @param {React.MouseEvent<HTMLButtonElement>} e
114	* @param {string} version the Electron version number to copy.
115	*/
116	export const renderVersionContextMenu = (	4✔
117	e: React.MouseEvent<HTMLButtonElement>,
118	version: string,
119	) => {
120	e.preventDefault();	×
121
122	ContextMenu.show(	×
123	<Menu>
124	<MenuItem
125	text="Copy Version Number"
126	onClick={() => {
127	clipboard.writeText(version);	×
128	}}
129	/>
130	</Menu>,
131	{ left: e.clientX, top: e.clientY },
132	);
133	};
134
135	/**
136	* Helper method: Returns the <Select /> <MenuItem /> for Electron
137	* versions.
138	*
139	* @param {RunnableVersion} item
140	* @param {IItemRendererProps} { handleClick, modifiers, query }
141	* @returns
142	*/
143	export const renderItem: ItemRenderer<RunnableVersion> = (	4✔
144	item,
145	{ handleClick, modifiers, query },
146	) => {
147	if (!modifiers.matchesPredicate) {	2✔
148	return null;	1✔
149	}
150
151	return (	1✔
152	<MenuItem
153	active={modifiers.active}
154	disabled={modifiers.disabled}
155	text={highlightText(item.version, query)}
156	key={item.version}
157	onClick={handleClick}
158	label={getItemLabel(item)}
159	icon={getItemIcon(item)}
160	/>
161	);
162	};
163
164	interface VersionSelectState {
165	value: string;
166	}
167
168	interface VersionSelectProps {
169	appState: AppState;
170	disabled?: boolean;
171	currentVersion: RunnableVersion;
172	onVersionSelect: (version: RunnableVersion) => void;
173	buttonGroupProps?: ButtonGroupProps;
174	itemDisabled?:
175	\| keyof RunnableVersion
176	\| ((item: RunnableVersion, index: number) => boolean);
177	}
178
179	/**
180	* A dropdown allowing the selection of Electron versions. The actual
181	* download is managed in the state.
182	*
183	* @class VersionSelect
184	* @extends {React.Component<VersionSelectProps, VersionSelectState>}
185	*/
186	@observer
187	export class VersionSelect extends React.Component<	4✔
188	VersionSelectProps,
189	VersionSelectState
190	> {
191	public render() {
192	const { currentVersion, itemDisabled } = this.props;	2✔
193	const { version } = currentVersion;	2✔
194
195	return (	2✔
196	<ElectronVersionSelect
197	filterable={true}
198	items={this.props.appState.versionsToShow}
199	itemRenderer={renderItem}
200	itemListPredicate={filterItems}
201	itemDisabled={itemDisabled}
202	onItemSelect={this.props.onVersionSelect}
203	noResults={<MenuItem disabled={true} text="No results." />}
204	disabled={!!this.props.disabled}
205	>
206	<Button
207	className="version-chooser"
208	text={`Electron v${version}`}
209	icon={getItemIcon(currentVersion)}
210	onContextMenu={(e: React.MouseEvent<HTMLButtonElement>) => {
211	renderVersionContextMenu(e, version);	×
212	}}
213	disabled={!!this.props.disabled}
214	/>
215	</ElectronVersionSelect>
216	);
217	}
218	}

electron / fiddle / 2508393672

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous