2433316964

Build Type

github

Committed by GitHub

Commit Message

Merge a70b5af80 into f9f699b77

Pull Request Pull Request #687: fix: prevent click works even when input is disabled

Run Details

494 of 1334 branches covered (37.03%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

34 existing lines in 9 files now uncovered.

2177 of 3395 relevant lines covered (64.12%)

37.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

65.61

/src/renderer/VanillaRenderer.ts

/*
 * Copyright (c) 2015 NAVER Corp.
 * egjs projects are licensed under the MIT license
 */
import { getFlickingAttached, toArray } from "../utils";
import Panel, { PanelOptions } from "../core/panel/Panel";

import Renderer from "./Renderer";

/**
 *
 */
class VanillaRenderer extends Renderer {
  // eslint-disable-next-line @typescript-eslint/require-await
  public async render() {
    const flicking = getFlickingAttached(this._flicking);
    const strategy = this._strategy;

    strategy.updateRenderingPanels(flicking);
    strategy.renderPanels(flicking);

    this._resetPanelElementOrder();
  }

  protected _collectPanels() {
    const flicking = getFlickingAttached(this._flicking);
    const camera = flicking.camera;

    this._removeAllTextNodes();
    this._panels = this._strategy.collectPanels(flicking, camera.children);
  }

  protected _createPanel(el: HTMLElement, options: Omit<PanelOptions, "elementProvider">): Panel {
    return this._strategy.createPanel(el, options);
  }

  private _resetPanelElementOrder() {
    const flicking = getFlickingAttached(this._flicking);
    const cameraEl = flicking.camera.element;

    // We're using reversed panels here as last panel should be the last element of camera element
    const reversedElements = this._strategy
      .getRenderingElementsByOrder(flicking)
      .reverse();

    reversedElements.forEach((el, idx) => {
      const nextEl = reversedElements[idx - 1] ? reversedElements[idx - 1] : null;

      if (el.nextElementSibling !== nextEl) {
        cameraEl.insertBefore(el, nextEl);
      }
    });
  }

  private _removeAllTextNodes() {
    const flicking = getFlickingAttached(this._flicking);
    const cameraElement = flicking.camera.element;

    // Remove all text nodes in the camera element
    toArray(cameraElement.childNodes).forEach(node => {
      if (node.nodeType === Node.TEXT_NODE) {
        cameraElement.removeChild(node);
      }
    });
  }
}

export default VanillaRenderer;

1	/*	1✔
2	* Copyright (c) 2015 NAVER Corp.	1✔
3	* egjs projects are licensed under the MIT license	1✔
4	*/	1!
5	import { getFlickingAttached, toArray } from "../utils";	5✔
6	import Panel, { PanelOptions } from "../core/panel/Panel";	×
7		1✔
8	import Renderer from "./Renderer";	5✔
9		1✔
10	/**	1!
11	*
12	*/	1✔
13	class VanillaRenderer extends Renderer {	6✔
14	// eslint-disable-next-line @typescript-eslint/require-await	1!
15	public async render() {	5✔
16	const flicking = getFlickingAttached(this._flicking);	35✔
17	const strategy = this._strategy;	36✔
18		×
19	strategy.updateRenderingPanels(flicking);	1,058✔
20	strategy.renderPanels(flicking);	35✔
21
22	this._resetPanelElementOrder();	1,058!
23	}	1,023✔
24
25	protected _collectPanels() {	5✔
26	const flicking = getFlickingAttached(this._flicking);	15✔
27	const camera = flicking.camera;	1,037!
28		1,023✔
29	this._removeAllTextNodes();	3,083✔
30	this._panels = this._strategy.collectPanels(flicking, camera.children);	14✔
31	}	1,023!
32		2,046✔
33	protected _createPanel(el: HTMLElement, options: Omit<PanelOptions, "elementProvider">): Panel {	2,051!
34	return this._strategy.createPanel(el, options);	2,046!
35	}	2,046!
36		1,023✔
37	private _resetPanelElementOrder() {	5✔
38	const flicking = getFlickingAttached(this._flicking);	35✔
39	const cameraEl = flicking.camera.element;	35✔
40
41	// We're using reversed panels here as last panel should be the last element of camera element	1,023!
42	const reversedElements = this._strategy	35!
43	.getRenderingElementsByOrder(flicking)	×
44	.reverse();	×
45		×
46	reversedElements.forEach((el, idx) => {	35✔
47	const nextEl = reversedElements[idx - 1] ? reversedElements[idx - 1] : null;	125✔
48		1,023✔
49	if (el.nextElementSibling !== nextEl) {	2,171!
50	cameraEl.insertBefore(el, nextEl);	1,023!
51	}
52	});
53	}	1✔
54		1!
55	private _removeAllTextNodes() {	5✔
56	const flicking = getFlickingAttached(this._flicking);	15✔
57	const cameraElement = flicking.camera.element;	14✔
58
59	// Remove all text nodes in the camera element
60	toArray(cameraElement.childNodes).forEach(node => {	14✔
61	if (node.nodeType === Node.TEXT_NODE) {	55!
62	cameraElement.removeChild(node);	1✔
63	}
64	});
65	}
66	}	6✔
67		1✔
68	export default VanillaRenderer;	5✔

naver / egjs-flicking / 2433316964

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous