mattn / go-sqlite3 / 309

pending completion

Build # 309

Build Type

Pull #267

travis-ci

Committed by

ianlancetaylor

Commit Message

bind: pass &v[0] in direct call to C

In Go 1.6, the cgo checking rules are more precise when they see an
address operation as an argument to the C function.  When you pass &v[0]
to a C function, the cgo check just verifies that v itself does not
contain any pointers.  When you write `p := &v[0]` and then pass p to
the C function, the cgo check is conservative: it verifies that the
entire memory block to which p points does not contain any pointers.
When the bind function is called by code that passes a slice that is
part of a larger struct, this means that the cgo check will look at the
entire larger struct, not just the slice.  This can cause a surprising
run time failure.

Avoid this problem by rewriting the code slightly to pass &v[0] in the
call to the C function itself.

In particular this fixes the tests of github.com/jmoiron/sqlx when using
Go 1.6.

Pull Request Pull Request #267: bind: pass &v[0] in direct call to C

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

826 of 998 relevant lines covered (82.77%)

77077.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.21

/sqlite3.go

Build SHA Not Found

The commit SHA "a97642d2bb5acb6e08c0c8c02d1cce2ddaf811d1" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

mattn / go-sqlite3 / 309

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous