2226567185

Committed 26 Apr 2022 12:12PM UTC coverage: 35.394%. Remained the same

Build Type

push

github

Committed by GitHub

Commit Message

Chore: fix lint (#3822)

Run Details

1270 of 4533 branches covered (28.02%)

Branch coverage included in aggregate %.

0 of 6 new or added lines in 4 files covered. (0.0%)

4 existing lines in 2 files now uncovered.

3591 of 9201 relevant lines covered (39.03%)

35.53 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/routes/safe/components/Settings/ThresholdSettings/ChangeThreshold/index.tsx

import MenuItem from '@material-ui/core/MenuItem'
import { ReactElement, useEffect, useState } from 'react'
import { useDispatch, useSelector } from 'react-redux'

import Field from 'src/components/forms/Field'
import GnoForm from 'src/components/forms/GnoForm'
import SelectField from 'src/components/forms/SelectField'
import { composeValidators, differentFrom, minValue, mustBeInteger, required } from 'src/components/forms/validator'
import Block from 'src/components/layout/Block'
import Col from 'src/components/layout/Col'
import Hairline from 'src/components/layout/Hairline'
import Paragraph from 'src/components/layout/Paragraph'
import Row from 'src/components/layout/Row'
import { ModalHeader } from 'src/routes/safe/components/Balances/SendModal/screens/ModalHeader'
import { currentSafeCurrentVersion } from 'src/logic/safe/store/selectors'
import { getGnosisSafeInstanceAt } from 'src/logic/contracts/safeContracts'
import { createTransaction } from 'src/logic/safe/store/actions/createTransaction'
import { TX_NOTIFICATION_TYPES } from 'src/logic/safe/transactions'
import { TxModalWrapper } from 'src/routes/safe/components/Transactions/helpers/TxModalWrapper'
import { TxParameters } from 'src/routes/safe/container/hooks/useTransactionParameters'

import { useStyles } from './style'
import { trackEvent } from 'src/utils/googleTagManager'
import { SETTINGS_EVENTS } from 'src/utils/events/settings'

const THRESHOLD_FIELD_NAME = 'threshold'

type ChangeThresholdModalProps = {
  onClose: () => void
  ownersCount?: number
  safeAddress: string
  threshold?: number
}

export const ChangeThresholdModal = ({
  onClose,
  ownersCount = 0,
  safeAddress,
  threshold = 1,
}: ChangeThresholdModalProps): ReactElement => {
  const classes = useStyles()
  const dispatch = useDispatch()
  const safeVersion = useSelector(currentSafeCurrentVersion) as string
  const [data, setData] = useState('')
  const [editedThreshold, setEditedThreshold] = useState<number>(threshold)
  const [disabledSubmitForm, setDisabledSubmitForm] = useState<boolean>(true)

  useEffect(() => {
    let isCurrent = true
    const calculateChangeThresholdData = () => {
      const safeInstance = getGnosisSafeInstanceAt(safeAddress, safeVersion)
      const txData = safeInstance.methods.changeThreshold(editedThreshold).encodeABI()
      if (isCurrent) {
        setData(txData)
      }
    }

    calculateChangeThresholdData()
    return () => {
      isCurrent = false
    }
  }, [safeAddress, safeVersion, editedThreshold])

  const handleThreshold = ({ target }) => {
    const value = parseInt(target.value)
    setDisabledSubmitForm(value === editedThreshold || value === threshold)
    setEditedThreshold(value)
  }

  const handleSubmit = (txParameters: TxParameters, delayExecution: boolean) => {
    dispatch(
      createTransaction({
        safeAddress,
        to: safeAddress,
        valueInWei: '0',
        txData: data,
        txNonce: txParameters.safeNonce,
        safeTxGas: txParameters.safeTxGas,
        ethParameters: txParameters,
        notifiedTransaction: TX_NOTIFICATION_TYPES.SETTINGS_CHANGE_TX,
        delayExecution,
      }),
    )

    trackEvent({ ...SETTINGS_EVENTS.THRESHOLD.OWNERS, label: ownersCount })
    trackEvent({ ...SETTINGS_EVENTS.THRESHOLD.THRESHOLD, label: editedThreshold })

    onClose()
  }

  return (
    <TxModalWrapper txData={data} onSubmit={handleSubmit} isSubmitDisabled={disabledSubmitForm} onClose={onClose}>
      <ModalHeader onClose={onClose} title="Change threshold" />
      <Hairline />
      <GnoForm initialValues={{ threshold: editedThreshold.toString() }} onSubmit={handleSubmit}>
        {() => (
          <Block className={classes.modalContent}>
            <Row>
              <Paragraph weight="bolder">Any transaction requires the confirmation of:</Paragraph>
            </Row>
            <Row align="center" className={classes.inputRow} margin="xl">
              <Col xs={2}>
                <Field
                  data-testid="threshold-select-input"
                  name={THRESHOLD_FIELD_NAME}
                  onChange={handleThreshold}
                  render={(props) => (
                    <SelectField {...props} disableError>
                      {[...Array(Number(ownersCount))].map((x, index) => (
                        <MenuItem key={index} value={`${index + 1}`}>
                          {index + 1}
                        </MenuItem>
                      ))}
                    </SelectField>
                  )}
                  validate={composeValidators(required, mustBeInteger, minValue(1), differentFrom(threshold))}
                />
              </Col>
              <Col xs={10}>
                <Paragraph className={classes.ownersText} color="primary" noMargin size="lg">
                  {`out of ${ownersCount} owner(s)`}
                </Paragraph>
              </Col>
            </Row>
          </Block>
        )}
      </GnoForm>
    </TxModalWrapper>
  )
}

1	import MenuItem from '@material-ui/core/MenuItem'
2	import { ReactElement, useEffect, useState } from 'react'
3	import { useDispatch, useSelector } from 'react-redux'
4
5	import Field from 'src/components/forms/Field'
6	import GnoForm from 'src/components/forms/GnoForm'
7	import SelectField from 'src/components/forms/SelectField'
8	import { composeValidators, differentFrom, minValue, mustBeInteger, required } from 'src/components/forms/validator'
9	import Block from 'src/components/layout/Block'
10	import Col from 'src/components/layout/Col'
11	import Hairline from 'src/components/layout/Hairline'
12	import Paragraph from 'src/components/layout/Paragraph'
13	import Row from 'src/components/layout/Row'
14	import { ModalHeader } from 'src/routes/safe/components/Balances/SendModal/screens/ModalHeader'
15	import { currentSafeCurrentVersion } from 'src/logic/safe/store/selectors'
16	import { getGnosisSafeInstanceAt } from 'src/logic/contracts/safeContracts'
17	import { createTransaction } from 'src/logic/safe/store/actions/createTransaction'
18	import { TX_NOTIFICATION_TYPES } from 'src/logic/safe/transactions'
19	import { TxModalWrapper } from 'src/routes/safe/components/Transactions/helpers/TxModalWrapper'
20	import { TxParameters } from 'src/routes/safe/container/hooks/useTransactionParameters'
21
22	import { useStyles } from './style'
23	import { trackEvent } from 'src/utils/googleTagManager'
24	import { SETTINGS_EVENTS } from 'src/utils/events/settings'
25
26	const THRESHOLD_FIELD_NAME = 'threshold'	×
27
28	type ChangeThresholdModalProps = {
29	onClose: () => void
30	ownersCount?: number
31	safeAddress: string
32	threshold?: number
33	}
34
35	export const ChangeThresholdModal = ({	×
36	onClose,
37	ownersCount = 0,	×
38	safeAddress,
39	threshold = 1,	×
40	}: ChangeThresholdModalProps): ReactElement => {
41	const classes = useStyles()	×
42	const dispatch = useDispatch()	×
43	const safeVersion = useSelector(currentSafeCurrentVersion) as string	×
44	const [data, setData] = useState('')	×
45	const [editedThreshold, setEditedThreshold] = useState<number>(threshold)	×
46	const [disabledSubmitForm, setDisabledSubmitForm] = useState<boolean>(true)	×
47
48	useEffect(() => {	×
49	let isCurrent = true	×
50	const calculateChangeThresholdData = () => {	×
51	const safeInstance = getGnosisSafeInstanceAt(safeAddress, safeVersion)	×
52	const txData = safeInstance.methods.changeThreshold(editedThreshold).encodeABI()	×
53	if (isCurrent) {	×
54	setData(txData)	×
55	}
56	}
57
58	calculateChangeThresholdData()	×
59	return () => {	×
60	isCurrent = false	×
61	}
62	}, [safeAddress, safeVersion, editedThreshold])
63
64	const handleThreshold = ({ target }) => {	×
65	const value = parseInt(target.value)	×
66	setDisabledSubmitForm(value === editedThreshold \|\| value === threshold)	×
67	setEditedThreshold(value)	×
68	}
69
70	const handleSubmit = (txParameters: TxParameters, delayExecution: boolean) => {	×
71	dispatch(	×
72	createTransaction({
73	safeAddress,
74	to: safeAddress,
75	valueInWei: '0',
76	txData: data,
77	txNonce: txParameters.safeNonce,
78	safeTxGas: txParameters.safeTxGas,
79	ethParameters: txParameters,
80	notifiedTransaction: TX_NOTIFICATION_TYPES.SETTINGS_CHANGE_TX,
81	delayExecution,
82	}),
83	)
84
85	trackEvent({ ...SETTINGS_EVENTS.THRESHOLD.OWNERS, label: ownersCount })	×
86	trackEvent({ ...SETTINGS_EVENTS.THRESHOLD.THRESHOLD, label: editedThreshold })	×
87
88	onClose()	×
89	}
90
91	return (	×
92	<TxModalWrapper txData={data} onSubmit={handleSubmit} isSubmitDisabled={disabledSubmitForm} onClose={onClose}>
93	<ModalHeader onClose={onClose} title="Change threshold" />
94	<Hairline />
95	<GnoForm initialValues={{ threshold: editedThreshold.toString() }} onSubmit={handleSubmit}>
96	{() => (
97	<Block className={classes.modalContent}>	×
98	<Row>
99	<Paragraph weight="bolder">Any transaction requires the confirmation of:</Paragraph>
100	</Row>
101	<Row align="center" className={classes.inputRow} margin="xl">
102	<Col xs={2}>
103	<Field
104	data-testid="threshold-select-input"
105	name={THRESHOLD_FIELD_NAME}
106	onChange={handleThreshold}
107	render={(props) => (
NEW 108	<SelectField {...props} disableError>	×
109	{[...Array(Number(ownersCount))].map((x, index) => (
NEW 110	<MenuItem key={index} value={`${index + 1}`}>	×
111	{index + 1}
112	</MenuItem>
113	))}
114	</SelectField>
115	)}
116	validate={composeValidators(required, mustBeInteger, minValue(1), differentFrom(threshold))}
117	/>
118	</Col>
119	<Col xs={10}>
120	<Paragraph className={classes.ownersText} color="primary" noMargin size="lg">
121	{`out of ${ownersCount} owner(s)`}
122	</Paragraph>
123	</Col>
124	</Row>
125	</Block>
126	)}
127	</GnoForm>
128	</TxModalWrapper>
129	)
130	}

safe-global / safe-react / 2226567185

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous