1829083876

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/HewlettPackard/squest/commit/<a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/13b7396293199a0815ac08b418a27645580828d4">13b739629">&lt;a href=&quot;https://github.com/HewlettPackard/squest/commit/</a><a class="double-link" href="https://github.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/13b7396293199a0815ac08b418a27645580828d4">13b739629</a><a href="https://github.com/HewlettPackard/squest/commit/13b7396293199a0815ac08b418a27645580828d4">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/HewlettPackard/squest/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/HewlettPackard/squest/commit/13b7396293199a0815ac08b418a27645580828d4&quot;&gt;13b739629&lt;/a&gt;&lt;a href=&quot;https://github.com/HewlettPackard/squest/commit/13b7396293199a0815ac08b418a27645580828d4&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/HewlettPackard/squest/commit/13b7396293199a0815ac08b418a27645580828d4&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;&amp;amp;amp;lt;a href=&amp;amp;amp;quot;https://gi... (continued)

Pull Request Pull Request #380: [Fix] API : Create a Service return wrong Serializer

Run Details

71 of 71 new or added lines in 4 files covered. (100.0%)

6247 of 6647 relevant lines covered (93.98%)

0.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

97.65

/resource_tracker/api/resource_group_api_views.py

from rest_framework import generics
from rest_framework.permissions import IsAdminUser
from rest_framework.response import Response
from rest_framework import status

from resource_tracker.api.serializers.resource_group.attribute_definition_serializers import \
    ResourceGroupAttributeDefinitionSerializer
from resource_tracker.api.serializers.resource_group.resource_group_serializers import ResourceGroupSerializer, \
    ResourceGroupSerializerRead
from resource_tracker.api.serializers.resource_group.text_attribute_definition_serializers import \
    ResourceGroupTextAttributeDefinitionSerializer
from resource_tracker.models import ResourceGroup, ResourceGroupAttributeDefinition, \
    ResourceGroupTextAttributeDefinition


class ResourceGroupList(generics.ListCreateAPIView):
    permission_classes = [IsAdminUser]
    serializer_class = ResourceGroupSerializer

    def get_queryset(self):
        """
        Optionally restricts the returned resource group to a given name,
        by filtering against a `name` query parameter in the URL.
        """
        queryset = ResourceGroup.objects.all()
        name = self.request.query_params.get('name')
        if name is not None:
            queryset = queryset.filter(name=name)
        return queryset


class ResourceGroupDetails(generics.RetrieveUpdateDestroyAPIView):
    permission_classes = [IsAdminUser]
    queryset = ResourceGroup.objects.all()
    serializer_class = ResourceGroupSerializerRead


class AttributeDefinitionList(generics.ListCreateAPIView):
    permission_classes = [IsAdminUser]
    serializer_class = ResourceGroupAttributeDefinitionSerializer

    def get_queryset(self):
        resource_group_id = self.kwargs.get("pk")
        return ResourceGroupAttributeDefinition.objects.filter(resource_group_id=resource_group_id)

    def create(self, request, *args, **kwargs):
        data = request.data
        data['resource_group'] = self.kwargs.get('pk', None)
        serializer = self.get_serializer(data=data)
        serializer.is_valid(raise_exception=True)
        serializer.save()
        headers = self.get_success_headers(serializer.data)
        return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers)


class AttributeDefinitionDetails(generics.RetrieveUpdateDestroyAPIView):
    permission_classes = [IsAdminUser]
    serializer_class = ResourceGroupAttributeDefinitionSerializer
    lookup_url_kwarg = "attribute_definition_id"

    def get_queryset(self):
        resource_group_id = self.kwargs.get("pk")
        return ResourceGroupAttributeDefinition.objects.filter(resource_group_id=resource_group_id)

    def update(self, request, *args, **kwargs):
        data = request.data
        data['resource_group'] = self.kwargs.get('pk', None)
        partial = kwargs.pop('partial', False)
        instance = self.get_object()
        serializer = self.get_serializer(instance, data=data, partial=partial)
        serializer.is_valid(raise_exception=True)
        self.perform_update(serializer)
        if getattr(instance, '_prefetched_objects_cache', None):
            instance._prefetched_objects_cache = {}
        return Response(serializer.data)


class TextAttributeDefinitionList(generics.ListCreateAPIView):
    permission_classes = [IsAdminUser]
    serializer_class = ResourceGroupTextAttributeDefinitionSerializer

    def get_queryset(self):
        resource_group_id = self.kwargs.get("pk")
        return ResourceGroupTextAttributeDefinition.objects.filter(resource_group_id=resource_group_id)

    def create(self, request, *args, **kwargs):
        data = request.data
        data['resource_group'] = self.kwargs.get('pk', None)
        serializer = self.get_serializer(data=data)
        serializer.is_valid(raise_exception=True)
        serializer.save()
        headers = self.get_success_headers(serializer.data)
        return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers)


class TextAttributeDefinitionDetails(generics.RetrieveUpdateDestroyAPIView):
    permission_classes = [IsAdminUser]
    serializer_class = ResourceGroupTextAttributeDefinitionSerializer
    lookup_url_kwarg = "text_attribute_definition_id"

    def get_queryset(self):
        resource_group_id = self.kwargs.get("pk")
        return ResourceGroupTextAttributeDefinition.objects.filter(resource_group_id=resource_group_id)

    def update(self, request, *args, **kwargs):
        data = request.data
        data['resource_group'] = self.kwargs.get('pk', None)
        partial = kwargs.pop('partial', False)
        instance = self.get_object()
        serializer = self.get_serializer(instance, data=data, partial=partial)
        serializer.is_valid(raise_exception=True)
        self.perform_update(serializer)
        if getattr(instance, '_prefetched_objects_cache', None):
            instance._prefetched_objects_cache = {}
        return Response(serializer.data)

1	from rest_framework import generics	1✔
2	from rest_framework.permissions import IsAdminUser	1✔
3	from rest_framework.response import Response	1✔
4	from rest_framework import status	1✔
5
6	from resource_tracker.api.serializers.resource_group.attribute_definition_serializers import \	1✔
7	ResourceGroupAttributeDefinitionSerializer
8	from resource_tracker.api.serializers.resource_group.resource_group_serializers import ResourceGroupSerializer, \	1✔
9	ResourceGroupSerializerRead
10	from resource_tracker.api.serializers.resource_group.text_attribute_definition_serializers import \	1✔
11	ResourceGroupTextAttributeDefinitionSerializer
12	from resource_tracker.models import ResourceGroup, ResourceGroupAttributeDefinition, \	1✔
13	ResourceGroupTextAttributeDefinition
14
15
16	class ResourceGroupList(generics.ListCreateAPIView):	1✔
17	permission_classes = [IsAdminUser]	1✔
18	serializer_class = ResourceGroupSerializer	1✔
19
20	def get_queryset(self):	1✔
21	"""
22	Optionally restricts the returned resource group to a given name,
23	by filtering against a `name` query parameter in the URL.
24	"""
25	queryset = ResourceGroup.objects.all()	1✔
26	name = self.request.query_params.get('name')	1✔
27	if name is not None:	1✔
28	queryset = queryset.filter(name=name)	1✔
29	return queryset	1✔
30
31
32	class ResourceGroupDetails(generics.RetrieveUpdateDestroyAPIView):	1✔
33	permission_classes = [IsAdminUser]	1✔
34	queryset = ResourceGroup.objects.all()	1✔
35	serializer_class = ResourceGroupSerializerRead	1✔
36
37
38	class AttributeDefinitionList(generics.ListCreateAPIView):	1✔
39	permission_classes = [IsAdminUser]	1✔
40	serializer_class = ResourceGroupAttributeDefinitionSerializer	1✔
41
42	def get_queryset(self):	1✔
43	resource_group_id = self.kwargs.get("pk")	1✔
44	return ResourceGroupAttributeDefinition.objects.filter(resource_group_id=resource_group_id)	1✔
45
46	def create(self, request, args, *kwargs):	1✔
47	data = request.data	1✔
48	data['resource_group'] = self.kwargs.get('pk', None)	1✔
49	serializer = self.get_serializer(data=data)	1✔
50	serializer.is_valid(raise_exception=True)	1✔
51	serializer.save()	1✔
52	headers = self.get_success_headers(serializer.data)	1✔
53	return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers)	1✔
54
55
56	class AttributeDefinitionDetails(generics.RetrieveUpdateDestroyAPIView):	1✔
57	permission_classes = [IsAdminUser]	1✔
58	serializer_class = ResourceGroupAttributeDefinitionSerializer	1✔
59	lookup_url_kwarg = "attribute_definition_id"	1✔
60
61	def get_queryset(self):	1✔
62	resource_group_id = self.kwargs.get("pk")	1✔
63	return ResourceGroupAttributeDefinition.objects.filter(resource_group_id=resource_group_id)	1✔
64
65	def update(self, request, args, *kwargs):	1✔
66	data = request.data	1✔
67	data['resource_group'] = self.kwargs.get('pk', None)	1✔
68	partial = kwargs.pop('partial', False)	1✔
69	instance = self.get_object()	1✔
70	serializer = self.get_serializer(instance, data=data, partial=partial)	1✔
71	serializer.is_valid(raise_exception=True)	1✔
72	self.perform_update(serializer)	1✔
73	if getattr(instance, '_prefetched_objects_cache', None):	1✔
74	instance._prefetched_objects_cache = {}	×
75	return Response(serializer.data)	1✔
76
77
78	class TextAttributeDefinitionList(generics.ListCreateAPIView):	1✔
79	permission_classes = [IsAdminUser]	1✔
80	serializer_class = ResourceGroupTextAttributeDefinitionSerializer	1✔
81
82	def get_queryset(self):	1✔
83	resource_group_id = self.kwargs.get("pk")	1✔
84	return ResourceGroupTextAttributeDefinition.objects.filter(resource_group_id=resource_group_id)	1✔
85
86	def create(self, request, args, *kwargs):	1✔
87	data = request.data	1✔
88	data['resource_group'] = self.kwargs.get('pk', None)	1✔
89	serializer = self.get_serializer(data=data)	1✔
90	serializer.is_valid(raise_exception=True)	1✔
91	serializer.save()	1✔
92	headers = self.get_success_headers(serializer.data)	1✔
93	return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers)	1✔
94
95
96	class TextAttributeDefinitionDetails(generics.RetrieveUpdateDestroyAPIView):	1✔
97	permission_classes = [IsAdminUser]	1✔
98	serializer_class = ResourceGroupTextAttributeDefinitionSerializer	1✔
99	lookup_url_kwarg = "text_attribute_definition_id"	1✔
100
101	def get_queryset(self):	1✔
102	resource_group_id = self.kwargs.get("pk")	1✔
103	return ResourceGroupTextAttributeDefinition.objects.filter(resource_group_id=resource_group_id)	1✔
104
105	def update(self, request, args, *kwargs):	1✔
106	data = request.data	1✔
107	data['resource_group'] = self.kwargs.get('pk', None)	1✔
108	partial = kwargs.pop('partial', False)	1✔
109	instance = self.get_object()	1✔
110	serializer = self.get_serializer(instance, data=data, partial=partial)	1✔
111	serializer.is_valid(raise_exception=True)	1✔
112	self.perform_update(serializer)	1✔
113	if getattr(instance, '_prefetched_objects_cache', None):	1✔
114	instance._prefetched_objects_cache = {}	×
115	return Response(serializer.data)	1✔

HewlettPackard / squest / 1829083876

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous