1829058878

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/HewlettPackard/squest/commit/<a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/69005fda8f5fa07447bed1dda6a11376aad04a41">69005fda8">&lt;a href=&quot;https://github.com/HewlettPackard/squest/commit/</a><a class="double-link" href="https://github.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/69005fda8f5fa07447bed1dda6a11376aad04a41">69005fda8</a><a href="https://github.com/HewlettPackard/squest/commit/69005fda8f5fa07447bed1dda6a11376aad04a41">&lt;a href=&quot;https://github.com/HewlettPackard/squest/commit/69005fda8f5fa07447bed1dda6a11376aad04a41&quot;&gt;&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/HewlettPackard/squest/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/HewlettPackard/squest/commit/&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://git&amp;quot;&amp;gt;&amp;amp;lt;a class=&amp;lt;/a&amp;gt;hub.com/HewlettPackard/squest/commit/69005fda8f5fa07447bed1dda6a11376aad04a41&amp;quot;&amp;gt;69005fda8&amp;lt;/a&amp;gt;&amp;lt;a href=&amp;quot;https://github.com/HewlettPackard/squest/commit/69005fda8f5fa07447bed1dda6a11376aad04a41&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/HewlettPackard/squest/commit/69005fda8f5fa07447bed1dda6a11376&amp;lt;/a&amp;gt;aad04a41&amp;</a>quot;&gt;&amp;quot;&amp;gt;Merge &amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/HewlettPackard/squ... (continued)

Pull Request Pull Request #380: [Fix] API : Create a Service return wrong Serializer

Run Details

71 of 71 new or added lines in 4 files covered. (100.0%)

6247 of 6647 relevant lines covered (93.98%)

0.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.04

/resource_tracker/api/resource_pool_api_views.py

from rest_framework import generics
from rest_framework.permissions import IsAdminUser
from rest_framework.response import Response
from rest_framework import status

from resource_tracker.api.serializers.resource_pool.resource_pool_serializer import ResourcePoolSerializer, \
    ResourcePoolSerializerRead, ResourcePoolAttributeDefinitionSerializer
from resource_tracker.models import ResourcePool, ResourcePoolAttributeDefinition


class ResourcePoolList(generics.ListCreateAPIView):
    permission_classes = [IsAdminUser]
    serializer_class = ResourcePoolSerializer

    def get_queryset(self):
        """
        Optionally restricts the returned resource pool to a given name,
        by filtering against a `name` query parameter in the URL.
        """
        queryset = ResourcePool.objects.all()
        name = self.request.query_params.get('name')
        if name is not None:
            queryset = queryset.filter(name=name)
        return queryset


class ResourcePoolDetails(generics.RetrieveUpdateDestroyAPIView):
    permission_classes = [IsAdminUser]
    queryset = ResourcePool.objects.all()
    serializer_class = ResourcePoolSerializerRead


class PoolAttributeDefinitionList(generics.ListCreateAPIView):
    permission_classes = [IsAdminUser]
    serializer_class = ResourcePoolAttributeDefinitionSerializer

    def get_queryset(self):
        resource_group_id = self.kwargs.get("pk")
        return ResourcePoolAttributeDefinition.objects.filter(resource_pool_id=resource_group_id)

    def create(self, request, *args, **kwargs):
        data = request.data
        data['resource_pool'] = self.kwargs.get('pk', None)
        serializer = self.get_serializer(data=data)
        serializer.is_valid(raise_exception=True)
        serializer.save()
        headers = self.get_success_headers(serializer.data)
        return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers)


class PoolAttributeDefinitionDetails(generics.RetrieveUpdateDestroyAPIView):
    permission_classes = [IsAdminUser]
    serializer_class = ResourcePoolAttributeDefinitionSerializer
    lookup_url_kwarg = "attribute_definition_id"

    def get_queryset(self):
        resource_group_id = self.kwargs.get("pk")
        return ResourcePoolAttributeDefinition.objects.filter(resource_pool_id=resource_group_id)

    def update(self, request, *args, **kwargs):
        data = request.data
        data['resource_pool'] = self.kwargs.get('pk', None)
        partial = kwargs.pop('partial', False)
        instance = self.get_object()
        serializer = self.get_serializer(instance, data=data, partial=partial)
        serializer.is_valid(raise_exception=True)
        self.perform_update(serializer)
        if getattr(instance, '_prefetched_objects_cache', None):
            instance._prefetched_objects_cache = {}
        return Response(serializer.data)

1	from rest_framework import generics	1✔
2	from rest_framework.permissions import IsAdminUser	1✔
3	from rest_framework.response import Response	1✔
4	from rest_framework import status	1✔
5
6	from resource_tracker.api.serializers.resource_pool.resource_pool_serializer import ResourcePoolSerializer, \	1✔
7	ResourcePoolSerializerRead, ResourcePoolAttributeDefinitionSerializer
8	from resource_tracker.models import ResourcePool, ResourcePoolAttributeDefinition	1✔
9
10
11	class ResourcePoolList(generics.ListCreateAPIView):	1✔
12	permission_classes = [IsAdminUser]	1✔
13	serializer_class = ResourcePoolSerializer	1✔
14
15	def get_queryset(self):	1✔
16	"""
17	Optionally restricts the returned resource pool to a given name,
18	by filtering against a `name` query parameter in the URL.
19	"""
20	queryset = ResourcePool.objects.all()	1✔
21	name = self.request.query_params.get('name')	1✔
22	if name is not None:	1✔
23	queryset = queryset.filter(name=name)	1✔
24	return queryset	1✔
25
26
27	class ResourcePoolDetails(generics.RetrieveUpdateDestroyAPIView):	1✔
28	permission_classes = [IsAdminUser]	1✔
29	queryset = ResourcePool.objects.all()	1✔
30	serializer_class = ResourcePoolSerializerRead	1✔
31
32
33	class PoolAttributeDefinitionList(generics.ListCreateAPIView):	1✔
34	permission_classes = [IsAdminUser]	1✔
35	serializer_class = ResourcePoolAttributeDefinitionSerializer	1✔
36
37	def get_queryset(self):	1✔
38	resource_group_id = self.kwargs.get("pk")	1✔
39	return ResourcePoolAttributeDefinition.objects.filter(resource_pool_id=resource_group_id)	1✔
40
41	def create(self, request, args, *kwargs):	1✔
42	data = request.data	1✔
43	data['resource_pool'] = self.kwargs.get('pk', None)	1✔
44	serializer = self.get_serializer(data=data)	1✔
45	serializer.is_valid(raise_exception=True)	1✔
46	serializer.save()	1✔
47	headers = self.get_success_headers(serializer.data)	1✔
48	return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers)	1✔
49
50
51	class PoolAttributeDefinitionDetails(generics.RetrieveUpdateDestroyAPIView):	1✔
52	permission_classes = [IsAdminUser]	1✔
53	serializer_class = ResourcePoolAttributeDefinitionSerializer	1✔
54	lookup_url_kwarg = "attribute_definition_id"	1✔
55
56	def get_queryset(self):	1✔
57	resource_group_id = self.kwargs.get("pk")	1✔
58	return ResourcePoolAttributeDefinition.objects.filter(resource_pool_id=resource_group_id)	1✔
59
60	def update(self, request, args, *kwargs):	1✔
61	data = request.data	1✔
62	data['resource_pool'] = self.kwargs.get('pk', None)	1✔
63	partial = kwargs.pop('partial', False)	1✔
64	instance = self.get_object()	1✔
65	serializer = self.get_serializer(instance, data=data, partial=partial)	1✔
66	serializer.is_valid(raise_exception=True)	1✔
67	self.perform_update(serializer)	1✔
68	if getattr(instance, '_prefetched_objects_cache', None):	1✔
69	instance._prefetched_objects_cache = {}	×
70	return Response(serializer.data)	1✔

HewlettPackard / squest / 1829058878

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous