1804823433

Build Type

github

Committed by GitHub

Commit Message

Merge a3fde8628 into 4fe61eeb3

Pull Request Pull Request #618: fix: vue-flicking panels are targeting old element

Run Details

3592 of 6231 branches covered (57.65%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

38 existing lines in 11 files now uncovered.

5537 of 6023 relevant lines covered (91.93%)

128.14 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

69.77

/src/control/states/AnimatingState.ts

/*
 * Copyright (c) 2015 NAVER Corp.
 * egjs projects are licensed under the MIT license
 */
import { ComponentEvent } from "@egjs/component";

import { EVENTS } from "../../const/external";
import { getDirection } from "../../utils";

import State, { STATE_TYPE } from "./State";

/**
 * A state that activates when Flicking's animating by user input or method call
 * @ko 사용자 입력이나 메소드 호출에 의해 Flicking의 애니메이션이 동작중인 상태
 * @internal
 */
class AnimatingState extends State {
  /**
   * Whether user is clicking or touching
   * @ko 현재 사용자가 클릭/터치중인지 여부
   * @type {false}
   * @readonly
   */
  public readonly holding = false;
  /**
   * Whether Flicking's animating
   * @ko 현재 애니메이션 동작 여부
   * @type {true}
   * @readonly
   */
  public readonly animating = true;

  public onHold(ctx: Parameters<State["onHold"]>[0]): void {
    const { flicking, axesEvent, transitTo } = ctx;

    this._delta = 0;
    flicking.control.updateInput();

    const holdStartEvent = new ComponentEvent(EVENTS.HOLD_START, { axesEvent });
    flicking.trigger(holdStartEvent);

    if (holdStartEvent.isCanceled()) {
      transitTo(STATE_TYPE.DISABLED);
    } else {
      transitTo(STATE_TYPE.DRAGGING);
    }
  }

  public onChange(ctx: Parameters<State["onChange"]>[0]): void {
    this._moveToChangedPosition(ctx);
  }

  public onFinish(ctx: Parameters<State["onFinish"]>[0]) {
    const { flicking, axesEvent, transitTo } = ctx;

    const control = flicking.control;
    const controller = control.controller;
    const animatingContext = controller.animatingContext;

    transitTo(STATE_TYPE.IDLE);

    flicking.trigger(new ComponentEvent(EVENTS.MOVE_END, {
      isTrusted: axesEvent.isTrusted,
      direction: getDirection(animatingContext.start, animatingContext.end),
      axesEvent
    }));

    control.setActive(this._targetPanel!, control.activePanel, axesEvent.isTrusted);
  }
}

export default AnimatingState;

1	/*	1✔
2	* Copyright (c) 2015 NAVER Corp.	1✔
3	* egjs projects are licensed under the MIT license	1✔
4	*/	1!
5	import { ComponentEvent } from "@egjs/component";	5✔
6		×
7	import { EVENTS } from "../../const/external";	6✔
8	import { getDirection } from "../../utils";	5✔
9		1✔
10	import State, { STATE_TYPE } from "./State";	6!
11
12	/**	1✔
13	* A state that activates when Flicking's animating by user input or method call	1✔
14	* @ko 사용자 입력이나 메소드 호출에 의해 Flicking의 애니메이션이 동작중인 상태	1!
15	* @internal
16	*/
17	class AnimatingState extends State {	19!
18	/**	×
19	* Whether user is clicking or touching
20	* @ko 현재 사용자가 클릭/터치중인지 여부
21	* @type {false}	×
22	* @readonly
23	*/
24	public readonly holding = false;	19!
25	/**
26	* Whether Flicking's animating
27	* @ko 현재 애니메이션 동작 여부
28	* @type {true}
29	* @readonly	1✔
30	*/	1!
31	public readonly animating = true;	18✔
32		×
33	public onHold(ctx: Parameters<State["onHold"]>[0]): void {	5✔
34	const { flicking, axesEvent, transitTo } = ctx;	×
35
36	this._delta = 0;	1✔
37	flicking.control.updateInput();
38
39	const holdStartEvent = new ComponentEvent(EVENTS.HOLD_START, { axesEvent });
40	flicking.trigger(holdStartEvent);
41		1✔
42	if (holdStartEvent.isCanceled()) {	1!
43	transitTo(STATE_TYPE.DISABLED);	1✔
44	} else {	1✔
45	transitTo(STATE_TYPE.DRAGGING);
46	}
47	}
48
49	public onChange(ctx: Parameters<State["onChange"]>[0]): void {	5✔
50	this._moveToChangedPosition(ctx);	81✔
51	}	1✔
52
53	public onFinish(ctx: Parameters<State["onFinish"]>[0]) {	198✔
54	const { flicking, axesEvent, transitTo } = ctx;	48✔
55
56	const control = flicking.control;	16✔
57	const controller = control.controller;	16✔
58	const animatingContext = controller.animatingContext;	16✔
59
60	transitTo(STATE_TYPE.IDLE);	209✔
61
62	flicking.trigger(new ComponentEvent(EVENTS.MOVE_END, {	16✔
63	isTrusted: axesEvent.isTrusted,
64	direction: getDirection(animatingContext.start, animatingContext.end),
65	axesEvent
66	}));
67		193✔
68	control.setActive(this._targetPanel!, control.activePanel, axesEvent.isTrusted);	209✔
69	}
70	}	6✔
71		3✔
72	export default AnimatingState;	8✔

naver / egjs-flicking / 1804823433

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous