1784576012

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/HewlettPackard/squest/commit/<a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/<a class="double-link" href="https://git"><a class=hub.com/HewlettPackard/squest/commit/c66abd3c29a046af7c8d0634c3335834ec92c4a3">c66abd3c2">&lt;a href=&quot;https://github.com/HewlettPackard/squest/commit/</a><a class="double-link" href="https://github.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/HewlettPackard/squest/commit/c66abd3c29a046af7c8d0634c3335834ec92c4a3">c66abd3c2</a><a href="https://github.com/HewlettPackard/squest/commit/c66abd3c29a046af7c8d0634c3335834ec92c4a3">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/HewlettPackard/squest/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/HewlettPackard/squest/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/HewlettPackard/squest/commit/c66abd3c29a046af7c8d0634c3335834ec92c4a3&quot;&gt;c66abd3c2&lt;/a&gt;&lt;a href=&quot;https://gith... (continued)

Pull Request Pull Request #371: Release 1.4.1

Run Details

498 of 498 new or added lines in 39 files covered. (100.0%)

6184 of 6594 relevant lines covered (93.78%)

0.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.08

/service_catalog/views/admin/request.py

import logging

import requests

from django.contrib import messages
from django.contrib.auth.decorators import user_passes_test, login_required
from django.core.exceptions import PermissionDenied
from django.shortcuts import render, get_object_or_404, redirect
from django.urls import reverse
from django.utils.safestring import mark_safe
from django_fsm import can_proceed

from service_catalog.forms import RequestMessageForm, AcceptRequestForm
from service_catalog.forms.request_forms import RequestForm
from service_catalog.mail_utils import send_mail_request_update
from service_catalog.models import Request

logger = logging.getLogger(__name__)


@user_passes_test(lambda u: u.is_superuser)
def admin_request_need_info(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    if not can_proceed(target_request.need_info):
        raise PermissionDenied
    if request.method == "POST":
        form = RequestMessageForm(request.POST or None, request.FILES or None, sender=request.user,
                                  target_request=target_request)
        if form.is_valid():
            message = form.save(send_notification=False)
            target_request.need_info()
            target_request.save()
            send_mail_request_update(target_request, user_applied_state=request.user, message=message)
            return redirect('service_catalog:request_list')
    else:
        form = RequestMessageForm(sender=request.user, target_request=target_request)
    breadcrumbs = [
        {'text': 'Requests', 'url': reverse('service_catalog:request_list')},
        {'text': request_id, 'url': ""},
    ]
    context = {
        'form': form,
        'target_request': target_request,
        'breadcrumbs': breadcrumbs
    }
    return render(request, "service_catalog/admin/request/request-need-info.html", context)


@user_passes_test(lambda u: u.is_superuser)
def admin_request_re_submit(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    if not can_proceed(target_request.re_submit):
        raise PermissionDenied
    if request.method == "POST":
        form = RequestMessageForm(request.POST or None, request.FILES or None, sender=request.user,
                                  target_request=target_request)
        if form.is_valid():
            message = form.save(send_notification=False)
            target_request.re_submit()
            target_request.save()
            send_mail_request_update(target_request, user_applied_state=request.user, message=message)
            return redirect('service_catalog:request_list')
    else:
        form = RequestMessageForm(sender=request.user, target_request=target_request)
    breadcrumbs = [
        {'text': 'Requests', 'url': reverse('service_catalog:request_list')},
        {'text': request_id, 'url': ""},
    ]
    context = {
        'form': form,
        'target_request': target_request,
        'breadcrumbs': breadcrumbs
    }
    return render(request, "service_catalog/admin/request/request-re-submit.html", context)


@user_passes_test(lambda u: u.is_superuser)
def admin_request_reject(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    if not can_proceed(target_request.reject):
        raise PermissionDenied
    if request.method == "POST":
        form = RequestMessageForm(request.POST or None, request.FILES or None, sender=request.user,
                                  target_request=target_request)
        if form.is_valid():
            message = form.save(send_notification=False)
            target_request.reject()
            target_request.save()
            send_mail_request_update(target_request, user_applied_state=request.user, message=message)
            return redirect('service_catalog:request_list')
    else:
        form = RequestMessageForm(sender=request.user, target_request=target_request)
    breadcrumbs = [
        {'text': 'Requests', 'url': reverse('service_catalog:request_list')},
        {'text': request_id, 'url': ""},
    ]
    context = {
        'form': form,
        'target_request': target_request,
        'breadcrumbs': breadcrumbs
    }
    return render(request, "service_catalog/admin/request/request-reject.html", context)


@user_passes_test(lambda u: u.is_superuser)
def admin_request_accept(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    if not can_proceed(target_request.accept):
        raise PermissionDenied
    parameters = {
        'request': target_request
    }
    if request.method == 'POST':
        form = AcceptRequestForm(request.user, request.POST, **parameters)
        if form.is_valid():
            form.save()
            target_request.refresh_from_db()
            send_mail_request_update(target_request, user_applied_state=request.user)
            return redirect('service_catalog:request_list')
    else:
        form = AcceptRequestForm(request.user, initial=target_request.fill_in_survey, **parameters)
    breadcrumbs = [
        {'text': 'Requests', 'url': reverse('service_catalog:request_list')},
        {'text': request_id, 'url': ""},
    ]
    context = {
        'form': form,
        'target_request': target_request,
        'breadcrumbs': breadcrumbs
    }
    return render(request, 'service_catalog/admin/request/request-accept.html', context=context)


@user_passes_test(lambda u: u.is_superuser)
def admin_request_process(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    if not can_proceed(target_request.process):
        raise PermissionDenied
    error_message = ""
    if request.method == "POST":
        error_message = process_request(request.user, target_request)
        if not error_message:
            return redirect('service_catalog:request_list')
    breadcrumbs = [
        {'text': 'Requests', 'url': reverse('service_catalog:request_list')},
        {'text': request_id, 'url': ""},
    ]
    context = {
        'target_request': target_request,
        'error_message': error_message,
        'breadcrumbs': breadcrumbs
    }
    return render(request, "service_catalog/admin/request/request-process.html", context)


@user_passes_test(lambda u: u.is_superuser)
def admin_request_archive(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    if not can_proceed(target_request.archive):
        raise PermissionDenied
    target_request.archive()
    target_request.save()
    return redirect('service_catalog:request_list')


@user_passes_test(lambda u: u.is_superuser)
def admin_request_unarchive(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    if not can_proceed(target_request.unarchive):
        raise PermissionDenied
    target_request.unarchive()
    target_request.save()
    return redirect('service_catalog:request_list')


@user_passes_test(lambda u: u.is_superuser)
def request_delete(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    parameters = {
        'request_id': request_id
    }
    if request.method == 'POST':
        target_request.delete()
        return redirect("service_catalog:request_list")
    breadcrumbs = [
        {'text': 'Requests', 'url': reverse('service_catalog:request_list')},
        {'text': request_id, 'url': ""},
        {'text': "Delete", 'url': ""},
    ]
    context = {
        'breadcrumbs': breadcrumbs,
        'confirm_text': mark_safe(f"Confirm deletion of request <strong>{target_request.id}</strong>?"),
        'action_url': reverse('service_catalog:request_delete', kwargs=parameters),
        'button_text': 'Delete'
    }
    return render(request, 'generics/confirm-delete-template.html', context=context)


def process_request(user, target_request):
    from towerlib.towerlibexceptions import AuthFailed
    try:
        # switch the state to processing before trying to execute the process
        target_request.process()
        target_request.save()
        target_request.perform_processing()
        target_request.save()
    except AuthFailed:
        logger.error(
            f"[admin_request_process] Fail to authenticate with provided token when trying to process request "
            f"id '{target_request.id}'")
        return "Fail to authenticate with provided token"
    except requests.exceptions.SSLError:
        logger.error(
            f"[admin_request_process] Certificate verify failed when trying to process request "
            f"id '{target_request.id}'")
        return "Certificate verify failed"
    except requests.exceptions.ConnectionError:
        logger.error(
            f"[admin_request_process] Unable to connect to remote server when trying to process request "
            f"id '{target_request.id}'")
        return "Unable to connect to remote server"
    target_request.save()
    send_mail_request_update(target_request, user_applied_state=user)
    return ""


@user_passes_test(lambda u: u.is_superuser)
def request_edit(request, request_id):
    target_request = get_object_or_404(Request, id=request_id)
    form = RequestForm(request.POST or None, request.FILES or None, instance=target_request)
    if form.is_valid():
        form.save()
        return redirect('service_catalog:request_details', target_request.id)
    context = dict()
    context['breadcrumbs'] = [
        {'text': 'Requests', 'url': reverse('service_catalog:request_list')},
        {'text': f"{target_request.id}",
         'url': reverse('service_catalog:request_details', args=[request_id])},
    ]
    context['object_name'] = 'request'
    context['form'] = form
    return render(request, 'generics/edit-sensitive-object.html', context)


@user_passes_test(lambda u: u.is_superuser)
def request_bulk_delete_confirm(request):
    context = {
        'confirm_text': mark_safe(f"Confirm deletion of the following requests?"),
        'action_url': reverse('service_catalog:request_bulk_delete'),
        'button_text': 'Delete',
        'breadcrumbs': [
            {'text': 'Requests', 'url': reverse('service_catalog:request_list')},
            {'text': "Delete multiple", 'url': ""}
        ]}
    if request.method == "POST":
        pks = request.POST.getlist("selection")
        context['object_list'] = Request.objects.filter(pk__in=pks)
        if context['object_list']:
            return render(request, 'generics/confirm-bulk-delete-template.html', context=context)
    messages.warning(request, 'No requests were selected for deletion.')
    return redirect('service_catalog:request_list')


@user_passes_test(lambda u: u.is_superuser)
def request_bulk_delete(request):
    if request.method == "POST":
        pks = request.POST.getlist("selection")
        selected_requests = Request.objects.filter(pk__in=pks)
        selected_requests.delete()
    return redirect("service_catalog:request_list")

1	import logging	1✔
2
3	import requests	1✔
4
5	from django.contrib import messages	1✔
6	from django.contrib.auth.decorators import user_passes_test, login_required	1✔
7	from django.core.exceptions import PermissionDenied	1✔
8	from django.shortcuts import render, get_object_or_404, redirect	1✔
9	from django.urls import reverse	1✔
10	from django.utils.safestring import mark_safe	1✔
11	from django_fsm import can_proceed	1✔
12
13	from service_catalog.forms import RequestMessageForm, AcceptRequestForm	1✔
14	from service_catalog.forms.request_forms import RequestForm	1✔
15	from service_catalog.mail_utils import send_mail_request_update	1✔
16	from service_catalog.models import Request	1✔
17
18	logger = logging.getLogger(__name__)	1✔
19
20
21	@user_passes_test(lambda u: u.is_superuser)	1✔
22	def admin_request_need_info(request, request_id):	1✔
23	target_request = get_object_or_404(Request, id=request_id)	1✔
24	if not can_proceed(target_request.need_info):	1✔
25	raise PermissionDenied	1✔
26	if request.method == "POST":	1✔
27	form = RequestMessageForm(request.POST or None, request.FILES or None, sender=request.user,	1✔
28	target_request=target_request)
29	if form.is_valid():	1✔
30	message = form.save(send_notification=False)	1✔
31	target_request.need_info()	1✔
32	target_request.save()	1✔
33	send_mail_request_update(target_request, user_applied_state=request.user, message=message)	1✔
34	return redirect('service_catalog:request_list')	1✔
35	else:
36	form = RequestMessageForm(sender=request.user, target_request=target_request)	1✔
37	breadcrumbs = [	1✔
38	{'text': 'Requests', 'url': reverse('service_catalog:request_list')},
39	{'text': request_id, 'url': ""},
40	]
41	context = {	1✔
42	'form': form,
43	'target_request': target_request,
44	'breadcrumbs': breadcrumbs
45	}
46	return render(request, "service_catalog/admin/request/request-need-info.html", context)	1✔
47
48
49	@user_passes_test(lambda u: u.is_superuser)	1✔
50	def admin_request_re_submit(request, request_id):	1✔
51	target_request = get_object_or_404(Request, id=request_id)	1✔
52	if not can_proceed(target_request.re_submit):	1✔
53	raise PermissionDenied	1✔
54	if request.method == "POST":	1✔
55	form = RequestMessageForm(request.POST or None, request.FILES or None, sender=request.user,	1✔
56	target_request=target_request)
57	if form.is_valid():	1✔
58	message = form.save(send_notification=False)	1✔
59	target_request.re_submit()	1✔
60	target_request.save()	1✔
61	send_mail_request_update(target_request, user_applied_state=request.user, message=message)	1✔
62	return redirect('service_catalog:request_list')	1✔
63	else:
64	form = RequestMessageForm(sender=request.user, target_request=target_request)	1✔
65	breadcrumbs = [	1✔
66	{'text': 'Requests', 'url': reverse('service_catalog:request_list')},
67	{'text': request_id, 'url': ""},
68	]
69	context = {	1✔
70	'form': form,
71	'target_request': target_request,
72	'breadcrumbs': breadcrumbs
73	}
74	return render(request, "service_catalog/admin/request/request-re-submit.html", context)	1✔
75
76
77	@user_passes_test(lambda u: u.is_superuser)	1✔
78	def admin_request_reject(request, request_id):	1✔
79	target_request = get_object_or_404(Request, id=request_id)	1✔
80	if not can_proceed(target_request.reject):	1✔
81	raise PermissionDenied	1✔
82	if request.method == "POST":	1✔
83	form = RequestMessageForm(request.POST or None, request.FILES or None, sender=request.user,	1✔
84	target_request=target_request)
85	if form.is_valid():	1✔
86	message = form.save(send_notification=False)	1✔
87	target_request.reject()	1✔
88	target_request.save()	1✔
89	send_mail_request_update(target_request, user_applied_state=request.user, message=message)	1✔
90	return redirect('service_catalog:request_list')	1✔
91	else:
92	form = RequestMessageForm(sender=request.user, target_request=target_request)	1✔
93	breadcrumbs = [	1✔
94	{'text': 'Requests', 'url': reverse('service_catalog:request_list')},
95	{'text': request_id, 'url': ""},
96	]
97	context = {	1✔
98	'form': form,
99	'target_request': target_request,
100	'breadcrumbs': breadcrumbs
101	}
102	return render(request, "service_catalog/admin/request/request-reject.html", context)	1✔
103
104
105	@user_passes_test(lambda u: u.is_superuser)	1✔
106	def admin_request_accept(request, request_id):	1✔
107	target_request = get_object_or_404(Request, id=request_id)	1✔
108	if not can_proceed(target_request.accept):	1✔
109	raise PermissionDenied	×
110	parameters = {	1✔
111	'request': target_request
112	}
113	if request.method == 'POST':	1✔
114	form = AcceptRequestForm(request.user, request.POST, **parameters)	1✔
115	if form.is_valid():	1✔
116	form.save()	1✔
117	target_request.refresh_from_db()	1✔
118	send_mail_request_update(target_request, user_applied_state=request.user)	1✔
119	return redirect('service_catalog:request_list')	1✔
120	else:
121	form = AcceptRequestForm(request.user, initial=target_request.fill_in_survey, **parameters)	1✔
122	breadcrumbs = [	1✔
123	{'text': 'Requests', 'url': reverse('service_catalog:request_list')},
124	{'text': request_id, 'url': ""},
125	]
126	context = {	1✔
127	'form': form,
128	'target_request': target_request,
129	'breadcrumbs': breadcrumbs
130	}
131	return render(request, 'service_catalog/admin/request/request-accept.html', context=context)	1✔
132
133
134	@user_passes_test(lambda u: u.is_superuser)	1✔
135	def admin_request_process(request, request_id):	1✔
136	target_request = get_object_or_404(Request, id=request_id)	1✔
137	if not can_proceed(target_request.process):	1✔
138	raise PermissionDenied	1✔
139	error_message = ""	1✔
140	if request.method == "POST":	1✔
141	error_message = process_request(request.user, target_request)	1✔
142	if not error_message:	1✔
143	return redirect('service_catalog:request_list')	1✔
144	breadcrumbs = [	1✔
145	{'text': 'Requests', 'url': reverse('service_catalog:request_list')},
146	{'text': request_id, 'url': ""},
147	]
148	context = {	1✔
149	'target_request': target_request,
150	'error_message': error_message,
151	'breadcrumbs': breadcrumbs
152	}
153	return render(request, "service_catalog/admin/request/request-process.html", context)	1✔
154
155
156	@user_passes_test(lambda u: u.is_superuser)	1✔
157	def admin_request_archive(request, request_id):	1✔
158	target_request = get_object_or_404(Request, id=request_id)	1✔
159	if not can_proceed(target_request.archive):	1✔
160	raise PermissionDenied	1✔
161	target_request.archive()	1✔
162	target_request.save()	1✔
163	return redirect('service_catalog:request_list')	1✔
164
165
166	@user_passes_test(lambda u: u.is_superuser)	1✔
167	def admin_request_unarchive(request, request_id):	1✔
168	target_request = get_object_or_404(Request, id=request_id)	1✔
169	if not can_proceed(target_request.unarchive):	1✔
170	raise PermissionDenied	1✔
171	target_request.unarchive()	1✔
172	target_request.save()	1✔
173	return redirect('service_catalog:request_list')	1✔
174
175
176	@user_passes_test(lambda u: u.is_superuser)	1✔
177	def request_delete(request, request_id):	1✔
178	target_request = get_object_or_404(Request, id=request_id)	1✔
179	parameters = {	1✔
180	'request_id': request_id
181	}
182	if request.method == 'POST':	1✔
183	target_request.delete()	1✔
184	return redirect("service_catalog:request_list")	1✔
185	breadcrumbs = [	1✔
186	{'text': 'Requests', 'url': reverse('service_catalog:request_list')},
187	{'text': request_id, 'url': ""},
188	{'text': "Delete", 'url': ""},
189	]
190	context = {	1✔
191	'breadcrumbs': breadcrumbs,
192	'confirm_text': mark_safe(f"Confirm deletion of request <strong>{target_request.id}</strong>?"),
193	'action_url': reverse('service_catalog:request_delete', kwargs=parameters),
194	'button_text': 'Delete'
195	}
196	return render(request, 'generics/confirm-delete-template.html', context=context)	1✔
197
198
199	def process_request(user, target_request):	1✔
200	from towerlib.towerlibexceptions import AuthFailed	1✔
201	try:	1✔
202	# switch the state to processing before trying to execute the process
203	target_request.process()	1✔
204	target_request.save()	1✔
205	target_request.perform_processing()	1✔
206	target_request.save()	1✔
207	except AuthFailed:	×
208	logger.error(	×
209	f"[admin_request_process] Fail to authenticate with provided token when trying to process request "
210	f"id '{target_request.id}'")
211	return "Fail to authenticate with provided token"	×
212	except requests.exceptions.SSLError:	×
213	logger.error(	×
214	f"[admin_request_process] Certificate verify failed when trying to process request "
215	f"id '{target_request.id}'")
216	return "Certificate verify failed"	×
217	except requests.exceptions.ConnectionError:	×
218	logger.error(	×
219	f"[admin_request_process] Unable to connect to remote server when trying to process request "
220	f"id '{target_request.id}'")
221	return "Unable to connect to remote server"	×
222	target_request.save()	1✔
223	send_mail_request_update(target_request, user_applied_state=user)	1✔
224	return ""	1✔
225
226
227	@user_passes_test(lambda u: u.is_superuser)	1✔
228	def request_edit(request, request_id):	1✔
229	target_request = get_object_or_404(Request, id=request_id)	1✔
230	form = RequestForm(request.POST or None, request.FILES or None, instance=target_request)	1✔
231	if form.is_valid():	1✔
232	form.save()	1✔
233	return redirect('service_catalog:request_details', target_request.id)	1✔
234	context = dict()	1✔
235	context['breadcrumbs'] = [	1✔
236	{'text': 'Requests', 'url': reverse('service_catalog:request_list')},
237	{'text': f"{target_request.id}",
238	'url': reverse('service_catalog:request_details', args=[request_id])},
239	]
240	context['object_name'] = 'request'	1✔
241	context['form'] = form	1✔
242	return render(request, 'generics/edit-sensitive-object.html', context)	1✔
243
244
245	@user_passes_test(lambda u: u.is_superuser)	1✔
246	def request_bulk_delete_confirm(request):	1✔
247	context = {	1✔
248	'confirm_text': mark_safe(f"Confirm deletion of the following requests?"),
249	'action_url': reverse('service_catalog:request_bulk_delete'),
250	'button_text': 'Delete',
251	'breadcrumbs': [
252	{'text': 'Requests', 'url': reverse('service_catalog:request_list')},
253	{'text': "Delete multiple", 'url': ""}
254	]}
255	if request.method == "POST":	1✔
256	pks = request.POST.getlist("selection")	1✔
257	context['object_list'] = Request.objects.filter(pk__in=pks)	1✔
258	if context['object_list']:	1✔
259	return render(request, 'generics/confirm-bulk-delete-template.html', context=context)	1✔
260	messages.warning(request, 'No requests were selected for deletion.')	1✔
261	return redirect('service_catalog:request_list')	1✔
262
263
264	@user_passes_test(lambda u: u.is_superuser)	1✔
265	def request_bulk_delete(request):	1✔
266	if request.method == "POST":	1✔
267	pks = request.POST.getlist("selection")	1✔
268	selected_requests = Request.objects.filter(pk__in=pks)	1✔
269	selected_requests.delete()	1✔
270	return redirect("service_catalog:request_list")	1✔

HewlettPackard / squest / 1784576012

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous