86479

pending completion

Build # 86479

Build Type

cron

travis-ci-com

Committed by

Fryguy

Commit Message

<a href="https://github.com/ManageIQ/manageiq/commit/<a class=hub.com/ManageIQ/manageiq/commit/98554337d27d58d21a383f4fdd0fe2f666478f7e">98554337d<a href="https://github.com/ManageIQ/manageiq/commit/98554337d27d58d21a383f4fdd0fe2f666478f7e">&quot;&gt;Merge pull request #20992 from agrare/fix_miq_environment_local_ip_address

Fix MiqEnvironment.local_ip_address to not prefer loopback

(cherry picked from commit </a><a class="double-link" href="https://github.com/ManageIQ/manageiq/commit/<a class="double-link" href="https://github.com/ManageIQ/manageiq/commit/fd276bac67283bf050e68ecc40cf95b31c5dd16b">fd276bac6</a>">fd276bac6</a><a href="https://github.com/ManageIQ/manageiq/commit/98554337d27d58d21a383f4fdd0fe2f666478f7e">)

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

31963 of 53556 relevant lines covered (59.68%)

208.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.19

/lib/miq_environment.rb

require 'sys-uname'
require 'socket'

module MiqEnvironment
  # Return the fully qualified hostname for the local host.
  #
  def self.fully_qualified_domain_name
    Socket.gethostbyname(Socket.gethostname).first
  end

  # Return the local IP v4 address of the local host
  #
  def self.local_ip_address
    ipv4_addrs = Socket.ip_address_list.select(&:ipv4?).sort_by(&:ip_address)

    # Prioritize "public" aka non-loopback non-private addresses first, then
    # prefer private addresses, then take whatever we can get
    local_addr   = ipv4_addrs.detect { |ip| !ip.ipv4_loopback? && !ip.ipv4_private? }
    local_addr ||= ipv4_addrs.detect { |ip| !ip.ipv4_loopback? }
    local_addr ||= ipv4_addrs.first

    local_addr&.ip_address
  end

  class Command
    EVM_KNOWN_COMMANDS = %w[apachectl memcached memcached-tool nohup service systemctl].freeze

    def self.supports_memcached?
      return @supports_memcached unless @supports_memcached.nil?
      @supports_memcached = is_linux? && is_appliance? && !is_container? && supports_command?('memcached') && supports_command?('memcached-tool') && supports_command?('service')
    end

    def self.supports_apache?
      return @supports_apache unless @supports_apache.nil?
      @supports_apache = is_appliance? && supports_command?('apachectl')
    end

    def self.supports_systemd?
      return @supports_systemd unless @supports_systemd.nil?
      @supports_systemd = is_appliance? && !is_container? && supports_command?('systemctl')
    end

    def self.supports_nohup_and_backgrounding?
      return @supports_nohup unless @supports_nohup.nil?
      @supports_nohup = is_appliance? && supports_command?('nohup')
    end

    def self.is_production_build?
      is_appliance? || is_podified? || is_container?
    end

    def self.is_container?
      return @is_container unless @is_container.nil?
      @is_container = ENV["CONTAINER"] == "true"
    end

    def self.is_podified?
      return @is_podified unless @is_podified.nil?
      @is_podified = is_container? && ContainerOrchestrator.available?
    end

    def self.is_appliance?
      return @is_appliance unless @is_appliance.nil?
      @is_appliance = ENV["APPLIANCE"] == "true"
    end

    # Return whether or not the current ManageIQ environment is a production
    # environment. Assumes production if Rails is not defined or if the Rails
    # environment is set to 'production'.
    #
    def self.is_production?
      defined?(Rails) ? Rails.env.production? : true
    end

    def self.is_linux?
      return @is_linux unless @is_linux.nil?
      @is_linux = (Sys::Platform::IMPL == :linux)
    end

    def self.rake_command
      "rake"
    end

    def self.runner_command
      "#{rails_command} runner"
    end

    def self.rails_command
      "rails"
    end

    def self.supports_command?(cmd)
      return false unless EVM_KNOWN_COMMANDS.include?(cmd)
      require "runcmd"

      begin
        # If 'which apachectl' returns non-zero, it wasn't found
        MiqUtil.runcmd(which, :params => [[cmd]])
      rescue
        false
      else
        true
      end
    end

    def self.which
      case Sys::Platform::IMPL
      when :linux
        "which"
      else
        raise "Not yet supported platform: #{Sys::Platform::IMPL}"
      end
    end
  end
end

1	require 'sys-uname'	1✔
2	require 'socket'	1✔
3
4	module MiqEnvironment	1✔
5	# Return the fully qualified hostname for the local host.
6	#
7	def self.fully_qualified_domain_name	1✔
8	Socket.gethostbyname(Socket.gethostname).first	1✔
9	end
10
11	# Return the local IP v4 address of the local host
12	#
13	def self.local_ip_address	1✔
14	ipv4_addrs = Socket.ip_address_list.select(&:ipv4?).sort_by(&:ip_address)	3✔
15
16	# Prioritize "public" aka non-loopback non-private addresses first, then
17	# prefer private addresses, then take whatever we can get
18	local_addr = ipv4_addrs.detect { \|ip\| !ip.ipv4_loopback? && !ip.ipv4_private? }	10✔
19	local_addr \|\|= ipv4_addrs.detect { \|ip\| !ip.ipv4_loopback? }	6✔
20	local_addr \|\|= ipv4_addrs.first	3✔
21
22	local_addr&.ip_address	3✔
23	end
24
25	class Command	1✔
26	EVM_KNOWN_COMMANDS = %w[apachectl memcached memcached-tool nohup service systemctl].freeze	1✔
27
28	def self.supports_memcached?	1✔
29	return @supports_memcached unless @supports_memcached.nil?	2✔
30	@supports_memcached = is_linux? && is_appliance? && !is_container? && supports_command?('memcached') && supports_command?('memcached-tool') && supports_command?('service')	1✔
31	end
32
33	def self.supports_apache?	1✔
34	return @supports_apache unless @supports_apache.nil?	5✔
35	@supports_apache = is_appliance? && supports_command?('apachectl')	4✔
36	end
37
38	def self.supports_systemd?	1✔
39	return @supports_systemd unless @supports_systemd.nil?	11✔
40	@supports_systemd = is_appliance? && !is_container? && supports_command?('systemctl')	9✔
41	end
42
43	def self.supports_nohup_and_backgrounding?	1✔
44	return @supports_nohup unless @supports_nohup.nil?	2✔
45	@supports_nohup = is_appliance? && supports_command?('nohup')	1✔
46	end
47
48	def self.is_production_build?	1✔
49	is_appliance? \|\| is_podified? \|\| is_container?	8✔
50	end
51
52	def self.is_container?	1✔
53	return @is_container unless @is_container.nil?	2,007✔
54	@is_container = ENV["CONTAINER"] == "true"	2,001✔
55	end
56
57	def self.is_podified?	1✔
58	return @is_podified unless @is_podified.nil?	3,050✔
59	@is_podified = is_container? && ContainerOrchestrator.available?	1,998✔
60	end
61
62	def self.is_appliance?	1✔
63	return @is_appliance unless @is_appliance.nil?	24✔
64	@is_appliance = ENV["APPLIANCE"] == "true"	17✔
65	end
66
67	# Return whether or not the current ManageIQ environment is a production
68	# environment. Assumes production if Rails is not defined or if the Rails
69	# environment is set to 'production'.
70	#
71	def self.is_production?	1✔
72	defined?(Rails) ? Rails.env.production? : true	6✔
73	end
74
75	def self.is_linux?	1✔
76	return @is_linux unless @is_linux.nil?	×
77	@is_linux = (Sys::Platform::IMPL == :linux)	×
78	end
79
80	def self.rake_command	1✔
81	"rake"	×
82	end
83
84	def self.runner_command	1✔
85	"#{rails_command} runner"	×
86	end
87
88	def self.rails_command	1✔
89	"rails"	×
90	end
91
92	def self.supports_command?(cmd)	1✔
93	return false unless EVM_KNOWN_COMMANDS.include?(cmd)	×
94	require "runcmd"	×
95
96	begin
97	# If 'which apachectl' returns non-zero, it wasn't found
98	MiqUtil.runcmd(which, :params => [[cmd]])	×
99	rescue
100	false	×
101	else
102	true	×
103	end
104	end
105
106	def self.which	1✔
107	case Sys::Platform::IMPL	×
108	when :linux
109	"which"	×
110	else
111	raise "Not yet supported platform: #{Sys::Platform::IMPL}"	×
112	end
113	end
114	end
115	end

ManageIQ / manageiq / 86479

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous