1630622659

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/PyCQA/pylint-django/commit/<a class=hub.com/PyCQA/pylint-django/commit/<a class="double-link" href="https://git"><a class=hub.com/PyCQA/pylint-django/commit/<a class="double-link" href="https://git"><a class=hub.com/PyCQA/pylint-django/commit/<a class="double-link" href="https://git"><a class=hub.com/PyCQA/pylint-django/commit/<a class="double-link" href="https://git"><a class=hub.com/PyCQA/pylint-django/commit/cf94f9107dbc33993f1da5197d396f6aca8abe8c">cf94f9107">&lt;a href=&quot;https://github.com/PyCQA/pylint-django/commit/</a><a class="double-link" href="https://github.com/PyCQA/pylint-django/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/PyCQA/pylint-django/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/PyCQA/pylint-django/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/PyCQA/pylint-django/commit/cf94f9107dbc33993f1da5197d396f6aca8abe8c">cf94f9107</a><a href="https://github.com/PyCQA/pylint-django/commit/cf94f9107dbc33993f1da5197d396f6aca8abe8c">&lt;a href=&quot;https://github.com/PyCQA/pylint-django/commit/cf94f9107dbc33993f1da5197d396f6aca8abe8c&quot;&gt;&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/PyCQA/pylint-django/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/PyCQA/pylint-django/commit/&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://git&amp;quot;&amp;gt;&amp;amp;lt;a class=&amp;lt;/a&amp;gt;hub.com/PyCQA/pylint-django/commit/cf94f9107dbc33993f1da5197d396f6aca8abe8c&amp;quot;&amp;gt;cf94f9107&amp;lt;/a&amp;gt;&amp;lt;a href=&amp;quot;https://github.com/PyCQA/pylint-django/commit/cf94f9107dbc33993f1da5197d396f6aca8abe8c&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/PyCQA/pylint-django/commit/cf94f9107dbc33993f1da5197d396f6a&amp;lt;/a&amp;gt;ca8abe8</a>c&quot;&gt;&amp;quot;&amp;gt;Merge &amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/PyCQA/pylint-django/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/PyCQA/pylint-django/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/PyCQA/pylint-django/commit/bb3cb1e5ee76ed0fa60078e63... (continued)

Pull Request Pull Request #340: GitHub actions

Run Details

260 of 260 new or added lines in 18 files covered. (100.0%)

724 of 839 relevant lines covered (86.29%)

6.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

57.78

/pylint_django/checkers/foreign_key_strings.py

from __future__ import absolute_import

import astroid
from pylint.checkers import BaseChecker
from pylint.checkers.utils import check_messages
from pylint.interfaces import IAstroidChecker

from pylint_django.__pkginfo__ import BASE_ID
from pylint_django.transforms import foreignkey


class ForeignKeyStringsChecker(BaseChecker):
    """
    Adds transforms to be able to do type inference for model ForeignKeyField
    properties which use a string to name the foreign relationship. This uses
    Django's model name resolution and this checker wraps the setup to ensure
    Django is able to configure itself before attempting to use the lookups.
    """

    _LONG_MESSAGE = """Finding foreign-key relationships from strings in pylint-django requires configuring Django.
This can be done via the DJANGO_SETTINGS_MODULE environment variable or the pylint option django-settings-module, eg:

    `pylint --load-plugins=pylint_django --django-settings-module=myproject.settings`

. This can also be set as an option in a .pylintrc configuration file.

Some basic default settings were used, however this will lead to less accurate linting.
Consider passing in an explicit Django configuration file to match your project to improve accuracy."""

    __implements__ = (IAstroidChecker,)

    name = "Django foreign keys referenced by strings"

    options = (
        (
            "django-settings-module",
            {
                "default": None,
                "type": "string",
                "metavar": "<django settings module>",
                "help": "A module containing Django settings to be used while linting.",
            },
        ),
    )

    msgs = {
        f"E{BASE_ID}10": (
            "Django was not configured. For more information run "
            "pylint --load-plugins=pylint_django --help-msg=django-not-configured",
            "django-not-configured",
            _LONG_MESSAGE,
        ),
        f"F{BASE_ID}10": (
            "Provided Django settings %s could not be loaded",
            "django-settings-module-not-found",
            "The provided Django settings module %s was not found on the path",
        ),
    }

    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self._raise_warning = False

    def open(self):
        # This is a bit of a hacky workaround. pylint-django does not *require* that
        # Django is configured explicitly, and will use some basic defaults in that
        # case. However, as this is a WARNING not a FATAL, the error must be raised
        # with an AST node - only F and R messages are scope exempt (see
        # https://github.com/PyCQA/pylint/blob/master/pylint/constants.py#L24)

        # However, testing to see if Django is configured happens in `open()`
        # before any modules are inspected, as Django needs to be configured with
        # defaults before the foreignkey checker can work properly. At this point,
        # there are no nodes.

        # Therefore, during the initialisation in `open()`, if django was configured
        # using defaults by pylint-django, it cannot raise the warning yet and
        # must wait until some module is inspected to be able to raise... so that
        # state is stashed in this property.

        try:
            from django.core.exceptions import (  # pylint: disable=import-outside-toplevel
                ImproperlyConfigured,
            )
        except ModuleNotFoundError:
            return

        try:
            import django  # pylint: disable=import-outside-toplevel

            django.setup()
            from django.apps import (  # noqa pylint: disable=import-outside-toplevel,unused-import
                apps,
            )

            # flake8: noqa=F401, F403
        except ImproperlyConfigured:
            # this means that Django wasn't able to configure itself using some defaults
            # provided (likely in a DJANGO_SETTINGS_MODULE environment variable)
            # so see if the user has specified a pylint option
            if self.config.django_settings_module is None:
                # we will warn the user that they haven't actually configured Django themselves
                self._raise_warning = True
                # but use django defaults then...
                from django.conf import (  # pylint: disable=import-outside-toplevel
                    settings,
                )

                settings.configure()
                django.setup()
            else:
                # see if we can load the provided settings module
                try:
                    from django.conf import (  # pylint: disable=import-outside-toplevel
                        Settings,
                        settings,
                    )

                    settings.configure(Settings(self.config.django_settings_module))
                    django.setup()
                except ImportError:
                    # we could not find the provided settings module...
                    # at least here it is a fatal error so we can just raise this immediately
                    self.add_message(
                        "django-settings-module-not-found",
                        args=self.config.django_settings_module,
                    )
                    # however we'll trundle on with basic settings
                    from django.conf import (  # pylint: disable=import-outside-toplevel
                        settings,
                    )

                    settings.configure()
                    django.setup()

        # Now we can add the transforms specific to this checker
        foreignkey.add_transform(astroid.MANAGER)

        # TODO: this is a bit messy having so many inline imports but in order to avoid
        # duplicating the django_installed checker, it'll do for now. In the future, merging
        # those two checkers together might make sense.

    @check_messages("django-not-configured")
    def visit_module(self, node):
        if self._raise_warning:
            # just add it to the first node we see... which isn't nice but not sure what else to do
            self.add_message("django-not-configured", node=node)
            self._raise_warning = False  # only raise it once...

1	from __future__ import absolute_import	8✔
2
3	import astroid	8✔
4	from pylint.checkers import BaseChecker	8✔
5	from pylint.checkers.utils import check_messages	8✔
6	from pylint.interfaces import IAstroidChecker	8✔
7
8	from pylint_django.__pkginfo__ import BASE_ID	8✔
9	from pylint_django.transforms import foreignkey	8✔
10
11
12	class ForeignKeyStringsChecker(BaseChecker):	8✔
13	"""
14	Adds transforms to be able to do type inference for model ForeignKeyField
15	properties which use a string to name the foreign relationship. This uses
16	Django's model name resolution and this checker wraps the setup to ensure
17	Django is able to configure itself before attempting to use the lookups.
18	"""
19
20	_LONG_MESSAGE = """Finding foreign-key relationships from strings in pylint-django requires configuring Django.	8✔
21	This can be done via the DJANGO_SETTINGS_MODULE environment variable or the pylint option django-settings-module, eg:
22
23	`pylint --load-plugins=pylint_django --django-settings-module=myproject.settings`
24
25	. This can also be set as an option in a .pylintrc configuration file.
26
27	Some basic default settings were used, however this will lead to less accurate linting.
28	Consider passing in an explicit Django configuration file to match your project to improve accuracy."""
29
30	__implements__ = (IAstroidChecker,)	8✔
31
32	name = "Django foreign keys referenced by strings"	8✔
33
34	options = (	8✔
35	(
36	"django-settings-module",
37	{
38	"default": None,
39	"type": "string",
40	"metavar": "<django settings module>",
41	"help": "A module containing Django settings to be used while linting.",
42	},
43	),
44	)
45
46	msgs = {	8✔
47	f"E{BASE_ID}10": (
48	"Django was not configured. For more information run "
49	"pylint --load-plugins=pylint_django --help-msg=django-not-configured",
50	"django-not-configured",
51	_LONG_MESSAGE,
52	),
53	f"F{BASE_ID}10": (
54	"Provided Django settings %s could not be loaded",
55	"django-settings-module-not-found",
56	"The provided Django settings module %s was not found on the path",
57	),
58	}
59
60	def __init__(self, args, *kwargs):	8✔
61	super().__init__(args, *kwargs)	8✔
62	self._raise_warning = False	8✔
63
64	def open(self):	8✔
65	# This is a bit of a hacky workaround. pylint-django does not require that
66	# Django is configured explicitly, and will use some basic defaults in that
67	# case. However, as this is a WARNING not a FATAL, the error must be raised
68	# with an AST node - only F and R messages are scope exempt (see
69	# https://github.com/PyCQA/pylint/blob/master/pylint/constants.py#L24)
70
71	# However, testing to see if Django is configured happens in `open()`
72	# before any modules are inspected, as Django needs to be configured with
73	# defaults before the foreignkey checker can work properly. At this point,
74	# there are no nodes.
75
76	# Therefore, during the initialisation in `open()`, if django was configured
77	# using defaults by pylint-django, it cannot raise the warning yet and
78	# must wait until some module is inspected to be able to raise... so that
79	# state is stashed in this property.
80
81	try:	8✔
82	from django.core.exceptions import ( # pylint: disable=import-outside-toplevel	8✔
83	ImproperlyConfigured,
84	)
85	except ModuleNotFoundError:	×
86	return	×
87
88	try:	8✔
89	import django # pylint: disable=import-outside-toplevel	8✔
90
91	django.setup()	8✔
92	from django.apps import ( # noqa pylint: disable=import-outside-toplevel,unused-import	8✔
93	apps,
94	)
95
96	# flake8: noqa=F401, F403
97	except ImproperlyConfigured:	×
98	# this means that Django wasn't able to configure itself using some defaults
99	# provided (likely in a DJANGO_SETTINGS_MODULE environment variable)
100	# so see if the user has specified a pylint option
101	if self.config.django_settings_module is None:	×
102	# we will warn the user that they haven't actually configured Django themselves
103	self._raise_warning = True	×
104	# but use django defaults then...
105	from django.conf import ( # pylint: disable=import-outside-toplevel	×
106	settings,
107	)
108
109	settings.configure()	×
110	django.setup()	×
111	else:
112	# see if we can load the provided settings module
113	try:	×
114	from django.conf import ( # pylint: disable=import-outside-toplevel	×
115	Settings,
116	settings,
117	)
118
119	settings.configure(Settings(self.config.django_settings_module))	×
120	django.setup()	×
121	except ImportError:	×
122	# we could not find the provided settings module...
123	# at least here it is a fatal error so we can just raise this immediately
124	self.add_message(	×
125	"django-settings-module-not-found",
126	args=self.config.django_settings_module,
127	)
128	# however we'll trundle on with basic settings
129	from django.conf import ( # pylint: disable=import-outside-toplevel	×
130	settings,
131	)
132
133	settings.configure()	×
134	django.setup()	×
135
136	# Now we can add the transforms specific to this checker
137	foreignkey.add_transform(astroid.MANAGER)	8✔
138
139	# TODO: this is a bit messy having so many inline imports but in order to avoid
140	# duplicating the django_installed checker, it'll do for now. In the future, merging
141	# those two checkers together might make sense.
142
143	@check_messages("django-not-configured")	8✔
144	def visit_module(self, node):
145	if self._raise_warning:	8✔
146	# just add it to the first node we see... which isn't nice but not sure what else to do
147	self.add_message("django-not-configured", node=node)	×
148	self._raise_warning = False # only raise it once...	×

PyCQA / pylint-django / 1630622659

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous