1565436304

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/SchemaPlus/schema_dev/commit/<a class=hub.com/SchemaPlus/schema_dev/commit/<a class="double-link" href="https://git"><a class=hub.com/SchemaPlus/schema_dev/commit/<a class="double-link" href="https://git"><a class=hub.com/SchemaPlus/schema_dev/commit/<a class="double-link" href="https://git"><a class=hub.com/SchemaPlus/schema_dev/commit/6e1f0bce43b7cf9323843724d63fc0bb51bc0de3">6e1f0bce4">&lt;a href=&quot;https://github.com/SchemaPlus/schema_dev/commit/</a><a class="double-link" href="https://github.com/SchemaPlus/schema_dev/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/SchemaPlus/schema_dev/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/SchemaPlus/schema_dev/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/SchemaPlus/schema_dev/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/SchemaPlus/schema_dev/commit/6e1f0bce43b7cf9323843724d63fc0bb51bc0de3">6e1f0bce4</a><a href="https://github.com/SchemaPlus/schema_dev/commit/6e1f0bce43b7cf9323843724d63fc0bb51bc0de3">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/SchemaPlus/schema_dev/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/SchemaPlus/schema_dev/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/SchemaPlus/schema_dev/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/SchemaPlus/schema_dev/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/SchemaPlus/schema_dev/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/SchemaPlus/schema_dev/commit/6e1f0bce43b7cf9323843724d63fc0bb51bc0de3&quot;&gt;6e1f0bce4&lt;/a&gt;&lt;a href=&quot;https://github.com/SchemaPlus/schema_dev/commit/6e1f0bce43b7cf9323843724d63fc0bb51bc0de3&quot;&gt;&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/SchemaPlus/schema_dev/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp... (continued)

Pull Request Pull Request #28: cleanup code based on several rubocop rules

Run Details

77 of 96 branches covered (80.21%)

92 of 93 new or added lines in 11 files covered. (98.92%)

430 of 433 relevant lines covered (99.31%)

90.02 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.82

/lib/schema_dev/config.rb

# frozen_string_literal: true

require 'active_support/core_ext/hash'
require 'pathname'
require 'yaml'
require 'rubygems/version'

module SchemaDev
  CONFIG_FILE = 'schema_dev.yml'

  class Config
    attr_accessor :quick, :db, :dbversions, :ruby, :activerecord, :exclude

    # for use by rspec
    def self._reset
      @load = nil
    end

    def self.read
      new(**YAML.safe_load(Pathname.new(CONFIG_FILE).read, [Symbol]).symbolize_keys)
    end

    def self.load
      @load ||= read
    end

    def initialize(ruby:, activerecord:, db:, dbversions: nil, exclude: nil, notify: nil, quick: nil)
      @ruby = Array.wrap(ruby).map(&:to_s)
      @activerecord = Array.wrap(activerecord).map(&:to_s)
      @db = Array.wrap(db)
      @dbversions = (dbversions || {}).symbolize_keys
      @exclude = Array.wrap(exclude).map(&:symbolize_keys).map { |tuple| Tuple.new(**tuple.transform_values(&:to_s)) }
      if @activerecord.include?('5.2')
        ruby3 = ::Gem::Version.new('3.0')

        @ruby.select { |e| ::Gem::Version.new(e) >= ruby3 }.each do |v|
          @exclude << Tuple.new(ruby: v, activerecord: '5.2')
        end
      end
      unless notify.nil?
        warn 'Notify is no longer supported'
      end
      @quick = Array.wrap(quick || { ruby: @ruby.last, activerecord: @activerecord.last, db: @db.last })
    end

    def dbms
      @dbms ||= %i[postgresql mysql].select { |dbm| @db.grep(/^#{dbm}/).any? }
    end

    DB_VERSION_DEFAULTS = {
      postgresql: ['9.6']
    }.freeze

    def db_versions_for(db)
      @dbversions.fetch(db.to_sym, DB_VERSION_DEFAULTS.fetch(db.to_sym, [])).map(&:to_s)
    end

    def matrix(quick: false, ruby: nil, activerecord: nil, db: nil, excluded: nil, with_dbversion: false)
      use_ruby = @ruby
      use_activerecord = @activerecord
      use_db = @db
      if quick
        use_ruby = @quick.map { |q| q[:ruby] }
        use_activerecord = @quick.map { |q| q[:activerecord] }
        use_db = @quick.map { |q| q[:db] }
      end
      use_ruby = Array.wrap(ruby) if ruby
      use_activerecord = Array.wrap(activerecord) if activerecord
      use_db = Array.wrap(db) if db

      use_ruby = [nil] unless use_ruby.any?
      use_activerecord = [nil] unless use_activerecord.any?
      use_db = [nil] unless use_db.any?

      m = use_ruby.product(use_activerecord, use_db)
      m = m.flat_map do |loop_ruby, loop_activerecord, loop_db|
        if with_dbversion && !(dbversions = db_versions_for(loop_db)).empty?
          dbversions.map { |v| Tuple.new(ruby: loop_ruby, activerecord: loop_activerecord, db: loop_db, dbversion: v) }
        else
          [Tuple.new(ruby: loop_ruby, activerecord: loop_activerecord, db: loop_db)]
        end
      end.compact
      m = m.reject { |r| r.match_any?(@exclude) } unless excluded == :none
      m = m.map(&:to_hash)

      if excluded == :only
        matrix(quick: quick, ruby: ruby, activerecord: activerecord, db: db, with_dbversion: with_dbversion, excluded: :none) - m
      else
        m
      end
    end

    Tuple = Struct.new(:ruby, :activerecord, :db, :dbversion, keyword_init: true) do
      def match?(other)
        return false if ruby and other.ruby and ruby != other.ruby
        return false if activerecord and other.activerecord and activerecord != other.activerecord
        return false if db and other.db and db != other.db
        return false if dbversion and other.dbversion and dbversion != other.dbversion

        true
      end

      def match_any?(others)
        others.any? { |other| match? other }
      end

      def to_hash
        to_h.compact.transform_values(&:to_s)
      end
    end
  end
end

1	# frozen_string_literal: true
2
3	require 'active_support/core_ext/hash'	4✔
4	require 'pathname'	4✔
5	require 'yaml'	4✔
6	require 'rubygems/version'	4✔
7
8	module SchemaDev	4✔
9	CONFIG_FILE = 'schema_dev.yml'	4✔
10
11	class Config	4✔
12	attr_accessor :quick, :db, :dbversions, :ruby, :activerecord, :exclude	4✔
13
14	# for use by rspec
15	def self._reset	4✔
16	@load = nil	104✔
17	end
18
19	def self.read	4✔
20	new(**YAML.safe_load(Pathname.new(CONFIG_FILE).read, [Symbol]).symbolize_keys)	124✔
21	end
22
23	def self.load	4✔
24	@load \|\|= read	104✔
25	end
26
27	def initialize(ruby:, activerecord:, db:, dbversions: nil, exclude: nil, notify: nil, quick: nil)	4✔
28	@ruby = Array.wrap(ruby).map(&:to_s)	124✔
29	@activerecord = Array.wrap(activerecord).map(&:to_s)	124✔
30	@db = Array.wrap(db)	124✔
31	@dbversions = (dbversions \|\| {}).symbolize_keys	124✔
32	@exclude = Array.wrap(exclude).map(&:symbolize_keys).map { \|tuple\| Tuple.new(**tuple.transform_values(&:to_s)) }	144✔
33	if @activerecord.include?('5.2')	124✔
34	ruby3 = ::Gem::Version.new('3.0')	64✔
35
36	@ruby.select { \|e\| ::Gem::Version.new(e) >= ruby3 }.each do \|v\|	164✔
37	@exclude << Tuple.new(ruby: v, activerecord: '5.2')	28✔
38	end
39	end
40	unless notify.nil?	124✔
41	warn 'Notify is no longer supported'	8✔
42	end
43	@quick = Array.wrap(quick \|\| { ruby: @ruby.last, activerecord: @activerecord.last, db: @db.last })	124✔
44	end
45
46	def dbms	4✔
NEW 47	@dbms \|\|= %i[postgresql mysql].select { \|dbm\| @db.grep(/^#{dbm}/).any? }	×
48	end
49
50	DB_VERSION_DEFAULTS = {	1✔
51	postgresql: ['9.6']	3✔
52	}.freeze
53
54	def db_versions_for(db)	4✔
55	@dbversions.fetch(db.to_sym, DB_VERSION_DEFAULTS.fetch(db.to_sym, [])).map(&:to_s)	628✔
56	end
57
58	def matrix(quick: false, ruby: nil, activerecord: nil, db: nil, excluded: nil, with_dbversion: false)	4✔
59	use_ruby = @ruby	180✔
60	use_activerecord = @activerecord	180✔
61	use_db = @db	180✔
62	if quick	180✔
63	use_ruby = @quick.map { \|q\| q[:ruby] }	8✔
64	use_activerecord = @quick.map { \|q\| q[:activerecord] }	8✔
65	use_db = @quick.map { \|q\| q[:db] }	8✔
66	end
67	use_ruby = Array.wrap(ruby) if ruby	180!
68	use_activerecord = Array.wrap(activerecord) if activerecord	180!
69	use_db = Array.wrap(db) if db	180✔
70
71	use_ruby = [nil] unless use_ruby.any?	180!
72	use_activerecord = [nil] unless use_activerecord.any?	180!
73	use_db = [nil] unless use_db.any?	180!
74
75	m = use_ruby.product(use_activerecord, use_db)	180✔
76	m = m.flat_map do \|loop_ruby, loop_activerecord, loop_db\|	180✔
77	if with_dbversion && !(dbversions = db_versions_for(loop_db)).empty?	800✔
78	dbversions.map { \|v\| Tuple.new(ruby: loop_ruby, activerecord: loop_activerecord, db: loop_db, dbversion: v) }	720✔
79	else	448✔
80	[Tuple.new(ruby: loop_ruby, activerecord: loop_activerecord, db: loop_db)]	448✔
81	end
82	end.compact
83	m = m.reject { \|r\| r.match_any?(@exclude) } unless excluded == :none	996!
84	m = m.map(&:to_hash)	180✔
85
86	if excluded == :only	180!
87	matrix(quick: quick, ruby: ruby, activerecord: activerecord, db: db, with_dbversion: with_dbversion, excluded: :none) - m	×
88	else	180✔
89	m	180✔
90	end
91	end
92
93	Tuple = Struct.new(:ruby, :activerecord, :db, :dbversion, keyword_init: true) do	4✔
94	def match?(other)	4✔
95	return false if ruby and other.ruby and ruby != other.ruby	628✔
96	return false if activerecord and other.activerecord and activerecord != other.activerecord	328✔
97	return false if db and other.db and db != other.db	132✔
98	return false if dbversion and other.dbversion and dbversion != other.dbversion	116✔
99
100	true	112✔
101	end
102
103	def match_any?(others)	4✔
104	others.any? { \|other\| match? other }	1,444✔
105	end
106
107	def to_hash	4✔
108	to_h.compact.transform_values(&:to_s)	736✔
109	end
110	end
111	end
112	end

SchemaPlus / schema_dev / 1565436304

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous