1232736708

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/ringcentral/ringcentral-js-widgets/commit/<a class=hub.com/ringcentral/ringcentral-js-widgets/commit/<a class="double-link" href="https://git"><a class=hub.com/ringcentral/ringcentral-js-widgets/commit/<a class="double-link" href="https://git"><a class=hub.com/ringcentral/ringcentral-js-widgets/commit/<a class="double-link" href="https://git"><a class=hub.com/ringcentral/ringcentral-js-widgets/commit/db8fbf38d6582be5c81de0625234535d2be5e1f6">db8fbf38d">&lt;a href=&quot;https://github.com/ringcentral/ringcentral-js-widgets/commit/</a><a class="double-link" href="https://github.com/ringcentral/ringcentral-js-widgets/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/ringcentral/ringcentral-js-widgets/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/ringcentral/ringcentral-js-widgets/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/ringcentral/ringcentral-js-widgets/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/ringcentral/ringcentral-js-widgets/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/ringcentral/ringcentral-js-widgets/commit/db8fbf38d6582be5c81de0625234535d2be5e1f6">db8fbf38d</a><a href="https://github.com/ringcentral/ringcentral-js-widgets/commit/db8fbf38d6582be5c81de0625234535d2be5e1f6">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/ringcentral/ringcentral-js-widgets/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/ringcentral/ringcentral-js-widgets/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/ringcentral/ringcentral-js-widgets/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/ringcentral/ringcentral-js-widgets/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/ringcentral/ringcentral-js-widgets/commit/db8fbf38d6582be5c81de0625234535d2be5e1f6&quot;&gt;db8fbf38d&lt;/a&gt;&lt;a href=&quot;https://github.com/ringcentral/ringcentral-js-widgets/commit/db8fbf38d6582be5c81de0625234535d2be5e1f6&quot;&gt;&amp;lt;a hre... (continued)

Pull Request Pull Request #1688: sync features and bugfixs from 206c0e0

Run Details

2473 of 5499 branches covered (44.97%)

Branch coverage included in aggregate %.

20 of 28 new or added lines in 8 files covered. (71.43%)

4116 of 7638 relevant lines covered (53.89%)

236717.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

4.59

/packages/ringcentral-widgets/modules/ContactDetailsUI/ContactDetailsUI.ts

import {
  track,
  state,
  action,
  RcUIModuleV2,
} from '@ringcentral-integration/core';
import { Module } from '@ringcentral-integration/commons/lib/di';
import background from '@ringcentral-integration/commons/lib/background';
import proxify from '@ringcentral-integration/commons/lib/proxy/proxify';
import {
  isE164,
  parseIncompletePhoneNumber,
} from '@ringcentral-integration/phone-number';
import { phoneTypes } from '@ringcentral-integration/commons/enums/phoneTypes';
import { formatNumber } from '@ringcentral-integration/commons/lib/formatNumber';
import { ContactModel } from '@ringcentral-integration/commons/interfaces/Contact.model';
import {
  ContactDetailsViewProps,
  ContactDetailsViewFunctionProps,
} from '../../components/ContactDetailsView/ContactDetailsView.interface';
import {
  Deps,
  RouteParams,
  InitParams,
  GetUIFunctions,
} from './ContactDetailsUI.interface';
import { trackEvents } from './trackEvents';
import { contactReadyStates, ContactReadyState } from './contactReadyStates';

const DEFAULT_DIALER_ROUTE = '/dialer';
const DEFAULT_COMPOSE_TEXT_ROUTE = '/composeText';

@Module({
  name: 'ContactDetailsUI',
  deps: [
    'Locale',
    'RouterInteraction',
    'ContactSearch',
    'Contacts',
    'ExtensionInfo',
    'AppFeatures',
    'RateLimiter',
    'RegionSettings',
    'ConnectivityManager',
    'Call',
    'DialerUI',
    'ComposeText',
    {
      dep: 'ContactDetailsUIOptions',
      optional: true,
    },
  ],
})
export class ContactDetailsUI extends RcUIModuleV2<Deps> {
  constructor(deps: Deps) {
    super({ deps });
  }

  @state
  currentContact: ContactModel = null;

  @state
  currentContactReadyState: ContactReadyState = contactReadyStates.pending;

  @action
  private _setCurrentContact(
    readyState: ContactReadyState,
    contact: ContactModel,
  ) {
    this.currentContactReadyState = readyState;
    this.currentContact = contact;
  }

  @background
  async resetCurrentContact() {
    this._setCurrentContact(contactReadyStates.pending, null);
  }

  @background
  async initCurrentContact({ contactType, contactId }: InitParams) {
    if (this.currentContactReadyState !== contactReadyStates.pending) {
      return;
    }
    this._setCurrentContact(contactReadyStates.loading, null);
    const contact = await this._deps.contacts.findContact({
      sourceName: contactType,
      contactId,
    });

    // hide hidden phone numbers when cdc is enabled
    if (this._deps.appFeatures.isCDCEnabled && contact.phoneNumbers.length) {
      contact.phoneNumbers = contact.phoneNumbers.filter(
        (phone) => !phone.hidden,
      );
    }
    // ignore result when it is reset during loading
    if (this.currentContactReadyState !== contactReadyStates.loading) {
      return;
    }
    this._setCurrentContact(contactReadyStates.loaded, contact as ContactModel);
    if (contact) {
      this._deps.contacts.getProfileImage(contact, false);
      this._deps.contacts.getPresence(contact, false);
    }
  }

  @proxify
  async showContactDetails({ id, type, direct = false }: RouteParams) {
    this._deps.routerInteraction.push(
      `/contacts/${type}/${id}${direct ? '?direct=true' : ''}`,
    );
  }

  @proxify
  async handleClickToDial(contact: ContactModel, phoneNumber: string) {
    const recipient = {
      ...contact,
      phoneNumber,
    };
    if (this._deps.call.isIdle) {
      this._deps.routerInteraction.push(
        this._deps.contactDetailsUIOptions?.dialerRoute ?? DEFAULT_DIALER_ROUTE,
      );
      this._deps.dialerUI.call({ recipient });
    }
    this._trackClickToCall();
  }

  @proxify
  async handleClickToSMS(contact: ContactModel, phoneNumber: string) {
    const recipient = {
      ...contact,
      phoneNumber,
    };
    this._deps.routerInteraction.push(
      this._deps.contactDetailsUIOptions?.composeTextRoute ??
        DEFAULT_COMPOSE_TEXT_ROUTE,
    );
    this._deps.composeText.addToNumber(recipient);
    if (this._deps.composeText.typingToNumber === recipient.phoneNumber) {
      this._deps.composeText.cleanTypingToNumber();
    }
    this._trackClickToSMS();
  }

  @track(trackEvents.clickToCall)
  private _trackClickToCall() {}

  @track(trackEvents.clickToSMS)
  private _trackClickToSMS() {}

  getUIProps(): ContactDetailsViewProps {
    return {
      currentLocale: this._deps.locale.currentLocale,
      contact: this.currentContact,
      isMultipleSiteEnabled:
        this._deps.extensionInfo.isMultipleSiteEnabled ?? false,
      isCallButtonDisabled: !!(
        this._deps.connectivityManager?.isOfflineMode ||
        this._deps.connectivityManager?.isWebphoneUnavailableMode ||
        this._deps.connectivityManager?.isWebphoneInitializing ||
        this._deps.rateLimiter?.throttling
      ),
      disableLinks: !!(
        this._deps.connectivityManager?.isOfflineMode ||
        this._deps.connectivityManager?.isVoipOnlyMode ||
        this._deps.rateLimiter?.throttling
      ),
      showSpinner: !(
        this.currentContactReadyState === contactReadyStates.loaded &&
        this._deps.locale.ready &&
        this._deps.contactSearch.ready &&
        this._deps.appFeatures.ready
      ),
    };
  }

  getUIFunctions({ params }: GetUIFunctions): ContactDetailsViewFunctionProps {
    return {
      onVisitPage: () => {
        this.initCurrentContact(params);
      },
      onLeavingPage: () => {
        this.resetCurrentContact();
      },
      formatNumber: (phoneNumber: string = '') => {
        if (!phoneNumber) {
          return phoneNumber;
        }
        // if the cleaned phone number is not a E164 format
        // we will show it directly, doesn't format it.
        const cleanedNumber: string = parseIncompletePhoneNumber(
          phoneNumber.toString(),
        );
        const isE164Number = isE164(cleanedNumber);
        if (isE164Number) {
          const formattedNumber: string = formatNumber({
            phoneNumber,
            countryCode: this._deps.regionSettings.countryCode,
          });
          return formattedNumber;
        }
        // if multi-site is enabled then we will try to remove site code with same site
        if (
          this._deps.extensionInfo.isMultipleSiteEnabled &&
          this._deps.extensionInfo.site?.code
        ) {
          const formattedNumber: string = formatNumber({
            phoneNumber,
            countryCode: this._deps.regionSettings.countryCode,
            siteCode: this._deps.extensionInfo.site?.code,
            isMultipleSiteEnabled: this._deps.extensionInfo
              .isMultipleSiteEnabled,
          });
          return formattedNumber;
        }
        return phoneNumber;
      },
      canTextButtonShow: (phoneType: string) => {
        const outboundSmsPermission = this._deps.appFeatures
          .hasOutboundSMSPermission;
        const internalSmsPermission = this._deps.appFeatures
          .hasInternalSMSPermission;
        // guess this statement is to avoid exception
        const isClickToTextEnabled = !!this._deps.composeText;
        return (
          isClickToTextEnabled &&
          phoneType !== phoneTypes.fax &&
          (phoneType === phoneTypes.extension
            ? internalSmsPermission
            : outboundSmsPermission)
        );
      },
      canCallButtonShow: (phoneType: string) => {
        const isClickToDialEnabled = !!(
          this._deps.dialerUI && this._deps.appFeatures.isCallingEnabled
        );
        return isClickToDialEnabled && phoneType !== phoneTypes.fax;
      },
      onBackClick: () => {
        this._deps.routerInteraction.goBack();
      },
      onClickToDial: (contact: ContactModel, phoneNumber: string) =>
        this.handleClickToDial(contact, phoneNumber),
      onClickToSMS: (contact: ContactModel, phoneNumber: string) =>
        this.handleClickToSMS(contact, phoneNumber),
    };
  }
}

1	import {
2	track,
3	state,
4	action,
5	RcUIModuleV2,
6	} from '@ringcentral-integration/core';
7	import { Module } from '@ringcentral-integration/commons/lib/di';
8	import background from '@ringcentral-integration/commons/lib/background';
9	import proxify from '@ringcentral-integration/commons/lib/proxy/proxify';
10	import {
11	isE164,
12	parseIncompletePhoneNumber,
13	} from '@ringcentral-integration/phone-number';
14	import { phoneTypes } from '@ringcentral-integration/commons/enums/phoneTypes';
15	import { formatNumber } from '@ringcentral-integration/commons/lib/formatNumber';
16	import { ContactModel } from '@ringcentral-integration/commons/interfaces/Contact.model';
17	import {
18	ContactDetailsViewProps,
19	ContactDetailsViewFunctionProps,
20	} from '../../components/ContactDetailsView/ContactDetailsView.interface';
21	import {
22	Deps,
23	RouteParams,
24	InitParams,
25	GetUIFunctions,
26	} from './ContactDetailsUI.interface';
27	import { trackEvents } from './trackEvents';
28	import { contactReadyStates, ContactReadyState } from './contactReadyStates';
29
30	const DEFAULT_DIALER_ROUTE = '/dialer';	29✔
31	const DEFAULT_COMPOSE_TEXT_ROUTE = '/composeText';	29✔
32
33	@Module({
34	name: 'ContactDetailsUI',
35	deps: [
36	'Locale',
37	'RouterInteraction',
38	'ContactSearch',
39	'Contacts',
40	'ExtensionInfo',
41	'AppFeatures',
42	'RateLimiter',
43	'RegionSettings',
44	'ConnectivityManager',
45	'Call',
46	'DialerUI',
47	'ComposeText',
48	{
49	dep: 'ContactDetailsUIOptions',
50	optional: true,
51	},
52	],
53	})
54	export class ContactDetailsUI extends RcUIModuleV2<Deps> {
55	constructor(deps: Deps) {
56	super({ deps });	194✔
57	}
58
59	@state
60	currentContact: ContactModel = null;	194✔
61
62	@state
63	currentContactReadyState: ContactReadyState = contactReadyStates.pending;	194✔
64
65	@action
66	private _setCurrentContact(
67	readyState: ContactReadyState,
68	contact: ContactModel,
69	) {
70	this.currentContactReadyState = readyState;	×
71	this.currentContact = contact;	×
72	}
73
74	@background
75	async resetCurrentContact() {
76	this._setCurrentContact(contactReadyStates.pending, null);	×
77	}
78
79	@background
80	async initCurrentContact({ contactType, contactId }: InitParams) {
81	if (this.currentContactReadyState !== contactReadyStates.pending) {	×
82	return;	×
83	}
84	this._setCurrentContact(contactReadyStates.loading, null);	×
85	const contact = await this._deps.contacts.findContact({	×
86	sourceName: contactType,
87	contactId,
88	});
89
90	// hide hidden phone numbers when cdc is enabled
NEW 91	if (this._deps.appFeatures.isCDCEnabled && contact.phoneNumbers.length) {	×
NEW 92	contact.phoneNumbers = contact.phoneNumbers.filter(	×
NEW 93	(phone) => !phone.hidden,	×
94	);
95	}
96	// ignore result when it is reset during loading
97	if (this.currentContactReadyState !== contactReadyStates.loading) {	×
98	return;	×
99	}
100	this._setCurrentContact(contactReadyStates.loaded, contact as ContactModel);	×
101	if (contact) {	×
102	this._deps.contacts.getProfileImage(contact, false);	×
103	this._deps.contacts.getPresence(contact, false);	×
104	}
105	}
106
107	@proxify
108	async showContactDetails({ id, type, direct = false }: RouteParams) {	×
109	this._deps.routerInteraction.push(	×
110	`/contacts/${type}/${id}${direct ? '?direct=true' : ''}`,	×
111	);
112	}
113
114	@proxify
115	async handleClickToDial(contact: ContactModel, phoneNumber: string) {
116	const recipient = {	×
117	...contact,
118	phoneNumber,
119	};
120	if (this._deps.call.isIdle) {	×
121	this._deps.routerInteraction.push(	×
122	this._deps.contactDetailsUIOptions?.dialerRoute ?? DEFAULT_DIALER_ROUTE,	×
123	);
124	this._deps.dialerUI.call({ recipient });	×
125	}
126	this._trackClickToCall();	×
127	}
128
129	@proxify
130	async handleClickToSMS(contact: ContactModel, phoneNumber: string) {
131	const recipient = {	×
132	...contact,
133	phoneNumber,
134	};
135	this._deps.routerInteraction.push(	×
136	this._deps.contactDetailsUIOptions?.composeTextRoute ??	×
137	DEFAULT_COMPOSE_TEXT_ROUTE,
138	);
139	this._deps.composeText.addToNumber(recipient);	×
140	if (this._deps.composeText.typingToNumber === recipient.phoneNumber) {	×
141	this._deps.composeText.cleanTypingToNumber();	×
142	}
143	this._trackClickToSMS();	×
144	}
145
146	@track(trackEvents.clickToCall)
147	private _trackClickToCall() {}
148
149	@track(trackEvents.clickToSMS)
150	private _trackClickToSMS() {}
151
152	getUIProps(): ContactDetailsViewProps {
153	return {	×
154	currentLocale: this._deps.locale.currentLocale,
155	contact: this.currentContact,
156	isMultipleSiteEnabled:
157	this._deps.extensionInfo.isMultipleSiteEnabled ?? false,	×
158	isCallButtonDisabled: !!(
159	this._deps.connectivityManager?.isOfflineMode \|\|	×
160	this._deps.connectivityManager?.isWebphoneUnavailableMode \|\|
161	this._deps.connectivityManager?.isWebphoneInitializing \|\|
162	this._deps.rateLimiter?.throttling
163	),
164	disableLinks: !!(
165	this._deps.connectivityManager?.isOfflineMode \|\|	×
166	this._deps.connectivityManager?.isVoipOnlyMode \|\|
167	this._deps.rateLimiter?.throttling
168	),
169	showSpinner: !(
170	this.currentContactReadyState === contactReadyStates.loaded &&	×
171	this._deps.locale.ready &&
172	this._deps.contactSearch.ready &&
173	this._deps.appFeatures.ready
174	),
175	};
176	}
177
178	getUIFunctions({ params }: GetUIFunctions): ContactDetailsViewFunctionProps {
179	return {	×
180	onVisitPage: () => {
181	this.initCurrentContact(params);	×
182	},
183	onLeavingPage: () => {
184	this.resetCurrentContact();	×
185	},
186	formatNumber: (phoneNumber: string = '') => {	×
187	if (!phoneNumber) {	×
188	return phoneNumber;	×
189	}
190	// if the cleaned phone number is not a E164 format
191	// we will show it directly, doesn't format it.
192	const cleanedNumber: string = parseIncompletePhoneNumber(	×
193	phoneNumber.toString(),
194	);
195	const isE164Number = isE164(cleanedNumber);	×
196	if (isE164Number) {	×
197	const formattedNumber: string = formatNumber({	×
198	phoneNumber,
199	countryCode: this._deps.regionSettings.countryCode,
200	});
201	return formattedNumber;	×
202	}
203	// if multi-site is enabled then we will try to remove site code with same site
204	if (	×
205	this._deps.extensionInfo.isMultipleSiteEnabled &&	×
206	this._deps.extensionInfo.site?.code
207	) {
208	const formattedNumber: string = formatNumber({	×
209	phoneNumber,
210	countryCode: this._deps.regionSettings.countryCode,
211	siteCode: this._deps.extensionInfo.site?.code,
212	isMultipleSiteEnabled: this._deps.extensionInfo
213	.isMultipleSiteEnabled,
214	});
215	return formattedNumber;	×
216	}
217	return phoneNumber;	×
218	},
219	canTextButtonShow: (phoneType: string) => {
220	const outboundSmsPermission = this._deps.appFeatures	×
221	.hasOutboundSMSPermission;
222	const internalSmsPermission = this._deps.appFeatures	×
223	.hasInternalSMSPermission;
224	// guess this statement is to avoid exception
225	const isClickToTextEnabled = !!this._deps.composeText;	×
226	return (	×
227	isClickToTextEnabled &&	×
228	phoneType !== phoneTypes.fax &&
229	(phoneType === phoneTypes.extension	×
230	? internalSmsPermission
231	: outboundSmsPermission)
232	);
233	},
234	canCallButtonShow: (phoneType: string) => {
235	const isClickToDialEnabled = !!(	×
236	this._deps.dialerUI && this._deps.appFeatures.isCallingEnabled	×
237	);
238	return isClickToDialEnabled && phoneType !== phoneTypes.fax;	×
239	},
240	onBackClick: () => {
241	this._deps.routerInteraction.goBack();	×
242	},
243	onClickToDial: (contact: ContactModel, phoneNumber: string) =>
244	this.handleClickToDial(contact, phoneNumber),	×
245	onClickToSMS: (contact: ContactModel, phoneNumber: string) =>
246	this.handleClickToSMS(contact, phoneNumber),	×
247	};
248	}
249	}

ringcentral / ringcentral-js-widgets / 1232736708

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous