lotus / validations / 272

pending completion

Build # 272

Build Type

Pull #82

travis-ci

Committed by

hlegius

Commit Message

Added blank_value? to size predicate

Now, the application will ignore blank values for `size` predicate as
well occurs for other predicates i.e. presence.

The only exceptional case down to Enumerable implementations which if
defined will be treated as filled value, as in examples below:

```ruby
class AwesomeValidator
  attribute :name, type: String, size: 8..10
  attribute :tags, type: Array, size: 2..10
end

AwesomeValidator.new().valid? # < true
AwesomeValidator.new(name: '12345678', tags: '').valid? # < true
AwesomeValidator.new(tags: ['a', 'b']).valid? # < true
AwesomeValidator.new(name: nil).valid? # < true

AwesomeValidator.new(name: 'ooo').valid? # < false
AwesomeValidator.new(tags: []).valid? # < false
AwesomeValidator.new(tags: []).valid? # < false
AwesomeValidator.new(name: 'abc', tags: []).valid? # < false
```

@solnic [has argued
about](https://github.com/lotus/validations/issues/80#issuecomment-158085889)
Conditional Validations and 'magical' validations/coercions
which may introduce more complexity into this kind of issue.

Closes #81

Pull Request Pull Request #82: Added blank_value? to size predicate

Run Details

358 of 365 relevant lines covered (98.08%)

1032.56 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.12

/lib/lotus/validations/attribute.rb

Build SHA Not Found

The commit SHA "c0e35cb4ebbad5d43bdb0f5aeb49e1739c27c098" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

lotus / validations / 272

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous