963617005

Build Type

github

Committed by GitHub

Commit Message

Merge 7eff1623f into 42d106c9c

Pull Request Pull Request #1205: Feature 1164 two handed weapon mechanics

Run Details

1969 of 3760 branches covered (52.37%)

Branch coverage included in aggregate %.

51 of 68 new or added lines in 3 files covered. (75.0%)

12 existing lines in 4 files now uncovered.

5046 of 7958 relevant lines covered (63.41%)

37043.15 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.01

/Zilon.Core/Zilon.Core/Commands/Sector/EquipCommand.cs

﻿using System;
using System.Diagnostics.CodeAnalysis;

using Zilon.Core.Client;
using Zilon.Core.PersonModules;
using Zilon.Core.Persons;
using Zilon.Core.Players;
using Zilon.Core.Props;
using Zilon.Core.Tactics;
using Zilon.Core.Tactics.Behaviour;

namespace Zilon.Core.Commands
{
    /// <summary>
    /// Команда на назначение экипировки.
    /// </summary>
    public class EquipCommand : SpecialActorCommandBase
    {
        private readonly IInventoryState _inventoryState;
        private readonly IPlayer _player;

        [ExcludeFromCodeCoverage]
        public EquipCommand(
            IPlayer player,
            ISectorUiState playerState,
            IInventoryState inventoryState) :
            base(playerState)
        {
            _player = player;
            _inventoryState = inventoryState;
        }

        public int? SlotIndex { get; set; }

        public override CanExecuteCheckResult CanExecute()
        {
            if (_inventoryState.SelectedProp is null)
            {
                // Means equipment will be unequiped from the slot (specified in command).
                return CanExecuteCheckResult.CreateSuccessful();
            }

            if (SlotIndex is null)
            {
                throw new InvalidOperationException("Для команды не указан слот.");
            }

            var equipmentFromInventory = GetSelectedEquipmentInInventory();
            if (equipmentFromInventory is null && _inventoryState.SelectedProp != null)
            {
                return new CanExecuteCheckResult { IsSuccess = false };
            }

            // Сломанную экипировку нельзя надевать
            //TODO Тут есть замечание, что equipment не проверяется.
            // Реорганизовать этот код в более понятный.
            if (equipmentFromInventory != null && equipmentFromInventory.Durable.Value <= 0)
            {
                return new CanExecuteCheckResult { IsSuccess = false };
            }

            var equipmentCarrier = PlayerState.ActiveActor!.Actor.Person.GetModule<IEquipmentModule>();
            var slot = equipmentCarrier.Slots[SlotIndex.Value];

            var canEquipInSlot = EquipmentCarrierHelper.CheckSlotCompability(equipmentFromInventory!, slot);
            if (!canEquipInSlot)
            {
                return new CanExecuteCheckResult { IsSuccess = false };
            }

            var canEquipDual = EquipmentCarrierHelper.CheckDualCompability(equipmentCarrier,
                equipmentFromInventory!,
                SlotIndex.Value);
            if (!canEquipDual)
            {
                return new CanExecuteCheckResult { IsSuccess = false };
            }

            var canEquipShield = EquipmentCarrierHelper.CheckShieldCompability(equipmentCarrier,
                equipmentFromInventory!,
                SlotIndex.Value);

            if (!canEquipShield)
            {
                return new CanExecuteCheckResult { IsSuccess = false };
            }

            return new CanExecuteCheckResult { IsSuccess = true };
        }

        protected override void ExecuteTacticCommand()
        {
            if (SlotIndex is null)
            {
                throw new InvalidOperationException("Для команды не указан слот.");
            }

            var equipment = GetSelectedEquipmentInInventory();

            var sector = _player.SectorNode.Sector;
            if (sector is null)
            {
                throw new InvalidOperationException();
            }

            var taskContext = new ActorTaskContext(sector);

            var intention = new Intention<EquipTask>(a => new EquipTask(a, taskContext, equipment, SlotIndex.Value));
            var taskSource = PlayerState.TaskSource;
            if (taskSource is null)
            {
                throw new InvalidOperationException();
            }

            var activeActor = PlayerState.ActiveActor?.Actor;
            if (activeActor is null)
            {
                throw new InvalidOperationException();
            }

            taskSource.Intent(intention, activeActor);
        }

        private Equipment? GetSelectedEquipmentInInventory()
        {
            var propVieModel = _inventoryState.SelectedProp;
            if (propVieModel is null)
            {
                return null;
            }

            if (propVieModel.Prop is Equipment equipment)
            {
                return equipment;
            }

            return null;
        }
    }
}

1	using System;
2	using System.Diagnostics.CodeAnalysis;
3
4	using Zilon.Core.Client;
5	using Zilon.Core.PersonModules;
6	using Zilon.Core.Persons;
7	using Zilon.Core.Players;
8	using Zilon.Core.Props;
9	using Zilon.Core.Tactics;
10	using Zilon.Core.Tactics.Behaviour;
11
12	namespace Zilon.Core.Commands
13	{
14	/// <summary>
15	/// Команда на назначение экипировки.
16	/// </summary>
17	public class EquipCommand : SpecialActorCommandBase
18	{
19	private readonly IInventoryState _inventoryState;
20	private readonly IPlayer _player;
21
22	[ExcludeFromCodeCoverage]
23	public EquipCommand(
24	IPlayer player,
25	ISectorUiState playerState,
26	IInventoryState inventoryState) :
27	base(playerState)
28	{
29	_player = player;
30	_inventoryState = inventoryState;
31	}
32
33	public int? SlotIndex { get; set; }
34
35	public override CanExecuteCheckResult CanExecute()
36	{
37	if (_inventoryState.SelectedProp is null)	40✔
38	{
39	// Means equipment will be unequiped from the slot (specified in command).
40	return CanExecuteCheckResult.CreateSuccessful();	4✔
41	}
42
43	if (SlotIndex is null)	36!
44	{
UNCOV 45	throw new InvalidOperationException("Для команды не указан слот.");	×
46	}
47
48	var equipmentFromInventory = GetSelectedEquipmentInInventory();	36✔
49	if (equipmentFromInventory is null && _inventoryState.SelectedProp != null)	36✔
50	{
51	return new CanExecuteCheckResult { IsSuccess = false };	1✔
52	}
53
54	// Сломанную экипировку нельзя надевать
55	//TODO Тут есть замечание, что equipment не проверяется.
56	// Реорганизовать этот код в более понятный.
57	if (equipmentFromInventory != null && equipmentFromInventory.Durable.Value <= 0)	35!
58	{
59	return new CanExecuteCheckResult { IsSuccess = false };	×
60	}
61
62	var equipmentCarrier = PlayerState.ActiveActor!.Actor.Person.GetModule<IEquipmentModule>();	35✔
63	var slot = equipmentCarrier.Slots[SlotIndex.Value];	35✔
64
65	var canEquipInSlot = EquipmentCarrierHelper.CheckSlotCompability(equipmentFromInventory!, slot);	35✔
66	if (!canEquipInSlot)	35!
67	{
UNCOV 68	return new CanExecuteCheckResult { IsSuccess = false };	×
69	}
70
71	var canEquipDual = EquipmentCarrierHelper.CheckDualCompability(equipmentCarrier,	35✔
72	equipmentFromInventory!,	35✔
73	SlotIndex.Value);	35✔
74	if (!canEquipDual)	35✔
75	{
76	return new CanExecuteCheckResult { IsSuccess = false };	2✔
77	}
78
79	var canEquipShield = EquipmentCarrierHelper.CheckShieldCompability(equipmentCarrier,	33✔
80	equipmentFromInventory!,	33✔
81	SlotIndex.Value);	33✔
82
83	if (!canEquipShield)	33✔
84	{
85	return new CanExecuteCheckResult { IsSuccess = false };	1✔
86	}
87
88	return new CanExecuteCheckResult { IsSuccess = true };	32✔
89	}
90
91	protected override void ExecuteTacticCommand()
92	{
93	if (SlotIndex is null)	35!
94	{
UNCOV 95	throw new InvalidOperationException("Для команды не указан слот.");	×
96	}
97
98	var equipment = GetSelectedEquipmentInInventory();	35✔
99
100	var sector = _player.SectorNode.Sector;	35✔
101	if (sector is null)	35!
102	{
UNCOV 103	throw new InvalidOperationException();	×
104	}
105
106	var taskContext = new ActorTaskContext(sector);	35✔
107
108	var intention = new Intention<EquipTask>(a => new EquipTask(a, taskContext, equipment, SlotIndex.Value));	35✔
109	var taskSource = PlayerState.TaskSource;	35✔
110	if (taskSource is null)	35!
111	{
112	throw new InvalidOperationException();	×
113	}
114
115	var activeActor = PlayerState.ActiveActor?.Actor;	35!
116	if (activeActor is null)	35!
117	{
118	throw new InvalidOperationException();	×
119	}
120
121	taskSource.Intent(intention, activeActor);	35✔
122	}	35✔
123
124	private Equipment? GetSelectedEquipmentInInventory()
125	{
126	var propVieModel = _inventoryState.SelectedProp;	71✔
127	if (propVieModel is null)	71✔
128	{
129	return null;	4✔
130	}
131
132	if (propVieModel.Prop is Equipment equipment)	67✔
133	{
134	return equipment;	66✔
135	}
136
137	return null;	1✔
138	}
139	}
140	}

kreghek / Zilon_Roguelike / 963617005

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous