#27395

pending completion

Build # #27395

Build Type

push

github

Committed by

web-flow

Commit Message

<a href="https://github.com/api-platform/core/commit/<a class=hub.com/api-platform/core/commit/8ca20c9160b0554f1c9bc9867e28d53b6b538670">8ca20c916<a href="https://github.com/api-platform/core/commit/8ca20c9160b0554f1c9bc9867e28d53b6b538670">">Merge </a><a class="double-link" href="https://github.com/api-platform/core/commit/<a class="double-link" href="https://github.com/api-platform/core/commit/5b683a8416e3ea2dd0c630867e255a2adbafe50d">5b683a841</a>">5b683a841</a><a href="https://github.com/api-platform/core/commit/8ca20c9160b0554f1c9bc9867e28d53b6b538670"> into ed0dea98a">ed0dea98a</a>

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

9757 of 11678 relevant lines covered (83.55%)

14.75 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.61

/src/Identifier/IdentifierConverter.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\Identifier;

use ApiPlatform\Core\Api\IdentifiersExtractorInterface;
use ApiPlatform\Core\Exception\InvalidIdentifierException;
use ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
use Symfony\Component\PropertyInfo\Type;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;

/**
 * Identifier converter that chains identifier denormalizers.
 *
 * @author Antoine Bluchet <soyuka@gmail.com>
 */
final class IdentifierConverter implements ContextAwareIdentifierConverterInterface
{
    private $propertyMetadataFactory;
    private $identifiersExtractor;
    private $identifierDenormalizers;
    private $resourceMetadataFactory;

    /**
     * TODO: rename identifierDenormalizers to identifierTransformers in 3.0 and change their interfaces to a IdentifierTransformerInterface.
     *
     * @param iterable<DenormalizerInterface> $identifierDenormalizers
     */
    public function __construct(IdentifiersExtractorInterface $identifiersExtractor, PropertyMetadataFactoryInterface $propertyMetadataFactory, iterable $identifierDenormalizers, ResourceMetadataFactoryInterface $resourceMetadataFactory = null)
    {
        $this->propertyMetadataFactory = $propertyMetadataFactory;
        $this->identifiersExtractor = $identifiersExtractor;
        $this->identifierDenormalizers = $identifierDenormalizers;
        $this->resourceMetadataFactory = $resourceMetadataFactory;
    }

    /**
     * {@inheritdoc}
     */
    public function convert($data, string $class, array $context = []): array
    {
        if (!\is_array($data)) {
            @trigger_error(sprintf('Not using an array as the first argument of "%s->convert" is deprecated since API Platform 2.6 and will not be possible anymore in API Platform 3', self::class), \E_USER_DEPRECATED);
            $data = ['id' => $data];
        }

        $identifiers = $data;

        foreach ($data as $parameter => $value) {
            if (null === $type = $this->getIdentifierType($context['identifiers'][$parameter][0] ?? $class, $context['identifiers'][$parameter][1] ?? $parameter)) {
                continue;
            }

            /* @var DenormalizerInterface[] */
            foreach ($this->identifierDenormalizers as $identifierTransformer) {
                if (!$identifierTransformer->supportsDenormalization($value, $type)) {
                    continue;
                }

                try {
                    $identifiers[$parameter] = $identifierTransformer->denormalize($value, $type);
                    break;
                } catch (InvalidIdentifierException $e) {
                    throw new InvalidIdentifierException(sprintf('Identifier "%s" could not be denormalized.', $parameter), $e->getCode(), $e);
                }
            }
        }

        return $identifiers;
    }

    private function getIdentifierType(string $resourceClass, string $property): ?string
    {
        if (!$type = $this->propertyMetadataFactory->create($resourceClass, $property)->getType()) {
            return null;
        }

        return Type::BUILTIN_TYPE_OBJECT === ($builtinType = $type->getBuiltinType()) ? $type->getClassName() : $builtinType;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Core\Identifier;
15
16	use ApiPlatform\Core\Api\IdentifiersExtractorInterface;
17	use ApiPlatform\Core\Exception\InvalidIdentifierException;
18	use ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
19	use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
20	use Symfony\Component\PropertyInfo\Type;
21	use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
22
23	/**
24	* Identifier converter that chains identifier denormalizers.
25	*
26	* @author Antoine Bluchet <soyuka@gmail.com>
27	*/
28	final class IdentifierConverter implements ContextAwareIdentifierConverterInterface
29	{
30	private $propertyMetadataFactory;
31	private $identifiersExtractor;
32	private $identifierDenormalizers;
33	private $resourceMetadataFactory;
34
35	/**
36	* TODO: rename identifierDenormalizers to identifierTransformers in 3.0 and change their interfaces to a IdentifierTransformerInterface.
37	*
38	* @param iterable<DenormalizerInterface> $identifierDenormalizers
39	*/
40	public function __construct(IdentifiersExtractorInterface $identifiersExtractor, PropertyMetadataFactoryInterface $propertyMetadataFactory, iterable $identifierDenormalizers, ResourceMetadataFactoryInterface $resourceMetadataFactory = null)
41	{
42	$this->propertyMetadataFactory = $propertyMetadataFactory;	36✔
43	$this->identifiersExtractor = $identifiersExtractor;	36✔
44	$this->identifierDenormalizers = $identifierDenormalizers;	36✔
45	$this->resourceMetadataFactory = $resourceMetadataFactory;	36✔
46	}	36✔
47
48	/**
49	* {@inheritdoc}
50	*/
51	public function convert($data, string $class, array $context = []): array
52	{
53	if (!\is_array($data)) {	8✔
54	@trigger_error(sprintf('Not using an array as the first argument of "%s->convert" is deprecated since API Platform 2.6 and will not be possible anymore in API Platform 3', self::class), \E_USER_DEPRECATED);	×
55	$data = ['id' => $data];	×
56	}
57
58	$identifiers = $data;	8✔
59
60	foreach ($data as $parameter => $value) {	8✔
61	if (null === $type = $this->getIdentifierType($context['identifiers'][$parameter][0] ?? $class, $context['identifiers'][$parameter][1] ?? $parameter)) {	8✔
62	continue;	1✔
63	}
64
65	/* @var DenormalizerInterface[] */
66	foreach ($this->identifierDenormalizers as $identifierTransformer) {	8✔
67	if (!$identifierTransformer->supportsDenormalization($value, $type)) {	8✔
68	continue;	4✔
69	}
70
71	try {
72	$identifiers[$parameter] = $identifierTransformer->denormalize($value, $type);	7✔
73	break;	7✔
74	} catch (InvalidIdentifierException $e) {	×
75	throw new InvalidIdentifierException(sprintf('Identifier "%s" could not be denormalized.', $parameter), $e->getCode(), $e);	×
76	}
77	}
78	}
79
80	return $identifiers;	8✔
81	}
82
83	private function getIdentifierType(string $resourceClass, string $property): ?string
84	{
85	if (!$type = $this->propertyMetadataFactory->create($resourceClass, $property)->getType()) {	8✔
86	return null;	1✔
87	}
88
89	return Type::BUILTIN_TYPE_OBJECT === ($builtinType = $type->getBuiltinType()) ? $type->getClassName() : $builtinType;	8✔
90	}
91	}

api-platform / core / #27395

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous