stanford-oval / thingpedia-common-devices / 977

pending completion

Build # 977

Build Type

Pull #309

travis-ci-com

Committed by

web-flow

Commit Message

Merge 732e858b8 into 9e3d456b0

Pull Request Pull Request #309: Implement playing audio in SmartNews

Run Details

401 of 773 branches covered (51.88%)

Branch coverage included in aggregate %.

13 of 24 new or added lines in 1 file covered. (54.17%)

2 existing lines in 1 file now uncovered.

746 of 1200 relevant lines covered (62.17%)

701.67 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.56

/main/com.smartnews/index.js

// -*- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 -*-
//
// Copyright 2020-2021 SmartNews Inc.
//           2021 The Board of Trustees of the Leland Stanford Junior University
//
// Redistribution and use in source and binary forms, with or
// without modification, are permitted provided that the following
// conditions are met:
//
// 1. Redistributions of source code must retain the above copyright
//    notice, this list of conditions and the following disclaimer.
// 2. Redistributions in binary form must reproduce the above
//    copyright notice, this list of conditions and the following
//    disclaimer in the documentation and/or other materials
//    provided with the distribution.
// 3. Neither the name of the copyright holder nor the names of its
//    contributors may be used to endorse or promote products derived
//    from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
// FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
// COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
// INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
// (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
// HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
// OF THE POSSIBILITY OF SUCH DAMAGE.
"use strict";

const Tp = require("thingpedia");
const byline = require('byline');

const API_URL = "http://dev-snva.smartnews.com/api/v1";
const DEVICE_TOKEN = 1;  // use 1 for now
// const API_URL = "https://039ev0y88l.execute-api.us-west-1.amazonaws.com/test/v2"; //DEMO API

const NEW_API = true;

module.exports = class SmartNewsDevice extends Tp.BaseDevice {
    constructor(engine, state) {
        super(engine, state);
        this.uniqueId = "com.smartnews";
        this.name = "SmartNews";
        this.description = "SmartNews latest articles";
    }

    async *get_article(params, hints) {
        if (NEW_API) {
            const now = new Date;
            const date = `${now.getYear()-100}${now.getMonth() < 9 ? '0' : ''}${now.getMonth()+1}${now.getDate()<10 ? '0': ''}${now.getDate()}`;
            const url = `https://oval-project.s3-ap-northeast-1.amazonaws.com/data/${date}/summary_${date}.jsonl`;

            const stream = (await Tp.Helpers.Http.getStream(url)).setEncoding('utf8').pipe(byline());
            for await (const line of stream) {
                const article = JSON.parse(line);
                if (article['articleViewStyle'] !== 'SMART')
                    continue;
                if (article['title'] === 'coronavirus_push_landingpage')
                    continue;
                yield {
                    id: new Tp.Value.Entity(String(article.link_id), null),
                    link: article.url,
                    title: article.title,
                    date: new Date(article.publishedTimestamp * 1000),
                    source: article.site ? article.site.name : null,
                    author: article.author ? article.author.name : null,
                    audio_url: article.summary_mp3_file,
                    content: article.body,
                };
            }
        } else {
            const device_token = DEVICE_TOKEN;
            let url = API_URL + "/top?deviceToken=" + device_token;

            const response = await Tp.Helpers.Http.get(url);
            const parsed = JSON.parse(response);

            for (const article of parsed['blocks'][0]['links'].concat(parsed['blocks'][1]['links'])) {
                if (article['articleViewStyle'] !== 'SMART')
                    continue;
                if (article['title'] === 'coronavirus_push_landingpage')
                    continue;
                yield {
                    id: new Tp.Value.Entity(String(article.id), null),
                    link: article.url,
                    title: article.title,
                    date: new Date(article.publishedTimestamp * 1000),
                    source: article.site ? article.site.name : null,
                    author: article.author ? article.author.name : null,
                    content: ''
                };
            }
        }
    }

    // get_reading_list({ device_token = DEVICE_TOKEN }) {
    //     let url = API_URL + "/list?deviceToken=" + device_token;
    //     return Tp.Helpers.Http.get(url).then((response) => {
    //         let jsonData = JSON.parse(response);
    //         let articleIdList = jsonData.articleIdList;
    //         let newsPromises = articleIdList.map((articleId) => {
    //             let url = API_URL + "/news?articleId=" + articleId;
    //             return Tp.Helpers.Http.get(url);
    //         });
    //         return Promise.all(newsPromises);
    //     }).then((responses) => {
    //         let newArray = responses.filter((element) => element['articleViewStyle'] === 'SMART');
    //         newArray = newArray.filter((element) => element['title'] !== 'coronavirus_push_landingpage');
    //         return newArray.map((response) => {
    //             /*console.log(response);
    //             let jsonData = JSON.parse(response);
    //             if (jsonData.error) {
    //                 return {
    //                     id: '',
    //                     title: jsonData.error,
    //                     url: '',
    //                     date: '',
    //                     source: ''
    //                 }
    //             }*/
    //             let article = JSON.parse(response);
    //             return {
    //                 id: article["id"],
    //                 title: article["title"],
    //                 url: article["url"],
    //                 date: new Date(article["publishedTimestamp"] * 1000),
    //                 source: article["site"]["name"]
    //             };
    //         });
    //     });
    // }

    // //connect SN API endpoint /pocket with POST request
    // do_pocket({ id, device_token = DEVICE_TOKEN }) {
    //     return Tp.Helpers.Http.post(
    //         API_URL + "/pocket?deviceToken=" + device_token,
    //         JSON.stringify({ articleIds: [id] }),
    //         { dataContentType: 'application/json' }
    //     );
    // }

    // //connect SN API endpoint /drop with POST request
    // do_drop({ id, device_token = DEVICE_TOKEN }) {
    //     return Tp.Helpers.Http.post(
    //         API_URL + "/drop?deviceToken=" + device_token,
    //         JSON.stringify({ articleIds: [id] }),
    //         { dataContentType: 'application/json' }
    //     );
    // }


    // //connect SN API endpoint /top with GET request
    // get_article({ count }) {
    //     count = count || 3; //default is 10 news
    //     let url = API_URL + "/top?count=" + count;
    //     return Tp.Helpers.Http.get(url).then((response) => {
    //         return JSON.parse(response);
    //     }).then((parsed) => {
    //         return parsed.map((article) => {
    //             return {
    //                 id: article["id"],
    //                 title: article["title"],
    //                 date: new Date(article["published_time"] * 1000),
    //                 source: article["site"],
    //                 audio: article["audio"],
    //                 content: article["content"],
    //                 url: article["url"]
    //             };
    //         });
    //     });
    // }

    // //connect SN API endpoint /list with GET request
    // get_reading_list({ user = USER }) {
    //     let url = API_URL + "/list?user=" + user;
    //     return Tp.Helpers.Http.get(url).then((response) => {
    //         return JSON.parse(response);
    //     }).then((parsed) => {
    //         return parsed.map((article) => {
    //             return {
    //                 id: article["id"],
    //                 title: article["title"],
    //                 date: new Date(article["publishedTimestamp"] * 1000),
    //                 source: article["site"],
    //                 audio: article["audio"],
    //                 content: article["content"]
    //             };
    //         });
    //     });
    // }

    // //connect SN API endpoint /pocket with POST request
    // do_pocket({ id, user = USER }) {
    //     return Tp.Helpers.Http.post(
    //         API_URL + "/pocket?user=" + user,
    //         JSON.stringify({ reading_list: [id] }),
    //         { dataContentType: 'application/json' }
    //     );
    // }

    // //connect SN API endpoint /drop with POST request
    // do_drop({ id, user = USER }) {
    //     return Tp.Helpers.Http.post(
    //         API_URL + "/drop?user=" + user,
    //         JSON.stringify({ reading_list: [id] }),
    //         { dataContentType: 'application/json' }
    //     );
    // }
};

1	// -- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 --
2	//
3	// Copyright 2020-2021 SmartNews Inc.
4	// 2021 The Board of Trustees of the Leland Stanford Junior University
5	//
6	// Redistribution and use in source and binary forms, with or
7	// without modification, are permitted provided that the following
8	// conditions are met:
9	//
10	// 1. Redistributions of source code must retain the above copyright
11	// notice, this list of conditions and the following disclaimer.
12	// 2. Redistributions in binary form must reproduce the above
13	// copyright notice, this list of conditions and the following
14	// disclaimer in the documentation and/or other materials
15	// provided with the distribution.
16	// 3. Neither the name of the copyright holder nor the names of its
17	// contributors may be used to endorse or promote products derived
18	// from this software without specific prior written permission.
19	//
20	// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
21	// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
22	// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
23	// FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
24	// COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
25	// INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
26	// (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
27	// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
28	// HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
29	// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
30	// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
31	// OF THE POSSIBILITY OF SUCH DAMAGE.
32	"use strict";
33
34	const Tp = require("thingpedia");	2✔
35	const byline = require('byline');	2✔
36
37	const API_URL = "http://dev-snva.smartnews.com/api/v1";	2✔
38	const DEVICE_TOKEN = 1; // use 1 for now	2✔
39	// const API_URL = "https://039ev0y88l.execute-api.us-west-1.amazonaws.com/test/v2"; //DEMO API
40
41	const NEW_API = true;	2✔
42
43	module.exports = class SmartNewsDevice extends Tp.BaseDevice {	2✔
44	constructor(engine, state) {
45	super(engine, state);	2✔
46	this.uniqueId = "com.smartnews";	2✔
47	this.name = "SmartNews";	2✔
48	this.description = "SmartNews latest articles";	2✔
49	}
50
51	async *get_article(params, hints) {
52	if (NEW_API) {	2!
53	const now = new Date;	2✔
54	const date = `${now.getYear()-100}${now.getMonth() < 9 ? '0' : ''}${now.getMonth()+1}${now.getDate()<10 ? '0': ''}${now.getDate()}`;	2!
55	const url = `https://oval-project.s3-ap-northeast-1.amazonaws.com/data/${date}/summary_${date}.jsonl`;	2✔
56
57	const stream = (await Tp.Helpers.Http.getStream(url)).setEncoding('utf8').pipe(byline());	2✔
58	for await (const line of stream) {	2✔
59	const article = JSON.parse(line);	9,106✔
60	if (article['articleViewStyle'] !== 'SMART')	9,106✔
61	continue;	7,520✔
62	if (article['title'] === 'coronavirus_push_landingpage')	1,586!
NEW 63	continue;	×
64	yield {	1,586✔
65	id: new Tp.Value.Entity(String(article.link_id), null),
66	link: article.url,
67	title: article.title,
68	date: new Date(article.publishedTimestamp * 1000),
69	source: article.site ? article.site.name : null,	1,586!
70	author: article.author ? article.author.name : null,	1,586✔
71	audio_url: article.summary_mp3_file,
72	content: article.body,
73	};
74	}
75	} else {
NEW 76	const device_token = DEVICE_TOKEN;	×
NEW 77	let url = API_URL + "/top?deviceToken=" + device_token;	×
78
NEW 79	const response = await Tp.Helpers.Http.get(url);	×
NEW 80	const parsed = JSON.parse(response);	×
81
NEW 82	for (const article of parsed['blocks'][0]['links'].concat(parsed['blocks'][1]['links'])) {	×
NEW 83	if (article['articleViewStyle'] !== 'SMART')	×
NEW 84	continue;	×
NEW 85	if (article['title'] === 'coronavirus_push_landingpage')	×
NEW 86	continue;	×
NEW 87	yield {	×
88	id: new Tp.Value.Entity(String(article.id), null),
89	link: article.url,
90	title: article.title,
91	date: new Date(article.publishedTimestamp * 1000),
92	source: article.site ? article.site.name : null,	×
93	author: article.author ? article.author.name : null,	×
94	content: ''
95	};
96	}
97	}
98	}
99
100	// get_reading_list({ device_token = DEVICE_TOKEN }) {
101	// let url = API_URL + "/list?deviceToken=" + device_token;
102	// return Tp.Helpers.Http.get(url).then((response) => {
103	// let jsonData = JSON.parse(response);
104	// let articleIdList = jsonData.articleIdList;
105	// let newsPromises = articleIdList.map((articleId) => {
106	// let url = API_URL + "/news?articleId=" + articleId;
107	// return Tp.Helpers.Http.get(url);
108	// });
109	// return Promise.all(newsPromises);
110	// }).then((responses) => {
111	// let newArray = responses.filter((element) => element['articleViewStyle'] === 'SMART');
112	// newArray = newArray.filter((element) => element['title'] !== 'coronavirus_push_landingpage');
113	// return newArray.map((response) => {
114	// /*console.log(response);
115	// let jsonData = JSON.parse(response);
116	// if (jsonData.error) {
117	// return {
118	// id: '',
119	// title: jsonData.error,
120	// url: '',
121	// date: '',
122	// source: ''
123	// }
124	// }*/
125	// let article = JSON.parse(response);
126	// return {
127	// id: article["id"],
128	// title: article["title"],
129	// url: article["url"],
130	// date: new Date(article["publishedTimestamp"] * 1000),
131	// source: article["site"]["name"]
132	// };
133	// });
134	// });
135	// }
136
137	// //connect SN API endpoint /pocket with POST request
138	// do_pocket({ id, device_token = DEVICE_TOKEN }) {
139	// return Tp.Helpers.Http.post(
140	// API_URL + "/pocket?deviceToken=" + device_token,
141	// JSON.stringify({ articleIds: [id] }),
142	// { dataContentType: 'application/json' }
143	// );
144	// }
145
146	// //connect SN API endpoint /drop with POST request
147	// do_drop({ id, device_token = DEVICE_TOKEN }) {
148	// return Tp.Helpers.Http.post(
149	// API_URL + "/drop?deviceToken=" + device_token,
150	// JSON.stringify({ articleIds: [id] }),
151	// { dataContentType: 'application/json' }
152	// );
153	// }
154
155
156	// //connect SN API endpoint /top with GET request
157	// get_article({ count }) {
158	// count = count \|\| 3; //default is 10 news
159	// let url = API_URL + "/top?count=" + count;
160	// return Tp.Helpers.Http.get(url).then((response) => {
161	// return JSON.parse(response);
162	// }).then((parsed) => {
163	// return parsed.map((article) => {
164	// return {
165	// id: article["id"],
166	// title: article["title"],
167	// date: new Date(article["published_time"] * 1000),
168	// source: article["site"],
169	// audio: article["audio"],
170	// content: article["content"],
171	// url: article["url"]
172	// };
173	// });
174	// });
175	// }
176
177	// //connect SN API endpoint /list with GET request
178	// get_reading_list({ user = USER }) {
179	// let url = API_URL + "/list?user=" + user;
180	// return Tp.Helpers.Http.get(url).then((response) => {
181	// return JSON.parse(response);
182	// }).then((parsed) => {
183	// return parsed.map((article) => {
184	// return {
185	// id: article["id"],
186	// title: article["title"],
187	// date: new Date(article["publishedTimestamp"] * 1000),
188	// source: article["site"],
189	// audio: article["audio"],
190	// content: article["content"]
191	// };
192	// });
193	// });
194	// }
195
196	// //connect SN API endpoint /pocket with POST request
197	// do_pocket({ id, user = USER }) {
198	// return Tp.Helpers.Http.post(
199	// API_URL + "/pocket?user=" + user,
200	// JSON.stringify({ reading_list: [id] }),
201	// { dataContentType: 'application/json' }
202	// );
203	// }
204
205	// //connect SN API endpoint /drop with POST request
206	// do_drop({ id, user = USER }) {
207	// return Tp.Helpers.Http.post(
208	// API_URL + "/drop?user=" + user,
209	// JSON.stringify({ reading_list: [id] }),
210	// { dataContentType: 'application/json' }
211	// );
212	// }
213	};

stanford-oval / thingpedia-common-devices / 977

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous