639401381

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/yast/yast-bootloader/commit/<a class=hub.com/yast/yast-bootloader/commit/<a class="double-link" href="https://git"><a class=hub.com/yast/yast-bootloader/commit/<a class="double-link" href="https://git"><a class=hub.com/yast/yast-bootloader/commit/8ed7b65f3749d6fa2ce2464ba51c185aa2856b4f">8ed7b65f3">&lt;a href=&quot;https://github.com/yast/yast-bootloader/commit/</a><a class="double-link" href="https://github.com/yast/yast-bootloader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-bootloader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-bootloader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-bootloader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-bootloader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-bootloader/commit/8ed7b65f3749d6fa2ce2464ba51c185aa2856b4f">8ed7b65f3</a><a href="https://github.com/yast/yast-bootloader/commit/8ed7b65f3749d6fa2ce2464ba51c185aa2856b4f">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/yast/yast-bootloader/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/yast/yast-bootloader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-bootloader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-bootloader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-bootloader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-bootloader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-bootloader/commit/8ed7b65f3749d6fa2ce2464ba51c185aa2856b4f&quot;&gt;8ed7b65f3&lt;/a&gt;&lt;a href=&quot;https://github.com/yast/yast... (continued)

Pull Request Pull Request #637: Device map dialog validation

Run Details

6 of 6 new or added lines in 1 file covered. (100.0%)

2840 of 3215 relevant lines covered (88.34%)

13.38 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.43

/src/lib/bootloader/device_map_dialog.rb

# frozen_string_literal: true

require "yast"
require "y2storage"

Yast.import "BootStorage"
Yast.import "Label"
Yast.import "Popup"
Yast.import "Mode"

require "bootloader/device_map"

module Bootloader
  # Represents dialog for modification of device map
  class DeviceMapDialog
    include Yast::UIShortcuts
    include Yast::I18n

    def self.run(device_map)
      new(device_map).run
    end

    def initialize(device_map)
      @device_map = device_map
    end

    def run
      textdomain "bootloader"

      return unless create_dialog

      begin
        return controller_loop
      ensure
        close_dialog
      end
    end

  private

    def create_dialog
      res = Yast::UI.OpenDialog dialog_content
      return false unless res

      refresh_buttons

      true
    end

    def close_dialog
      Yast::UI.CloseDialog
    end

    def controller_loop
      loop do
        input = Yast::UI.UserInput
        pos = selected_disk_index
        case input
        when :ok
          if disks.empty?
            Yast::Popup.Error(_("Device map must contain at least one device"))
            next
          end
          max_dev = Bootloader::DeviceMap::BIOS_LIMIT
          if disks.size > max_dev
            # TRANSLATORS: an error message where %i is the number of devices.
            Yast::Popup.Error(_("Device map can have at maximum %i devices") % max_dev)
            next
          end
          store_order
          return :back # we just go back to original dialog
        when :cancel
          return :back
        when :up, :down, :delete, :add
          pos = handle_buttons(input, pos)
        when :disks
          refresh_buttons
          next
        else
          raise "Unknown action #{input}"
        end
        refresh_disks
        Yast::UI.ChangeWidget(Id(:disks), :CurrentItem, disks[pos])
        refresh_buttons
      end
    end

    def handle_buttons(action, pos)
      case action
      when :up
        disks.insert(pos - 1, disks.delete_at(pos))
        pos -= 1
      when :down
        disks.insert(pos + 1, disks.delete_at(pos))
        pos += 1
      when :delete
        disks.delete_at(pos)
        pos = (pos == disks.size) ? pos - 1 : pos
      when :add
        disks_to_add = if Yast::Mode.config || Yast::Mode.auto
          add_device_popup_ay_mode
        else
          add_devices_popup
        end
        disks.concat disks_to_add
        pos = disks.size - 1
      end

      pos
    end

    def dialog_content
      VBox(
        headings,
        VSpacing(1),
        contents,
        VSpacing(1),
        ending_buttons
      )
    end

    def headings
      Heading(_("Disk order settings"))
    end

    def contents
      HBox(
        VBox(
          SelectionBox(Id(:disks), Opt(:notify), _("D&isks"), disks),
          # make dialog reasonable big, but increace mainly selection box which contain device names
          HSpacing(60)
        ),
        action_buttons
      )
    end

    def action_buttons
      VBox(
        PushButton(Id(:add), Opt(:key_F3), Yast::Label.AddButton),
        PushButton(Id(:delete), Opt(:key_F5), Yast::Label.DeleteButton),
        VSpacing(1),
        PushButton(Id(:up), Opt(:hstretch), Yast::Label.UpButton),
        PushButton(Id(:down), Opt(:hstretch), Yast::Label.DownButton),
        VStretch()
      )
    end

    def ending_buttons
      ButtonBox(
        PushButton(Id(:ok), Yast::Label.OKButton),
        PushButton(Id(:cancel), Yast::Label.CancelButton)
      )
    end

    def disks
      @disks ||= @device_map.disks_order
    end

    def refresh_disks
      Yast::UI.ChangeWidget(Id(:disks), :Items, disks)
    end

    def available_devices
      staging = Y2Storage::StorageManager.instance.staging
      staging.disk_devices.map(&:name)
    end

    def store_order
      @device_map.clear_mapping
      disks.each_with_index do |disk, index|
        @device_map.add_mapping("hd#{index}", disk)
      end
    end

    def add_device_popup_ay_mode
      popup = VBox(
        VSpacing(1),
        # textentry header
        InputField(Id(:devname), Opt(:hstretch), _("&Device")),
        VSpacing(1),
        ButtonBox(
          PushButton(Id(:ok), Opt(:key_F10, :default), Yast::Label.OKButton),
          PushButton(Id(:cancel), Opt(:key_F8), Yast::Label.CancelButton)
        ),
        VSpacing(1)
      )
      Yast::UI.OpenDialog(popup)
      Yast::UI.SetFocus(:devname)
      pushed = Yast::UI.UserInput
      new_dev = Yast::UI.QueryWidget(Id(:devname), :Value)
      Yast::UI.CloseDialog

      (pushed == :ok) ? [new_dev] : []
    end

    def add_devices_popup
      devices = available_devices - disks
      popup = VBox(
        MultiSelectionBox(
          Id(:devnames),
          _("&Devices:"),
          devices
        ),
        ending_buttons,
        VSpacing(1)
      )
      Yast::UI.OpenDialog(popup)
      Yast::UI.SetFocus(:devnames)
      pushed = Yast::UI.UserInput
      new_devs = Yast::UI.QueryWidget(Id(:devnames), :SelectedItems)
      Yast::UI.CloseDialog

      (pushed == :ok) ? new_devs : []
    end

    def selected_disk_index
      disks.index(Yast::UI.QueryWidget(Id(:disks), :CurrentItem))
    end

    def refresh_buttons
      # by default enable delete and later disable if there are no disks
      Yast::UI.ChangeWidget(Id(:delete), :Enabled, true)
      pos = selected_disk_index
      if !pos # nothing selected
        disk_to_select = disks.first
        # there is no disks
        if !disk_to_select
          up_down_enablement(false, false)
          Yast::UI.ChangeWidget(Id(:delete), :Enabled, false)
          return
        end
        Yast::UI.ChangeWidget(Id(:disks), :CurrentItem, disk_to_select)
        refresh_buttons
        return
      end

      up_down_enablement(pos > 0, pos < (disks.size - 1))
    end

    def up_down_enablement(up_enabled, down_enabled)
      Yast::UI.ChangeWidget(Id(:up), :Enabled, up_enabled)
      Yast::UI.ChangeWidget(Id(:down), :Enabled, down_enabled)
    end
  end
end

1	# frozen_string_literal: true
2
3	require "yast"	1✔
4	require "y2storage"	1✔
5
6	Yast.import "BootStorage"	1✔
7	Yast.import "Label"	1✔
8	Yast.import "Popup"	1✔
9	Yast.import "Mode"	1✔
10
11	require "bootloader/device_map"	1✔
12
13	module Bootloader	1✔
14	# Represents dialog for modification of device map
15	class DeviceMapDialog	1✔
16	include Yast::UIShortcuts	1✔
17	include Yast::I18n	1✔
18
19	def self.run(device_map)	1✔
20	new(device_map).run	×
21	end
22
23	def initialize(device_map)	1✔
24	@device_map = device_map	8✔
25	end
26
27	def run	1✔
28	textdomain "bootloader"	9✔
29
30	return unless create_dialog	9✔
31
32	begin	9✔
33	return controller_loop	9✔
34	ensure
35	close_dialog	9✔
36	end
37	end
38
39	private	1✔
40
41	def create_dialog	1✔
42	res = Yast::UI.OpenDialog dialog_content	9✔
43	return false unless res	9✔
44
45	refresh_buttons	9✔
46
47	true	9✔
48	end
49
50	def close_dialog	1✔
51	Yast::UI.CloseDialog	9✔
52	end
53
54	def controller_loop	1✔
55	loop do	9✔
56	input = Yast::UI.UserInput	16✔
57	pos = selected_disk_index	16✔
58	case input	16✔
59	when :ok
60	if disks.empty?	8✔
61	Yast::Popup.Error(_("Device map must contain at least one device"))	×
62	next	×
63	end
64	max_dev = Bootloader::DeviceMap::BIOS_LIMIT	8✔
65	if disks.size > max_dev	8✔
66	# TRANSLATORS: an error message where %i is the number of devices.
67	Yast::Popup.Error(_("Device map can have at maximum %i devices") % max_dev)	×
68	next	×
69	end
70	store_order	8✔
71	return :back # we just go back to original dialog	8✔
72	when :cancel
73	return :back	1✔
74	when :up, :down, :delete, :add
75	pos = handle_buttons(input, pos)	6✔
76	when :disks
77	refresh_buttons	1✔
78	next	1✔
79	else
80	raise "Unknown action #{input}"	×
81	end
82	refresh_disks	6✔
83	Yast::UI.ChangeWidget(Id(:disks), :CurrentItem, disks[pos])	6✔
84	refresh_buttons	6✔
85	end
86	end
87
88	def handle_buttons(action, pos)	1✔
89	case action	6✔
90	when :up
91	disks.insert(pos - 1, disks.delete_at(pos))	1✔
92	pos -= 1	1✔
93	when :down
94	disks.insert(pos + 1, disks.delete_at(pos))	1✔
95	pos += 1	1✔
96	when :delete
97	disks.delete_at(pos)	1✔
98	pos = (pos == disks.size) ? pos - 1 : pos	1✔
99	when :add
100	disks_to_add = if Yast::Mode.config \|\| Yast::Mode.auto	3✔
101	add_device_popup_ay_mode	2✔
102	else
103	add_devices_popup	1✔
104	end
105	disks.concat disks_to_add	3✔
106	pos = disks.size - 1	3✔
107	end
108
109	pos	6✔
110	end
111
112	def dialog_content	1✔
113	VBox(	9✔
114	headings,
115	VSpacing(1),
116	contents,
117	VSpacing(1),
118	ending_buttons
119	)
120	end
121
122	def headings	1✔
123	Heading(_("Disk order settings"))	9✔
124	end
125
126	def contents	1✔
127	HBox(	9✔
128	VBox(
129	SelectionBox(Id(:disks), Opt(:notify), _("D&isks"), disks),
130	# make dialog reasonable big, but increace mainly selection box which contain device names
131	HSpacing(60)
132	),
133	action_buttons
134	)
135	end
136
137	def action_buttons	1✔
138	VBox(	9✔
139	PushButton(Id(:add), Opt(:key_F3), Yast::Label.AddButton),
140	PushButton(Id(:delete), Opt(:key_F5), Yast::Label.DeleteButton),
141	VSpacing(1),
142	PushButton(Id(:up), Opt(:hstretch), Yast::Label.UpButton),
143	PushButton(Id(:down), Opt(:hstretch), Yast::Label.DownButton),
144	VStretch()
145	)
146	end
147
148	def ending_buttons	1✔
149	ButtonBox(	10✔
150	PushButton(Id(:ok), Yast::Label.OKButton),
151	PushButton(Id(:cancel), Yast::Label.CancelButton)
152	)
153	end
154
155	def disks	1✔
156	@disks \|\|= @device_map.disks_order	106✔
157	end
158
159	def refresh_disks	1✔
160	Yast::UI.ChangeWidget(Id(:disks), :Items, disks)	6✔
161	end
162
163	def available_devices	1✔
164	staging = Y2Storage::StorageManager.instance.staging	1✔
165	staging.disk_devices.map(&:name)	1✔
166	end
167
168	def store_order	1✔
169	@device_map.clear_mapping	8✔
170	disks.each_with_index do \|disk, index\|	8✔
171	@device_map.add_mapping("hd#{index}", disk)	20✔
172	end
173	end
174
175	def add_device_popup_ay_mode	1✔
176	popup = VBox(	2✔
177	VSpacing(1),
178	# textentry header
179	InputField(Id(:devname), Opt(:hstretch), _("&Device")),
180	VSpacing(1),
181	ButtonBox(
182	PushButton(Id(:ok), Opt(:key_F10, :default), Yast::Label.OKButton),
183	PushButton(Id(:cancel), Opt(:key_F8), Yast::Label.CancelButton)
184	),
185	VSpacing(1)
186	)
187	Yast::UI.OpenDialog(popup)	2✔
188	Yast::UI.SetFocus(:devname)	2✔
189	pushed = Yast::UI.UserInput	2✔
190	new_dev = Yast::UI.QueryWidget(Id(:devname), :Value)	2✔
191	Yast::UI.CloseDialog	2✔
192
193	(pushed == :ok) ? [new_dev] : []	2✔
194	end
195
196	def add_devices_popup	1✔
197	devices = available_devices - disks	1✔
198	popup = VBox(	1✔
199	MultiSelectionBox(
200	Id(:devnames),
201	_("&Devices:"),
202	devices
203	),
204	ending_buttons,
205	VSpacing(1)
206	)
207	Yast::UI.OpenDialog(popup)	1✔
208	Yast::UI.SetFocus(:devnames)	1✔
209	pushed = Yast::UI.UserInput	1✔
210	new_devs = Yast::UI.QueryWidget(Id(:devnames), :SelectedItems)	1✔
211	Yast::UI.CloseDialog	1✔
212
213	(pushed == :ok) ? new_devs : []	1✔
214	end
215
216	def selected_disk_index	1✔
217	disks.index(Yast::UI.QueryWidget(Id(:disks), :CurrentItem))	32✔
218	end
219
220	def refresh_buttons	1✔
221	# by default enable delete and later disable if there are no disks
222	Yast::UI.ChangeWidget(Id(:delete), :Enabled, true)	16✔
223	pos = selected_disk_index	16✔
224	if !pos # nothing selected	16✔
225	disk_to_select = disks.first	×
226	# there is no disks
227	if !disk_to_select	×
228	up_down_enablement(false, false)	×
229	Yast::UI.ChangeWidget(Id(:delete), :Enabled, false)	×
230	return	×
231	end
232	Yast::UI.ChangeWidget(Id(:disks), :CurrentItem, disk_to_select)	×
233	refresh_buttons	×
234	return	×
235	end
236
237	up_down_enablement(pos > 0, pos < (disks.size - 1))	16✔
238	end
239
240	def up_down_enablement(up_enabled, down_enabled)	1✔
241	Yast::UI.ChangeWidget(Id(:up), :Enabled, up_enabled)	16✔
242	Yast::UI.ChangeWidget(Id(:down), :Enabled, down_enabled)	16✔
243	end
244	end
245	end

yast / yast-bootloader / 639401381

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous