stanford-oval / thingpedia-common-devices / 894

pending completion

Build # 894

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Merge pull request #279 from stanford-oval/wip/spotify-fix

Prefer songs to albums

Run Details

398 of 745 branches covered (53.42%)

Branch coverage included in aggregate %.

15 of 33 new or added lines in 1 file covered. (45.45%)

61 existing lines in 2 files now uncovered.

741 of 1163 relevant lines covered (63.71%)

931.87 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.7

/main/org.thingpedia.weather/index.js

// -*- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 -*-
//
// Copyright 2016 Giovanni Campagna <gcampagn@cs.stanford.edu>
//                Silei Xu <silei@cs.stanford.edu>
//                Andrei Bajenov <abajenov@stanford.edu>
//                Darshan Kapashi <darshank@stanford.edu>
//
// See LICENSE for details
"use strict";

const Tp = require('thingpedia');

const MS_PER_HOUR = 60 * 60 * 1000;
const MS_PER_DAY = 24 * MS_PER_HOUR;

const SUNRISE_URL = 'https://api.met.no/weatherapi/sunrise/2.0/?lat=%f&lon=%f&date=%04d-%02d-%02d&offset=-00:00';
const WEATHER_URL = 'https://api.met.no/weatherapi/locationforecast/2.0/classic?lat=%f;lon=%f';


function dateDiff(date1, date2) {
    // Discard the time and time-zone information.
    const utc1 = Date.UTC(date1.getFullYear(), date1.getMonth(), date1.getDate());
    const utc2 = Date.UTC(date2.getFullYear(), date2.getMonth(), date2.getDate());
    return Math.floor((utc2 - utc1) / MS_PER_DAY);
}

class ForecastError extends Error {
    constructor(code, message) {
        super(message);
        this.code = code;
    }
}

module.exports = class WeatherAPIDevice extends Tp.BaseDevice {
    async _sunrise_data(location, date) {
        const url = SUNRISE_URL.format(location.y, location.x, date.getFullYear(), date.getMonth()+1, date.getDate());
        console.log('Loading sunrise data from ' + url);
        const parsed = await Tp.Helpers.Http.get(url).then(Tp.Helpers.Xml.parseString);
        return parsed.astrodata.location[0].time[0];
    }

    async _weather_data(location) {
        const url = WEATHER_URL.format(location.y, location.x);
        console.log('Loading weather data from ' + url);
        const parsed = await Tp.Helpers.Http.get(url).then(Tp.Helpers.Xml.parseString);
        return parsed.weatherdata.product[0].time;
    }

    // the weather details is stored in the entry where time $.from === $.to
    // however it contains no status information, which is available in the following entries
    // (which have the same $.to, but different $.from)
    // this function takes the entry with $.from === $.to for details, and one following entry for status info
    async _extract_weather(entry1, entry2) {
        const details = entry1.location[0];
        const weather_id = parseInt(entry2.location[0].symbol[0].$.number);

        // although symbol comes with a string, we still map it to a fixed set to simply natural language
        // for example, "a cloudy day" can be LightCloud/PartlyCloud/Cloud in status
        // for the full list of status, see: https://api.met.no/weatherapi/weathericon/1.1/documentation
        let status;
        if (weather_id === 1)
            status = 'sunny';
        else if (weather_id === 15)
            status = 'foggy';
        else if ([2, 3, 4].indexOf(weather_id) >= 0)
            status = 'cloudy';
        else if ([5, 6, 9, 10, 11, 22, 41].indexOf(weather_id) >= 0)
            status = 'raining';
        else if ([24, 30, 40, 46].indexOf(weather_id) >= 0)
            status = 'drizzling';
        else if ([8, 13, 14, 21, 28, 29, 33, 34, 44, 45, 49, 50].indexOf(weather_id) >= 0)
            status = 'snowy';
        else if ([7, 12, 20, 23, 26, 27, 31, 32, 42, 43, 47, 48].indexOf(weather_id) >= 0)
            status = 'sleety';

        return {
            temperature: parseFloat(details.temperature ? details.temperature[0].$.value : 0),
            wind_speed: parseFloat(details.windSpeed ? details.windSpeed[0].$.mps || 0 : 0),
            humidity: parseFloat(details.humidity ? details.humidity[0].$.value || 0 : 0),
            cloudiness: parseFloat(details.cloudiness ? details.cloudiness[0].$.percent || 0 : 0),
            fog: parseFloat(details.fog ? details.fog[0].$.percent || 0 : 0),
            status,
            icon: `http://api.met.no/weatherapi/weathericon/1.1/?symbol=${weather_id};content_type=image/png`
        };
    }

    async get_sunrise({ location, date }) {
        if (date === undefined || date === null)
            date = new Date();
        const data = await this._sunrise_data(location, date);

        // the api might return sunset/sunrise time from the previous day
        // we will need to convert to the same date first before comparison
        // note that, using date.setDate(date.getDate() + 1) might cause problems due to daylight savings
        // so we use millisecond instead.
        let rise = new Date(data.sunrise[0].$.time);
        if (rise.getDate() !== date.getDate())
            rise = new Date(rise.getTime() + (dateDiff(rise, date) * MS_PER_DAY));
        let set = new Date(data.sunset[0].$.time);
        if (set.getDate() !== date.getDate())
            set = new Date(set.getTime() + (dateDiff(set, date) * MS_PER_DAY));

        const now = new Date();
        return [{
            location,
            date,
            sunrise_time: new Tp.Value.Time(rise.getHours(), rise.getMinutes(), rise.getSeconds()),
            sunset_time: new Tp.Value.Time(set.getHours(), set.getMinutes(), set.getSeconds()),
            sunrisen: now > rise,
            sunset: now > set
        }];
    }

    async get_moon({ location, date }) {
        if (date === undefined || date === null)
            date = new Date();
        const data = await this._sunrise_data(location, date);
        const phase = /(?:\()([a-z ]*)(?:\))/g.exec(data.moonphase[0].$.desc)[1].replace(/ /g, '_');
        return [{ location, date, phase }];
    }

    async get_current({ location }) {
        const data = await this._weather_data(location);
        const current = await this._extract_weather(data[0], data[1]);

        current.location = location;
        return [ current ];
    }

    async get_forecast({ date, location }) {
        const data = await this._weather_data(location);
        const now = new Date(data[0].$.from);
        const today = new Date(now);
        today.setHours(0, 0, 0);
        // do forecast for tomorrow if time is unspecified
        if (!date)
            date = new Date(today + 86400 * 1000);

        if (date < now)
            throw new ForecastError('no_past_forecast', `Invalid date ${date}: is in the past`);

        // find the weather closest to the time the user asked for

        // if the time is midnight (ie the user specified a date without a time), we do 2pm,
        // which is usually the hottest time of the day
        //
        // FIXME: we should do 2pm local-time of the location we're asking the weather for,
        // but that's a bit difficult so we just 2pm local-time to the server
        // (which is 2pm pacific for cloud, and 2pm local-time to the user for server/gnome)

        let comparetime = new Date(date.getTime());
        if (comparetime.getHours() === 0 && comparetime.getMinutes() === 0 &&
            comparetime.getSeconds() === 0)
            comparetime.setHours(14, 0, 0);

        let best = undefined, bestdelta = undefined;
        for (let i = 0; i < data.length; i++) {
            if (data[i].$.from !== data[i].$.to)
                continue;
            const datetime = new Date(data[i].$.from);

            // never select a forecast for the wrong day
            if (datetime.getDate() !== comparetime.getDate() ||
                datetime.getMonth() !== comparetime.getMonth() ||
                datetime.getFullYear() !== comparetime.getFullYear())
                continue;

            let delta = Math.abs(datetime - comparetime);
            if (bestdelta === undefined || delta < bestdelta) {
                best = await this._extract_weather(data[i], data[i+1]);
                best.date = datetime;
                bestdelta = delta;
            }
        }
        if (!best)
            throw new ForecastError('not_available', `Forecast for ${date} not available yet`);

        return [best];
    }
};

1	// -- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 --
2	//
3	// Copyright 2016 Giovanni Campagna <gcampagn@cs.stanford.edu>
4	// Silei Xu <silei@cs.stanford.edu>
5	// Andrei Bajenov <abajenov@stanford.edu>
6	// Darshan Kapashi <darshank@stanford.edu>
7	//
8	// See LICENSE for details
9	"use strict";
10
11	const Tp = require('thingpedia');	2✔
12
13	const MS_PER_HOUR = 60 * 60 * 1000;	2✔
14	const MS_PER_DAY = 24 * MS_PER_HOUR;	2✔
15
16	const SUNRISE_URL = 'https://api.met.no/weatherapi/sunrise/2.0/?lat=%f&lon=%f&date=%04d-%02d-%02d&offset=-00:00';	2✔
17	const WEATHER_URL = 'https://api.met.no/weatherapi/locationforecast/2.0/classic?lat=%f;lon=%f';	2✔
18
19
20	function dateDiff(date1, date2) {
21	// Discard the time and time-zone information.
22	const utc1 = Date.UTC(date1.getFullYear(), date1.getMonth(), date1.getDate());	1✔
23	const utc2 = Date.UTC(date2.getFullYear(), date2.getMonth(), date2.getDate());	1✔
24	return Math.floor((utc2 - utc1) / MS_PER_DAY);	1✔
25	}
26
27	class ForecastError extends Error {
28	constructor(code, message) {
29	super(message);	2✔
30	this.code = code;	2✔
31	}
32	}
33
34	module.exports = class WeatherAPIDevice extends Tp.BaseDevice {	2✔
35	async _sunrise_data(location, date) {
36	const url = SUNRISE_URL.format(location.y, location.x, date.getFullYear(), date.getMonth()+1, date.getDate());	2✔
37	console.log('Loading sunrise data from ' + url);	2✔
38	const parsed = await Tp.Helpers.Http.get(url).then(Tp.Helpers.Xml.parseString);	2✔
39	return parsed.astrodata.location[0].time[0];	2✔
40	}
41
42	async _weather_data(location) {
43	const url = WEATHER_URL.format(location.y, location.x);	7✔
44	console.log('Loading weather data from ' + url);	7✔
45	const parsed = await Tp.Helpers.Http.get(url).then(Tp.Helpers.Xml.parseString);	7✔
46	return parsed.weatherdata.product[0].time;	7✔
47	}
48
49	// the weather details is stored in the entry where time $.from === $.to
50	// however it contains no status information, which is available in the following entries
51	// (which have the same $.to, but different $.from)
52	// this function takes the entry with $.from === $.to for details, and one following entry for status info
53	async _extract_weather(entry1, entry2) {
54	const details = entry1.location[0];	20✔
55	const weather_id = parseInt(entry2.location[0].symbol[0].$.number);	20✔
56
57	// although symbol comes with a string, we still map it to a fixed set to simply natural language
58	// for example, "a cloudy day" can be LightCloud/PartlyCloud/Cloud in status
59	// for the full list of status, see: https://api.met.no/weatherapi/weathericon/1.1/documentation
60	let status;
61	if (weather_id === 1)	20✔
62	status = 'sunny';	4✔
63	else if (weather_id === 15)	16!
64	status = 'foggy';	×
65	else if ([2, 3, 4].indexOf(weather_id) >= 0)	16✔
66	status = 'cloudy';	14✔
67	else if ([5, 6, 9, 10, 11, 22, 41].indexOf(weather_id) >= 0)	2!
68	status = 'raining';	2✔
UNCOV 69	else if ([24, 30, 40, 46].indexOf(weather_id) >= 0)	×
UNCOV 70	status = 'drizzling';	×
UNCOV 71	else if ([8, 13, 14, 21, 28, 29, 33, 34, 44, 45, 49, 50].indexOf(weather_id) >= 0)	×
UNCOV 72	status = 'snowy';	×
UNCOV 73	else if ([7, 12, 20, 23, 26, 27, 31, 32, 42, 43, 47, 48].indexOf(weather_id) >= 0)	×
UNCOV 74	status = 'sleety';	×
75
76	return {	20✔
77	temperature: parseFloat(details.temperature ? details.temperature[0].$.value : 0),	20!
78	wind_speed: parseFloat(details.windSpeed ? details.windSpeed[0].$.mps \|\| 0 : 0),	40!
79	humidity: parseFloat(details.humidity ? details.humidity[0].$.value \|\| 0 : 0),	40!
80	cloudiness: parseFloat(details.cloudiness ? details.cloudiness[0].$.percent \|\| 0 : 0),	40!
81	fog: parseFloat(details.fog ? details.fog[0].$.percent \|\| 0 : 0),	40!
82	status,
83	icon: `http://api.met.no/weatherapi/weathericon/1.1/?symbol=${weather_id};content_type=image/png`
84	};
85	}
86
87	async get_sunrise({ location, date }) {
88	if (date === undefined \|\| date === null)	1!
UNCOV 89	date = new Date();	×
90	const data = await this._sunrise_data(location, date);	1✔
91
92	// the api might return sunset/sunrise time from the previous day
93	// we will need to convert to the same date first before comparison
94	// note that, using date.setDate(date.getDate() + 1) might cause problems due to daylight savings
95	// so we use millisecond instead.
96	let rise = new Date(data.sunrise[0].$.time);	1✔
97	if (rise.getDate() !== date.getDate())	1!
UNCOV 98	rise = new Date(rise.getTime() + (dateDiff(rise, date) * MS_PER_DAY));	×
99	let set = new Date(data.sunset[0].$.time);	1✔
100	if (set.getDate() !== date.getDate())	1!
101	set = new Date(set.getTime() + (dateDiff(set, date) * MS_PER_DAY));	1✔
102
103	const now = new Date();	1✔
104	return [{	1✔
105	location,
106	date,
107	sunrise_time: new Tp.Value.Time(rise.getHours(), rise.getMinutes(), rise.getSeconds()),
108	sunset_time: new Tp.Value.Time(set.getHours(), set.getMinutes(), set.getSeconds()),
109	sunrisen: now > rise,
110	sunset: now > set
111	}];
112	}
113
114	async get_moon({ location, date }) {
115	if (date === undefined \|\| date === null)	1!
UNCOV 116	date = new Date();	×
117	const data = await this._sunrise_data(location, date);	1✔
118	const phase = /(?:\()([a-z ]*)(?:\))/g.exec(data.moonphase[0].$.desc)[1].replace(/ /g, '_');	1✔
119	return [{ location, date, phase }];	1✔
120	}
121
122	async get_current({ location }) {
123	const data = await this._weather_data(location);	3✔
124	const current = await this._extract_weather(data[0], data[1]);	3✔
125
126	current.location = location;	3✔
127	return [ current ];	3✔
128	}
129
130	async get_forecast({ date, location }) {
131	const data = await this._weather_data(location);	4✔
132	const now = new Date(data[0].$.from);	4✔
133	const today = new Date(now);	4✔
134	today.setHours(0, 0, 0);	4✔
135	// do forecast for tomorrow if time is unspecified
136	if (!date)	4!
137	date = new Date(today + 86400 * 1000);	×
138
139	if (date < now)	4✔
140	throw new ForecastError('no_past_forecast', `Invalid date ${date}: is in the past`);	1✔
141
142	// find the weather closest to the time the user asked for
143
144	// if the time is midnight (ie the user specified a date without a time), we do 2pm,
145	// which is usually the hottest time of the day
146	//
147	// FIXME: we should do 2pm local-time of the location we're asking the weather for,
148	// but that's a bit difficult so we just 2pm local-time to the server
149	// (which is 2pm pacific for cloud, and 2pm local-time to the user for server/gnome)
150
151	let comparetime = new Date(date.getTime());	3✔
152	if (comparetime.getHours() === 0 && comparetime.getMinutes() === 0 &&	3✔
153	comparetime.getSeconds() === 0)
154	comparetime.setHours(14, 0, 0);	2✔
155
156	let best = undefined, bestdelta = undefined;	3✔
157	for (let i = 0; i < data.length; i++) {	3✔
158	if (data[i].$.from !== data[i].$.to)	714✔
159	continue;	450✔
160	const datetime = new Date(data[i].$.from);	264✔
161
162	// never select a forecast for the wrong day
163	if (datetime.getDate() !== comparetime.getDate() \|\|	264✔
164	datetime.getMonth() !== comparetime.getMonth() \|\|
165	datetime.getFullYear() !== comparetime.getFullYear())
166	continue;	237✔
167
168	let delta = Math.abs(datetime - comparetime);	27✔
169	if (bestdelta === undefined \|\| delta < bestdelta) {	27✔
170	best = await this._extract_weather(data[i], data[i+1]);	17✔
171	best.date = datetime;	17✔
172	bestdelta = delta;	17✔
173	}
174	}
175	if (!best)	3✔
176	throw new ForecastError('not_available', `Forecast for ${date} not available yet`);	1✔
177
178	return [best];	2✔
179	}
180	};

stanford-oval / thingpedia-common-devices / 894

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous