stanford-oval / thingpedia-common-devices / 876

pending completion

Build # 876

Build Type

Pull #275

travis-ci-com

Committed by

web-flow

Commit Message

Merge ca4e8ce39 into 004634394

Pull Request Pull Request #275: Two tiny Yelp fixes

Run Details

361 of 693 branches covered (52.09%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

703 of 1144 relevant lines covered (61.45%)

987.27 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

44.85

/main/org.thingpedia.weather/index.js

// -*- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 -*-
//
// Copyright 2016 Giovanni Campagna <gcampagn@cs.stanford.edu>
//                Silei Xu <silei@cs.stanford.edu>
//                Andrei Bajenov <abajenov@stanford.edu>
//                Darshan Kapashi <darshank@stanford.edu>
//
// See LICENSE for details
"use strict";

const Tp = require('thingpedia');

const MS_PER_HOUR = 60 * 60 * 1000;
const MS_PER_DAY = 24 * MS_PER_HOUR;

const SUNRISE_URL = 'https://api.met.no/weatherapi/sunrise/2.0/?lat=%f&lon=%f&date=%04d-%02d-%02d&offset=-00:00';
const WEATHER_URL = 'https://api.met.no/weatherapi/locationforecast/2.0/classic?lat=%f;lon=%f';


function dateDiff(date1, date2) {
    // Discard the time and time-zone information.
    const utc1 = Date.UTC(date1.getFullYear(), date1.getMonth(), date1.getDate());
    const utc2 = Date.UTC(date2.getFullYear(), date2.getMonth(), date2.getDate());
    return Math.floor((utc2 - utc1) / MS_PER_DAY);
}

module.exports = class WeatherAPIDevice extends Tp.BaseDevice {
    async _sunrise_data(location, date) {
        const url = SUNRISE_URL.format(location.y, location.x, date.getFullYear(), date.getMonth()+1, date.getDate());
        console.log('Loading sunrise data from ' + url);
        const parsed = await Tp.Helpers.Http.get(url).then(Tp.Helpers.Xml.parseString);
        return parsed.astrodata.location[0].time[0];
    }

    async _weather_data(location) {
        const url = WEATHER_URL.format(location.y, location.x);
        console.log('Loading weather data from ' + url);
        const parsed = await Tp.Helpers.Http.get(url).then(Tp.Helpers.Xml.parseString);
        return parsed.weatherdata.product[0].time;
    }

    // the weather details is stored in the entry where time $.from === $.to
    // however it contains no status information, which is available in the following entries
    // (which have the same $.to, but different $.from)
    // this function takes the entry with $.from === $.to for details, and one following entry for status info
    async _extract_weather(entry1, entry2) {
        const details = entry1.location[0];
        const weather_id = parseInt(entry2.location[0].symbol[0].$.number);

        // although symbol comes with a string, we still map it to a fixed set to simply natural language
        // for example, "a cloudy day" can be LightCloud/PartlyCloud/Cloud in status
        // for the full list of status, see: https://api.met.no/weatherapi/weathericon/1.1/documentation
        let status;
        if (weather_id === 1)
            status = 'sunny';
        else if (weather_id === 15)
            status = 'foggy';
        else if ([2, 3, 4].indexOf(weather_id) >= 0)
            status = 'cloudy';
        else if ([5, 6, 9, 10, 11, 22, 41].indexOf(weather_id) >= 0)
            status = 'raining';
        else if ([24, 30, 40, 46].indexOf(weather_id) >= 0)
            status = 'drizzling';
        else if ([8, 13, 14, 21, 28, 29, 33, 34, 44, 45, 49, 50].indexOf(weather_id) >= 0)
            status = 'snowy';
        else if ([7, 12, 20, 23, 26, 27, 31, 32, 42, 43, 47, 48].indexOf(weather_id) >= 0)
            status = 'sleety';

        return {
            temperature: parseFloat(details.temperature ? details.temperature[0].$.value : 0),
            wind_speed: parseFloat(details.windSpeed ? details.windSpeed[0].$.mps || 0 : 0),
            humidity: parseFloat(details.humidity ? details.humidity[0].$.value || 0 : 0),
            cloudiness: parseFloat(details.cloudiness ? details.cloudiness[0].$.percent || 0 : 0),
            fog: parseFloat(details.fog ? details.fog[0].$.percent || 0 : 0),
            status,
            icon: `http://api.met.no/weatherapi/weathericon/1.1/?symbol=${weather_id};content_type=image/png`
        };
    }

    async get_sunrise({ location, date }) {
        if (date === undefined || date === null)
            date = new Date();
        const data = await this._sunrise_data(location, date);

        // the api might return sunset/sunrise time from the previous day
        // we will need to convert to the same date first before comparison
        // note that, using date.setDate(date.getDate() + 1) might cause problems due to daylight savings
        // so we use millisecond instead.
        let rise = new Date(data.sunrise[0].$.time);
        if (rise.getDate() !== date.getDate())
            rise = new Date(rise.getTime() + (dateDiff(rise, date) * MS_PER_DAY));
        let set = new Date(data.sunset[0].$.time);
        if (set.getDate() !== date.getDate())
            set = new Date(set.getTime() + (dateDiff(set, date) * MS_PER_DAY));

        const now = new Date();
        return [{
            location,
            date,
            sunrise_time: new Tp.Value.Time(rise.getHours(), rise.getMinutes(), rise.getSeconds()),
            sunset_time: new Tp.Value.Time(set.getHours(), set.getMinutes(), set.getSeconds()),
            sunrisen: now > rise,
            sunset: now > set
        }];
    }

    async get_moon({ location, date }) {
        if (date === undefined || date === null)
            date = new Date();
        const data = await this._sunrise_data(location, date);
        const phase = /(?:\()([a-z ]*)(?:\))/g.exec(data.moonphase[0].$.desc)[1].replace(/ /g, '_');
        return [{ location, date, phase }];
    }

    async get_current({ location }) {
        const data = await this._weather_data(location);
        const current = await this._extract_weather(data[0], data[1]);

        current.location = location;
        return [ current ];
    }

    async get_forecast({ location }) {
        const data = await this._weather_data(location);
        const forecasts = [];
        const now = new Date(data[0].$.from);
        const added = new Set();
        for (let i = 0; i < data.length; i++) {
            if (data[i].$.from !== data[i].$.to)
                continue;
            const datetime = new Date(data[i].$.from);
            if (datetime.getDate() === now.getDate()) {
                // same day forecast
                // return forecast every 6 hours
                if ((datetime - now) < 6 * MS_PER_HOUR)
                    continue;
                if ((datetime - now) % (6 * MS_PER_HOUR) !== 0)
                    continue;
                let forecast = await this._extract_weather(data[i], data[i+1]);
                forecast.location = location;
                forecast.date = datetime;
                forecasts.push(forecast);
            } else {
                // forecast for tomorrow and later
                // only return one forecast for each date
                if (added.has(datetime.getDate()))
                    continue;
                // store the first UTC time that is later than 9 AM in local time
                if (datetime.getHours() >= 9) {
                    added.add(datetime.getDate());
                    let forecast = await this._extract_weather(data[i], data[i+1]);
                    forecast.location = location;
                    forecast.date = datetime;
                    forecasts.push(forecast);
                }
            }
        }
        return forecasts;
    }
};

1	// -- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 --
2	//
3	// Copyright 2016 Giovanni Campagna <gcampagn@cs.stanford.edu>
4	// Silei Xu <silei@cs.stanford.edu>
5	// Andrei Bajenov <abajenov@stanford.edu>
6	// Darshan Kapashi <darshank@stanford.edu>
7	//
8	// See LICENSE for details
9	"use strict";
10
11	const Tp = require('thingpedia');	2✔
12
13	const MS_PER_HOUR = 60 * 60 * 1000;	2✔
14	const MS_PER_DAY = 24 * MS_PER_HOUR;	2✔
15
16	const SUNRISE_URL = 'https://api.met.no/weatherapi/sunrise/2.0/?lat=%f&lon=%f&date=%04d-%02d-%02d&offset=-00:00';	2✔
17	const WEATHER_URL = 'https://api.met.no/weatherapi/locationforecast/2.0/classic?lat=%f;lon=%f';	2✔
18
19
20	function dateDiff(date1, date2) {
21	// Discard the time and time-zone information.
22	const utc1 = Date.UTC(date1.getFullYear(), date1.getMonth(), date1.getDate());	1✔
23	const utc2 = Date.UTC(date2.getFullYear(), date2.getMonth(), date2.getDate());	1✔
24	return Math.floor((utc2 - utc1) / MS_PER_DAY);	1✔
25	}
26
27	module.exports = class WeatherAPIDevice extends Tp.BaseDevice {	2✔
28	async _sunrise_data(location, date) {
29	const url = SUNRISE_URL.format(location.y, location.x, date.getFullYear(), date.getMonth()+1, date.getDate());	2✔
30	console.log('Loading sunrise data from ' + url);	2✔
31	const parsed = await Tp.Helpers.Http.get(url).then(Tp.Helpers.Xml.parseString);	2✔
32	return parsed.astrodata.location[0].time[0];	2✔
33	}
34
35	async _weather_data(location) {
36	const url = WEATHER_URL.format(location.y, location.x);	2✔
37	console.log('Loading weather data from ' + url);	2✔
38	const parsed = await Tp.Helpers.Http.get(url).then(Tp.Helpers.Xml.parseString);	2✔
39	return parsed.weatherdata.product[0].time;	2✔
40	}
41
42	// the weather details is stored in the entry where time $.from === $.to
43	// however it contains no status information, which is available in the following entries
44	// (which have the same $.to, but different $.from)
45	// this function takes the entry with $.from === $.to for details, and one following entry for status info
46	async _extract_weather(entry1, entry2) {
47	const details = entry1.location[0];	2✔
48	const weather_id = parseInt(entry2.location[0].symbol[0].$.number);	2✔
49
50	// although symbol comes with a string, we still map it to a fixed set to simply natural language
51	// for example, "a cloudy day" can be LightCloud/PartlyCloud/Cloud in status
52	// for the full list of status, see: https://api.met.no/weatherapi/weathericon/1.1/documentation
53	let status;
54	if (weather_id === 1)	2!
UNCOV 55	status = 'sunny';	×
56	else if (weather_id === 15)	2!
57	status = 'foggy';	×
58	else if ([2, 3, 4].indexOf(weather_id) >= 0)	2!
59	status = 'cloudy';	2✔
60	else if ([5, 6, 9, 10, 11, 22, 41].indexOf(weather_id) >= 0)	×
61	status = 'raining';	×
62	else if ([24, 30, 40, 46].indexOf(weather_id) >= 0)	×
63	status = 'drizzling';	×
64	else if ([8, 13, 14, 21, 28, 29, 33, 34, 44, 45, 49, 50].indexOf(weather_id) >= 0)	×
65	status = 'snowy';	×
66	else if ([7, 12, 20, 23, 26, 27, 31, 32, 42, 43, 47, 48].indexOf(weather_id) >= 0)	×
67	status = 'sleety';	×
68
69	return {	2✔
70	temperature: parseFloat(details.temperature ? details.temperature[0].$.value : 0),	2!
71	wind_speed: parseFloat(details.windSpeed ? details.windSpeed[0].$.mps \|\| 0 : 0),	4!
72	humidity: parseFloat(details.humidity ? details.humidity[0].$.value \|\| 0 : 0),	4!
73	cloudiness: parseFloat(details.cloudiness ? details.cloudiness[0].$.percent \|\| 0 : 0),	4!
74	fog: parseFloat(details.fog ? details.fog[0].$.percent \|\| 0 : 0),	4!
75	status,
76	icon: `http://api.met.no/weatherapi/weathericon/1.1/?symbol=${weather_id};content_type=image/png`
77	};
78	}
79
80	async get_sunrise({ location, date }) {
81	if (date === undefined \|\| date === null)	1!
82	date = new Date();	×
83	const data = await this._sunrise_data(location, date);	1✔
84
85	// the api might return sunset/sunrise time from the previous day
86	// we will need to convert to the same date first before comparison
87	// note that, using date.setDate(date.getDate() + 1) might cause problems due to daylight savings
88	// so we use millisecond instead.
89	let rise = new Date(data.sunrise[0].$.time);	1✔
90	if (rise.getDate() !== date.getDate())	1!
91	rise = new Date(rise.getTime() + (dateDiff(rise, date) * MS_PER_DAY));	×
92	let set = new Date(data.sunset[0].$.time);	1✔
93	if (set.getDate() !== date.getDate())	1!
94	set = new Date(set.getTime() + (dateDiff(set, date) * MS_PER_DAY));	1✔
95
96	const now = new Date();	1✔
97	return [{	1✔
98	location,
99	date,
100	sunrise_time: new Tp.Value.Time(rise.getHours(), rise.getMinutes(), rise.getSeconds()),
101	sunset_time: new Tp.Value.Time(set.getHours(), set.getMinutes(), set.getSeconds()),
102	sunrisen: now > rise,
103	sunset: now > set
104	}];
105	}
106
107	async get_moon({ location, date }) {
108	if (date === undefined \|\| date === null)	1!
109	date = new Date();	×
110	const data = await this._sunrise_data(location, date);	1✔
111	const phase = /(?:\()([a-z ]*)(?:\))/g.exec(data.moonphase[0].$.desc)[1].replace(/ /g, '_');	1✔
112	return [{ location, date, phase }];	1✔
113	}
114
115	async get_current({ location }) {
116	const data = await this._weather_data(location);	2✔
117	const current = await this._extract_weather(data[0], data[1]);	2✔
118
119	current.location = location;	2✔
120	return [ current ];	2✔
121	}
122
123	async get_forecast({ location }) {
124	const data = await this._weather_data(location);	×
125	const forecasts = [];	×
126	const now = new Date(data[0].$.from);	×
127	const added = new Set();	×
128	for (let i = 0; i < data.length; i++) {	×
129	if (data[i].$.from !== data[i].$.to)	×
130	continue;	×
131	const datetime = new Date(data[i].$.from);	×
132	if (datetime.getDate() === now.getDate()) {	×
133	// same day forecast
134	// return forecast every 6 hours
135	if ((datetime - now) < 6 * MS_PER_HOUR)	×
136	continue;	×
137	if ((datetime - now) % (6 * MS_PER_HOUR) !== 0)	×
138	continue;	×
139	let forecast = await this._extract_weather(data[i], data[i+1]);	×
140	forecast.location = location;	×
141	forecast.date = datetime;	×
142	forecasts.push(forecast);	×
143	} else {
144	// forecast for tomorrow and later
145	// only return one forecast for each date
146	if (added.has(datetime.getDate()))	×
147	continue;	×
148	// store the first UTC time that is later than 9 AM in local time
149	if (datetime.getHours() >= 9) {	×
150	added.add(datetime.getDate());	×
151	let forecast = await this._extract_weather(data[i], data[i+1]);	×
152	forecast.location = location;	×
153	forecast.date = datetime;	×
154	forecasts.push(forecast);	×
155	}
156	}
157	}
158	return forecasts;	×
159	}
160	};

stanford-oval / thingpedia-common-devices / 876

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous