609137467

Build Type

github

Committed by GitHub

Commit Message

Merge 0f9804ce6 into cb145aa3f

Pull Request Pull Request #1048: Handle precisely argument exceptions in tests

Run Details

2189 of 3426 branches covered (63.89%)

Branch coverage included in aggregate %.

9 of 11 new or added lines in 1 file covered. (81.82%)

8 existing lines in 6 files now uncovered.

5920 of 7657 relevant lines covered (77.31%)

73741.67 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.62

/Zilon.Core/Zilon.Core/Tactics/Behaviour/MoveTask.cs

﻿using System;
using System.Collections.Generic;
using System.Linq;

using Zilon.Core.Graphs;
using Zilon.Core.Persons;
using Zilon.Core.Tactics.Spatial;
using Zilon.Core.World;

namespace Zilon.Core.Tactics.Behaviour
{
    public class MoveTask : ActorTaskBase
    {
        private readonly ISectorMap _map;
        private readonly List<IGraphNode> _path;

        public MoveTask(IActor actor, IActorTaskContext context, IGraphNode targetNode, ISectorMap map) : this(actor,
            context, targetNode, map, GlobeMetrics.OneIterationLength)
        {
        }

        public MoveTask(IActor actor, IActorTaskContext context, IGraphNode targetNode, ISectorMap map, int cost) :
            base(actor, context)
        {
            TargetNode = targetNode ?? throw new ArgumentNullException(nameof(targetNode));
            _map = map ?? throw new ArgumentNullException(nameof(map));
            Cost = cost;
            if (actor.Node == targetNode)
            {
                // Это может произойти, если источник команд выбрал целевую точку ту же, что и сам актёр
                // в результате рандома.
                IsComplete = true;

                _path = new List<IGraphNode>(0);
            }
            else
            {
                _path = new List<IGraphNode>();

                CreatePath();

                if (!_path.Any())
                {
                    IsComplete = true;
                }
            }
        }

        public override int Cost { get; }

        public IGraphNode TargetNode { get; }

        public bool CanExecute()
        {
            if (!_path.Any())
            {
                return false;
            }

            var nextNode = _path[0];

            return _map.IsPositionAvailableFor(nextNode, Actor);
        }

        public override void Execute()
        {
            if (IsComplete)
            {
                return;
            }

            if (!_path.Any())
            {
                if (TargetNode != Actor.Node)
                {
                    throw new TaskException("Актёр не достиг целевого узла при окончании пути.");
                }

                IsComplete = true;
                return;
            }

            var nextNode = _path[0];

            var actorCanMove = !Actor.Person.CheckIsDead();

            if (actorCanMove && _map.IsPositionAvailableFor(nextNode, Actor))
            {
                ReleaseNodes(Actor);
                Actor.MoveToNode(nextNode);
                HoldNodes(nextNode, Actor);

                _path.RemoveAt(0);

                if (!_path.Any())
                {
                    IsComplete = true;
                }
            }
            else
            {
                // Это может произойти, если кто-то опередил текущего персонажа и занял узел первым.
                IsComplete = true;
            }
        }

        public override string ToString()
        {
            return $"{Actor} ({TargetNode})";
        }

        private void CreatePath()
        {
            var context = new ActorPathFindingContext(Actor, _map, TargetNode);

            var startNode = Actor.Node;
            var finishNode = TargetNode;

            _path.Clear();

            _map.FindPath(startNode, finishNode, context, _path);
        }

        private IEnumerable<IGraphNode> GetActorNodes(IPerson person, IGraphNode baseNode)
        {
            yield return baseNode;

            if (person.PhysicalSize == PhysicalSizePattern.Size7)
            {
                var neighbors = _map.GetNext(baseNode);
                foreach (var neighbor in neighbors)
                {
                    yield return neighbor;
                }
            }
        }

        private void HoldNodes(IGraphNode nextNode, IActor actor)
        {
            var actorNodes = GetActorNodes(actor.Person, nextNode);

            foreach (var node in actorNodes)
            {
                _map.HoldNode(node, actor);
            }
        }

        private void ReleaseNodes(IActor actor)
        {
            var actorNodes = GetActorNodes(actor.Person, actor.Node);

            foreach (var node in actorNodes)
            {
                _map.ReleaseNode(node, actor);
            }
        }
    }
}

1	using System;
2	using System.Collections.Generic;
3	using System.Linq;
4
5	using Zilon.Core.Graphs;
6	using Zilon.Core.Persons;
7	using Zilon.Core.Tactics.Spatial;
8	using Zilon.Core.World;
9
10	namespace Zilon.Core.Tactics.Behaviour
11	{
12	public class MoveTask : ActorTaskBase
13	{
14	private readonly ISectorMap _map;
15	private readonly List<IGraphNode> _path;
16
17	public MoveTask(IActor actor, IActorTaskContext context, IGraphNode targetNode, ISectorMap map) : this(actor,	3,486✔
18	context, targetNode, map, GlobeMetrics.OneIterationLength)	3,486✔
19	{
20	}	3,486✔
21
22	public MoveTask(IActor actor, IActorTaskContext context, IGraphNode targetNode, ISectorMap map, int cost) :
23	base(actor, context)	3,486✔
24	{
25	TargetNode = targetNode ?? throw new ArgumentNullException(nameof(targetNode));	3,486!
26	_map = map ?? throw new ArgumentNullException(nameof(map));	3,486!
27	Cost = cost;	3,486✔
28	if (actor.Node == targetNode)	3,486✔
29	{
30	// Это может произойти, если источник команд выбрал целевую точку ту же, что и сам актёр
31	// в результате рандома.
32	IsComplete = true;	36✔
33
34	_path = new List<IGraphNode>(0);	36✔
35	}
36	else
37	{
38	_path = new List<IGraphNode>();	3,450✔
39
40	CreatePath();	3,450✔
41
42	if (!_path.Any())	3,450✔
43	{
44	IsComplete = true;	1✔
45	}
46	}
47	}	3,450✔
48
49	public override int Cost { get; }
50
51	public IGraphNode TargetNode { get; }
52
53	public bool CanExecute()
54	{
55	if (!_path.Any())	3,055!
56	{
UNCOV 57	return false;	×
58	}
59
60	var nextNode = _path[0];	3,055✔
61
62	return _map.IsPositionAvailableFor(nextNode, Actor);	3,055✔
63	}
64
65	public override void Execute()
66	{
67	if (IsComplete)	6,528✔
68	{
69	return;	36✔
70	}
71
72	if (!_path.Any())	6,492!
73	{
74	if (TargetNode != Actor.Node)	×
75	{
76	throw new TaskException("Актёр не достиг целевого узла при окончании пути.");	×
77	}
78
79	IsComplete = true;	×
80	return;	×
81	}
82
83	var nextNode = _path[0];	6,492✔
84
85	var actorCanMove = !Actor.Person.CheckIsDead();	6,492✔
86
87	if (actorCanMove && _map.IsPositionAvailableFor(nextNode, Actor))	6,492✔
88	{
89	ReleaseNodes(Actor);	6,485✔
90	Actor.MoveToNode(nextNode);	6,485✔
91	HoldNodes(nextNode, Actor);	6,485✔
92
93	_path.RemoveAt(0);	6,485✔
94
95	if (!_path.Any())	6,485✔
96	{
97	IsComplete = true;	3,301✔
98	}
99	}
100	else
101	{
102	// Это может произойти, если кто-то опередил текущего персонажа и занял узел первым.
103	IsComplete = true;	7✔
104	}
105	}	3,191✔
106
107	public override string ToString()
108	{
109	return $"{Actor} ({TargetNode})";	×
110	}
111
112	private void CreatePath()
113	{
114	var context = new ActorPathFindingContext(Actor, _map, TargetNode);	3,450✔
115
116	var startNode = Actor.Node;	3,450✔
117	var finishNode = TargetNode;	3,450✔
118
119	_path.Clear();	3,450✔
120
121	_map.FindPath(startNode, finishNode, context, _path);	3,450✔
122	}	3,450✔
123
124	private IEnumerable<IGraphNode> GetActorNodes(IPerson person, IGraphNode baseNode)
125	{
126	yield return baseNode;
127
128	if (person.PhysicalSize == PhysicalSizePattern.Size7)
129	{
130	var neighbors = _map.GetNext(baseNode);
131	foreach (var neighbor in neighbors)
132	{
133	yield return neighbor;
134	}
135	}
136	}
137
138	private void HoldNodes(IGraphNode nextNode, IActor actor)
139	{
140	var actorNodes = GetActorNodes(actor.Person, nextNode);	6,485✔
141
142	foreach (var node in actorNodes)	25,940✔
143	{
144	_map.HoldNode(node, actor);	6,485✔
145	}
146	}	6,485✔
147
148	private void ReleaseNodes(IActor actor)
149	{
150	var actorNodes = GetActorNodes(actor.Person, actor.Node);	6,485✔
151
152	foreach (var node in actorNodes)	25,940✔
153	{
154	_map.ReleaseNode(node, actor);	6,485✔
155	}
156	}	6,485✔
157	}
158	}

kreghek / Zilon_Roguelike / 609137467

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous