stanford-oval / almond-server / 481

pending completion

Build # 481

Build Type

Pull #127

travis-ci-com

Committed by

web-flow

Commit Message

<a href="https://github.com/stanford-oval/almond-server/commit/<a class=hub.com/stanford-oval/almond-server/commit/f6c226696a5b7ae2eed55307a93cb5e82484da23">f6c226696<a href="https://github.com/stanford-oval/almond-server/commit/f6c226696a5b7ae2eed55307a93cb5e82484da23">">Merge </a><a class="double-link" href="https://github.com/stanford-oval/almond-server/commit/<a class="double-link" href="https://github.com/stanford-oval/almond-server/commit/f94b0fca83df605c77340aa4b058ba57176b3f3e">f94b0fca8</a>">f94b0fca8</a><a href="https://github.com/stanford-oval/almond-server/commit/f6c226696a5b7ae2eed55307a93cb5e82484da23"> into 063ae6c1d">063ae6c1d</a>

Pull Request Pull Request #127: Only show warning when recording is enabled for the first time

Run Details

106 of 348 branches covered (30.46%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

569 of 1031 relevant lines covered (55.19%)

3.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

27.12

/routes/recording.js

// -*- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 -*-
//
// This file is part of Almond
//
// Copyright 2016-2020 The Board of Trustees of the Leland Stanford Junior University
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//    http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Author: Silei Xu <silei@cs.stanford.edu>
"use strict";

const fs = require('fs');
const express = require('express');

const user = require('../util/user');
const platform = require('../service/platform');

const router = express.Router();

router.use(user.requireLogIn);

router.post('/start', (req, res, next) => {
    const engine = req.app.engine;

    Promise.resolve().then(() => {
        const prefs = platform.getSharedPreferences();
        prefs.set('recording-warning-shown', 'yes');
        return engine.assistant.getConversation(req.body.id);
    }).then((conversation) => {
        if (!conversation) {
            res.status(404);
            return res.json({ error: 'No conversation found' });
        } else {
            conversation.startRecording();
            return res.json({ status: 'ok' });
        }
    }).catch(next);
});

router.post('/stop', (req, res, next) => {
    const engine = req.app.engine;

    Promise.resolve().then(() => {
        return engine.assistant.getConversation(req.body.id);
    }).then((conversation) => {
        if (!conversation) {
            res.status(404);
            return res.json({ error: 'No conversation found' });
        } else {
            conversation.endRecording();
            return res.json({ status:'ok' });
        }
    }).catch(next);
});

router.get('/warned', (req, res, next) => {
    Promise.resolve().then(async () => {
        const prefs = platform.getSharedPreferences();
        res.json({ warned: prefs.get('recording-warning-shown') === 'yes' ? 'yes' : 'no' });
    }).catch(next);
});

router.get('/status/:id', (req, res, next) => {
    const engine = req.app.engine;

    Promise.resolve().then(() => {
        return engine.assistant.getConversation(req.params.id);
    }).then((conversation) => {
        if (!conversation) {
            res.status(404);
            res.json({ error: 'No conversation found' });
        } else {
            res.json({ status: conversation.inRecordingMode ? 'on' : 'off' });
        }
    }).catch(next);
});

router.post('/vote/:vote', (req, res, next) => {
    const engine = req.app.engine;

    Promise.resolve().then(() => {
        return engine.assistant.getConversation(req.body.id);
    }).then((conversation) => {
        if (!['up', 'down'].includes(req.params.vote)) {
            res.status(400);
            return res.json({ error: 'Invalid voting option' });
        } else if (!conversation) {
            res.status(404);
            return res.json({ error: 'No conversation found' });
        } else {
            conversation.voteLast(req.params.vote);
            return res.json({ status:'ok' });
        }
    }).catch(next);
});

router.post('/comment', (req, res, next) => {
    const engine = req.app.engine;
    const command = req.body.comment;
    if (!command) {
        res.status(400).json({ error: 'Missing comment' });
        return;
    }

    Promise.resolve().then(() => {
        return engine.assistant.getConversation(req.body.id);
    }).then((conversation) => {
        if (!conversation) {
            res.status(404);
            return res.json({ error: 'No conversation found' });
        } else {
            conversation.commentLast(req.body.comment);
            return res.json({ status:'ok' });
        }
    }).catch(next);
});

router.post('/save', (req, res, next) => {
    const engine = req.app.engine;

    Promise.resolve().then(() => {
        return engine.assistant.getConversation(req.body.id);
    }).then((conversation) => {
        if (!conversation) {
            res.status(404);
            return res.json({ error: 'No conversation found' });
        } else {
            return conversation.saveLog().then(() => res.json({ status:'ok' }));
        }
    }).catch(next);
});

router.get('/log/:id.txt', (req, res, next) => {
    const engine = req.app.engine;

    Promise.resolve().then(() => {
        return engine.assistant.getConversation(req.params.id);
    }).then((conversation) => {
        if (!conversation || !conversation.log) {
            res.status(404);
            res.json({ error: 'No conversation found' });
        } else {
            res.set('Content-Type', 'text/plain');
            res.set('Content-Disposition', `attachment; filename="log-${conversation.id}.txt"`);
            fs.createReadStream(conversation.log).pipe(res);
        }
    }).catch(next);
});

router.get('/log/:id', (req, res, next) => {
    const engine = req.app.engine;

    Promise.resolve().then(() => {
        return engine.assistant.getConversation(req.params.id);
    }).then((conversation) => {
        if (!conversation || !conversation.log) {
            res.status(404);
            res.json({ error: 'No conversation found' });
        } else {
            res.json({
                status: 'ok',
                log: fs.readFileSync(conversation.log, 'utf-8')
            });
        }
    }).catch(next);
});


module.exports = router;

1	// -- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 --
2	//
3	// This file is part of Almond
4	//
5	// Copyright 2016-2020 The Board of Trustees of the Leland Stanford Junior University
6	//
7	// Licensed under the Apache License, Version 2.0 (the "License");
8	// you may not use this file except in compliance with the License.
9	// You may obtain a copy of the License at
10	//
11	// http://www.apache.org/licenses/LICENSE-2.0
12	//
13	// Unless required by applicable law or agreed to in writing, software
14	// distributed under the License is distributed on an "AS IS" BASIS,
15	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16	// See the License for the specific language governing permissions and
17	// limitations under the License.
18	//
19	// Author: Silei Xu <silei@cs.stanford.edu>
20	"use strict";
21
22	const fs = require('fs');	1✔
23	const express = require('express');	1✔
24
25	const user = require('../util/user');	1✔
26	const platform = require('../service/platform');	1✔
27
28	const router = express.Router();	1✔
29
30	router.use(user.requireLogIn);	1✔
31
32	router.post('/start', (req, res, next) => {	1✔
33	const engine = req.app.engine;	×
34
35	Promise.resolve().then(() => {	×
36	const prefs = platform.getSharedPreferences();	×
37	prefs.set('recording-warning-shown', 'yes');	×
38	return engine.assistant.getConversation(req.body.id);	×
39	}).then((conversation) => {
40	if (!conversation) {	×
41	res.status(404);	×
42	return res.json({ error: 'No conversation found' });	×
43	} else {
44	conversation.startRecording();	×
45	return res.json({ status: 'ok' });	×
46	}
47	}).catch(next);
48	});
49
50	router.post('/stop', (req, res, next) => {	1✔
51	const engine = req.app.engine;	×
52
53	Promise.resolve().then(() => {	×
54	return engine.assistant.getConversation(req.body.id);	×
55	}).then((conversation) => {
56	if (!conversation) {	×
57	res.status(404);	×
58	return res.json({ error: 'No conversation found' });	×
59	} else {
60	conversation.endRecording();	×
61	return res.json({ status:'ok' });	×
62	}
63	}).catch(next);
64	});
65
66	router.get('/warned', (req, res, next) => {	1✔
67	Promise.resolve().then(async () => {	×
68	const prefs = platform.getSharedPreferences();	×
69	res.json({ warned: prefs.get('recording-warning-shown') === 'yes' ? 'yes' : 'no' });	×
70	}).catch(next);
71	});
72
73	router.get('/status/:id', (req, res, next) => {	1✔
74	const engine = req.app.engine;	7✔
75
76	Promise.resolve().then(() => {	7✔
77	return engine.assistant.getConversation(req.params.id);	7✔
78	}).then((conversation) => {
79	if (!conversation) {	7!
80	res.status(404);	×
81	res.json({ error: 'No conversation found' });	×
82	} else {
83	res.json({ status: conversation.inRecordingMode ? 'on' : 'off' });	7!
84	}
85	}).catch(next);
86	});
87
88	router.post('/vote/:vote', (req, res, next) => {	1✔
89	const engine = req.app.engine;	×
90
91	Promise.resolve().then(() => {	×
92	return engine.assistant.getConversation(req.body.id);	×
93	}).then((conversation) => {
94	if (!['up', 'down'].includes(req.params.vote)) {	×
95	res.status(400);	×
96	return res.json({ error: 'Invalid voting option' });	×
97	} else if (!conversation) {	×
98	res.status(404);	×
99	return res.json({ error: 'No conversation found' });	×
100	} else {
101	conversation.voteLast(req.params.vote);	×
102	return res.json({ status:'ok' });	×
103	}
104	}).catch(next);
105	});
106
107	router.post('/comment', (req, res, next) => {	1✔
108	const engine = req.app.engine;	×
109	const command = req.body.comment;	×
110	if (!command) {	×
111	res.status(400).json({ error: 'Missing comment' });	×
112	return;	×
113	}
114
115	Promise.resolve().then(() => {	×
116	return engine.assistant.getConversation(req.body.id);	×
117	}).then((conversation) => {
118	if (!conversation) {	×
119	res.status(404);	×
120	return res.json({ error: 'No conversation found' });	×
121	} else {
122	conversation.commentLast(req.body.comment);	×
123	return res.json({ status:'ok' });	×
124	}
125	}).catch(next);
126	});
127
128	router.post('/save', (req, res, next) => {	1✔
129	const engine = req.app.engine;	×
130
131	Promise.resolve().then(() => {	×
132	return engine.assistant.getConversation(req.body.id);	×
133	}).then((conversation) => {
134	if (!conversation) {	×
135	res.status(404);	×
136	return res.json({ error: 'No conversation found' });	×
137	} else {
138	return conversation.saveLog().then(() => res.json({ status:'ok' }));	×
139	}
140	}).catch(next);
141	});
142
143	router.get('/log/:id.txt', (req, res, next) => {	1✔
144	const engine = req.app.engine;	×
145
146	Promise.resolve().then(() => {	×
147	return engine.assistant.getConversation(req.params.id);	×
148	}).then((conversation) => {
149	if (!conversation \|\| !conversation.log) {	×
150	res.status(404);	×
151	res.json({ error: 'No conversation found' });	×
152	} else {
153	res.set('Content-Type', 'text/plain');	×
154	res.set('Content-Disposition', `attachment; filename="log-${conversation.id}.txt"`);	×
155	fs.createReadStream(conversation.log).pipe(res);	×
156	}
157	}).catch(next);
158	});
159
160	router.get('/log/:id', (req, res, next) => {	1✔
161	const engine = req.app.engine;	7✔
162
163	Promise.resolve().then(() => {	7✔
164	return engine.assistant.getConversation(req.params.id);	7✔
165	}).then((conversation) => {
166	if (!conversation \|\| !conversation.log) {	7!
167	res.status(404);	7✔
168	res.json({ error: 'No conversation found' });	7✔
169	} else {
170	res.json({	×
171	status: 'ok',
172	log: fs.readFileSync(conversation.log, 'utf-8')
173	});
174	}
175	}).catch(next);
176	});
177
178
179	module.exports = router;	1✔

stanford-oval / almond-server / 481

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous