1655

pending completion

Build # 1655

Build Type

Pull #421

travis-ci-com

Committed by

web-flow

Commit Message

Merge 2f70c6838 into 2d0f5eef9

Pull Request Pull Request #421: Confidence-based dispatch

Run Details

10836 of 23282 branches covered (46.54%)

Branch coverage included in aggregate %.

191 of 312 new or added lines in 8 files covered. (61.22%)

18 existing lines in 10 files now uncovered.

25386 of 43912 relevant lines covered (57.81%)

510266.28 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.9

/lib/dialogue-agent/value-category.ts

// -*- mode: typescript; indent-tabs-mode: nil; js-basic-offset: 4 -*-
//
// This file is part of Genie
//
// Copyright 2020 The Board of Trustees of the Leland Stanford Junior University
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//    http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Author: Giovanni Campagna <gcampagn@cs.stanford.edu>

import { Ast, Type } from 'thingtalk';

enum ValueCategory {
    YesNo,
    MultipleChoice,
    Number,
    Measure,
    RawString,
    Password,
    Date,
    Time,
    Unknown,
    Picture,
    Location,
    PhoneNumber,
    EmailAddress,
    Contact,
    Command,
}
export default ValueCategory;

namespace ValueCategory {
    export function fromType(type : Type) : ValueCategory {
        if (type instanceof Type.Entity && type.type === 'tt:picture')
            return ValueCategory.Picture;
        else if (type instanceof Type.Entity && type.type === 'tt:phone_number')
            return ValueCategory.PhoneNumber;
        else if (type instanceof Type.Entity && type.type === 'tt:email_address')
            return ValueCategory.EmailAddress;
        else if (type instanceof Type.Entity && type.type === 'tt:contact')
            return ValueCategory.Contact;
        else if (type instanceof Type.Entity)
            return ValueCategory.RawString;
        else if (type.isBoolean)
            return ValueCategory.YesNo;
        else if (type.isString)
            return ValueCategory.RawString;
        else if (type.isNumber)
            return ValueCategory.Number;
        else if (type.isMeasure)
            return ValueCategory.Measure;
        else if (type.isEnum)
            return ValueCategory.RawString;
        else if (type.isTime)
            return ValueCategory.Time;
        else if (type.isDate)
            return ValueCategory.Date;
        else if (type.isLocation)
            return ValueCategory.Location;
        else
            return ValueCategory.Unknown;
    }

    export function fromValue(value : Ast.Value) : ValueCategory {
        if (value.isVarRef)
            return ValueCategory.Unknown;

        const type = value.getType();
        return fromType(type);
    }

    export function toAskSpecial(expected : ValueCategory|null) : string|null {
        let what;
        if (expected === ValueCategory.YesNo)
            what = 'yesno';
        else if (expected === ValueCategory.Location)
            what = 'location';
        else if (expected === ValueCategory.Picture)
            what = 'picture';
        else if (expected === ValueCategory.PhoneNumber)
            what = 'phone_number';
        else if (expected === ValueCategory.EmailAddress)
            what = 'email_address';
        else if (expected === ValueCategory.Contact)
            what = 'contact';
        else if (expected === ValueCategory.Number)
            what = 'number';
        else if (expected === ValueCategory.Date)
            what = 'date';
        else if (expected === ValueCategory.Time)
            what = 'time';
        else if (expected === ValueCategory.RawString)
            what = 'raw_string';
        else if (expected === ValueCategory.Password)
            what = 'password';
        else if (expected === ValueCategory.MultipleChoice)
            what = 'choice';
        else if (expected === ValueCategory.Command)
            what = 'command';
        else if (expected !== null)
            what = 'generic';
        else
            what = null;
        return what;
    }
}

1	// -- mode: typescript; indent-tabs-mode: nil; js-basic-offset: 4 --
2	//
3	// This file is part of Genie
4	//
5	// Copyright 2020 The Board of Trustees of the Leland Stanford Junior University
6	//
7	// Licensed under the Apache License, Version 2.0 (the "License");
8	// you may not use this file except in compliance with the License.
9	// You may obtain a copy of the License at
10	//
11	// http://www.apache.org/licenses/LICENSE-2.0
12	//
13	// Unless required by applicable law or agreed to in writing, software
14	// distributed under the License is distributed on an "AS IS" BASIS,
15	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16	// See the License for the specific language governing permissions and
17	// limitations under the License.
18	//
19	// Author: Giovanni Campagna <gcampagn@cs.stanford.edu>
20
21	import { Ast, Type } from 'thingtalk';	61✔
22
23	enum ValueCategory {	61✔
24	YesNo,	61✔
25	MultipleChoice,	61✔
26	Number,	61✔
27	Measure,	61✔
28	RawString,	61✔
29	Password,	61✔
30	Date,	61✔
31	Time,	61✔
32	Unknown,	61✔
33	Picture,	61✔
34	Location,	61✔
35	PhoneNumber,	61✔
36	EmailAddress,	61✔
37	Contact,	61✔
38	Command,	61✔
39	}
40	export default ValueCategory;	61✔
41
42	namespace ValueCategory {	61!
43	export function fromType(type : Type) : ValueCategory {	61✔
44	if (type instanceof Type.Entity && type.type === 'tt:picture')	9!
45	return ValueCategory.Picture;	×
46	else if (type instanceof Type.Entity && type.type === 'tt:phone_number')	9!
47	return ValueCategory.PhoneNumber;	×
48	else if (type instanceof Type.Entity && type.type === 'tt:email_address')	9!
49	return ValueCategory.EmailAddress;	×
50	else if (type instanceof Type.Entity && type.type === 'tt:contact')	9!
51	return ValueCategory.Contact;	×
52	else if (type instanceof Type.Entity)	9!
53	return ValueCategory.RawString;	×
54	else if (type.isBoolean)	9✔
55	return ValueCategory.YesNo;	4✔
56	else if (type.isString)	5✔
57	return ValueCategory.RawString;	4✔
58	else if (type.isNumber)	1!
59	return ValueCategory.Number;	×
60	else if (type.isMeasure)	1!
61	return ValueCategory.Measure;	×
62	else if (type.isEnum)	1!
63	return ValueCategory.RawString;	×
64	else if (type.isTime)	1!
65	return ValueCategory.Time;	×
66	else if (type.isDate)	1!
67	return ValueCategory.Date;	×
68	else if (type.isLocation)	1!
69	return ValueCategory.Location;	1✔
70	else
71	return ValueCategory.Unknown;	×
72	}
73
74	export function fromValue(value : Ast.Value) : ValueCategory {	61✔
UNCOV 75	if (value.isVarRef)	×
76	return ValueCategory.Unknown;	×
77
UNCOV 78	const type = value.getType();	×
UNCOV 79	return fromType(type);	×
80	}
81
82	export function toAskSpecial(expected : ValueCategory\|null) : string\|null {	61✔
83	let what;
84	if (expected === ValueCategory.YesNo)	124✔
85	what = 'yesno';	4✔
86	else if (expected === ValueCategory.Location)	120✔
87	what = 'location';	1✔
88	else if (expected === ValueCategory.Picture)	119!
89	what = 'picture';	×
90	else if (expected === ValueCategory.PhoneNumber)	119!
91	what = 'phone_number';	×
92	else if (expected === ValueCategory.EmailAddress)	119!
93	what = 'email_address';	×
94	else if (expected === ValueCategory.Contact)	119!
95	what = 'contact';	×
96	else if (expected === ValueCategory.Number)	119!
97	what = 'number';	×
98	else if (expected === ValueCategory.Date)	119!
99	what = 'date';	×
100	else if (expected === ValueCategory.Time)	119!
101	what = 'time';	×
102	else if (expected === ValueCategory.RawString)	119✔
103	what = 'raw_string';	4✔
104	else if (expected === ValueCategory.Password)	115!
105	what = 'password';	×
106	else if (expected === ValueCategory.MultipleChoice)	115!
107	what = 'choice';	×
108	else if (expected === ValueCategory.Command)	115✔
109	what = 'command';	16✔
110	else if (expected !== null)	99!
111	what = 'generic';	×
112	else
113	what = null;	99✔
114	return what;	124✔
115	}
116	}

stanford-oval / genie-toolkit / 1655

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous