526322995

Build Type

push

github

Committed by GitHub

Commit Message

fix: eslint errors around unused vars and return types (#63)

Run Details

457 of 697 branches covered (65.57%)

Branch coverage included in aggregate %.

6 of 8 new or added lines in 7 files covered. (75.0%)

7 existing lines in 2 files now uncovered.

1848 of 2174 relevant lines covered (85.0%)

23.12 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.88

/src/internal/common/measures/dimensions.ts

import { Dimensions as IDimensions, DimensionsPOJO, LengthUnit } from "../../../public";
import { error, SystemErrorCode } from "../errors";
import { hideAndFreeze, _internal } from "../utils";
import { Joi } from "../validation";

export class Dimensions implements IDimensions {
  public static readonly [_internal] = {
    label: "dimensions",
    schema: Joi.object({
      length: Joi.number().min(0).optional(),
      width: Joi.number().min(0).optional(),
      height: Joi.number().min(0).optional(),
      unit: Joi.string().enum(LengthUnit).required(),
    }),
  };

  public readonly length: number;
  public readonly width: number;
  public readonly height: number;
  public readonly unit: LengthUnit;

  public constructor(pojo: DimensionsPOJO) {

    this.length = pojo.length;
    this.width = pojo.width;
    this.height = pojo.height;
    this.unit = pojo.unit;

    // Check that at least two of the three dimensions properties are set. (Allows for 2 dimensional packages such as envelopes)
    const zeroCount = [this.length, this.width, this.height].reduce((totalCount, currentValue) => {
      if(!currentValue) {
        return totalCount + 1;
      }
      return totalCount;
    }, 0);

    if (zeroCount > 1) {
      const message = "Dimensions property must have at least 2 of the 3 length, width, and height properties set.";
      throw error(SystemErrorCode.InvalidInput, message);
    }

    // Make this object immutable
    hideAndFreeze(this);
  }

  public toInches(): Dimensions {
    const centimetersToInches = 0.393701;
    switch (this.unit) {
      case LengthUnit.Centimeters:
        return new Dimensions({
          length: this.length * centimetersToInches,
          width: this.width * centimetersToInches,
          height: this.height * centimetersToInches,
          unit: LengthUnit.Inches,
        });

      default:
        return this;
    }
  }

  public toCentimeters(): Dimensions {
    const inchesToCentimeters = 2.54;
    switch (this.unit) {
      case LengthUnit.Inches:
        return new Dimensions({
          length: this.length * inchesToCentimeters,
          width: this.width * inchesToCentimeters,
          height: this.height * inchesToCentimeters,
          unit: LengthUnit.Centimeters,
        });

      default:
        return this;
    }
  }
}

1	import { Dimensions as IDimensions, DimensionsPOJO, LengthUnit } from "../../../public";	1✔
2	import { error, SystemErrorCode } from "../errors";	1✔
3	import { hideAndFreeze, _internal } from "../utils";	1✔
4	import { Joi } from "../validation";	1✔
5
6	export class Dimensions implements IDimensions {	1✔
7	public static readonly [_internal] = {	1✔
8	label: "dimensions",
9	schema: Joi.object({
10	length: Joi.number().min(0).optional(),
11	width: Joi.number().min(0).optional(),
12	height: Joi.number().min(0).optional(),
13	unit: Joi.string().enum(LengthUnit).required(),
14	}),
15	};
16
17	public readonly length: number;
18	public readonly width: number;
19	public readonly height: number;
20	public readonly unit: LengthUnit;
21
22	public constructor(pojo: DimensionsPOJO) {
23
24	this.length = pojo.length;	3✔
25	this.width = pojo.width;	3✔
26	this.height = pojo.height;	3✔
27	this.unit = pojo.unit;	3✔
28
29	// Check that at least two of the three dimensions properties are set. (Allows for 2 dimensional packages such as envelopes)
30	const zeroCount = [this.length, this.width, this.height].reduce((totalCount, currentValue) => {	3✔
31	if(!currentValue) {	9✔
32	return totalCount + 1;	1✔
33	}
34	return totalCount;	8✔
35	}, 0);
36
37	if (zeroCount > 1) {	3!
38	const message = "Dimensions property must have at least 2 of the 3 length, width, and height properties set.";	×
39	throw error(SystemErrorCode.InvalidInput, message);	×
40	}
41
42	// Make this object immutable
43	hideAndFreeze(this);	3✔
44	}
45
46	public toInches(): Dimensions {
NEW 47	const centimetersToInches = 0.393701;	×
48	switch (this.unit) {	×
49	case LengthUnit.Centimeters:	×
UNCOV 50	return new Dimensions({	×
51	length: this.length * centimetersToInches,
52	width: this.width * centimetersToInches,
53	height: this.height * centimetersToInches,
54	unit: LengthUnit.Inches,
55	});
56
57	default:
58	return this;	×
59	}
60	}
61
62	public toCentimeters(): Dimensions {
NEW 63	const inchesToCentimeters = 2.54;	×
64	switch (this.unit) {	×
65	case LengthUnit.Inches:	×
UNCOV 66	return new Dimensions({	×
67	length: this.length * inchesToCentimeters,
68	width: this.width * inchesToCentimeters,
69	height: this.height * inchesToCentimeters,
70	unit: LengthUnit.Centimeters,
71	});
72
73	default:
74	return this;	×
75	}
76	}
77	}

ShipEngine / connect-sdk / 526322995

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous