mozillazg / go-httpheader / 21

Committed 21 Jan 2021 05:23PM UTC coverage: 83.333%. First build

Build # 21

Build Type

Pull #1

travis-ci

Committed by

web-flow

Commit Message

<a href="https://github.com/mozillazg/go-httpheader/commit/<a class=hub.com/mozillazg/go-httpheader/commit/<a class="double-link" href="https://git"><a class=hub.com/mozillazg/go-httpheader/commit/<a class="double-link" href="https://git"><a class=hub.com/mozillazg/go-httpheader/commit/<a class="double-link" href="https://git"><a class=hub.com/mozillazg/go-httpheader/commit/fa9e2f8af9c7f211fbf8ffb4664c5b5375c32747">fa9e2f8af">&lt;a href=&quot;https://github.com/mozillazg/go-httpheader/commit/</a><a class="double-link" href="https://github.com/mozillazg/go-httpheader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/mozillazg/go-httpheader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/mozillazg/go-httpheader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/mozillazg/go-httpheader/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/mozillazg/go-httpheader/commit/fa9e2f8af9c7f211fbf8ffb4664c5b5375c32747">fa9e2f8af</a><a href="https://github.com/mozillazg/go-httpheader/commit/fa9e2f8af9c7f211fbf8ffb4664c5b5375c32747">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/mozillazg/go-httpheader/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/mozillazg/go-httpheader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/mozillazg/go-httpheader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/mozillazg/go-httpheader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/mozillazg/go-httpheader/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/mozillazg/go-httpheader/commit/fa9e2f8af9c7f211fbf8ffb4664c5b5375c32747&quot;&gt;fa9e2f8af&lt;/a&gt;&lt;a href=&quot;https://github.com/mozillazg/go-httpheader/commit/fa9e2f8af9c7f211fbf8ffb4664c5b5375c32747&quot;&gt;&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/mozillazg/go-httpheader/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot... (continued)

Pull Request Pull Request #1: parse headers to struct using reflection tags

Run Details

59 of 59 new or added lines in 1 file covered. (100.0%)

150 of 180 relevant lines covered (83.33%)

80.2 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

59.32

/decode.go

package httpheader

import (
        "fmt"
        "net/http"
        "reflect"
        "strconv"
        "time"
)

var decoderType = reflect.TypeOf(new(Decoder)).Elem()

// Decoder is an interface implemented by any type that wishes to decode
// itself from Header fields in a non-standard way.
type Decoder interface {
        DecodeHeader(header http.Header, v interface{}) error
}

// DecodeHeader expects to be passed an http.Header and a struct, and parses
// header into the struct recursively using the same rules as Header (see above)
func DecodeHeader(header http.Header, v interface{}) error {
        val := reflect.ValueOf(v)
        for val.Kind() == reflect.Ptr {
                val = val.Elem()
        }

        if val.Kind() != reflect.Struct {
                return fmt.Errorf("val is not a struct %+v", val.Kind())
        }
        return parseValue(header, val)
}

func parseValue(header http.Header, val reflect.Value) error {
        typ := val.Type()
        for i := 0; i < typ.NumField(); i++ {
                sf := typ.Field(i)
                if sf.PkgPath != "" && !sf.Anonymous { // unexported
                        continue
                }

                sv := val.Field(i)
                tag := sf.Tag.Get(tagName)
                if tag == "-" {
                        continue
                }
                name, opts := parseTag(tag)
                if name == "" {
                        if sf.Anonymous && sv.Kind() == reflect.Struct {
                                continue
                        }
                        name = sf.Name
                }

                if opts.Contains("omitempty") && header.Get(name) == "" {
                        continue
                }

                if sv.Type().Implements(decoderType) {
                        if !reflect.Indirect(sv).IsValid() {
                                sv = reflect.New(sv.Type().Elem())
                        }

                        m := sv.Interface().(Decoder)
                        if err := m.DecodeHeader(header, &val); err != nil {
                                return err
                        }
                        continue
                }

                // TODO: implement iterating over multiple Headers with the same name such as `Cooke:` or `Server:`
                // if sv.Kind() == reflect.Slice || sv.Kind() == reflect.Array {
                //         for k, v := range header[name] {

                //         }
                //         continue
                // }

                for sv.Kind() == reflect.Ptr {
                        sv = sv.Elem()
                }

                if sv.Type() == timeType {
                        h := header.Get(name)
                        t, err := time.Parse(time.RFC1123, h)
                        if err != nil {
                                return err
                        }
                        sv.Set(reflect.ValueOf(t))
                        continue
                }

                if sv.Kind() == reflect.Struct {
                        parseValue(header, sv)
                        continue
                }

                if sv.Kind() == reflect.Int {
                        j, err := strconv.Atoi(header.Get(name))
                        if err != nil {
                                return err
                        }
                        sv.SetInt(int64(j))
                }

                if sv.Kind() == reflect.String {
                        sv.SetString(header.Get(name))
                }
        }
        return nil
}

1	package httpheader
2
3	import (
4	"fmt"
5	"net/http"
6	"reflect"
7	"strconv"
8	"time"
9	)
10
11	var decoderType = reflect.TypeOf(new(Decoder)).Elem()
12
13	// Decoder is an interface implemented by any type that wishes to decode
14	// itself from Header fields in a non-standard way.
15	type Decoder interface {
16	DecodeHeader(header http.Header, v interface{}) error
17	}
18
19	// DecodeHeader expects to be passed an http.Header and a struct, and parses
20	// header into the struct recursively using the same rules as Header (see above)
21	func DecodeHeader(header http.Header, v interface{}) error {	18✔
22	val := reflect.ValueOf(v)	18✔
23	for val.Kind() == reflect.Ptr {	36✔
24	val = val.Elem()	18✔
25	}	18✔
26
27	if val.Kind() != reflect.Struct {	18✔
28	return fmt.Errorf("val is not a struct %+v", val.Kind())	×
29	}	×
30	return parseValue(header, val)	18✔
31	}
32
33	func parseValue(header http.Header, val reflect.Value) error {	18✔
34	typ := val.Type()	18✔
35	for i := 0; i < typ.NumField(); i++ {	144✔
36	sf := typ.Field(i)	126✔
37	if sf.PkgPath != "" && !sf.Anonymous { // unexported	126✔
38	continue	×
39	}
40
41	sv := val.Field(i)	126✔
42	tag := sf.Tag.Get(tagName)	126✔
43	if tag == "-" {	126✔
44	continue	×
45	}
46	name, opts := parseTag(tag)	126✔
47	if name == "" {	126✔
48	if sf.Anonymous && sv.Kind() == reflect.Struct {	×
49	continue	×
50	}
51	name = sf.Name	×
52	}
53
54	if opts.Contains("omitempty") && header.Get(name) == "" {	126✔
55	continue	×
56	}
57
58	if sv.Type().Implements(decoderType) {	126✔
59	if !reflect.Indirect(sv).IsValid() {	×
60	sv = reflect.New(sv.Type().Elem())	×
61	}	×
62
63	m := sv.Interface().(Decoder)	×
64	if err := m.DecodeHeader(header, &val); err != nil {	×
65	return err	×
66	}	×
67	continue	×
68	}
69
70	// TODO: implement iterating over multiple Headers with the same name such as `Cooke:` or `Server:`
71	// if sv.Kind() == reflect.Slice \|\| sv.Kind() == reflect.Array {
72	// for k, v := range header[name] {
73
74	// }
75	// continue
76	// }
77
78	for sv.Kind() == reflect.Ptr {	126✔
79	sv = sv.Elem()	×
80	}	×
81
82	if sv.Type() == timeType {	144✔
83	h := header.Get(name)	18✔
84	t, err := time.Parse(time.RFC1123, h)	18✔
85	if err != nil {	18✔
86	return err	×
87	}	×
88	sv.Set(reflect.ValueOf(t))	18✔
89	continue	18✔
90	}
91
92	if sv.Kind() == reflect.Struct {	108✔
93	parseValue(header, sv)	×
94	continue	×
95	}
96
97	if sv.Kind() == reflect.Int {	126✔
98	j, err := strconv.Atoi(header.Get(name))	18✔
99	if err != nil {	18✔
100	return err	×
101	}	×
102	sv.SetInt(int64(j))	18✔
103	}
104
105	if sv.Kind() == reflect.String {	198✔
106	sv.SetString(header.Get(name))	90✔
107	}	90✔
108	}
109	return nil	18✔
110	}

mozillazg / go-httpheader / 21

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous