480194166

Build # 480194166

Build Type

github

Committed by GitHub

Commit Message

Merge 1ab63b5af into 022a51f71

Pull Request Pull Request #1003: Fix 986 restore code coverage gate passing unit

Run Details

1314 of 3642 branches covered (36.08%)

Branch coverage included in aggregate %.

17 of 43 new or added lines in 4 files covered. (39.53%)

3138 existing lines in 160 files now uncovered.

4965 of 12149 relevant lines covered (40.87%)

5600.46 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.75

/Zilon.Core/Zilon.Core/Tactics/Behaviour/AttackTask.cs

﻿using System;
using System.Collections.Generic;
using System.Linq;

using Zilon.Core.Components;
using Zilon.Core.Graphs;
using Zilon.Core.PersonModules;
using Zilon.Core.Persons;

namespace Zilon.Core.Tactics.Behaviour
{
    public class AttackTask : OneTurnActorTaskBase
    {
        private readonly ITacticalActUsageService _actService;

        public AttackTask(IActor actor,
            IActorTaskContext context,
            IAttackTarget target,
            ITacticalAct tacticalAct,
            ITacticalActUsageService actService) :
            base(actor, context)
        {
            _actService = actService;

            TargetObject = target ?? throw new ArgumentNullException(nameof(target));
            TacticalAct = tacticalAct ?? throw new ArgumentNullException(nameof(tacticalAct));

            TargetNode = target.Node;
        }

        public ITacticalAct TacticalAct { get; }

        public IGraphNode TargetNode { get; }

        public IAttackTarget TargetObject { get; }

        protected override void ExecuteTask()
        {
            if (Actor.Person.GetModuleSafe<ICombatActModule>() is null)
            {
                throw new NotImplementedException("Не неализована возможность атаковать без навыков.");
            }

            if (!TargetObject.CanBeDamaged())
            {
                // Эта ситуация может произойти, когда:
                // 1. Текущий актёр начал выполнять задачу.
                // 2. Цель убили/умерла сама.
                // 3. Наступил момент, когда задача текущего актёра должна выполниться.

                // Эту првоерку нужно проводить выше, когда пользователю сообщаяется возможность
                // выполнить эту задачу до её начала.
                return;
            }

            var availableSlotAct = GetSecondaryUsedActs();

            var primary = new[] { TacticalAct };
            var secondary = availableSlotAct.Where(x => x != TacticalAct).Skip(1).ToArray();

            var usedActs = new UsedTacticalActs(primary, secondary);

            var actTargetInfo = new ActTargetInfo(TargetObject, TargetNode);

            _actService.UseOn(Actor, actTargetInfo, usedActs, Context.Sector);
        }

        private IEnumerable<ITacticalAct> GetSecondaryUsedActs()
        {
            var equipmentModule = Actor.Person.GetModuleSafe<IEquipmentModule>();
            var combatActModule = Actor.Person.GetModule<ICombatActModule>();
            var currentActs = combatActModule.CalcCombatActs();

            if (equipmentModule == null)
            {
                // If person has not equipment, the has only one default action in current moment. Use it.
                yield return currentActs.Single();
            }
            else
            {
                var usedEquipmentActs = false;
                var slots = equipmentModule.Slots;
                for (var i = 0; i < slots.Length; i++)
                {
                    var slotEquipment = equipmentModule[i];
                    if (slotEquipment == null)
                    {
                        continue;
                    }

                    if ((slots[i].Types & EquipmentSlotTypes.Hand) == 0)
                    {
                        continue;
                    }

                    var equipmentActs = from act in currentActs
                                        where act.Equipment == slotEquipment
                                        select act;

                    var usedAct = equipmentActs.FirstOrDefault();

                    if (usedAct != null)
                    {
                        usedEquipmentActs = true;

                        yield return usedAct;
                    }
                }

                if (!usedEquipmentActs)
                {
                    // If no equipment was selected then use default act. Each person has only one default act in current moment.
                    yield return currentActs.Single();
                }
            }
        }
    }
}

1	using System;
2	using System.Collections.Generic;
3	using System.Linq;
4
5	using Zilon.Core.Components;
6	using Zilon.Core.Graphs;
7	using Zilon.Core.PersonModules;
8	using Zilon.Core.Persons;
9
10	namespace Zilon.Core.Tactics.Behaviour
11	{
12	public class AttackTask : OneTurnActorTaskBase
13	{
14	private readonly ITacticalActUsageService _actService;
15
16	public AttackTask(IActor actor,
17	IActorTaskContext context,
18	IAttackTarget target,
19	ITacticalAct tacticalAct,
20	ITacticalActUsageService actService) :
21	base(actor, context)	164✔
22	{	164✔
23	_actService = actService;	164✔
24
25	TargetObject = target ?? throw new ArgumentNullException(nameof(target));	164!
26	TacticalAct = tacticalAct ?? throw new ArgumentNullException(nameof(tacticalAct));	164!
27
28	TargetNode = target.Node;	164✔
29	}	164✔
30
31	public ITacticalAct TacticalAct { get; }	314✔
32
33	public IGraphNode TargetNode { get; }	156✔
34
35	public IAttackTarget TargetObject { get; }	313✔
36
37	protected override void ExecuteTask()
38	{	156✔
39	if (Actor.Person.GetModuleSafe<ICombatActModule>() is null)	156!
UNCOV 40	{	×
UNCOV 41	throw new NotImplementedException("Не неализована возможность атаковать без навыков.");	×
42	}
43
44	if (!TargetObject.CanBeDamaged())	156!
45	{	×
46	// Эта ситуация может произойти, когда:
47	// 1. Текущий актёр начал выполнять задачу.
48	// 2. Цель убили/умерла сама.
49	// 3. Наступил момент, когда задача текущего актёра должна выполниться.
50
51	// Эту првоерку нужно проводить выше, когда пользователю сообщаяется возможность
52	// выполнить эту задачу до её начала.
53	return;	×
54	}
55
56	var availableSlotAct = GetSecondaryUsedActs();	156✔
57
58	var primary = new[] { TacticalAct };	156✔
59	var secondary = availableSlotAct.Where(x => x != TacticalAct).Skip(1).ToArray();	314✔
60
61	var usedActs = new UsedTacticalActs(primary, secondary);	156✔
62
63	var actTargetInfo = new ActTargetInfo(TargetObject, TargetNode);	156✔
64
65	_actService.UseOn(Actor, actTargetInfo, usedActs, Context.Sector);	156✔
66	}	156✔
67
68	private IEnumerable<ITacticalAct> GetSecondaryUsedActs()
69	{	156✔
70	var equipmentModule = Actor.Person.GetModuleSafe<IEquipmentModule>();	156✔
71	var combatActModule = Actor.Person.GetModule<ICombatActModule>();	156✔
72	var currentActs = combatActModule.CalcCombatActs();	156✔
73
74	if (equipmentModule == null)	156✔
75	{	12✔
76	// If person has not equipment, the has only one default action in current moment. Use it.
77	yield return currentActs.Single();	12✔
78	}	12✔
79	else
80	{	144✔
81	var usedEquipmentActs = false;	144✔
82	var slots = equipmentModule.Slots;	144✔
83	for (var i = 0; i < slots.Length; i++)	2,304✔
84	{	1,008✔
85	var slotEquipment = equipmentModule[i];	1,008✔
86	if (slotEquipment == null)	1,008✔
87	{	995✔
88	continue;	995✔
89	}
90
91	if ((slots[i].Types & EquipmentSlotTypes.Hand) == 0)	13!
UNCOV 92	{	×
UNCOV 93	continue;	×
94	}
95
96	var equipmentActs = from act in currentActs	×
97	where act.Equipment == slotEquipment	26✔
98	select act;	×
99
100	var usedAct = equipmentActs.FirstOrDefault();	13✔
101
102	if (usedAct != null)	13✔
103	{	11✔
104	usedEquipmentActs = true;	11✔
105
106	yield return usedAct;	11✔
107	}	11✔
108	}	13✔
109
110	if (!usedEquipmentActs)	144✔
111	{	135✔
112	// If no equipment was selected then use default act. Each person has only one default act in current moment.
113	yield return currentActs.Single();	135✔
114	}	135✔
115	}	144✔
116	}	156✔
117	}
118	}

kreghek / Zilon_Roguelike / 480194166

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous