zf-fr / zfr-cors / 50

pending completion

Build # 50

Build Type

Pull #16

travis-ci

Committed by

weierophinney

Commit Message

Better response handling

- In cases where the application may inject a new response in the
  MvcEvent, we can end up with a situation where the response no longer
  has the specified CORS headers -- which leads to invalid responses,
  and the client initiating the CORS request to fail.

  These changes push inflight CORS request detection to the "finish"
  event, which ensures we can inject the headers on the actual response
  object we plan to return to the client.

  Preflight requests are still handled during the "route" event. An
  internal state flag is set in the listener so that the later, inflight
  listener can quit early.

Pull Request Pull Request #16: Better response handling

Run Details

110 of 112 relevant lines covered (98.21%)

10.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.59

/ZfrCors/Mvc/CorsRequestListener.php

Build SHA Not Found

The commit SHA "96e966d82c82613e2c0fafa6939ff853b9090bb5" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

zf-fr / zfr-cors / 50

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous