274348942

Build Type

push

github

Committed by Unrud

Commit Message

Improve log messages

Run Details

1211 of 1559 branches covered (77.68%)

Branch coverage included in aggregate %.

1 of 12 new or added lines in 9 files covered. (8.33%)

37 existing lines in 5 files now uncovered.

2900 of 3438 relevant lines covered (84.35%)

15.17 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.73

/radicale/app/mkcalendar.py

# This file is part of Radicale Server - Calendar Server
# Copyright © 2008 Nicolas Kandel
# Copyright © 2008 Pascal Halter
# Copyright © 2008-2017 Guillaume Ayoub
# Copyright © 2017-2018 Unrud <unrud@outlook.com>
#
# This library is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Radicale.  If not, see <http://www.gnu.org/licenses/>.

import posixpath
import socket
from http import client

from radicale import httputils
from radicale import item as radicale_item
from radicale import pathutils, storage, xmlutils
from radicale.log import logger


class ApplicationMkcalendarMixin:
    def do_MKCALENDAR(self, environ, base_prefix, path, user):
        """Manage MKCALENDAR request."""
        if "w" not in self._rights.authorization(user, path):
            return httputils.NOT_ALLOWED
        try:
            xml_content = self._read_xml_request_body(environ)
        except RuntimeError as e:
            logger.warning(
                "Bad MKCALENDAR request on %r: %s", path, e, exc_info=True)
            return httputils.BAD_REQUEST
        except socket.timeout:
            logger.debug("Client timed out", exc_info=True)
            return httputils.REQUEST_TIMEOUT
        # Prepare before locking
        props = xmlutils.props_from_request(xml_content)
        props = {k: v for k, v in props.items() if v is not None}
        props["tag"] = "VCALENDAR"
        # TODO: use this?
        # timezone = props.get("C:calendar-timezone")
        try:
            radicale_item.check_and_sanitize_props(props)
        except ValueError as e:
            logger.warning(
                "Bad MKCALENDAR request on %r: %s", path, e, exc_info=True)
        with self._storage.acquire_lock("w", user):
            item = next(self._storage.discover(path), None)
            if item:
                return self._webdav_error_response(
                    client.CONFLICT, "D:resource-must-be-null")
            parent_path = pathutils.unstrip_path(
                posixpath.dirname(pathutils.strip_path(path)), True)
            parent_item = next(self._storage.discover(parent_path), None)
            if not parent_item:
                return httputils.CONFLICT
            if (not isinstance(parent_item, storage.BaseCollection) or
                    parent_item.get_meta("tag")):
                return httputils.FORBIDDEN
            try:
                self._storage.create_collection(path, props=props)
            except ValueError as e:
                logger.warning(
                    "Bad MKCALENDAR request on %r: %s", path, e, exc_info=True)
                return httputils.BAD_REQUEST
            return client.CREATED, {}, None

1	# This file is part of Radicale Server - Calendar Server
2	# Copyright © 2008 Nicolas Kandel
3	# Copyright © 2008 Pascal Halter
4	# Copyright © 2008-2017 Guillaume Ayoub
5	# Copyright © 2017-2018 Unrud <unrud@outlook.com>
6	#
7	# This library is free software: you can redistribute it and/or modify
8	# it under the terms of the GNU General Public License as published by
9	# the Free Software Foundation, either version 3 of the License, or
10	# (at your option) any later version.
11	#
12	# This library is distributed in the hope that it will be useful,
13	# but WITHOUT ANY WARRANTY; without even the implied warranty of
14	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15	# GNU General Public License for more details.
16	#
17	# You should have received a copy of the GNU General Public License
18	# along with Radicale. If not, see <http://www.gnu.org/licenses/>.
19
20	import posixpath	18✔
21	import socket	18✔
22	from http import client	18✔
23
24	from radicale import httputils	18✔
25	from radicale import item as radicale_item	18✔
26	from radicale import pathutils, storage, xmlutils	18✔
27	from radicale.log import logger	18✔
28
29
30	class ApplicationMkcalendarMixin:	18✔
31	def do_MKCALENDAR(self, environ, base_prefix, path, user):	18✔
32	"""Manage MKCALENDAR request."""
33	if "w" not in self._rights.authorization(user, path):	18✔
34	return httputils.NOT_ALLOWED	18✔
35	try:	18✔
36	xml_content = self._read_xml_request_body(environ)	18✔
37	except RuntimeError as e:	×
38	logger.warning(	×
39	"Bad MKCALENDAR request on %r: %s", path, e, exc_info=True)
40	return httputils.BAD_REQUEST	×
41	except socket.timeout:	×
NEW 42	logger.debug("Client timed out", exc_info=True)	×
43	return httputils.REQUEST_TIMEOUT	×
44	# Prepare before locking
45	props = xmlutils.props_from_request(xml_content)	18✔
46	props = {k: v for k, v in props.items() if v is not None}	18✔
47	props["tag"] = "VCALENDAR"	18✔
48	# TODO: use this?
49	# timezone = props.get("C:calendar-timezone")
50	try:	18✔
51	radicale_item.check_and_sanitize_props(props)	18✔
52	except ValueError as e:	×
UNCOV 53	logger.warning(	×
54	"Bad MKCALENDAR request on %r: %s", path, e, exc_info=True)
55	with self._storage.acquire_lock("w", user):	18✔
56	item = next(self._storage.discover(path), None)	18✔
57	if item:	18✔
58	return self._webdav_error_response(	18✔
59	client.CONFLICT, "D:resource-must-be-null")
60	parent_path = pathutils.unstrip_path(	18✔
61	posixpath.dirname(pathutils.strip_path(path)), True)
62	parent_item = next(self._storage.discover(parent_path), None)	18✔
63	if not parent_item:	18✔
64	return httputils.CONFLICT	18✔
65	if (not isinstance(parent_item, storage.BaseCollection) or	18!
66	parent_item.get_meta("tag")):
UNCOV 67	return httputils.FORBIDDEN	×
68	try:	18✔
69	self._storage.create_collection(path, props=props)	18✔
70	except ValueError as e:	×
UNCOV 71	logger.warning(	×
72	"Bad MKCALENDAR request on %r: %s", path, e, exc_info=True)
UNCOV 73	return httputils.BAD_REQUEST	×
74	return client.CREATED, {}, None	18✔

Kozea / Radicale / 274348942

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous