2805

pending completion

Build # 2805

Build Type

Pull #763

travis-ci-com

Committed by

web-flow

Commit Message

<a href="https://github.com/w3c/echidna/commit/<a class=hub.com/w3c/echidna/commit/d8c7311a3f626cddfac5c018b2011e962acbbe18">d8c7311a3<a href="https://github.com/w3c/echidna/commit/d8c7311a3f626cddfac5c018b2011e962acbbe18">">Merge </a><a class="double-link" href="https://github.com/w3c/echidna/commit/<a class="double-link" href="https://github.com/w3c/echidna/commit/306d9a7adab36870275a4141b045d5ef4f3f0f62">306d9a7ad</a>">306d9a7ad</a><a href="https://github.com/w3c/echidna/commit/d8c7311a3f626cddfac5c018b2011e962acbbe18"> into bd411ad29">bd411ad29</a>

Pull Request Pull Request #763: process 2020: no need for the editorial parameter anymore

Run Details

132 of 1143 branches covered (11.55%)

9 of 9 new or added lines in 3 files covered. (100.0%)

402 of 1251 relevant lines covered (32.13%)

3.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

6.02

/lib/transition-checker.js

/**
 * @file Check if the state of document can be transfered, relayed on issue and comments in [w3c/transitions](https://github.com/w3c/transitions)
 */
'use strict';

var List = require('immutable').List;
var Octokat = require('octokat');

/**
 * @exports lib/transition-checker
 */

var TransitionChecker = {};

/**
 * @returns {Promise.<List.<String>>}
 */

/**
 * @description Check if the document can be transfered. Accounting:
 * - Getting Issues in [w3c/transitions](https://github.com/w3c/transitions) and check the comments.
 * - directorApproval: [request-a-transition-request](https://github.com/w3c/echidna/wiki/CR-publication-workflow#request-a-transition-request)
 * - commApproval: [draft-announcement-to-the-members](https://github.com/w3c/echidna/wiki/CR-publication-workflow#draft-announcement-to-the-members)
 * @param {*} profile
 * @param {*} latestVersion
 * @param {*} previousVersion
 * @param {*} isUpdate
 */
TransitionChecker.check = function (profile, latestVersion, previousVersion, isUpdate) {
  return new Promise(function (resolve, reject) {
    var errors = new List();

    if (profile === 'WD' || profile === 'WG-NOTE' || profile === 'IG-NOTE' || isUpdate) {
      resolve({ errors: errors, requiresCfE: false });
    }
    else if (profile === 'CR') {
      if (previousVersion.includes('/WD-') || previousVersion.includes('/CR-') || (previousVersion.includes('/CRD-'))) {
        var octo = new Octokat({
          token: global.GH_TOKEN
        });
        var repo = octo.repos('w3c', 'transitions');

        var shortname = latestVersion.match(new RegExp(/.*\/([^/]+)\/$/))[1];
        var directorApproval = 'transition approved.';
        var commApproval = 'draft transition approved.';
        var directorApprovalFound = false;
        var commApprovalFound = false;
        var issueFound = false;
        var issueNumber;

        repo.issues.fetch(
          {
            labels: 'Awaiting Publication',
            state: 'open',
            sort: 'updated',
            per_page: 100 // TODO: get all the issues, not just the first 100
          })
        .then((content) => {
          for (var issue of content.items) {
            if (issue.title.endsWith(' ' + shortname)) {
              issueFound = true;
              issueNumber = issue.number;
              repo.issues(issue.number).comments.fetch()
              .then((comments) => {
                var promises = [];

                for (var comment of comments.items) {
                  if (comment.body.toLowerCase().startsWith(directorApproval)) {
                    // Director's approval
                    var p1 = octo.teams(global.GH_DIRECTOR_TEAM_ID).members(comment.user.login).fetch((err) => {
                      if (!err) directorApprovalFound = true;
                    });

                    promises.push(p1);
                  }
                  else if (comment.body.toLowerCase().startsWith(commApproval)) {
                    // Comm's approval
                    var p2 = octo.teams(global.GH_COMM_TEAM_ID).members(comment.user.login).fetch((err) => {
                      if (!err) commApprovalFound = true;
                    });

                    promises.push(p2);
                  }
                }
                Promise.all(promises).then(function () {
                  if (!directorApprovalFound) errors = errors.push('Approval from Director not found.');
                  if (!commApprovalFound) errors = errors.push('Approval from Communication Team not found.');
                  if (directorApprovalFound && commApprovalFound) {
                    // Close issue
                    repo.issues(issueNumber).update({ state: 'closed' });
                  }
                  return resolve({ errors: errors, requiresCfE: true });
                });
              });
            }
          }
          if (!issueFound) {
            // Issue not found
            return reject(new Error('Issue not found on the github repository w3c/transitions. Make sure all the requirements are met: https://github.com/w3c/echidna/wiki/CR-publication-workflow#request-a-transition-request'));
          }
        })
        .catch(function (error) {
          return reject(new Error('An error occured while looking for the transition issue: ' + error));
        });
      }
    } else if (profile === 'CRD') {
      return resolve({ errors: errors, requiresCfE: false });
    }
    else
      reject(new Error('Only WD, CR and Notes are allowed!'));
  });
};

module.exports = TransitionChecker;

1	/**
2	* @file Check if the state of document can be transfered, relayed on issue and comments in [w3c/transitions](https://github.com/w3c/transitions)
3	*/
4	'use strict';
5
6	var List = require('immutable').List;	2✔
7	var Octokat = require('octokat');	2✔
8
9	/**
10	* @exports lib/transition-checker
11	*/
12
13	var TransitionChecker = {};	2✔
14
15	/**
16	* @returns {Promise.<List.<String>>}
17	*/
18
19	/**
20	* @description Check if the document can be transfered. Accounting:
21	* - Getting Issues in [w3c/transitions](https://github.com/w3c/transitions) and check the comments.
22	* - directorApproval: [request-a-transition-request](https://github.com/w3c/echidna/wiki/CR-publication-workflow#request-a-transition-request)
23	* - commApproval: [draft-announcement-to-the-members](https://github.com/w3c/echidna/wiki/CR-publication-workflow#draft-announcement-to-the-members)
24	* @param {*} profile
25	* @param {*} latestVersion
26	* @param {*} previousVersion
27	* @param {*} isUpdate
28	*/
29	TransitionChecker.check = function (profile, latestVersion, previousVersion, isUpdate) {	2✔
30	return new Promise(function (resolve, reject) {	×
31	var errors = new List();	×
32
33	if (profile === 'WD' \|\| profile === 'WG-NOTE' \|\| profile === 'IG-NOTE' \|\| isUpdate) {	×
34	resolve({ errors: errors, requiresCfE: false });	×
35	}
36	else if (profile === 'CR') {	×
37	if (previousVersion.includes('/WD-') \|\| previousVersion.includes('/CR-') \|\| (previousVersion.includes('/CRD-'))) {	×
38	var octo = new Octokat({	×
39	token: global.GH_TOKEN
40	});
41	var repo = octo.repos('w3c', 'transitions');	×
42
43	var shortname = latestVersion.match(new RegExp(/.*\/([^/]+)\/$/))[1];	×
44	var directorApproval = 'transition approved.';	×
45	var commApproval = 'draft transition approved.';	×
46	var directorApprovalFound = false;	×
47	var commApprovalFound = false;	×
48	var issueFound = false;	×
49	var issueNumber;	×
50
51	repo.issues.fetch(	×
52	{
53	labels: 'Awaiting Publication',
54	state: 'open',
55	sort: 'updated',
56	per_page: 100 // TODO: get all the issues, not just the first 100
57	})
58	.then((content) => {
59	for (var issue of content.items) {	×
60	if (issue.title.endsWith(' ' + shortname)) {	×
61	issueFound = true;	×
62	issueNumber = issue.number;	×
63	repo.issues(issue.number).comments.fetch()	×
64	.then((comments) => {
65	var promises = [];	×
66
67	for (var comment of comments.items) {	×
68	if (comment.body.toLowerCase().startsWith(directorApproval)) {	×
69	// Director's approval
70	var p1 = octo.teams(global.GH_DIRECTOR_TEAM_ID).members(comment.user.login).fetch((err) => {	×
71	if (!err) directorApprovalFound = true;	×
72	});
73
74	promises.push(p1);	×
75	}
76	else if (comment.body.toLowerCase().startsWith(commApproval)) {	×
77	// Comm's approval
78	var p2 = octo.teams(global.GH_COMM_TEAM_ID).members(comment.user.login).fetch((err) => {	×
79	if (!err) commApprovalFound = true;	×
80	});
81
82	promises.push(p2);	×
83	}
84	}
85	Promise.all(promises).then(function () {	×
86	if (!directorApprovalFound) errors = errors.push('Approval from Director not found.');	×
87	if (!commApprovalFound) errors = errors.push('Approval from Communication Team not found.');	×
88	if (directorApprovalFound && commApprovalFound) {	×
89	// Close issue
90	repo.issues(issueNumber).update({ state: 'closed' });	×
91	}
92	return resolve({ errors: errors, requiresCfE: true });	×
93	});
94	});
95	}
96	}
97	if (!issueFound) {	×
98	// Issue not found
99	return reject(new Error('Issue not found on the github repository w3c/transitions. Make sure all the requirements are met: https://github.com/w3c/echidna/wiki/CR-publication-workflow#request-a-transition-request'));	×
100	}
101	})
102	.catch(function (error) {
103	return reject(new Error('An error occured while looking for the transition issue: ' + error));	×
104	});
105	}
106	} else if (profile === 'CRD') {	×
107	return resolve({ errors: errors, requiresCfE: false });	×
108	}
109	else
110	reject(new Error('Only WD, CR and Notes are allowed!'));	×
111	});
112	};
113
114	module.exports = TransitionChecker;	2✔

w3c / echidna / 2805

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous