zendframework / zend-inputfilter / 47

pending completion

Build # 47

Build Type

Pull #18

travis-ci

Committed by

Maks3w

Commit Message

BaseInputFilter::add() does not allow all input types defined in the interface contract

InputFlterInterface::add() specify array (input specification format) as an allowed type for $input. BaseInputFilter::add() throws exception for this case.

This commit promote the logic present in InputFilter (now deprecated) to BaseInputFilter so this one become compatible with Interface contract.

Since InputFilter allow too Traversable object and Factory (underlying logic) allows InputProviderInterface objects then I decided promote all this types to Interface.

With this change add too many allowed types is the only one way for to do this change preserving the backward compatibility.

Pull Request Pull Request #18: Deprecate InputFilter and fix BaseInputFilter::add() contract violation

Run Details

15 of 15 new or added lines in 1 file covered. (100.0%)

670 of 791 relevant lines covered (84.7%)

24.85 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.47

/src/BaseInputFilter.php

Build SHA Not Found

The commit SHA "2ad7cd8afa402ec5bd2000dc2498b84757a65a9e" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

zendframework / zend-inputfilter / 47

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous