ministryofjustice / bootstrap-salt / 402

pending completion

Build # 402

Build Type

push

travis-ci

Committed by

ashb

Commit Message

When building the tar for upload resolve symlinks, don't copy them

Using `cp` was causing us problems when we run the task on linux where
it's `cp` behaves differently to OSX when it encounters symlinks. OSX
was copying the symlink contents, linux was copying the symlink itself.

Rather than having to detect the OS and invoke cp differently ourselves
the shutils module in the python standard library has a copytree
function that has a `symlink` arg that when set to False gives us the
behaviour we want: to copy the symlink as if it was a normal directory,
rather than copy the symlink as a symlink.

This means that the tar file we generate contains just the formula
folders directly in /srv/salt-formulas, so we also specify the file_root
config for salt minion so that the directory overlaying works properly
rather than mashing thing from the formulas on top of the local salt/
tree (which would reverse the precedence so that files from the formulas
would be used over files in salt/)

Run Details

321 of 570 relevant lines covered (56.32%)

0.56 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

37.58

/bootstrap_salt/fab_tasks.py

Build SHA Not Found

The commit SHA "5dd2894925580378bc268699f31b6e635d54e96e" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

ministryofjustice / bootstrap-salt / 402

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous