1109

pending completion

Build # 1109

Build Type

Pull #254

travis-ci-com

Committed by

web-flow

Commit Message

Merge 58d3fc657 into 65b4e469a

Pull Request Pull Request #254: Making the Spotify skill work

Run Details

8202 of 15366 branches covered (53.38%)

Branch coverage included in aggregate %.

173 of 213 new or added lines in 16 files covered. (81.22%)

38 existing lines in 8 files now uncovered.

14503 of 22455 relevant lines covered (64.59%)

1517322.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

8.93

/languages/thingtalk/dialogue_acts/related-questions.js

// -*- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 -*-
//
// This file is part of Genie
//
// Copyright 2020 The Board of Trustees of the Leland Stanford Junior University
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//    http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Author: Giovanni Campagna <gcampagn@cs.stanford.edu>
"use strict";

const assert = require('assert');

const C = require('../ast_manip');

const {
    addQuery,
} = require('../state_manip');
const {
    findOrMakeFilterTable,
    refineFilterToAnswerQuestion,
} = require('./refinement-helpers');

function relatedQuestion(ctx, stmt) {
    const currentTable = ctx.current.stmt.table;

    if (!stmt.isCommand || !stmt.table)
        return null;
    if (stmt.actions.some((a) => !a.isNotify))
        return null;
    let newTable = stmt.table;
    if (!newTable.schema.class)
        return null;

    if (C.isSameFunction(currentTable.schema, newTable.schema))
        return null;
    let functionName = newTable.schema.class.kind + ':' + newTable.schema.name;
    const related = currentTable.schema.getAnnotation('related');
    if (!related.includes(functionName))
        return null;

    if (!C.checkValidQuery(stmt.table))
        return null;

    let ctxFilterTable, newFilterTable;
    [newTable, newFilterTable] = findOrMakeFilterTable(newTable.clone());
    if (newFilterTable === null)
        return null;
    assert(newFilterTable.isFilter);
    if (!newFilterTable.table.isInvocation)
        return null;

    ctxFilterTable = C.findFilterTable(currentTable);

    if (ctxFilterTable) {
        const newFilter = refineFilterToAnswerQuestion(ctxFilterTable.filter, newFilterTable.filter);
        if (newFilter === null)
            return null;
        newFilterTable.filter = newFilter;
    }

    return addQuery(ctx, 'execute', newTable, 'accepted');
}

module.exports = {
    relatedQuestion,
};

1	// -- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 --
2	//
3	// This file is part of Genie
4	//
5	// Copyright 2020 The Board of Trustees of the Leland Stanford Junior University
6	//
7	// Licensed under the Apache License, Version 2.0 (the "License");
8	// you may not use this file except in compliance with the License.
9	// You may obtain a copy of the License at
10	//
11	// http://www.apache.org/licenses/LICENSE-2.0
12	//
13	// Unless required by applicable law or agreed to in writing, software
14	// distributed under the License is distributed on an "AS IS" BASIS,
15	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16	// See the License for the specific language governing permissions and
17	// limitations under the License.
18	//
19	// Author: Giovanni Campagna <gcampagn@cs.stanford.edu>
20	"use strict";
21
22	const assert = require('assert');	3✔
23
24	const C = require('../ast_manip');	3✔
25
26	const {
27	addQuery,
28	} = require('../state_manip');	3✔
29	const {
30	findOrMakeFilterTable,
31	refineFilterToAnswerQuestion,
32	} = require('./refinement-helpers');	3✔
33
34	function relatedQuestion(ctx, stmt) {
UNCOV 35	const currentTable = ctx.current.stmt.table;	×
36
UNCOV 37	if (!stmt.isCommand \|\| !stmt.table)	×
38	return null;	×
UNCOV 39	if (stmt.actions.some((a) => !a.isNotify))	×
40	return null;	×
UNCOV 41	let newTable = stmt.table;	×
NEW 42	if (!newTable.schema.class)	×
UNCOV 43	return null;	×
44
NEW 45	if (C.isSameFunction(currentTable.schema, newTable.schema))	×
46	return null;	×
NEW 47	let functionName = newTable.schema.class.kind + ':' + newTable.schema.name;	×
UNCOV 48	const related = currentTable.schema.getAnnotation('related');	×
NEW 49	if (!related.includes(functionName))	×
UNCOV 50	return null;	×
51
NEW 52	if (!C.checkValidQuery(stmt.table))	×
NEW 53	return null;	×
54
55	let ctxFilterTable, newFilterTable;
56	[newTable, newFilterTable] = findOrMakeFilterTable(newTable.clone());	×
57	if (newFilterTable === null)	×
58	return null;	×
59	assert(newFilterTable.isFilter);	×
60	if (!newFilterTable.table.isInvocation)	×
61	return null;	×
62
63	ctxFilterTable = C.findFilterTable(currentTable);	×
64
65	if (ctxFilterTable) {	×
66	const newFilter = refineFilterToAnswerQuestion(ctxFilterTable.filter, newFilterTable.filter);	×
67	if (newFilter === null)	×
68	return null;	×
69	newFilterTable.filter = newFilter;	×
70	}
71
72	return addQuery(ctx, 'execute', newTable, 'accepted');	×
73	}
74
75	module.exports = {	3✔
76	relatedQuestion,
77	};

stanford-oval / genie-toolkit / 1109

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous