1019

pending completion

Build # 1019

Build Type

Pull #214

travis-ci-com

Committed by

web-flow

Commit Message

Merge 97b8c929b into 26b8cb60e

Pull Request Pull Request #214: Auto annotate multiwoz

Run Details

6567 of 14816 branches covered (44.32%)

Branch coverage included in aggregate %.

2 of 14 new or added lines in 2 files covered. (14.29%)

2403 existing lines in 57 files now uncovered.

12462 of 21858 relevant lines covered (57.01%)

2459235.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.56

/languages/thingtalk/dialogue_acts/coref-actions.js

// -*- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 -*-
//
// This file is part of Genie
//
// Copyright 2020 The Board of Trustees of the Leland Stanford Junior University
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//    http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Author: Giovanni Campagna <gcampagn@cs.stanford.edu>
"use strict";

const assert = require('assert');

const ThingTalk = require('thingtalk');
const Ast = ThingTalk.Ast;

const C = require('../ast_manip');

function contextualAction(ctx, action) {
    assert(action instanceof Ast.Invocation);
    const ctxInvocation = C.getInvocation(ctx.next);
    if (!ctxInvocation || ctxInvocation.selector.isBuiltin)
        return null;
    if (!C.isSameFunction(ctxInvocation.schema, action.schema))
        return null;
    if (action.in_params.length === 0) // common case, no new parameters
        return ctxInvocation;

    const clone = ctxInvocation.clone();
    for (let newParam of action.in_params) {
        if (newParam.value.isUndefined)
            continue;

        // check that we don't change a previous parameter

        // if we're introducing a value for the chain parameter that was not previously provided,
        // it must one of the top 3 results
        if (newParam.name === ctx.nextInfo.chainParameter &&
           !ctx.nextInfo.chainParameterFilled) {
            if (!ctx.results)
                return null;
            const results = ctx.results;
            let good = false;
            for (let i = 0; i < Math.min(results.length, 3); i ++) {
                const id = results[i].value.id;
                if (id && id.equals(newParam.value)) {
                    good = true;
                    break;
                }
            }
            if (!good)
                return null;
        }

        let found = false;
        for (let oldParam of clone.in_params) {
            if (newParam.name === oldParam.name) {
                if (oldParam.value.isUndefined)
                    oldParam.value = newParam.value;
                else if (!newParam.value.equals(oldParam.value))
                    return null;
                found = true;
                break;
            }
        }
        if (!found)
            clone.in_params.push(newParam);
    }

    return clone;
}

module.exports = {
    contextualAction
};

1	// -- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 --
2	//
3	// This file is part of Genie
4	//
5	// Copyright 2020 The Board of Trustees of the Leland Stanford Junior University
6	//
7	// Licensed under the Apache License, Version 2.0 (the "License");
8	// you may not use this file except in compliance with the License.
9	// You may obtain a copy of the License at
10	//
11	// http://www.apache.org/licenses/LICENSE-2.0
12	//
13	// Unless required by applicable law or agreed to in writing, software
14	// distributed under the License is distributed on an "AS IS" BASIS,
15	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16	// See the License for the specific language governing permissions and
17	// limitations under the License.
18	//
19	// Author: Giovanni Campagna <gcampagn@cs.stanford.edu>
20	"use strict";
21
22	const assert = require('assert');	2✔
23
24	const ThingTalk = require('thingtalk');	2✔
25	const Ast = ThingTalk.Ast;	2✔
26
27	const C = require('../ast_manip');	2✔
28
29	function contextualAction(ctx, action) {
30	assert(action instanceof Ast.Invocation);	23,850✔
31	const ctxInvocation = C.getInvocation(ctx.next);	23,850✔
32	if (!ctxInvocation \|\| ctxInvocation.selector.isBuiltin)	23,850!
33	return null;	×
34	if (!C.isSameFunction(ctxInvocation.schema, action.schema))	23,850✔
35	return null;	22,122✔
36	if (action.in_params.length === 0) // common case, no new parameters	1,728!
37	return ctxInvocation;	×
38
39	const clone = ctxInvocation.clone();	1,728✔
40	for (let newParam of action.in_params) {	1,728✔
41	if (newParam.value.isUndefined)	1,728✔
42	continue;	90✔
43
44	// check that we don't change a previous parameter
45
46	// if we're introducing a value for the chain parameter that was not previously provided,
47	// it must one of the top 3 results
48	if (newParam.name === ctx.nextInfo.chainParameter &&	1,638!
49	!ctx.nextInfo.chainParameterFilled) {
UNCOV 50	if (!ctx.results)	×
51	return null;	×
UNCOV 52	const results = ctx.results;	×
UNCOV 53	let good = false;	×
UNCOV 54	for (let i = 0; i < Math.min(results.length, 3); i ++) {	×
UNCOV 55	const id = results[i].value.id;	×
UNCOV 56	if (id && id.equals(newParam.value)) {	×
UNCOV 57	good = true;	×
UNCOV 58	break;	×
59	}
60	}
UNCOV 61	if (!good)	×
UNCOV 62	return null;	×
63	}
64
65	let found = false;	1,638✔
66	for (let oldParam of clone.in_params) {	1,638✔
67	if (newParam.name === oldParam.name) {	1,638!
68	if (oldParam.value.isUndefined)	1,638✔
69	oldParam.value = newParam.value;	787✔
70	else if (!newParam.value.equals(oldParam.value))	851✔
71	return null;	11✔
72	found = true;	1,627✔
73	break;	1,627✔
74	}
75	}
76	if (!found)	1,627!
77	clone.in_params.push(newParam);	×
78	}
79
80	return clone;	1,717✔
81	}
82
83	module.exports = {	2✔
84	contextualAction
85	};

stanford-oval / genie-toolkit / 1019

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous