3883

pending completion

Build # 3883

Build Type

Pull #863

travis-ci

Committed by

web-flow

Commit Message

<a href="https://github.com/yast/yast-installation/commit/<a class=hub.com/yast/yast-installation/commit/<a class="double-link" href="https://git"><a class=hub.com/yast/yast-installation/commit/<a class="double-link" href="https://git"><a class=hub.com/yast/yast-installation/commit/<a class="double-link" href="https://git"><a class=hub.com/yast/yast-installation/commit/43a79c789ce6fb6f832b0ba92e4deb9e2d8f3e99">43a79c789">&lt;a href=&quot;https://github.com/yast/yast-installation/commit/</a><a class="double-link" href="https://github.com/yast/yast-installation/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-installation/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-installation/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-installation/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/yast/yast-installation/commit/43a79c789ce6fb6f832b0ba92e4deb9e2d8f3e99">43a79c789</a><a href="https://github.com/yast/yast-installation/commit/43a79c789ce6fb6f832b0ba92e4deb9e2d8f3e99">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/yast/yast-installation/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/yast/yast-installation/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-installation/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-installation/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-installation/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/yast/yast-installation/commit/43a79c789ce6fb6f832b0ba92e4deb9e2d8f3e99&quot;&gt;43a79c789&lt;/a&gt;&lt;a href=&quot;https://github.com/yast/yast-installation/commit/43a79c789ce6fb6f832b0ba92e4deb9e2d8f3e99&quot;&gt;&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/yast/yast-installation/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp... (continued)

Pull Request Pull Request #863: Replace some labels in the Previously Used Repositories dialog

Run Details

12 of 12 new or added lines in 1 file covered. (100.0%)

3711 of 13226 relevant lines covered (28.06%)

4.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

65.74

/src/lib/installation/clients/inst_upgrade_urls.rb

# encoding: utf-8

# ------------------------------------------------------------------------------
# Copyright (c) 2006-2012 Novell, Inc. All Rights Reserved.
# Copyright (c) 2020 SUSE LLC
#
# This program is free software; you can redistribute it and/or modify it under
# the terms of version 2 of the GNU General Public License as published by the
# Free Software Foundation.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# this program; if not, contact Novell, Inc.
#
# To contact Novell about this file by physical or electronic mail, you may find
# current contact information at www.novell.com.
# ------------------------------------------------------------------------------

require "yast"
require "installation/upgrade_repo_manager"
require "y2packager/repository"

Yast.import "GetInstArgs"
Yast.import "Label"
Yast.import "Mode"
Yast.import "Pkg"
Yast.import "Popup"
Yast.import "Stage"
Yast.import "UI"
Yast.import "Wizard"
Yast.import "String"

module Yast
  # This client allows reusing the old repositories during system upgrade.
  #
  # @note For testing in an installed system use this command:
  #      YAST_TEST=1 yast2 inst_upgrade_urls
  #   It will load the current repositories from the system,
  #   the changes will NOT be saved.
  class InstUpgradeUrlsClient < Client
    include Yast::Logger

    def main
      textdomain "installation"

      ret = GetInstArgs.going_back ? :back : :next

      if test?
        log.info("Test mode activated")
        init_pkg_mgr
      elsif !Stage.initial || !Mode.update
        log.info("Not in update mode or initial stage")
        return ret
      end

      # use ::Installation avoid collision with Yast::Installation
      @repo_manager = ::Installation::UpgradeRepoManager.create_from_old_repositories

      # nothing to show
      if repo_manager.repositories.empty?
        log.info("No old repository defined, skipping the dialog")
        return ret
      end

      ret = run_dialog

      log.info("Returning #{ret.inspect}")
      ret
    end

  private

    attr_reader :repo_manager

    # Run the main dialog
    #
    # @return [Symbol] the UserInput symbol
    def run_dialog
      # just for testing purposes
      Wizard.CreateDialog if Mode.normal

      display_dialog
      refresh_dialog

      ret = handle_dialog
      if ret == :next
        repo_manager.activate_changes
        save_pkg_mgr
      end

      # just for testing purposes
      Wizard.CloseDialog if Mode.normal

      ret
    end

    def display_dialog
      Wizard.SetContents(
        # TRANSLATORS: dialog caption
        _("Previously Used Repositories"),
        VBox(
          # TRANSLATORS: dialog text, possibly multiline,
          # Please, do not use more than about 50 characters per line.
          Left(
            Label(
              _(
                "These repositories were found on the system\nyou are upgrading:"
              )
            )
          ),
          Table(
            Id("table_of_repos"),
            Opt(:notify, :keepSorting),
            Header(
              # TRANSLATORS: Table header item
              _("Action"),
              # TRANSLATORS: Table header item
              _("Repository"),
              # TRANSLATORS: Table header item
              _("URL")
            ),
            []
          ),
          Left(
            HBox(
              # TRANSLATORS: Push button
              PushButton(Id(:edit), edit_button_label),
              HSpacing(1),
              # TRANSLATORS: Push button
              PushButton(Id(:toggle), toggle_button_label),
              HStretch()
            )
          )
        ),
        help_text,
        true,
        true
      )

      nil
    end

    # Translated repository action, based on its status
    #
    # @param status [Symbol] the repository status
    # @return [String] the action to perform with a repository
    def repo_action(status)
      case status
      when :removed
        # TRANSLATORS: The action to perform with a repository
        _("Remove")
      when :disable
        # TRANSLATORS: The action to perform with a repository
        _("Disable")
      when :enable
        # TRANSLATORS: The action to perform with a repository
        _("Enable")
      else
        # TRANSLATORS: The action to perform with a repository
        _("Keep")
      end
    end

    # Returns the label for the toggle button
    #
    # @return [String]
    def toggle_button_label
      # TRANSLATORS: the "Toggle Action" button label
      _("&Toggle Action")
    end

    # Returns the label for the change url button
    #
    # @return [String]
    def edit_button_label
      # TRANSLATORS: the "Change URL" button label
      _("&Change URL...")
    end

    def refresh_dialog
      current_item = UI.QueryWidget(Id("table_of_repos"), :CurrentItem)

      items = repo_manager.repositories.map do |r|
        Item(
          Id(r.repo_alias),
          repo_action(repo_manager.repo_status(r)),
          r.name,
          repo_manager.repo_url(r)
        )
      end

      UI.ChangeWidget(Id("table_of_repos"), :Items, items)

      return unless current_item
      UI.ChangeWidget(Id("table_of_repos"), :CurrentItem, current_item)
    end

    def find_repo(repo_alias)
      repo_manager.repositories.find { |r| r.repo_alias == repo_alias }
    end

    def edit_item(repo)
      url = repo_manager.repo_url(repo)
      # limit the minimal width
      min_width = [url.size, 60].max

      UI.OpenDialog(
        VBox(
          # TRANSLATORS: Text entry for changing the repositoru URL
          MinWidth(min_width, TextEntry(Id(:url), _("&Repository URL"), url)),
          VSpacing(1),
          ButtonBox(
            PushButton(
              Id(:ok),
              Opt(:default, :okButton, :key_F10),
              Label.OKButton
            ),
            PushButton(
              Id(:cancel),
              Opt(:cancelButton, :key_F9),
              Label.CancelButton
            )
          )
        )
      )

      ret = UI.UserInput
      url = UI.QueryWidget(Id(:url), :Value)
      UI.CloseDialog

      return unless ret == :ok

      repo_manager.change_url(repo, url)
    end

    def handle_dialog
      log.info("Offering repositories: #{repo_manager.repositories.map(&:repo_alias).inspect}")

      ret = nil

      loop do
        ret = UI.UserInput
        ret = :abort if ret == :cancel

        case ret
        when :toggle, :edit, "table_of_repos"
          current_item = UI.QueryWidget(Id("table_of_repos"), :CurrentItem)
          next unless current_item

          selected_repo = repo_manager.repositories.find { |r| r.repo_alias == current_item }
          if !selected_repo
            log.error("Selected repository #{current_item.inspect} not found???")
            next
          end

          if ret == :edit
            edit_item(selected_repo)
          else
            repo_manager.toggle_repo_status(selected_repo)
          end

          refresh_dialog
        when :next, :back
          break
        when :abort
          break if Popup.ConfirmAbort(:painless)
        else
          log.warn("Unknown input: #{ret}")
        end
      end

      ret
    end

    # Initialize the package manager and read the current repositories.
    # This is only needed in the testing mode to display some reasonable values,
    # it reads the data from the current system.
    def init_pkg_mgr
      # import the pkg-bindings module
      Yast.import "Pkg"
      Yast.import "PackageCallbacks"
      # display progress during refresh
      PackageCallbacks.InitPackageCallbacks
      # initialize the target
      Pkg.TargetInitialize("/")
      # load the repository configuration. Refreshes the repositories if needed.
      Pkg.SourceRestore
      # read the current setup
      Y2Packager::OriginalRepositorySetup.instance.read
    end

    # Save the changes to disk, reset the stored old repositories to not display
    # this dialog again after going back.
    def save_pkg_mgr
      # do not save the changes in the test mode
      Pkg.SourceSaveAll unless test?

      # clear the old repositories
      Y2Packager::OriginalRepositorySetup.instance.repositories.clear
    end

    # Running in a test mode?
    #
    # @return [Boolean] `true` if running in the test mode, `false` otherwise
    def test?
      ENV["YAST_TEST"] == "1"
    end

    # Returns the help text for the dialog
    #
    # @return [String]
    def help_text
      [
        # TRANSLATORS: help text 1/3
        _("<p>Here you see all software repositories found on the system you are upgrading. " \
          "Enable the ones you want to include in the upgrade process.</p>"),
        # TRANSLATORS: help text 2/3, %{toggle_action} is replaced by the button label
        format(
          _("<p>To enable, remove or disable an URL, click the <b>%{toggle_action}</b> button " \
            "or double-click the respective table item.</p>"),
          toggle_action: Yast::String.RemoveShortcut(toggle_button_label)
        ),
        # TRANSLATORS: help text 3/3, %{change_url} is replaced by the button label
        format(
          _("<p>To change the URL, click the <b>%{change_url}</b> button.</p>"),
          change_url: Yast::String.RemoveShortcut(edit_button_label)
        )
      ].join
    end
  end
end

1	# encoding: utf-8
2
3	# ------------------------------------------------------------------------------
4	# Copyright (c) 2006-2012 Novell, Inc. All Rights Reserved.
5	# Copyright (c) 2020 SUSE LLC
6	#
7	# This program is free software; you can redistribute it and/or modify it under
8	# the terms of version 2 of the GNU General Public License as published by the
9	# Free Software Foundation.
10	#
11	# This program is distributed in the hope that it will be useful, but WITHOUT
12	# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
13	# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
14	#
15	# You should have received a copy of the GNU General Public License along with
16	# this program; if not, contact Novell, Inc.
17	#
18	# To contact Novell about this file by physical or electronic mail, you may find
19	# current contact information at www.novell.com.
20	# ------------------------------------------------------------------------------
21
22	require "yast"	1✔
23	require "installation/upgrade_repo_manager"	1✔
24	require "y2packager/repository"	1✔
25
26	Yast.import "GetInstArgs"	1✔
27	Yast.import "Label"	1✔
28	Yast.import "Mode"	1✔
29	Yast.import "Pkg"	1✔
30	Yast.import "Popup"	1✔
31	Yast.import "Stage"	1✔
32	Yast.import "UI"	1✔
33	Yast.import "Wizard"	1✔
34	Yast.import "String"	1✔
35
36	module Yast	1✔
37	# This client allows reusing the old repositories during system upgrade.
38	#
39	# @note For testing in an installed system use this command:
40	# YAST_TEST=1 yast2 inst_upgrade_urls
41	# It will load the current repositories from the system,
42	# the changes will NOT be saved.
43	class InstUpgradeUrlsClient < Client	1✔
44	include Yast::Logger	1✔
45
46	def main	1✔
47	textdomain "installation"	2✔
48
49	ret = GetInstArgs.going_back ? :back : :next	2✔
50
51	if test?	2✔
52	log.info("Test mode activated")	×
53	init_pkg_mgr	×
54	elsif !Stage.initial \|\| !Mode.update	2✔
55	log.info("Not in update mode or initial stage")	×
56	return ret	×
57	end
58
59	# use ::Installation avoid collision with Yast::Installation
60	@repo_manager = ::Installation::UpgradeRepoManager.create_from_old_repositories	2✔
61
62	# nothing to show
63	if repo_manager.repositories.empty?	2✔
64	log.info("No old repository defined, skipping the dialog")	×
65	return ret	×
66	end
67
68	ret = run_dialog	2✔
69
70	log.info("Returning #{ret.inspect}")	2✔
71	ret	2✔
72	end
73
74	private	1✔
75
76	attr_reader :repo_manager	1✔
77
78	# Run the main dialog
79	#
80	# @return [Symbol] the UserInput symbol
81	def run_dialog	1✔
82	# just for testing purposes
83	Wizard.CreateDialog if Mode.normal	2✔
84
85	display_dialog	2✔
86	refresh_dialog	2✔
87
88	ret = handle_dialog	2✔
89	if ret == :next	2✔
90	repo_manager.activate_changes	2✔
91	save_pkg_mgr	2✔
92	end
93
94	# just for testing purposes
95	Wizard.CloseDialog if Mode.normal	2✔
96
97	ret	2✔
98	end
99
100	def display_dialog	1✔
101	Wizard.SetContents(	2✔
102	# TRANSLATORS: dialog caption
103	_("Previously Used Repositories"),
104	VBox(
105	# TRANSLATORS: dialog text, possibly multiline,
106	# Please, do not use more than about 50 characters per line.
107	Left(
108	Label(
109	_(
110	"These repositories were found on the system\nyou are upgrading:"
111	)
112	)
113	),
114	Table(
115	Id("table_of_repos"),
116	Opt(:notify, :keepSorting),
117	Header(
118	# TRANSLATORS: Table header item
119	_("Action"),
120	# TRANSLATORS: Table header item
121	_("Repository"),
122	# TRANSLATORS: Table header item
123	_("URL")
124	),
125	[]
126	),
127	Left(
128	HBox(
129	# TRANSLATORS: Push button
130	PushButton(Id(:edit), edit_button_label),
131	HSpacing(1),
132	# TRANSLATORS: Push button
133	PushButton(Id(:toggle), toggle_button_label),
134	HStretch()
135	)
136	)
137	),
138	help_text,
139	true,
140	true
141	)
142
143	nil
144	end
145
146	# Translated repository action, based on its status
147	#
148	# @param status [Symbol] the repository status
149	# @return [String] the action to perform with a repository
150	def repo_action(status)	1✔
151	case status	4✔
152	when :removed
153	# TRANSLATORS: The action to perform with a repository
154	_("Remove")	4✔
155	when :disable
156	# TRANSLATORS: The action to perform with a repository
157	_("Disable")	×
158	when :enable
159	# TRANSLATORS: The action to perform with a repository
160	_("Enable")	×
161	else
162	# TRANSLATORS: The action to perform with a repository
163	_("Keep")	×
164	end
165	end
166
167	# Returns the label for the toggle button
168	#
169	# @return [String]
170	def toggle_button_label	1✔
171	# TRANSLATORS: the "Toggle Action" button label
172	_("&Toggle Action")	4✔
173	end
174
175	# Returns the label for the change url button
176	#
177	# @return [String]
178	def edit_button_label	1✔
179	# TRANSLATORS: the "Change URL" button label
180	_("&Change URL...")	4✔
181	end
182
183	def refresh_dialog	1✔
184	current_item = UI.QueryWidget(Id("table_of_repos"), :CurrentItem)	2✔
185
186	items = repo_manager.repositories.map do \|r\|	2✔
187	Item(	4✔
188	Id(r.repo_alias),
189	repo_action(repo_manager.repo_status(r)),
190	r.name,
191	repo_manager.repo_url(r)
192	)
193	end
194
195	UI.ChangeWidget(Id("table_of_repos"), :Items, items)	2✔
196
197	return unless current_item	2✔
198	UI.ChangeWidget(Id("table_of_repos"), :CurrentItem, current_item)	×
199	end
200
201	def find_repo(repo_alias)	1✔
202	repo_manager.repositories.find { \|r\| r.repo_alias == repo_alias }	×
203	end
204
205	def edit_item(repo)	1✔
206	url = repo_manager.repo_url(repo)	×
207	# limit the minimal width
208	min_width = [url.size, 60].max	×
209
210	UI.OpenDialog(	×
211	VBox(
212	# TRANSLATORS: Text entry for changing the repositoru URL
213	MinWidth(min_width, TextEntry(Id(:url), _("&Repository URL"), url)),
214	VSpacing(1),
215	ButtonBox(
216	PushButton(
217	Id(:ok),
218	Opt(:default, :okButton, :key_F10),
219	Label.OKButton
220	),
221	PushButton(
222	Id(:cancel),
223	Opt(:cancelButton, :key_F9),
224	Label.CancelButton
225	)
226	)
227	)
228	)
229
230	ret = UI.UserInput	×
231	url = UI.QueryWidget(Id(:url), :Value)	×
232	UI.CloseDialog	×
233
234	return unless ret == :ok	×
235
236	repo_manager.change_url(repo, url)	×
237	end
238
239	def handle_dialog	1✔
240	log.info("Offering repositories: #{repo_manager.repositories.map(&:repo_alias).inspect}")	2✔
241
242	ret = nil	2✔
243
244	loop do	2✔
245	ret = UI.UserInput	2✔
246	ret = :abort if ret == :cancel	2✔
247
248	case ret	2✔
249	when :toggle, :edit, "table_of_repos"
250	current_item = UI.QueryWidget(Id("table_of_repos"), :CurrentItem)	×
251	next unless current_item	×
252
253	selected_repo = repo_manager.repositories.find { \|r\| r.repo_alias == current_item }	×
254	if !selected_repo	×
255	log.error("Selected repository #{current_item.inspect} not found???")	×
256	next	×
257	end
258
259	if ret == :edit	×
260	edit_item(selected_repo)	×
261	else
262	repo_manager.toggle_repo_status(selected_repo)	×
263	end
264
265	refresh_dialog	×
266	when :next, :back
267	break	2✔
268	when :abort
269	break if Popup.ConfirmAbort(:painless)	×
270	else
271	log.warn("Unknown input: #{ret}")	×
272	end
273	end
274
275	ret	2✔
276	end
277
278	# Initialize the package manager and read the current repositories.
279	# This is only needed in the testing mode to display some reasonable values,
280	# it reads the data from the current system.
281	def init_pkg_mgr	1✔
282	# import the pkg-bindings module
283	Yast.import "Pkg"	×
284	Yast.import "PackageCallbacks"	×
285	# display progress during refresh
286	PackageCallbacks.InitPackageCallbacks	×
287	# initialize the target
288	Pkg.TargetInitialize("/")	×
289	# load the repository configuration. Refreshes the repositories if needed.
290	Pkg.SourceRestore	×
291	# read the current setup
292	Y2Packager::OriginalRepositorySetup.instance.read	×
293	end
294
295	# Save the changes to disk, reset the stored old repositories to not display
296	# this dialog again after going back.
297	def save_pkg_mgr	1✔
298	# do not save the changes in the test mode
299	Pkg.SourceSaveAll unless test?	2✔
300
301	# clear the old repositories
302	Y2Packager::OriginalRepositorySetup.instance.repositories.clear	2✔
303	end
304
305	# Running in a test mode?
306	#
307	# @return [Boolean] `true` if running in the test mode, `false` otherwise
308	def test?	1✔
309	ENV["YAST_TEST"] == "1"	4✔
310	end
311
312	# Returns the help text for the dialog
313	#
314	# @return [String]
315	def help_text	1✔
316	[
317	# TRANSLATORS: help text 1/3
318	_("<p>Here you see all software repositories found on the system you are upgrading. " \	2✔
319	"Enable the ones you want to include in the upgrade process.</p>"),
320	# TRANSLATORS: help text 2/3, %{toggle_action} is replaced by the button label
321	format(
322	_("<p>To enable, remove or disable an URL, click the <b>%{toggle_action}</b> button " \
323	"or double-click the respective table item.</p>"),
324	toggle_action: Yast::String.RemoveShortcut(toggle_button_label)
325	),
326	# TRANSLATORS: help text 3/3, %{change_url} is replaced by the button label
327	format(
328	_("<p>To change the URL, click the <b>%{change_url}</b> button.</p>"),
329	change_url: Yast::String.RemoveShortcut(edit_button_label)
330	)
331	].join
332	end
333	end
334	end

yast / yast-installation / 3883

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous