Build has been canceled!

OpenBuildings / jam / 120

120

Pull #32

travis-ci

hkdobrev 
Overhaul of Jam_Query_Builder_Insert. Fixes #31.

In short this will:
* Change it to be more consistent with Database_Query_Builder_Insert.
* Fix small bugs in `params()` and `__call()`.
* Add real unit tests. `compile()` and `execute()` are still to be tested.
* Fix PHPDoc.
* Change `Jam::insert()` accordingly.
* Fix docs.

See the squashed commits below for more details.

commit a3fa684ef
Author: Haralan Dobrev <hkdobrev@gmail.com>
Date:   Sat Nov 9 20:32:49 2013 +0200

    Fix docs for `Jam::insert()`

    Basically the previous documentation for `Jam::insert()` was a shameless
    copy of the documentation of `Jam::update`.
    Wrong SQL examples like:
        INSERT INTO clients SET title = 'Patrik', username = 'patrik76'
    are removed.

    Added more/better examples for:
     * inserting a single record
     * using the columns argument
     * using a sub query

commit 87a410a22
Author: Haralan Dobrev <hkdobrev@gmail.com>
Date:   Sat Nov 9 20:32:45 2013 +0200

    Make `Jam::insert()` support columns

commit 5973a8769
Author: Haralan Dobrev <hkdobrev@gmail.com>
Date:   Sat Nov 9 20:32:21 2013 +0200

    Add unit tests for Jam_Query_Builder_Insert

commit c0a825558
Author: Haralan Dobrev <hkdobrev@gmail.com>
Date:   Sat Nov 9 20:31:15 2013 +0200

    Improve PHPDoc for Jam_Query_Builder_Insert methods

commit 342063c2b
Author: Haralan Dobrev <hkdobrev@gmail.com>
Date:   Sat Nov 9 20:29:46 2013 +0200

    Fix Jam_Query_Builder_Insert::__call()

    When the called function return a non-NULL, evaluating-to-FALSE value,
    it should be returned instead of $this.
    Indented code to not go over 80 characters per line.

commit a591ffb9a
Author: Haralan Dobrev <hkdobrev@gmail.com>
Date:   Sat Nov 9 20:26:48 2013 +0200

    Fix Jam_Query_Builder_Insert::params()

  ... (continued)
Pull Request #32: Overhaul of Jam_Query_Builder_Insert. Fixes #31

3288 of 4007 relevant lines covered (82.06%)

30.06 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.29
/Kohana/Jam/Query/Builder/Insert.php


Source Not Available