7f2d5cea62d663306ba7e7f024e321d359521cb0

Build # 7f2d5cea62d663306ba7e7f024e321d359521cb0

Build Type

push

github-actions

Committed by Unrud

Commit Message

New right "i": Only allowing HTTP method GET

Run Details

1183 of 1531 branches covered (77.27%)

Branch coverage included in aggregate %.

6 of 8 new or added lines in 1 file covered. (75.0%)

75 existing lines in 10 files now uncovered.

2853 of 3408 relevant lines covered (83.71%)

11.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

71.95

/radicale/app/proppatch.py

# This file is part of Radicale Server - Calendar Server
# Copyright © 2008 Nicolas Kandel
# Copyright © 2008 Pascal Halter
# Copyright © 2008-2017 Guillaume Ayoub
# Copyright © 2017-2018 Unrud <unrud@outlook.com>
#
# This library is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Radicale.  If not, see <http://www.gnu.org/licenses/>.

import socket
from http import client
from xml.etree import ElementTree as ET

from radicale import app, httputils
from radicale import item as radicale_item
from radicale import storage, xmlutils
from radicale.log import logger


def xml_add_propstat_to(element, tag, status_number):
    """Add a PROPSTAT response structure to an element.

    The PROPSTAT answer structure is defined in rfc4918-9.1. It is added to the
    given ``element``, for the following ``tag`` with the given
    ``status_number``.

    """
    propstat = ET.Element(xmlutils.make_clark("D:propstat"))
    element.append(propstat)

    prop = ET.Element(xmlutils.make_clark("D:prop"))
    propstat.append(prop)

    clark_tag = xmlutils.make_clark(tag)
    prop_tag = ET.Element(clark_tag)
    prop.append(prop_tag)

    status = ET.Element(xmlutils.make_clark("D:status"))
    status.text = xmlutils.make_response(status_number)
    propstat.append(status)


def xml_proppatch(base_prefix, path, xml_request, collection):
    """Read and answer PROPPATCH requests.

    Read rfc4918-9.2 for info.

    """
    props_to_set = xmlutils.props_from_request(xml_request, actions=("set",))
    props_to_remove = xmlutils.props_from_request(xml_request,
                                                  actions=("remove",))

    multistatus = ET.Element(xmlutils.make_clark("D:multistatus"))
    response = ET.Element(xmlutils.make_clark("D:response"))
    multistatus.append(response)

    href = ET.Element(xmlutils.make_clark("D:href"))
    href.text = xmlutils.make_href(base_prefix, path)
    response.append(href)

    new_props = collection.get_meta()
    for short_name, value in props_to_set.items():
        new_props[short_name] = value
        xml_add_propstat_to(response, short_name, 200)
    for short_name in props_to_remove:
        try:
            del new_props[short_name]
        except KeyError:
            pass
        xml_add_propstat_to(response, short_name, 200)
    radicale_item.check_and_sanitize_props(new_props)
    collection.set_meta(new_props)

    return multistatus


class ApplicationProppatchMixin:
    def do_PROPPATCH(self, environ, base_prefix, path, user):
        """Manage PROPPATCH request."""
        access = app.Access(self._rights, user, path)
        if not access.check("w"):
            return httputils.NOT_ALLOWED
        try:
            xml_content = self._read_xml_content(environ)
        except RuntimeError as e:
            logger.warning(
                "Bad PROPPATCH request on %r: %s", path, e, exc_info=True)
            return httputils.BAD_REQUEST
        except socket.timeout:
            logger.debug("client timed out", exc_info=True)
            return httputils.REQUEST_TIMEOUT
        with self._storage.acquire_lock("w", user):
            item = next(self._storage.discover(path), None)
            if not item:
                return httputils.NOT_FOUND
            if not access.check("w", item):
                return httputils.NOT_ALLOWED
            if not isinstance(item, storage.BaseCollection):
                return httputils.FORBIDDEN
            headers = {"DAV": httputils.DAV_HEADERS,
                       "Content-Type": "text/xml; charset=%s" % self._encoding}
            try:
                xml_answer = xml_proppatch(base_prefix, path, xml_content,
                                           item)
            except ValueError as e:
                logger.warning(
                    "Bad PROPPATCH request on %r: %s", path, e, exc_info=True)
                return httputils.BAD_REQUEST
            return (client.MULTI_STATUS, headers,
                    self._write_xml_content(xml_answer))

1	# This file is part of Radicale Server - Calendar Server
2	# Copyright © 2008 Nicolas Kandel
3	# Copyright © 2008 Pascal Halter
4	# Copyright © 2008-2017 Guillaume Ayoub
5	# Copyright © 2017-2018 Unrud <unrud@outlook.com>
6	#
7	# This library is free software: you can redistribute it and/or modify
8	# it under the terms of the GNU General Public License as published by
9	# the Free Software Foundation, either version 3 of the License, or
10	# (at your option) any later version.
11	#
12	# This library is distributed in the hope that it will be useful,
13	# but WITHOUT ANY WARRANTY; without even the implied warranty of
14	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15	# GNU General Public License for more details.
16	#
17	# You should have received a copy of the GNU General Public License
18	# along with Radicale. If not, see <http://www.gnu.org/licenses/>.
19
20	import socket	15✔
21	from http import client	15✔
22	from xml.etree import ElementTree as ET	15✔
23
24	from radicale import app, httputils	15✔
25	from radicale import item as radicale_item	15✔
26	from radicale import storage, xmlutils	15✔
27	from radicale.log import logger	15✔
28
29
30	def xml_add_propstat_to(element, tag, status_number):	15✔
31	"""Add a PROPSTAT response structure to an element.
32
33	The PROPSTAT answer structure is defined in rfc4918-9.1. It is added to the
34	given ``element``, for the following ``tag`` with the given
35	``status_number``.
36
37	"""
38	propstat = ET.Element(xmlutils.make_clark("D:propstat"))	15✔
39	element.append(propstat)	15✔
40
41	prop = ET.Element(xmlutils.make_clark("D:prop"))	15✔
42	propstat.append(prop)	15✔
43
44	clark_tag = xmlutils.make_clark(tag)	15✔
45	prop_tag = ET.Element(clark_tag)	15✔
46	prop.append(prop_tag)	15✔
47
48	status = ET.Element(xmlutils.make_clark("D:status"))	15✔
49	status.text = xmlutils.make_response(status_number)	15✔
50	propstat.append(status)	15✔
51
52
53	def xml_proppatch(base_prefix, path, xml_request, collection):	15✔
54	"""Read and answer PROPPATCH requests.
55
56	Read rfc4918-9.2 for info.
57
58	"""
59	props_to_set = xmlutils.props_from_request(xml_request, actions=("set",))	15✔
60	props_to_remove = xmlutils.props_from_request(xml_request,	15✔
61	actions=("remove",))
62
63	multistatus = ET.Element(xmlutils.make_clark("D:multistatus"))	15✔
64	response = ET.Element(xmlutils.make_clark("D:response"))	15✔
65	multistatus.append(response)	15✔
66
67	href = ET.Element(xmlutils.make_clark("D:href"))	15✔
68	href.text = xmlutils.make_href(base_prefix, path)	15✔
69	response.append(href)	15✔
70
71	new_props = collection.get_meta()	15✔
72	for short_name, value in props_to_set.items():	15✔
73	new_props[short_name] = value	15✔
74	xml_add_propstat_to(response, short_name, 200)	15✔
75	for short_name in props_to_remove:	15!
76	try:	×
77	del new_props[short_name]	×
78	except KeyError:	×
79	pass	×
80	xml_add_propstat_to(response, short_name, 200)	×
81	radicale_item.check_and_sanitize_props(new_props)	15✔
82	collection.set_meta(new_props)	15✔
83
84	return multistatus	15✔
85
86
87	class ApplicationProppatchMixin:	15✔
88	def do_PROPPATCH(self, environ, base_prefix, path, user):	15✔
89	"""Manage PROPPATCH request."""
90	access = app.Access(self._rights, user, path)	15✔
91	if not access.check("w"):	15✔
92	return httputils.NOT_ALLOWED	15✔
93	try:	15✔
94	xml_content = self._read_xml_content(environ)	15✔
95	except RuntimeError as e:	×
UNCOV 96	logger.warning(	×
97	"Bad PROPPATCH request on %r: %s", path, e, exc_info=True)
98	return httputils.BAD_REQUEST	×
99	except socket.timeout:	×
100	logger.debug("client timed out", exc_info=True)	×
UNCOV 101	return httputils.REQUEST_TIMEOUT	×
102	with self._storage.acquire_lock("w", user):	15✔
103	item = next(self._storage.discover(path), None)	15✔
104	if not item:	15!
UNCOV 105	return httputils.NOT_FOUND	×
106	if not access.check("w", item):	15!
UNCOV 107	return httputils.NOT_ALLOWED	×
108	if not isinstance(item, storage.BaseCollection):	15!
UNCOV 109	return httputils.FORBIDDEN	×
110	headers = {"DAV": httputils.DAV_HEADERS,	15✔
111	"Content-Type": "text/xml; charset=%s" % self._encoding}
112	try:	15✔
113	xml_answer = xml_proppatch(base_prefix, path, xml_content,	15✔
114	item)
115	except ValueError as e:	×
UNCOV 116	logger.warning(	×
117	"Bad PROPPATCH request on %r: %s", path, e, exc_info=True)
UNCOV 118	return httputils.BAD_REQUEST	×
119	return (client.MULTI_STATUS, headers,	15✔
120	self._write_xml_content(xml_answer))

Kozea / Radicale / 7f2d5cea62d663306ba7e7f024e321d359521cb0

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous