stanford-oval / thingtalk / 837

837

Pull #191

travis-ci-com

web-flow 
Add visit methods to all Ast.Value classes

So we no longer need ugly chains of "if (value.isX) ..."

Note that, unlike other AstNode subclasses, I kept a general
"visitValue", because it is often useful to visit all values
regardless of type, and it is tedious to override all class-specific
methods.
Pull Request #191: Convert Ast.Value away from adt into true classes

4162 of 5500 branches covered (75.67%)

Branch coverage included in aggregate %.

396 of 457 new or added lines in 12 files covered. (86.65%)

15 existing lines in 2 files now uncovered.

8221 of 9778 relevant lines covered (84.08%)

729.15 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

34.15
/lib/ast/index.js
1 
// -*- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 -*-
2 
//
3 
// This file is part of ThingTalk
4 
//
5 
// Copyright 2015-2016 The Board of Trustees of the Leland Stanford Junior University
6 
//
7 
// Author: Giovanni Campagna <gcampagn@cs.stanford.edu>
8 
//
9 
// See COPYING for details
10 
"use strict";
11 









12



const adt = require('adt');




1✔





13












14



const FunctionDefs = require('./function_def');




1✔





15



const ClassDefs = require('./class_def');




1✔





16



const ComputeDefs = require('./compute_def');




1✔





17



const Values = require('./values');




1✔





18



const Expressions = require('./expression');




1✔





19



const Primitives = require('./primitive');




1✔





20



const Programs = require('./program');




1✔





21



const Bookkeepings = require('./bookkeeping');




1✔





22



const NodeVisitor = require('./visitor');




1✔





23












24



adt.nativeClone = function nativeClone(x) {




1✔






UNCOV

25



    if (x === null || x === undefined)





×








UNCOV

26



        return x;




×








UNCOV

27



    if (x instanceof adt.__Base__ || typeof x.clone === 'function')





×








UNCOV

28



        return x.clone();




×








UNCOV

29



    if (Array.isArray(x))





×








UNCOV

30



        return x.map((el) => nativeClone(el));




×








UNCOV

31



    if (x instanceof Date)





×








UNCOV

32



        return new Date(x);




×








UNCOV

33



    if (typeof x === 'object') {





×








UNCOV

34



        let clone = {};




×








UNCOV

35



        Object.assign(clone, x);




×








UNCOV

36



        return clone;




×







37



    }











UNCOV

38



    return x;




×







39



};










40












41



/**










42



 * The AST namespace includes the definition of AST nodes.










43



 *










44



 * @namespace Ast










45



 */










46



Object.assign(module.exports, FunctionDefs, ClassDefs, ComputeDefs, Values, Expressions, Primitives, Programs, Bookkeepings);




1✔





47



module.exports.NodeVisitor = NodeVisitor;




1✔





48



require('./api');




1✔



















    

  • 

    •