jstasiak / python-zeroconf / 555

pending completion

Build # 555

Build Type

Pull #232

travis-ci

Committed by

web-flow

Commit Message

Optimize handle_response cache check

The handle_response loop would encounter a unique record
it would search the cache in order to remove keys that
matched the DNSEntry for the record.

Since the cache is stored as a list of records with the key as the DNSEntry
key we can avoid searching the entire cache search time and only
search for the DNSEntry of the record. In practice this means
with 5000 entries and records in the cache we now only need to search
4 or 5.

This also fixes a memory leak in the DNSCache.  When all the records for
a given DNSEntry key were removed from the cache, the DNSEntry key
itself that contain the list was never removed.  This left an empty list
in memory for every device that was no longer broadcasting on the
network.

Test environment:

  Home Assistant running on home networking with a /22
  and a significant amount of broadcast traffic

  Testing was done with py-spy v0.3.3
    (https://github.com/benfred/py-spy/releases)

Pull Request Pull Request #232: Optimize handle_response cache check

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

2113 of 2258 relevant lines covered (93.58%)

0.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.81

/zeroconf/test.py

Build SHA Not Found

The commit SHA "8d14104be37e00213efc5fda2325b01792b00ecb" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

jstasiak / python-zeroconf / 555

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous