a96dcb20a4134872661bb8f1fcfb3c793d05baf3

Build # a96dcb20a4134872661bb8f1fcfb3c793d05baf3

Build Type

push

github

Committed by Todd Bluhm

Commit Message

feat(login): added facebook login

Run Details

9 of 44 branches covered (20.45%)

Branch coverage included in aggregate %.

6 of 31 new or added lines in 3 files covered. (19.35%)

3 existing lines in 1 file now uncovered.

147 of 206 relevant lines covered (71.36%)

1.11 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.97

/src/services/users/users.class.ts

import crypto from 'crypto'
import { Params } from '@feathersjs/feathers'
import { Service, NedbServiceOptions } from 'feathers-nedb'
import { GeneralError } from '@feathersjs/errors'
import { Application } from '../../declarations'

// The Gravatar image service
const gravatarUrl = 'https://s.gravatar.com/avatar'
// The size query. Our chat needs 60px images
const query = 's=60'

// A type interface for our user (it does not validate any data)
export interface UserData {
  _id?: string
  email: string
  password: string
  avatar?: string
  githubId?: string
  facebookId?: string
}

export class Users extends Service<UserData> {
  constructor (options: Partial<NedbServiceOptions>, app: Application) {
    super(options)
  }

  async create (data: UserData, params?: Params): Promise<UserData> {
    // This is the information we want from the user signup data
    const { email, password, githubId, facebookId } = data
    let { avatar } = data
    // If no avatar attempt to use the email to grab a gravatar
    if (avatar == null || avatar === '') {
      // Gravatar uses MD5 hashes from an email address (all lowercase) to get the image
      const hash = crypto.createHash('md5').update(email.toLowerCase()).digest('hex')
      avatar = `${gravatarUrl}/${hash}?${query}`
    }
    // The complete user
    const userData = {
      email,
      password,
      githubId,
      avatar,
      facebookId
    }

    // Call the original `create` method with existing `params` and new data
    try {
      const res = await super.create(userData, params)
      if (Array.isArray(res)) {
        return res[0]
      }
      return res
    } catch (e) {
      if (/violates the unique constraint/gi.test(e.message)) {
        throw new GeneralError('That user already exists. Please login instead.')
      }
      throw e
    }
  }
}

1	import crypto from 'crypto'	1✔
2	import { Params } from '@feathersjs/feathers'
3	import { Service, NedbServiceOptions } from 'feathers-nedb'	1✔
4	import { GeneralError } from '@feathersjs/errors'	1✔
5	import { Application } from '../../declarations'
6
7	// The Gravatar image service
8	const gravatarUrl = 'https://s.gravatar.com/avatar'	1✔
9	// The size query. Our chat needs 60px images
10	const query = 's=60'	1✔
11
12	// A type interface for our user (it does not validate any data)
13	export interface UserData {
14	_id?: string
15	email: string
16	password: string
17	avatar?: string
18	githubId?: string
19	facebookId?: string
20	}
21
22	export class Users extends Service<UserData> {	1✔
23	constructor (options: Partial<NedbServiceOptions>, app: Application) {
24	super(options)	1✔
25	}
26
27	async create (data: UserData, params?: Params): Promise<UserData> {
28	// This is the information we want from the user signup data
29	const { email, password, githubId, facebookId } = data	6✔
30	let { avatar } = data	6✔
31	// If no avatar attempt to use the email to grab a gravatar
32	if (avatar == null \|\| avatar === '') {	6!
33	// Gravatar uses MD5 hashes from an email address (all lowercase) to get the image
34	const hash = crypto.createHash('md5').update(email.toLowerCase()).digest('hex')	6✔
35	avatar = `${gravatarUrl}/${hash}?${query}`	6✔
36	}
37	// The complete user
38	const userData = {	6✔
39	email,
40	password,
41	githubId,
42	avatar,
43	facebookId
44	}
45
46	// Call the original `create` method with existing `params` and new data
47	try {	6✔
48	const res = await super.create(userData, params)	6✔
49	if (Array.isArray(res)) {	6!
UNCOV 50	return res[0]	×
51	}
52	return res	6✔
53	} catch (e) {
UNCOV 54	if (/violates the unique constraint/gi.test(e.message)) {	×
UNCOV 55	throw new GeneralError('That user already exists. Please login instead.')	×
56	}
57	throw e	×
58	}
59	}
60	}

toddbluhm / sparrow-chat / a96dcb20a4134872661bb8f1fcfb3c793d05baf3

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous