5d55efdd7d2e8a1b935874da7cf6197cc017d079-PR-5

Build # 5d55efdd7d2e8a1b935874da7cf6197cc017d079-PR-5

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/toddbluhm/sparrow-chat/commit/<a class=hub.com/toddbluhm/sparrow-chat/commit/5d55efdd7d2e8a1b935874da7cf6197cc017d079">5d55efdd7<a href="https://github.com/toddbluhm/sparrow-chat/commit/5d55efdd7d2e8a1b935874da7cf6197cc017d079">">Merge </a><a class="double-link" href="https://github.com/toddbluhm/sparrow-chat/commit/<a class="double-link" href="https://github.com/toddbluhm/sparrow-chat/commit/f5e54bd21499b8411ab045b4c773841f7ee5c4a8">f5e54bd21</a>">f5e54bd21</a><a href="https://github.com/toddbluhm/sparrow-chat/commit/5d55efdd7d2e8a1b935874da7cf6197cc017d079"> into 91ca991a4">91ca991a4</a>

Pull Request Pull Request #5: tests

Run Details

9 of 32 branches covered (28.13%)

Branch coverage included in aggregate %.

3 of 4 new or added lines in 1 file covered. (75.0%)

142 of 176 relevant lines covered (80.68%)

2.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.97

/src/services/users/users.class.ts

import crypto from 'crypto'
import { Params } from '@feathersjs/feathers'
import { Service, NedbServiceOptions } from 'feathers-nedb'
import { GeneralError } from '@feathersjs/errors'
import { Application } from '../../declarations'

// The Gravatar image service
const gravatarUrl = 'https://s.gravatar.com/avatar'
// The size query. Our chat needs 60px images
const query = 's=60'

// A type interface for our user (it does not validate any data)
export interface UserData {
  _id?: string
  email: string
  password: string
  avatar?: string
  githubId?: string
}

export class Users extends Service<UserData> {
  constructor (options: Partial<NedbServiceOptions>, app: Application) {
    super(options)
  }

  async create (data: UserData, params?: Params): Promise<UserData> {
    // This is the information we want from the user signup data
    const { email, password, githubId } = data
    let { avatar } = data
    // If no avatar attempt to use the email to grab a gravatar
    if (avatar == null || avatar === '') {
      // Gravatar uses MD5 hashes from an email address (all lowercase) to get the image
      const hash = crypto.createHash('md5').update(email.toLowerCase()).digest('hex')
      avatar = `${gravatarUrl}/${hash}?${query}`
    }
    // The complete user
    const userData = {
      email,
      password,
      githubId,
      avatar
    }

    // Call the original `create` method with existing `params` and new data
    try {
      const res = await super.create(userData, params)
      if (Array.isArray(res)) {
        return res[0]
      }
      return res
    } catch (e) {
      if (/violates the unique constraint/gi.test(e.message)) {
        throw new GeneralError('That user already exists. Please login instead.')
      }
      throw e
    }
  }
}

1	import crypto from 'crypto'	2✔
2	import { Params } from '@feathersjs/feathers'
3	import { Service, NedbServiceOptions } from 'feathers-nedb'	2✔
4	import { GeneralError } from '@feathersjs/errors'	2✔
5	import { Application } from '../../declarations'
6
7	// The Gravatar image service
8	const gravatarUrl = 'https://s.gravatar.com/avatar'	2✔
9	// The size query. Our chat needs 60px images
10	const query = 's=60'	2✔
11
12	// A type interface for our user (it does not validate any data)
13	export interface UserData {
14	_id?: string
15	email: string
16	password: string
17	avatar?: string
18	githubId?: string
19	}
20
21	export class Users extends Service<UserData> {	2✔
22	constructor (options: Partial<NedbServiceOptions>, app: Application) {
23	super(options)	2✔
24	}
25
26	async create (data: UserData, params?: Params): Promise<UserData> {
27	// This is the information we want from the user signup data
28	const { email, password, githubId } = data	12✔
29	let { avatar } = data	12✔
30	// If no avatar attempt to use the email to grab a gravatar
31	if (avatar == null \|\| avatar === '') {	12!
32	// Gravatar uses MD5 hashes from an email address (all lowercase) to get the image
33	const hash = crypto.createHash('md5').update(email.toLowerCase()).digest('hex')	12✔
34	avatar = `${gravatarUrl}/${hash}?${query}`	12✔
35	}
36	// The complete user
37	const userData = {	12✔
38	email,
39	password,
40	githubId,
41	avatar
42	}
43
44	// Call the original `create` method with existing `params` and new data
45	try {	12✔
46	const res = await super.create(userData, params)	12✔
47	if (Array.isArray(res)) {	12!
NEW 48	return res[0]	×
49	}
50	return res	12✔
51	} catch (e) {
52	if (/violates the unique constraint/gi.test(e.message)) {	×
53	throw new GeneralError('That user already exists. Please login instead.')	×
54	}
55	throw e	×
56	}
57	}
58	}

toddbluhm / sparrow-chat / 5d55efdd7d2e8a1b935874da7cf6197cc017d079-PR-5

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous