Kdyby / Autowired / 602

pending completion

Build # 602

Build Type

Pull #28

travis-ci

Committed by

web-flow

Commit Message

use callable getter instead of resolver

compatibility with DI/Resolver since this commit https://github.com/nette/di/commit/d9621e65f#diff-6682ea383870132c0a5bfc2133f557d1R456

Pull Request Pull Request #28: use callable $getter instead of $resolver

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

193 of 229 relevant lines covered (84.28%)

0.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.02

/src/Kdyby/Autowired/AutowireComponentFactories.php

<?php declare(strict_types=1);

/**
 * This file is part of the Kdyby (http://www.kdyby.org)
 *
 * Copyright (c) 2008 Filip Procházka (filip@prochazka.su)
 *
 * For the full copyright and license information, please view the file license.txt that was distributed with this source code.
 */

namespace Kdyby\Autowired;

use Nette;
use Nette\ComponentModel\IComponent;
use Nette\Reflection\ClassType;
use Nette\Reflection\Method;
use Nette\Utils\Strings;



/**
 * @author matej21 <matej21@matej21.cz>
 * @author Filip Procházka <filip@prochazka.su>
 *
 * @method Nette\Application\UI\Presenter getPresenter()
 */
trait AutowireComponentFactories
{

        /**
         * @var Nette\DI\Container
         */
        private $autowireComponentFactoriesLocator;



        protected function getComponentFactoriesLocator(): Nette\DI\Container
        {
                if ($this->autowireComponentFactoriesLocator === NULL) {
                        $this->injectComponentFactories($this->getPresenter()->getContext());
                }

                return $this->autowireComponentFactoriesLocator;
        }



        /**
         * @throws MemberAccessException
         * @internal
         */
        public function injectComponentFactories(Nette\DI\Container $dic): void
        {
                if (!$this instanceof Nette\Application\UI\PresenterComponent && !$this instanceof Nette\Application\UI\Component) {
                        throw new MemberAccessException('Trait ' . __TRAIT__ . ' can be used only in descendants of PresenterComponent.');
                }

                $this->autowireComponentFactoriesLocator = $dic;

                /** @var Nette\Caching\IStorage $storage */
                $storage = $dic->hasService('autowired.cacheStorage')
                        ? $dic->getService('autowired.cacheStorage')
                        : $dic->getByType('Nette\Caching\IStorage');
                $cache = new Nette\Caching\Cache($storage, 'Kdyby.Autowired.AutowireComponentFactories');

                if ($cache->load($presenterClass = get_class($this)) !== NULL) {
                        return;
                }

                $ignore = class_parents('Nette\Application\UI\Presenter') + ['ui' => 'Nette\Application\UI\Presenter'];
                $rc = new ClassType($this);
                foreach ($rc->getMethods() as $method) {
                        if (in_array($method->getDeclaringClass()->getName(), $ignore, TRUE) || !Strings::startsWith($method->getName(), 'createComponent')) {
                                continue;
                        }

                        foreach ($method->getParameters() as $parameter) {
                                if (!$class = $parameter->getClassName()) { // has object type hint
                                        continue;
                                }

                                if (!$this->findByTypeForFactory($class) && !$parameter->allowsNull()) {
                                        throw new MissingServiceException("No service of type {$class} found. Make sure the type hint in $method is written correctly and service of this type is registered.");
                                }
                        }
                }

                $files = array_map(function ($class) {
                        return ClassType::from($class)->getFileName();
                }, array_diff(array_values(class_parents($presenterClass) + ['me' => $presenterClass]), $ignore));

                $files[] = ClassType::from($this->autowireComponentFactoriesLocator)->getFileName();

                $cache->save($presenterClass, TRUE, [
                        $cache::FILES => $files,
                ]);
        }



        /**
         * @return string|bool
         */
        private function findByTypeForFactory(string $type)
        {
                $found = $this->autowireComponentFactoriesLocator->findByType($type);
                return reset($found);
        }



        /**
         * @throws Nette\UnexpectedValueException
         */
        protected function createComponent(string $name): ?IComponent
        {
                $sl = $this->getComponentFactoriesLocator();

                $ucName = ucfirst($name);
                $method = 'createComponent' . $ucName;
                if ($ucName !== $name && method_exists($this, $method)) {
                        $methodReflection = new Method($this, $method);
                        if ($methodReflection->getName() !== $method) {
                                return null;
                        }
                        $parameters = $methodReflection->getParameters();

                        $args = [];
                        $first = reset($parameters);
                        if ($first !== false && !$first->getClassName()) {
                                $args[] = $name;
                        }
                        
                        $resolver = [$sl, 'findAutowired'];
                        $args = Nette\DI\Resolver::autowireArguments($methodReflection, $args, $resolver);
                        $component = $this->{$method}(...$args);
                        if (!$component instanceof Nette\ComponentModel\IComponent && !isset($this->components[$name])) {
                                throw new Nette\UnexpectedValueException("Method $methodReflection did not return or create the desired component.");
                        }

                        return $component;
                }

                return null;
        }

}

1	<?php declare(strict_types=1);
2
3	/**
4	* This file is part of the Kdyby (http://www.kdyby.org)
5	*
6	* Copyright (c) 2008 Filip Procházka (filip@prochazka.su)
7	*
8	* For the full copyright and license information, please view the file license.txt that was distributed with this source code.
9	*/
10
11	namespace Kdyby\Autowired;
12
13	use Nette;
14	use Nette\ComponentModel\IComponent;
15	use Nette\Reflection\ClassType;
16	use Nette\Reflection\Method;
17	use Nette\Utils\Strings;
18
19
20
21	/**
22	* @author matej21 <matej21@matej21.cz>
23	* @author Filip Procházka <filip@prochazka.su>
24	*
25	* @method Nette\Application\UI\Presenter getPresenter()
26	*/
27	trait AutowireComponentFactories
28	{
29
30	/**
31	* @var Nette\DI\Container
32	*/
33	private $autowireComponentFactoriesLocator;
34
35
36
37	protected function getComponentFactoriesLocator(): Nette\DI\Container
38	{
39	if ($this->autowireComponentFactoriesLocator === NULL) {	1✔
40	$this->injectComponentFactories($this->getPresenter()->getContext());	×
41	}
42
43	return $this->autowireComponentFactoriesLocator;	1✔
44	}
45
46
47
48	/**
49	* @throws MemberAccessException
50	* @internal
51	*/
52	public function injectComponentFactories(Nette\DI\Container $dic): void	1✔
53	{
54	if (!$this instanceof Nette\Application\UI\PresenterComponent && !$this instanceof Nette\Application\UI\Component) {	1✔
55	throw new MemberAccessException('Trait ' . __TRAIT__ . ' can be used only in descendants of PresenterComponent.');	1✔
56	}
57
58	$this->autowireComponentFactoriesLocator = $dic;	1✔
59
60	/** @var Nette\Caching\IStorage $storage */
61	$storage = $dic->hasService('autowired.cacheStorage')	1✔
62	? $dic->getService('autowired.cacheStorage')	×
63	: $dic->getByType('Nette\Caching\IStorage');	1✔
64	$cache = new Nette\Caching\Cache($storage, 'Kdyby.Autowired.AutowireComponentFactories');	1✔
65
66	if ($cache->load($presenterClass = get_class($this)) !== NULL) {	1✔
67	return;	×
68	}
69
70	$ignore = class_parents('Nette\Application\UI\Presenter') + ['ui' => 'Nette\Application\UI\Presenter'];	1✔
71	$rc = new ClassType($this);	1✔
72	foreach ($rc->getMethods() as $method) {	1✔
73	if (in_array($method->getDeclaringClass()->getName(), $ignore, TRUE) \|\| !Strings::startsWith($method->getName(), 'createComponent')) {	1✔
74	continue;	1✔
75	}
76
77	foreach ($method->getParameters() as $parameter) {	1✔
78	if (!$class = $parameter->getClassName()) { // has object type hint	1✔
79	continue;	1✔
80	}
81
82	if (!$this->findByTypeForFactory($class) && !$parameter->allowsNull()) {	1✔
83	throw new MissingServiceException("No service of type {$class} found. Make sure the type hint in $method is written correctly and service of this type is registered.");	1✔
84	}
85	}
86	}
87
88	$files = array_map(function ($class) {	1✔
89	return ClassType::from($class)->getFileName();	1✔
90	}, array_diff(array_values(class_parents($presenterClass) + ['me' => $presenterClass]), $ignore));	1✔
91
92	$files[] = ClassType::from($this->autowireComponentFactoriesLocator)->getFileName();	1✔
93
94	$cache->save($presenterClass, TRUE, [	1✔
95	$cache::FILES => $files,	1✔
96	]);
97	}	1✔
98
99
100
101	/**
102	* @return string\|bool
103	*/
104	private function findByTypeForFactory(string $type)	1✔
105	{
106	$found = $this->autowireComponentFactoriesLocator->findByType($type);	1✔
107	return reset($found);	1✔
108	}
109
110
111
112	/**
113	* @throws Nette\UnexpectedValueException
114	*/
115	protected function createComponent(string $name): ?IComponent	1✔
116	{
117	$sl = $this->getComponentFactoriesLocator();	1✔
118
119	$ucName = ucfirst($name);	1✔
120	$method = 'createComponent' . $ucName;	1✔
121	if ($ucName !== $name && method_exists($this, $method)) {	1✔
122	$methodReflection = new Method($this, $method);	1✔
123	if ($methodReflection->getName() !== $method) {	1✔
124	return null;	×
125	}
126	$parameters = $methodReflection->getParameters();	1✔
127
128	$args = [];	1✔
129	$first = reset($parameters);	1✔
130	if ($first !== false && !$first->getClassName()) {	1✔
131	$args[] = $name;	×
132	}
133
134	$resolver = [$sl, 'findAutowired'];	1✔
135	$args = Nette\DI\Resolver::autowireArguments($methodReflection, $args, $resolver);	1✔
136	$component = $this->{$method}(...$args);	1✔
137	if (!$component instanceof Nette\ComponentModel\IComponent && !isset($this->components[$name])) {	×
138	throw new Nette\UnexpectedValueException("Method $methodReflection did not return or create the desired component.");	×
139	}
140
141	return $component;	×
142	}
143
144	return null;	×
145	}
146
147	}

Kdyby / Autowired / 602

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous