creativelifeform / three-nebula / 320

pending completion

Build # 320

Build Type

Pull #68

travis-ci

Committed by

web-flow

Commit Message

Added test for not setting rotation in MeshRenderer.onParticleUpdate if the target is a THREE.Sprite

Pull Request Pull Request #68: Feature/issue 65 performance improvements

Run Details

623 of 964 branches covered (64.63%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 2 files covered. (100.0%)

1469 of 1891 relevant lines covered (77.68%)

125.44 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.75

/src/renderer/MeshRenderer.js

import BaseRenderer from './BaseRenderer';
import { PUID } from '../utils';
import { Pool } from '../core';
import { RENDERER_TYPE_MESH as type } from './types';

export default class MeshRenderer extends BaseRenderer {
  /**
   * @param {object} container - An Object3D container, usually a THREE.Scene
   * @param {object} THREE - THREE Api
   */
  constructor(container, THREE) {
    super(type);

    this.container = container;
    this._targetPool = new Pool();
    this._materialPool = new Pool();
    this._body = new THREE.Mesh(
      new THREE.BoxGeometry(50, 50, 50),
      new THREE.MeshLambertMaterial({ color: '#ff0000' })
    );
    this.ThreeSprite = THREE.Sprite;
  }

  isThreeSprite(particle) {
    return particle.target instanceof this.ThreeSprite;
  }

  onSystemUpdate() {}

  onParticleCreated(particle) {
    if (!particle.target) {
      //set target
      if (!particle.body) particle.body = this._body;
      particle.target = this._targetPool.get(particle.body);

      //set material
      if (particle.useAlpha || particle.useColor) {
        particle.target.material.__puid = PUID.id(particle.body.material);
        particle.target.material = this._materialPool.get(
          particle.target.material
        );
      }
    }

    if (particle.target) {
      particle.target.position.copy(particle.position);
      this.container.add(particle.target);
    }
  }

  onParticleUpdate(particle) {
    const { target, useAlpha, useColor, rotation } = particle;

    if (!target) {
      return;
    }

    target.position.copy(particle.position);

    if (!this.isThreeSprite(particle)) {
      target.rotation.set(rotation.x, rotation.y, rotation.z);
    }

    this.scale(particle);

    if (useAlpha) {
      target.material.opacity = particle.alpha;
      target.material.transparent = true;
    }

    if (useColor) {
      target.material.color.copy(particle.color);
    }
  }

  scale(particle) {
    particle.target.scale.set(particle.scale, particle.scale, particle.scale);
  }

  onParticleDead(particle) {
    if (particle.target) {
      if (particle.useAlpha || particle.useColor)
        this._materialPool.expire(particle.target.material);

      this._targetPool.expire(particle.target);
      this.container.remove(particle.target);
      particle.target = null;
    }
  }
}

1	import BaseRenderer from './BaseRenderer';	1✔
2	import { PUID } from '../utils';	1✔
3	import { Pool } from '../core';	1✔
4	import { RENDERER_TYPE_MESH as type } from './types';	1✔
5
6	export default class MeshRenderer extends BaseRenderer {
7	/**
8	* @param {object} container - An Object3D container, usually a THREE.Scene
9	* @param {object} THREE - THREE Api
10	*/
11	constructor(container, THREE) {	34✔
12	super(type);	17✔
13
14	this.container = container;	17✔
15	this._targetPool = new Pool();	17✔
16	this._materialPool = new Pool();	17✔
17	this._body = new THREE.Mesh(	17✔
18	new THREE.BoxGeometry(50, 50, 50),
19	new THREE.MeshLambertMaterial({ color: '#ff0000' })
20	);
21	this.ThreeSprite = THREE.Sprite;	17✔
22	}
23
24	isThreeSprite(particle) {
25	return particle.target instanceof this.ThreeSprite;	1,005✔
26	}
27
28	onSystemUpdate() {}
29
30	onParticleCreated(particle) {
31	if (!particle.target) {	1,013✔
32	//set target
33	if (!particle.body) particle.body = this._body;	1,012✔
34	particle.target = this._targetPool.get(particle.body);	1,012✔
35
36	//set material
37	if (particle.useAlpha \|\| particle.useColor) {	1,012✔
38	particle.target.material.__puid = PUID.id(particle.body.material);	3✔
39	particle.target.material = this._materialPool.get(	3✔
40	particle.target.material
41	);
42	}
43	}
44
45	if (particle.target) {	1,013!
46	particle.target.position.copy(particle.position);	1,013✔
47	this.container.add(particle.target);	1,013✔
48	}
49	}
50
51	onParticleUpdate(particle) {
52	const { target, useAlpha, useColor, rotation } = particle;	4,020✔
53
54	if (!target) {	1,005!
55	return;	×
56	}
57
58	target.position.copy(particle.position);	1,005✔
59
60	if (!this.isThreeSprite(particle)) {	1,005✔
61	target.rotation.set(rotation.x, rotation.y, rotation.z);	4✔
62	}
63
64	this.scale(particle);	1,005✔
65
66	if (useAlpha) {	1,005✔
67	target.material.opacity = particle.alpha;	1✔
68	target.material.transparent = true;	1✔
69	}
70
71	if (useColor) {	1,005✔
72	target.material.color.copy(particle.color);	1✔
73	}
74	}
75
76	scale(particle) {
77	particle.target.scale.set(particle.scale, particle.scale, particle.scale);	5✔
78	}
79
80	onParticleDead(particle) {
81	if (particle.target) {	3!
82	if (particle.useAlpha \|\| particle.useColor)	3✔
83	this._materialPool.expire(particle.target.material);	2✔
84
85	this._targetPool.expire(particle.target);	3✔
86	this.container.remove(particle.target);	3✔
87	particle.target = null;	3✔
88	}
89	}
90	}

creativelifeform / three-nebula / 320

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous